All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [CI 1/7] drm/i915/lmem: don't treat small BAR as an error
@ 2022-03-15 18:14 Matthew Auld
  2022-03-15 18:14 ` [Intel-gfx] [CI 2/7] drm/i915/stolen: " Matthew Auld
                   ` (9 more replies)
  0 siblings, 10 replies; 13+ messages in thread
From: Matthew Auld @ 2022-03-15 18:14 UTC (permalink / raw)
  To: intel-gfx

Just pass along the probed io_size. The backend should be able to
utilize the entire range here, even if some of it is non-mappable.

It does leave open with what to do with stolen local-memory.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@linux.intel.com>
---
 drivers/gpu/drm/i915/gt/intel_region_lmem.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
index 6cecfdae07ad..783d81072c3b 100644
--- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
+++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
@@ -93,6 +93,7 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt)
 	struct intel_memory_region *mem;
 	resource_size_t min_page_size;
 	resource_size_t io_start;
+	resource_size_t io_size;
 	resource_size_t lmem_size;
 	int err;
 
@@ -124,7 +125,8 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt)
 
 
 	io_start = pci_resource_start(pdev, 2);
-	if (GEM_WARN_ON(lmem_size > pci_resource_len(pdev, 2)))
+	io_size = min(pci_resource_len(pdev, 2), lmem_size);
+	if (!io_size)
 		return ERR_PTR(-ENODEV);
 
 	min_page_size = HAS_64K_PAGES(i915) ? I915_GTT_PAGE_SIZE_64K :
@@ -134,7 +136,7 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt)
 					 lmem_size,
 					 min_page_size,
 					 io_start,
-					 lmem_size,
+					 io_size,
 					 INTEL_MEMORY_LOCAL,
 					 0,
 					 &intel_region_lmem_ops);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2022-03-16 16:50 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-15 18:14 [Intel-gfx] [CI 1/7] drm/i915/lmem: don't treat small BAR as an error Matthew Auld
2022-03-15 18:14 ` [Intel-gfx] [CI 2/7] drm/i915/stolen: " Matthew Auld
2022-03-15 18:14 ` [Intel-gfx] [CI 3/7] drm/i915/stolen: consider I915_BO_ALLOC_GPU_ONLY Matthew Auld
2022-03-15 18:14 ` [Intel-gfx] [CI 4/7] drm/i915: add i915_gem_object_create_region_at() Matthew Auld
2022-03-15 18:14 ` [Intel-gfx] [CI 5/7] drm/i915/ttm: wire up the object offset Matthew Auld
2022-03-15 18:14 ` [Intel-gfx] [CI 6/7] drm/i915/display: Check mappable aperture when pinning preallocated vma Matthew Auld
2022-03-15 18:14 ` [Intel-gfx] [CI 7/7] drm/i915: fixup the initial fb base on DGFX Matthew Auld
2022-03-15 20:04 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/7] drm/i915/lmem: don't treat small BAR as an error Patchwork
2022-03-15 20:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-16  0:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-16  9:15   ` Matthew Auld
2022-03-16 16:50     ` Vudum, Lakshminarayana
2022-03-16 15:53 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.