From: Jason Gunthorpe via iommu <iommu@lists.linux-foundation.org>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Jean-Philippe Brucker <jean-philippe@linaro.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"Pan, Jacob jun" <jacob.jun.pan@intel.com>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH RFC 03/11] iommu: Add attach/detach_dev_pasid domain ops
Date: Mon, 21 Mar 2022 08:53:08 -0300 [thread overview]
Message-ID: <20220321115308.GJ11336@nvidia.com> (raw)
In-Reply-To: <BL1PR11MB527174765D1253AB4B88D2AD8C169@BL1PR11MB5271.namprd11.prod.outlook.com>
On Mon, Mar 21, 2022 at 07:13:49AM +0000, Tian, Kevin wrote:
> /*
> * To keep things simple, SVA currently doesn't support IOMMU groups
> * with more than one device. Existing SVA-capable systems are not
> * affected by the problems that required IOMMU groups (lack of ACS
> * isolation, device ID aliasing and other hardware issues).
> */
> if (iommu_group_device_count(group) != 1)
> goto out_unlock;
>
> btw I didn't see any safeguard on above assumption in device hotplug path
> to a group which already has SVA enabled...
This is because using device_count is always wrong for these kinds of
tests.
The exclusion needs to be built up from the new owner mechanism. Once
the device is in SVA mode it is the same as having exclusive ownership
against any other probes()
Jason
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>,
Christoph Hellwig <hch@infradead.org>,
"Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jean-Philippe Brucker <jean-philippe@linaro.com>,
Eric Auger <eric.auger@redhat.com>,
"Liu, Yi L" <yi.l.liu@intel.com>,
"Pan, Jacob jun" <jacob.jun.pan@intel.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC 03/11] iommu: Add attach/detach_dev_pasid domain ops
Date: Mon, 21 Mar 2022 08:53:08 -0300 [thread overview]
Message-ID: <20220321115308.GJ11336@nvidia.com> (raw)
In-Reply-To: <BL1PR11MB527174765D1253AB4B88D2AD8C169@BL1PR11MB5271.namprd11.prod.outlook.com>
On Mon, Mar 21, 2022 at 07:13:49AM +0000, Tian, Kevin wrote:
> /*
> * To keep things simple, SVA currently doesn't support IOMMU groups
> * with more than one device. Existing SVA-capable systems are not
> * affected by the problems that required IOMMU groups (lack of ACS
> * isolation, device ID aliasing and other hardware issues).
> */
> if (iommu_group_device_count(group) != 1)
> goto out_unlock;
>
> btw I didn't see any safeguard on above assumption in device hotplug path
> to a group which already has SVA enabled...
This is because using device_count is always wrong for these kinds of
tests.
The exclusion needs to be built up from the new owner mechanism. Once
the device is in SVA mode it is the same as having exclusive ownership
against any other probes()
Jason
next prev parent reply other threads:[~2022-03-21 11:53 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 6:40 [PATCH RFC 00/11] iommu: SVA and IOPF refactoring Lu Baolu
2022-03-20 6:40 ` Lu Baolu
2022-03-20 6:40 ` [PATCH RFC 01/11] iommu: Add pasid_bits field in struct dev_iommu Lu Baolu
2022-03-20 6:40 ` Lu Baolu
2022-03-21 7:01 ` Tian, Kevin
2022-03-21 7:01 ` Tian, Kevin
2022-03-21 10:22 ` Lu Baolu
2022-03-21 10:22 ` Lu Baolu
2022-03-22 0:26 ` Tian, Kevin
2022-03-22 0:26 ` Tian, Kevin
2022-03-22 0:48 ` Lu Baolu
2022-03-22 0:48 ` Lu Baolu
2022-03-21 11:22 ` Jean-Philippe Brucker
2022-03-21 11:22 ` Jean-Philippe Brucker
2022-03-22 0:45 ` Lu Baolu
2022-03-22 0:45 ` Lu Baolu
2022-03-20 6:40 ` [PATCH RFC 02/11] iommu: Add iommu_domain type for SVA Lu Baolu
2022-03-20 6:40 ` Lu Baolu
2022-03-21 7:06 ` Tian, Kevin
2022-03-21 7:06 ` Tian, Kevin
2022-03-21 10:23 ` Lu Baolu
2022-03-21 10:23 ` Lu Baolu
2022-03-21 11:47 ` Jason Gunthorpe
2022-03-21 11:47 ` Jason Gunthorpe via iommu
2022-03-22 0:54 ` Lu Baolu
2022-03-22 0:54 ` Lu Baolu
2022-03-20 6:40 ` [PATCH RFC 03/11] iommu: Add attach/detach_dev_pasid domain ops Lu Baolu
2022-03-20 6:40 ` Lu Baolu
2022-03-21 7:13 ` Tian, Kevin
2022-03-21 7:13 ` Tian, Kevin
2022-03-21 10:27 ` Lu Baolu
2022-03-21 10:27 ` Lu Baolu
2022-03-21 11:53 ` Jason Gunthorpe via iommu [this message]
2022-03-21 11:53 ` Jason Gunthorpe
2022-03-20 6:40 ` [PATCH RFC 04/11] iommu/vt-d: Add SVA domain support Lu Baolu
2022-03-20 6:40 ` Lu Baolu
2022-03-21 7:45 ` Tian, Kevin
2022-03-21 7:45 ` Tian, Kevin
2022-03-21 10:37 ` Lu Baolu
2022-03-21 10:37 ` Lu Baolu
2022-03-21 11:56 ` Jason Gunthorpe via iommu
2022-03-21 11:56 ` Jason Gunthorpe
2022-03-22 4:25 ` Lu Baolu
2022-03-22 4:25 ` Lu Baolu
2022-03-20 6:40 ` [PATCH RFC 05/11] arm-smmu-v3/sva: " Lu Baolu
2022-03-20 6:40 ` Lu Baolu
2022-03-21 11:31 ` Jean-Philippe Brucker
2022-03-21 11:31 ` Jean-Philippe Brucker
2022-03-21 11:58 ` Jason Gunthorpe
2022-03-21 11:58 ` Jason Gunthorpe via iommu
2022-03-20 6:40 ` [PATCH RFC 06/11] iommu/sva: Use attach/detach_pasid_dev in SVA interfaces Lu Baolu
2022-03-20 6:40 ` Lu Baolu
2022-03-21 8:04 ` Tian, Kevin
2022-03-21 8:04 ` Tian, Kevin
2022-03-21 11:01 ` Lu Baolu
2022-03-21 11:01 ` Lu Baolu
2022-03-21 12:03 ` Jason Gunthorpe
2022-03-21 12:03 ` Jason Gunthorpe via iommu
2022-03-21 11:33 ` Jean-Philippe Brucker
2022-03-21 11:33 ` Jean-Philippe Brucker
2022-03-22 4:29 ` Lu Baolu
2022-03-22 4:29 ` Lu Baolu
2022-03-21 12:05 ` Jason Gunthorpe
2022-03-21 12:05 ` Jason Gunthorpe via iommu
2022-03-22 4:31 ` Lu Baolu
2022-03-22 4:31 ` Lu Baolu
2022-03-20 6:40 ` [PATCH RFC 07/11] iommu: Remove SVA related callbacks from iommu ops Lu Baolu
2022-03-20 6:40 ` Lu Baolu
2022-03-20 6:40 ` [PATCH RFC 08/11] iommu: Handle IO page faults directly Lu Baolu
2022-03-20 6:40 ` Lu Baolu
2022-03-21 11:35 ` Jean-Philippe Brucker
2022-03-21 11:35 ` Jean-Philippe Brucker
2022-03-22 0:39 ` Tian, Kevin
2022-03-22 0:39 ` Tian, Kevin
2022-03-20 6:40 ` [PATCH RFC 09/11] iommu: Add iommu_get_domain_for_dev_pasid() Lu Baolu
2022-03-20 6:40 ` Lu Baolu
2022-03-21 12:40 ` Jason Gunthorpe
2022-03-21 12:40 ` Jason Gunthorpe via iommu
2022-03-22 4:50 ` Lu Baolu
2022-03-22 4:50 ` Lu Baolu
2022-03-20 6:40 ` [PATCH RFC 10/11] iommu: Make IOPF handling framework generic Lu Baolu
2022-03-20 6:40 ` Lu Baolu
2022-03-21 8:09 ` Tian, Kevin
2022-03-21 8:09 ` Tian, Kevin
2022-03-21 11:42 ` Jean-Philippe Brucker
2022-03-21 11:42 ` Jean-Philippe Brucker
2022-03-21 12:43 ` Jason Gunthorpe
2022-03-21 12:43 ` Jason Gunthorpe via iommu
2022-03-22 5:03 ` Lu Baolu
2022-03-22 5:03 ` Lu Baolu
2022-03-22 10:02 ` Jean-Philippe Brucker
2022-03-22 10:02 ` Jean-Philippe Brucker
2022-03-22 12:15 ` Jason Gunthorpe
2022-03-22 12:15 ` Jason Gunthorpe via iommu
2022-03-22 1:00 ` Tian, Kevin
2022-03-22 1:00 ` Tian, Kevin
2022-03-22 10:06 ` Jean-Philippe Brucker
2022-03-22 10:06 ` Jean-Philippe Brucker
2022-03-22 10:24 ` Tian, Kevin
2022-03-22 10:24 ` Tian, Kevin
2022-03-22 10:50 ` Jean-Philippe Brucker
2022-03-22 10:50 ` Jean-Philippe Brucker
2022-03-21 11:39 ` Jean-Philippe Brucker
2022-03-21 11:39 ` Jean-Philippe Brucker
2022-03-22 5:28 ` Lu Baolu
2022-03-22 5:28 ` Lu Baolu
2022-03-21 12:50 ` Jason Gunthorpe
2022-03-21 12:50 ` Jason Gunthorpe via iommu
2022-03-22 5:48 ` Lu Baolu
2022-03-22 5:48 ` Lu Baolu
2022-03-20 6:40 ` [PATCH RFC 11/11] iommu: Rename iommu-sva-lib.{c,h} Lu Baolu
2022-03-20 6:40 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220321115308.GJ11336@nvidia.com \
--to=iommu@lists.linux-foundation.org \
--cc=ashok.raj@intel.com \
--cc=hch@infradead.org \
--cc=jacob.jun.pan@intel.com \
--cc=jean-philippe@linaro.com \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.