All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-renesas-soc@vger.kernel.org, linux-serial@vger.kernel.org,
	Milan Stevanovic <milan.stevanovic@se.com>,
	Jimmy Lalande <jimmy.lalande@se.com>,
	Pascal Eberhard <pascal.eberhard@se.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Herve Codina <herve.codina@bootlin.com>,
	Clement Leger <clement.leger@bootlin.com>
Subject: [PATCH v3 07/10] serial: 8250: dw: Introduce an rx_timeout variable in the IRQ path
Date: Tue, 29 Mar 2022 17:24:27 +0200	[thread overview]
Message-ID: <20220329152430.756947-8-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20220329152430.756947-1-miquel.raynal@bootlin.com>

In a next change we are going to need the same Rx timeout condition as
we already have in the IRQ handling code. Let's just create a boolean to
clarify what this operation does before reusing it.

There is no functional change.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 drivers/tty/serial/8250/8250_dw.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 95c4321022d5..1a6932d69332 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -228,6 +228,7 @@ static int dw8250_handle_irq(struct uart_port *p)
 	struct uart_8250_port *up = up_to_u8250p(p);
 	struct dw8250_data *d = to_dw8250_data(p->private_data);
 	unsigned int iir = p->serial_in(p, UART_IIR);
+	bool rx_timeout = (iir & 0x3f) == UART_IIR_RX_TIMEOUT;
 	unsigned int status;
 	unsigned long flags;
 
@@ -241,7 +242,7 @@ static int dw8250_handle_irq(struct uart_port *p)
 	 * This problem has only been observed so far when not in DMA mode
 	 * so we limit the workaround only to non-DMA mode.
 	 */
-	if (!up->dma && ((iir & 0x3f) == UART_IIR_RX_TIMEOUT)) {
+	if (!up->dma && rx_timeout) {
 		spin_lock_irqsave(&p->lock, flags);
 		status = p->serial_in(p, UART_LSR);
 
-- 
2.27.0


  parent reply	other threads:[~2022-03-29 15:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29 15:24 [PATCH v3 00/10] serial: 8250: dw: RZN1 DMA support Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 01/10] serial: 8250: dw: Move the per-device structure Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 02/10] serial: 8250: dw: Use the device API Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 03/10] serial: 8250: dw: Change the quirks type to unsigned int Miquel Raynal
2022-03-29 15:43   ` Andy Shevchenko
2022-03-29 15:58   ` Geert Uytterhoeven
2022-03-29 16:06     ` Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 04/10] serial: 8250: dw: Create a more generic platform data structure Miquel Raynal
2022-03-29 15:51   ` Andy Shevchenko
2022-03-29 15:24 ` [PATCH v3 05/10] serial: 8250: dw: Allow to use a fallback CPR value if not synthesized Miquel Raynal
2022-03-29 15:49   ` Andy Shevchenko
2022-03-29 15:24 ` [PATCH v3 06/10] serial: 8250: dma: Allow driver operations before starting DMA transfers Miquel Raynal
2022-03-29 15:24 ` Miquel Raynal [this message]
2022-03-29 15:24 ` [PATCH v3 08/10] serial: 8250: dw: Add support for DMA flow controlling devices Miquel Raynal
2022-03-29 15:58   ` Andy Shevchenko
2022-03-29 15:24 ` [PATCH v3 09/10] serial: 8250: dw: Improve RZN1 support Miquel Raynal
2022-03-29 16:00   ` Andy Shevchenko
2022-03-29 15:24 ` [PATCH v3 10/10] ARM: dts: r9a06g032: Fill the UART DMA properties Miquel Raynal
2022-03-29 16:01 ` [PATCH v3 00/10] serial: 8250: dw: RZN1 DMA support Andy Shevchenko
2022-03-29 16:10   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220329152430.756947-8-miquel.raynal@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=clement.leger@bootlin.com \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=herve.codina@bootlin.com \
    --cc=jimmy.lalande@se.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=milan.stevanovic@se.com \
    --cc=pascal.eberhard@se.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.