From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-renesas-soc@vger.kernel.org, linux-serial@vger.kernel.org,
Milan Stevanovic <milan.stevanovic@se.com>,
Jimmy Lalande <jimmy.lalande@se.com>,
Pascal Eberhard <pascal.eberhard@se.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>,
Clement Leger <clement.leger@bootlin.com>,
Phil Edworthy <phil.edworthy@renesas.com>
Subject: Re: [PATCH v3 09/10] serial: 8250: dw: Improve RZN1 support
Date: Tue, 29 Mar 2022 19:00:02 +0300 [thread overview]
Message-ID: <YkMtAnySw3wdttUf@smile.fi.intel.com> (raw)
In-Reply-To: <20220329152430.756947-10-miquel.raynal@bootlin.com>
On Tue, Mar 29, 2022 at 05:24:29PM +0200, Miquel Raynal wrote:
> From: Phil Edworthy <phil.edworthy@renesas.com>
>
> Renesas RZ/N1 SoC features a slightly modified DW UART.
>
> On this SoC, the CPR register value is known but not synthetized in
> hardware. We hence need to provide a CPR value in the platform
> data. This version of the controller also relies on acting as flow
> controller when using DMA, so we need to provide the
> 'IS_DMA_FLOW_CONTROLLER' quirk.
...
> - { .compatible = "renesas,rzn1-uart" },
> + { .compatible = "renesas,rzn1-uart", .data = &dw8250_renesas_rzn1_data },
Btw, you may avoid if (pdata) checks if you add a stub in the first place here.
It will also make this patch shorter.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-29 16:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 15:24 [PATCH v3 00/10] serial: 8250: dw: RZN1 DMA support Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 01/10] serial: 8250: dw: Move the per-device structure Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 02/10] serial: 8250: dw: Use the device API Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 03/10] serial: 8250: dw: Change the quirks type to unsigned int Miquel Raynal
2022-03-29 15:43 ` Andy Shevchenko
2022-03-29 15:58 ` Geert Uytterhoeven
2022-03-29 16:06 ` Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 04/10] serial: 8250: dw: Create a more generic platform data structure Miquel Raynal
2022-03-29 15:51 ` Andy Shevchenko
2022-03-29 15:24 ` [PATCH v3 05/10] serial: 8250: dw: Allow to use a fallback CPR value if not synthesized Miquel Raynal
2022-03-29 15:49 ` Andy Shevchenko
2022-03-29 15:24 ` [PATCH v3 06/10] serial: 8250: dma: Allow driver operations before starting DMA transfers Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 07/10] serial: 8250: dw: Introduce an rx_timeout variable in the IRQ path Miquel Raynal
2022-03-29 15:24 ` [PATCH v3 08/10] serial: 8250: dw: Add support for DMA flow controlling devices Miquel Raynal
2022-03-29 15:58 ` Andy Shevchenko
2022-03-29 15:24 ` [PATCH v3 09/10] serial: 8250: dw: Improve RZN1 support Miquel Raynal
2022-03-29 16:00 ` Andy Shevchenko [this message]
2022-03-29 15:24 ` [PATCH v3 10/10] ARM: dts: r9a06g032: Fill the UART DMA properties Miquel Raynal
2022-03-29 16:01 ` [PATCH v3 00/10] serial: 8250: dw: RZN1 DMA support Andy Shevchenko
2022-03-29 16:10 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkMtAnySw3wdttUf@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=clement.leger@bootlin.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=jimmy.lalande@se.com \
--cc=jirislaby@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=milan.stevanovic@se.com \
--cc=miquel.raynal@bootlin.com \
--cc=pascal.eberhard@se.com \
--cc=phil.edworthy@renesas.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.