* [PATCH v2 1/3] drm/panel: nt36672a: add backlight support [not found] <20220401001810.81507-1-jo@jsfamily.in> @ 2022-04-01 0:18 ` Joel Selvaraj 2022-04-01 0:18 ` [PATCH v2 2/3] dt-bindings: display: novatek, nt36672a: " Joel Selvaraj 2022-04-01 0:18 ` Joel Selvaraj 2 siblings, 0 replies; 26+ messages in thread From: Joel Selvaraj @ 2022-04-01 0:18 UTC (permalink / raw) To: Sumit Semwal, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring, Andy Gross, Bjorn Andersson Cc: dri-devel, devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Amit Pundir, Marijn Suijten, Joel Selvaraj Add support for backlight. This panel supports backlight control through the QCOM WLED driver in Xiaomi Poco F1 device. Signed-off-by: Joel Selvaraj <jo@jsfamily.in> --- drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c index 231f371901e8..6d6ce42787e2 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c @@ -628,6 +628,10 @@ static int nt36672a_panel_add(struct nt36672a_panel *pinfo) drm_panel_init(&pinfo->base, dev, &panel_funcs, DRM_MODE_CONNECTOR_DSI); + ret = drm_panel_of_backlight(&pinfo->base); + if (ret) + return dev_err_probe(dev, ret, "Failed to get backlight\n"); + drm_panel_add(&pinfo->base); return 0; -- 2.35.1 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH v2 1/3] drm/panel: nt36672a: add backlight support @ 2022-04-01 0:18 ` Joel Selvaraj 0 siblings, 0 replies; 26+ messages in thread From: Joel Selvaraj @ 2022-04-01 0:18 UTC (permalink / raw) To: Sumit Semwal, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring, Andy Gross, Bjorn Andersson Cc: Amit Pundir, devicetree, linux-arm-msm, linux-kernel, dri-devel, ~postmarketos/upstreaming, Marijn Suijten, phone-devel, Joel Selvaraj Add support for backlight. This panel supports backlight control through the QCOM WLED driver in Xiaomi Poco F1 device. Signed-off-by: Joel Selvaraj <jo@jsfamily.in> --- drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c index 231f371901e8..6d6ce42787e2 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c @@ -628,6 +628,10 @@ static int nt36672a_panel_add(struct nt36672a_panel *pinfo) drm_panel_init(&pinfo->base, dev, &panel_funcs, DRM_MODE_CONNECTOR_DSI); + ret = drm_panel_of_backlight(&pinfo->base); + if (ret) + return dev_err_probe(dev, ret, "Failed to get backlight\n"); + drm_panel_add(&pinfo->base); return 0; -- 2.35.1 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support 2022-04-01 0:18 ` Joel Selvaraj @ 2022-04-06 16:18 ` Marijn Suijten -1 siblings, 0 replies; 26+ messages in thread From: Marijn Suijten @ 2022-04-06 16:18 UTC (permalink / raw) To: Joel Selvaraj Cc: Amit Pundir, devicetree, David Airlie, linux-kernel, Andy Gross, dri-devel, Bjorn Andersson, Rob Herring, Thierry Reding, ~postmarketos/upstreaming, linux-arm-msm, phone-devel, Sam Ravnborg, Sumit Semwal On 2022-04-01 05:48:08, Joel Selvaraj wrote: > Add support for backlight. This panel supports backlight control > through the QCOM WLED driver in Xiaomi Poco F1 device. > > Signed-off-by: Joel Selvaraj <jo@jsfamily.in> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c > index 231f371901e8..6d6ce42787e2 100644 > --- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c > +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c > @@ -628,6 +628,10 @@ static int nt36672a_panel_add(struct nt36672a_panel *pinfo) > > drm_panel_init(&pinfo->base, dev, &panel_funcs, DRM_MODE_CONNECTOR_DSI); > > + ret = drm_panel_of_backlight(&pinfo->base); > + if (ret) > + return dev_err_probe(dev, ret, "Failed to get backlight\n"); > + > drm_panel_add(&pinfo->base); > > return 0; > -- > 2.35.1 > ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support @ 2022-04-06 16:18 ` Marijn Suijten 0 siblings, 0 replies; 26+ messages in thread From: Marijn Suijten @ 2022-04-06 16:18 UTC (permalink / raw) To: Joel Selvaraj Cc: Sumit Semwal, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring, Andy Gross, Bjorn Andersson, dri-devel, devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Amit Pundir On 2022-04-01 05:48:08, Joel Selvaraj wrote: > Add support for backlight. This panel supports backlight control > through the QCOM WLED driver in Xiaomi Poco F1 device. > > Signed-off-by: Joel Selvaraj <jo@jsfamily.in> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c > index 231f371901e8..6d6ce42787e2 100644 > --- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c > +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c > @@ -628,6 +628,10 @@ static int nt36672a_panel_add(struct nt36672a_panel *pinfo) > > drm_panel_init(&pinfo->base, dev, &panel_funcs, DRM_MODE_CONNECTOR_DSI); > > + ret = drm_panel_of_backlight(&pinfo->base); > + if (ret) > + return dev_err_probe(dev, ret, "Failed to get backlight\n"); > + > drm_panel_add(&pinfo->base); > > return 0; > -- > 2.35.1 > ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: (subset) [PATCH v2 1/3] drm/panel: nt36672a: add backlight support 2022-04-01 0:18 ` Joel Selvaraj @ 2022-04-21 14:26 ` Bjorn Andersson -1 siblings, 0 replies; 26+ messages in thread From: Bjorn Andersson @ 2022-04-21 14:26 UTC (permalink / raw) To: Daniel Vetter, David Airlie, Sumit Semwal, Sam Ravnborg, Andy Gross, Joel Selvaraj, Rob Herring, Thierry Reding Cc: devicetree, ~postmarketos/upstreaming, linux-kernel, linux-arm-msm, dri-devel, phone-devel, Amit Pundir, Marijn Suijten On Fri, 1 Apr 2022 05:48:08 +0530, Joel Selvaraj wrote: > Add support for backlight. This panel supports backlight control > through the QCOM WLED driver in Xiaomi Poco F1 device. > > Applied, thanks! [3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel commit: 89561886191c0dcb6ce1491f14552eac16e14a80 Best regards, -- Bjorn Andersson <bjorn.andersson@linaro.org> ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: (subset) [PATCH v2 1/3] drm/panel: nt36672a: add backlight support @ 2022-04-21 14:26 ` Bjorn Andersson 0 siblings, 0 replies; 26+ messages in thread From: Bjorn Andersson @ 2022-04-21 14:26 UTC (permalink / raw) To: Daniel Vetter, David Airlie, Sumit Semwal, Sam Ravnborg, Andy Gross, Joel Selvaraj, Rob Herring, Thierry Reding Cc: Amit Pundir, devicetree, linux-arm-msm, linux-kernel, dri-devel, ~postmarketos/upstreaming, Marijn Suijten, phone-devel On Fri, 1 Apr 2022 05:48:08 +0530, Joel Selvaraj wrote: > Add support for backlight. This panel supports backlight control > through the QCOM WLED driver in Xiaomi Poco F1 device. > > Applied, thanks! [3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel commit: 89561886191c0dcb6ce1491f14552eac16e14a80 Best regards, -- Bjorn Andersson <bjorn.andersson@linaro.org> ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support 2022-04-01 0:18 ` Joel Selvaraj @ 2022-06-07 18:31 ` Joel Selvaraj -1 siblings, 0 replies; 26+ messages in thread From: Joel Selvaraj @ 2022-06-07 18:31 UTC (permalink / raw) To: Sumit Semwal, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring, Andy Gross, Bjorn Andersson Cc: Amit Pundir, devicetree, linux-arm-msm, linux-kernel, dri-devel, ~postmarketos/upstreaming, Marijn Suijten, phone-devel Hi, I can see that the dts changes from this patch series has been applied to 5.19-rc1 release. However, this patch that has the related change to the panel driver, is not applied in the 5.19-rc1 release. Any particular reason why it's not picked up? or just that, it got missed out? Kindly let me know if changes are required from my end. With Regards, Joel Selvaraj ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support @ 2022-06-07 18:31 ` Joel Selvaraj 0 siblings, 0 replies; 26+ messages in thread From: Joel Selvaraj @ 2022-06-07 18:31 UTC (permalink / raw) To: Sumit Semwal, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring, Andy Gross, Bjorn Andersson Cc: dri-devel, devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Amit Pundir, Marijn Suijten Hi, I can see that the dts changes from this patch series has been applied to 5.19-rc1 release. However, this patch that has the related change to the panel driver, is not applied in the 5.19-rc1 release. Any particular reason why it's not picked up? or just that, it got missed out? Kindly let me know if changes are required from my end. With Regards, Joel Selvaraj ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support 2022-06-07 18:31 ` Joel Selvaraj @ 2022-06-08 16:30 ` Sumit Semwal -1 siblings, 0 replies; 26+ messages in thread From: Sumit Semwal @ 2022-06-08 16:30 UTC (permalink / raw) To: Joel Selvaraj Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring, Andy Gross, Bjorn Andersson, dri-devel, devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Amit Pundir, Marijn Suijten Hi Joel, On Wed, 8 Jun 2022 at 00:01, Joel Selvaraj <jo@jsfamily.in> wrote: > > Hi, > > I can see that the dts changes from this patch series has been applied > to 5.19-rc1 release. However, this patch that has the related change to > the panel driver, is not applied in the 5.19-rc1 release. Any particular > reason why it's not picked up? or just that, it got missed out? Kindly > let me know if changes are required from my end. This is entirely my fault - It somehow missed my radar, and I didn't queue it up. I will push it via drm-misc tree tonight. Apologies again! > > With Regards, > Joel Selvaraj Best, Sumit. ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support @ 2022-06-08 16:30 ` Sumit Semwal 0 siblings, 0 replies; 26+ messages in thread From: Sumit Semwal @ 2022-06-08 16:30 UTC (permalink / raw) To: Joel Selvaraj Cc: Amit Pundir, devicetree, David Airlie, linux-kernel, Andy Gross, dri-devel, Bjorn Andersson, Rob Herring, Thierry Reding, ~postmarketos/upstreaming, linux-arm-msm, Marijn Suijten, phone-devel, Sam Ravnborg Hi Joel, On Wed, 8 Jun 2022 at 00:01, Joel Selvaraj <jo@jsfamily.in> wrote: > > Hi, > > I can see that the dts changes from this patch series has been applied > to 5.19-rc1 release. However, this patch that has the related change to > the panel driver, is not applied in the 5.19-rc1 release. Any particular > reason why it's not picked up? or just that, it got missed out? Kindly > let me know if changes are required from my end. This is entirely my fault - It somehow missed my radar, and I didn't queue it up. I will push it via drm-misc tree tonight. Apologies again! > > With Regards, > Joel Selvaraj Best, Sumit. ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support 2022-06-08 16:30 ` Sumit Semwal @ 2022-06-08 16:40 ` Joel Selvaraj -1 siblings, 0 replies; 26+ messages in thread From: Joel Selvaraj @ 2022-06-08 16:40 UTC (permalink / raw) To: Sumit Semwal Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring, Andy Gross, Bjorn Andersson, dri-devel, devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Amit Pundir, Marijn Suijten Hi Sumit, On 08/06/22 22:00, Sumit Semwal wrote: > This is entirely my fault - It somehow missed my radar, and I didn't > queue it up. I will push it via drm-misc tree tonight. Apologies > again! No problem. Thanks for the update! So it will land on upcoming 5.19-rcs or 5.20-rc? > Best, > Sumit. Best Regards, Joel Selvaraj ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support @ 2022-06-08 16:40 ` Joel Selvaraj 0 siblings, 0 replies; 26+ messages in thread From: Joel Selvaraj @ 2022-06-08 16:40 UTC (permalink / raw) To: Sumit Semwal Cc: Amit Pundir, devicetree, David Airlie, linux-kernel, Andy Gross, dri-devel, Bjorn Andersson, Rob Herring, Thierry Reding, ~postmarketos/upstreaming, linux-arm-msm, Marijn Suijten, phone-devel, Sam Ravnborg Hi Sumit, On 08/06/22 22:00, Sumit Semwal wrote: > This is entirely my fault - It somehow missed my radar, and I didn't > queue it up. I will push it via drm-misc tree tonight. Apologies > again! No problem. Thanks for the update! So it will land on upcoming 5.19-rcs or 5.20-rc? > Best, > Sumit. Best Regards, Joel Selvaraj ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support 2022-06-08 16:40 ` Joel Selvaraj @ 2022-06-08 17:52 ` Sumit Semwal -1 siblings, 0 replies; 26+ messages in thread From: Sumit Semwal @ 2022-06-08 17:52 UTC (permalink / raw) To: Joel Selvaraj Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring, Andy Gross, Bjorn Andersson, dri-devel, devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Amit Pundir, Marijn Suijten Hi Joel, On Wed, 8 Jun 2022 at 22:10, Joel Selvaraj <jo@jsfamily.in> wrote: > > Hi Sumit, > > On 08/06/22 22:00, Sumit Semwal wrote: > > This is entirely my fault - It somehow missed my radar, and I didn't > > queue it up. I will push it via drm-misc tree tonight. Apologies > > again! > > No problem. Thanks for the update! So it will land on upcoming 5.19-rcs > or 5.20-rc? Not for 5.19-rcs for sure, but I think it should make it for 5.20-rcs? > > > Best, > > Sumit. > > Best Regards, > Joel Selvaraj Best, Sumit. ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support @ 2022-06-08 17:52 ` Sumit Semwal 0 siblings, 0 replies; 26+ messages in thread From: Sumit Semwal @ 2022-06-08 17:52 UTC (permalink / raw) To: Joel Selvaraj Cc: Amit Pundir, devicetree, David Airlie, linux-kernel, Andy Gross, dri-devel, Bjorn Andersson, Rob Herring, Thierry Reding, ~postmarketos/upstreaming, linux-arm-msm, Marijn Suijten, phone-devel, Sam Ravnborg Hi Joel, On Wed, 8 Jun 2022 at 22:10, Joel Selvaraj <jo@jsfamily.in> wrote: > > Hi Sumit, > > On 08/06/22 22:00, Sumit Semwal wrote: > > This is entirely my fault - It somehow missed my radar, and I didn't > > queue it up. I will push it via drm-misc tree tonight. Apologies > > again! > > No problem. Thanks for the update! So it will land on upcoming 5.19-rcs > or 5.20-rc? Not for 5.19-rcs for sure, but I think it should make it for 5.20-rcs? > > > Best, > > Sumit. > > Best Regards, > Joel Selvaraj Best, Sumit. ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support 2022-06-08 17:52 ` Sumit Semwal @ 2022-06-08 17:55 ` Joel Selvaraj -1 siblings, 0 replies; 26+ messages in thread From: Joel Selvaraj @ 2022-06-08 17:55 UTC (permalink / raw) To: Sumit Semwal Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring, Andy Gross, Bjorn Andersson, dri-devel, devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Amit Pundir, Marijn Suijten Hi Sumit, On 08/06/22 23:22, Sumit Semwal wrote: > Not for 5.19-rcs for sure, but I think it should make it for 5.20-rcs? Ok. No problem. Thanks. > Best, > Sumit. Best Regards, Joel Selvaraj ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support @ 2022-06-08 17:55 ` Joel Selvaraj 0 siblings, 0 replies; 26+ messages in thread From: Joel Selvaraj @ 2022-06-08 17:55 UTC (permalink / raw) To: Sumit Semwal Cc: Amit Pundir, devicetree, David Airlie, linux-kernel, Andy Gross, dri-devel, Bjorn Andersson, Rob Herring, Thierry Reding, ~postmarketos/upstreaming, linux-arm-msm, Marijn Suijten, phone-devel, Sam Ravnborg Hi Sumit, On 08/06/22 23:22, Sumit Semwal wrote: > Not for 5.19-rcs for sure, but I think it should make it for 5.20-rcs? Ok. No problem. Thanks. > Best, > Sumit. Best Regards, Joel Selvaraj ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v2 2/3] dt-bindings: display: novatek,nt36672a: add backlight property [not found] <20220401001810.81507-1-jo@jsfamily.in> @ 2022-04-01 0:18 ` Joel Selvaraj 2022-04-01 0:18 ` [PATCH v2 2/3] dt-bindings: display: novatek, nt36672a: " Joel Selvaraj 2022-04-01 0:18 ` Joel Selvaraj 2 siblings, 0 replies; 26+ messages in thread From: Joel Selvaraj @ 2022-04-01 0:18 UTC (permalink / raw) To: Sumit Semwal, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring, Andy Gross, Bjorn Andersson Cc: dri-devel, devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Amit Pundir, Marijn Suijten, Joel Selvaraj Add backlight property and update example to include it. Signed-off-by: Joel Selvaraj <jo@jsfamily.in> --- .../devicetree/bindings/display/panel/novatek,nt36672a.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml index 563766d283f6..41ee3157a1cd 100644 --- a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml @@ -46,6 +46,7 @@ properties: reg: true port: true + backlight: true required: - compatible @@ -73,6 +74,7 @@ examples: vddpos-supply = <&lab>; vddneg-supply = <&ibb>; + backlight = <&pmi8998_wled>; reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>; port { -- 2.35.1 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH v2 2/3] dt-bindings: display: novatek, nt36672a: add backlight property @ 2022-04-01 0:18 ` Joel Selvaraj 0 siblings, 0 replies; 26+ messages in thread From: Joel Selvaraj @ 2022-04-01 0:18 UTC (permalink / raw) To: Sumit Semwal, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring, Andy Gross, Bjorn Andersson Cc: Amit Pundir, devicetree, linux-arm-msm, linux-kernel, dri-devel, ~postmarketos/upstreaming, Marijn Suijten, phone-devel, Joel Selvaraj Add backlight property and update example to include it. Signed-off-by: Joel Selvaraj <jo@jsfamily.in> --- .../devicetree/bindings/display/panel/novatek,nt36672a.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml index 563766d283f6..41ee3157a1cd 100644 --- a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml @@ -46,6 +46,7 @@ properties: reg: true port: true + backlight: true required: - compatible @@ -73,6 +74,7 @@ examples: vddpos-supply = <&lab>; vddneg-supply = <&ibb>; + backlight = <&pmi8998_wled>; reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>; port { -- 2.35.1 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: display: novatek,nt36672a: add backlight property 2022-04-01 0:18 ` [PATCH v2 2/3] dt-bindings: display: novatek, nt36672a: " Joel Selvaraj @ 2022-04-06 16:05 ` Rob Herring -1 siblings, 0 replies; 26+ messages in thread From: Rob Herring @ 2022-04-06 16:05 UTC (permalink / raw) To: Joel Selvaraj Cc: Amit Pundir, devicetree, David Airlie, linux-arm-msm, Andy Gross, linux-kernel, dri-devel, Bjorn Andersson, Rob Herring, Thierry Reding, ~postmarketos/upstreaming, Marijn Suijten, phone-devel, Sam Ravnborg, Sumit Semwal On Fri, 01 Apr 2022 05:48:09 +0530, Joel Selvaraj wrote: > Add backlight property and update example to include it. > > Signed-off-by: Joel Selvaraj <jo@jsfamily.in> > --- > .../devicetree/bindings/display/panel/novatek,nt36672a.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: display: novatek,nt36672a: add backlight property @ 2022-04-06 16:05 ` Rob Herring 0 siblings, 0 replies; 26+ messages in thread From: Rob Herring @ 2022-04-06 16:05 UTC (permalink / raw) To: Joel Selvaraj Cc: ~postmarketos/upstreaming, Thierry Reding, Rob Herring, linux-kernel, Bjorn Andersson, dri-devel, devicetree, David Airlie, Marijn Suijten, phone-devel, linux-arm-msm, Amit Pundir, Daniel Vetter, Sam Ravnborg, Andy Gross, Sumit Semwal On Fri, 01 Apr 2022 05:48:09 +0530, Joel Selvaraj wrote: > Add backlight property and update example to include it. > > Signed-off-by: Joel Selvaraj <jo@jsfamily.in> > --- > .../devicetree/bindings/display/panel/novatek,nt36672a.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: display: novatek,nt36672a: add backlight property 2022-04-01 0:18 ` [PATCH v2 2/3] dt-bindings: display: novatek, nt36672a: " Joel Selvaraj @ 2022-04-06 16:23 ` Marijn Suijten -1 siblings, 0 replies; 26+ messages in thread From: Marijn Suijten @ 2022-04-06 16:23 UTC (permalink / raw) To: Joel Selvaraj Cc: Amit Pundir, devicetree, David Airlie, linux-kernel, Andy Gross, dri-devel, Bjorn Andersson, Rob Herring, Thierry Reding, ~postmarketos/upstreaming, linux-arm-msm, phone-devel, Sam Ravnborg, Sumit Semwal On 2022-04-01 05:48:09, Joel Selvaraj wrote: > Add backlight property and update example to include it. > > Signed-off-by: Joel Selvaraj <jo@jsfamily.in> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > .../devicetree/bindings/display/panel/novatek,nt36672a.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml > index 563766d283f6..41ee3157a1cd 100644 > --- a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml > +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml > @@ -46,6 +46,7 @@ properties: > > reg: true > port: true > + backlight: true > > required: > - compatible > @@ -73,6 +74,7 @@ examples: > vddpos-supply = <&lab>; > vddneg-supply = <&ibb>; > > + backlight = <&pmi8998_wled>; > reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>; > > port { > -- > 2.35.1 > ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: display: novatek,nt36672a: add backlight property @ 2022-04-06 16:23 ` Marijn Suijten 0 siblings, 0 replies; 26+ messages in thread From: Marijn Suijten @ 2022-04-06 16:23 UTC (permalink / raw) To: Joel Selvaraj Cc: Sumit Semwal, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring, Andy Gross, Bjorn Andersson, dri-devel, devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Amit Pundir On 2022-04-01 05:48:09, Joel Selvaraj wrote: > Add backlight property and update example to include it. > > Signed-off-by: Joel Selvaraj <jo@jsfamily.in> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > .../devicetree/bindings/display/panel/novatek,nt36672a.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml > index 563766d283f6..41ee3157a1cd 100644 > --- a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml > +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml > @@ -46,6 +46,7 @@ properties: > > reg: true > port: true > + backlight: true > > required: > - compatible > @@ -73,6 +74,7 @@ examples: > vddpos-supply = <&lab>; > vddneg-supply = <&ibb>; > > + backlight = <&pmi8998_wled>; > reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>; > > port { > -- > 2.35.1 > ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v2 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel [not found] <20220401001810.81507-1-jo@jsfamily.in> @ 2022-04-01 0:18 ` Joel Selvaraj 2022-04-01 0:18 ` [PATCH v2 2/3] dt-bindings: display: novatek, nt36672a: " Joel Selvaraj 2022-04-01 0:18 ` Joel Selvaraj 2 siblings, 0 replies; 26+ messages in thread From: Joel Selvaraj @ 2022-04-01 0:18 UTC (permalink / raw) To: Sumit Semwal, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring, Andy Gross, Bjorn Andersson Cc: dri-devel, devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Amit Pundir, Marijn Suijten, Joel Selvaraj Xiaomi Poco F1 uses the QCOM WLED driver for backlight control. Enable and link it to the panel to use it. Signed-off-by: Joel Selvaraj <jo@jsfamily.in> --- Changes in v2: - Remove qcom,enabled-strings property as either it or qcom,num-strings should be present. qcom,num-strings is specified and sufficient. (Marijn Suijten's Suggestion) arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts index 798fc72578a7..d88dc07205f7 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts @@ -231,6 +231,7 @@ panel@0 { #address-cells = <1>; #size-cells = <0>; + backlight = <&pmi8998_wled>; reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>; port { @@ -314,6 +315,17 @@ vol_up_pin_a: vol-up-active { }; }; +&pmi8998_wled { + status = "okay"; + qcom,current-boost-limit = <970>; + qcom,ovp-millivolt = <29600>; + qcom,current-limit-microamp = <20000>; + qcom,num-strings = <2>; + qcom,switching-freq = <600>; + qcom,external-pfet; + qcom,cabc; +}; + &pm8998_pon { resin { compatible = "qcom,pm8941-resin"; -- 2.35.1 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH v2 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel @ 2022-04-01 0:18 ` Joel Selvaraj 0 siblings, 0 replies; 26+ messages in thread From: Joel Selvaraj @ 2022-04-01 0:18 UTC (permalink / raw) To: Sumit Semwal, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring, Andy Gross, Bjorn Andersson Cc: Amit Pundir, devicetree, linux-arm-msm, linux-kernel, dri-devel, ~postmarketos/upstreaming, Marijn Suijten, phone-devel, Joel Selvaraj Xiaomi Poco F1 uses the QCOM WLED driver for backlight control. Enable and link it to the panel to use it. Signed-off-by: Joel Selvaraj <jo@jsfamily.in> --- Changes in v2: - Remove qcom,enabled-strings property as either it or qcom,num-strings should be present. qcom,num-strings is specified and sufficient. (Marijn Suijten's Suggestion) arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts index 798fc72578a7..d88dc07205f7 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts @@ -231,6 +231,7 @@ panel@0 { #address-cells = <1>; #size-cells = <0>; + backlight = <&pmi8998_wled>; reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>; port { @@ -314,6 +315,17 @@ vol_up_pin_a: vol-up-active { }; }; +&pmi8998_wled { + status = "okay"; + qcom,current-boost-limit = <970>; + qcom,ovp-millivolt = <29600>; + qcom,current-limit-microamp = <20000>; + qcom,num-strings = <2>; + qcom,switching-freq = <600>; + qcom,external-pfet; + qcom,cabc; +}; + &pm8998_pon { resin { compatible = "qcom,pm8941-resin"; -- 2.35.1 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel 2022-04-01 0:18 ` Joel Selvaraj @ 2022-04-06 16:21 ` Marijn Suijten -1 siblings, 0 replies; 26+ messages in thread From: Marijn Suijten @ 2022-04-06 16:21 UTC (permalink / raw) To: Joel Selvaraj Cc: Amit Pundir, devicetree, David Airlie, linux-kernel, Andy Gross, dri-devel, Bjorn Andersson, Rob Herring, Thierry Reding, ~postmarketos/upstreaming, linux-arm-msm, phone-devel, Sam Ravnborg, Sumit Semwal On 2022-04-01 05:48:10, Joel Selvaraj wrote: > Xiaomi Poco F1 uses the QCOM WLED driver for backlight control. > Enable and link it to the panel to use it. > > Signed-off-by: Joel Selvaraj <jo@jsfamily.in> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > Changes in v2: > - Remove qcom,enabled-strings property as either it or qcom,num-strings > should be present. qcom,num-strings is specified and sufficient. > (Marijn Suijten's Suggestion) Thanks :) > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts > index 798fc72578a7..d88dc07205f7 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts > @@ -231,6 +231,7 @@ panel@0 { > #address-cells = <1>; > #size-cells = <0>; > > + backlight = <&pmi8998_wled>; > reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>; > > port { > @@ -314,6 +315,17 @@ vol_up_pin_a: vol-up-active { > }; > }; > > +&pmi8998_wled { > + status = "okay"; > + qcom,current-boost-limit = <970>; > + qcom,ovp-millivolt = <29600>; > + qcom,current-limit-microamp = <20000>; > + qcom,num-strings = <2>; > + qcom,switching-freq = <600>; > + qcom,external-pfet; > + qcom,cabc; Unlike the number of connected strings and configured ovp/current limits, aren't external-pfet (and probably switching-freq, perhaps CABC) hardware features that are common across all users of `pmi8998`? - Marijn > +}; > + > &pm8998_pon { > resin { > compatible = "qcom,pm8941-resin"; > -- > 2.35.1 > ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel @ 2022-04-06 16:21 ` Marijn Suijten 0 siblings, 0 replies; 26+ messages in thread From: Marijn Suijten @ 2022-04-06 16:21 UTC (permalink / raw) To: Joel Selvaraj Cc: Sumit Semwal, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring, Andy Gross, Bjorn Andersson, dri-devel, devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Amit Pundir On 2022-04-01 05:48:10, Joel Selvaraj wrote: > Xiaomi Poco F1 uses the QCOM WLED driver for backlight control. > Enable and link it to the panel to use it. > > Signed-off-by: Joel Selvaraj <jo@jsfamily.in> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > Changes in v2: > - Remove qcom,enabled-strings property as either it or qcom,num-strings > should be present. qcom,num-strings is specified and sufficient. > (Marijn Suijten's Suggestion) Thanks :) > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts > index 798fc72578a7..d88dc07205f7 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts > @@ -231,6 +231,7 @@ panel@0 { > #address-cells = <1>; > #size-cells = <0>; > > + backlight = <&pmi8998_wled>; > reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>; > > port { > @@ -314,6 +315,17 @@ vol_up_pin_a: vol-up-active { > }; > }; > > +&pmi8998_wled { > + status = "okay"; > + qcom,current-boost-limit = <970>; > + qcom,ovp-millivolt = <29600>; > + qcom,current-limit-microamp = <20000>; > + qcom,num-strings = <2>; > + qcom,switching-freq = <600>; > + qcom,external-pfet; > + qcom,cabc; Unlike the number of connected strings and configured ovp/current limits, aren't external-pfet (and probably switching-freq, perhaps CABC) hardware features that are common across all users of `pmi8998`? - Marijn > +}; > + > &pm8998_pon { > resin { > compatible = "qcom,pm8941-resin"; > -- > 2.35.1 > ^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2022-06-09 7:36 UTC | newest] Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20220401001810.81507-1-jo@jsfamily.in> 2022-04-01 0:18 ` [PATCH v2 1/3] drm/panel: nt36672a: add backlight support Joel Selvaraj 2022-04-01 0:18 ` Joel Selvaraj 2022-04-06 16:18 ` Marijn Suijten 2022-04-06 16:18 ` Marijn Suijten 2022-04-21 14:26 ` (subset) " Bjorn Andersson 2022-04-21 14:26 ` Bjorn Andersson 2022-06-07 18:31 ` Joel Selvaraj 2022-06-07 18:31 ` Joel Selvaraj 2022-06-08 16:30 ` Sumit Semwal 2022-06-08 16:30 ` Sumit Semwal 2022-06-08 16:40 ` Joel Selvaraj 2022-06-08 16:40 ` Joel Selvaraj 2022-06-08 17:52 ` Sumit Semwal 2022-06-08 17:52 ` Sumit Semwal 2022-06-08 17:55 ` Joel Selvaraj 2022-06-08 17:55 ` Joel Selvaraj 2022-04-01 0:18 ` [PATCH v2 2/3] dt-bindings: display: novatek,nt36672a: add backlight property Joel Selvaraj 2022-04-01 0:18 ` [PATCH v2 2/3] dt-bindings: display: novatek, nt36672a: " Joel Selvaraj 2022-04-06 16:05 ` [PATCH v2 2/3] dt-bindings: display: novatek,nt36672a: " Rob Herring 2022-04-06 16:05 ` Rob Herring 2022-04-06 16:23 ` Marijn Suijten 2022-04-06 16:23 ` Marijn Suijten 2022-04-01 0:18 ` [PATCH v2 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel Joel Selvaraj 2022-04-01 0:18 ` Joel Selvaraj 2022-04-06 16:21 ` Marijn Suijten 2022-04-06 16:21 ` Marijn Suijten
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.