All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: broonie@kernel.org
Cc: Manohar.Puri@microchip.com, UNGLinuxDriver@microchip.com,
	alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com,
	devicetree@vger.kernel.org, kavyasree.kotagiri@microchip.com,
	krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	nicolas.ferre@microchip.com, robh+dt@kernel.org,
	tudor.ambarus@microchip.com, Michael Walle <michael@walle.cc>
Subject: Re: [PATCH] spi: atmel,quadspi: Define lan966x QSPI
Date: Thu,  7 Apr 2022 13:23:45 +0200	[thread overview]
Message-ID: <20220407112345.148316-1-michael@walle.cc> (raw)
In-Reply-To: <Yk7Ex5ltaxC7Z+N6@sirena.org.uk>

> > @@ -19,6 +19,7 @@ properties:
> >        - microchip,sam9x60-qspi
> >        - microchip,sama7g5-qspi
> >        - microchip,sama7g5-ospi
> > +      - microchip,lan966x-qspi
> 
> Generally DT compatibles should be for specific SoCs rather than having
> wildcards in them, even if that means you have to list a lot of SoCs.
> Having used wildcards in the past doesn't mean it's a good idea to
> continue adding them!

The subject should also be prefixed with "dt-bindings: ".

Mark, I did a git log on
Documentation/devicetree/bindings/spi/atmel,quadspi.yaml and all the
subjects are without "dt-bindings:" although the original patch was with
that prefix [1]. Is that intended?

-michael

[1] https://lore.kernel.org/linux-devicetree/163962128492.2075495.3678727080606971257.b4-ty@kernel.org/

WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc>
To: broonie@kernel.org
Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com,
	tudor.ambarus@microchip.com, linux-kernel@vger.kernel.org,
	UNGLinuxDriver@microchip.com, Michael Walle <michael@walle.cc>,
	robh+dt@kernel.org, kavyasree.kotagiri@microchip.com,
	Manohar.Puri@microchip.com, krzk+dt@kernel.org,
	linux-spi@vger.kernel.org, claudiu.beznea@microchip.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] spi: atmel,quadspi: Define lan966x QSPI
Date: Thu,  7 Apr 2022 13:23:45 +0200	[thread overview]
Message-ID: <20220407112345.148316-1-michael@walle.cc> (raw)
In-Reply-To: <Yk7Ex5ltaxC7Z+N6@sirena.org.uk>

> > @@ -19,6 +19,7 @@ properties:
> >        - microchip,sam9x60-qspi
> >        - microchip,sama7g5-qspi
> >        - microchip,sama7g5-ospi
> > +      - microchip,lan966x-qspi
> 
> Generally DT compatibles should be for specific SoCs rather than having
> wildcards in them, even if that means you have to list a lot of SoCs.
> Having used wildcards in the past doesn't mean it's a good idea to
> continue adding them!

The subject should also be prefixed with "dt-bindings: ".

Mark, I did a git log on
Documentation/devicetree/bindings/spi/atmel,quadspi.yaml and all the
subjects are without "dt-bindings:" although the original patch was with
that prefix [1]. Is that intended?

-michael

[1] https://lore.kernel.org/linux-devicetree/163962128492.2075495.3678727080606971257.b4-ty@kernel.org/

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-07 11:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 10:54 [PATCH] spi: atmel,quadspi: Define lan966x QSPI Kavyasree Kotagiri
2022-04-07 10:54 ` Kavyasree Kotagiri
2022-04-07 11:02 ` Mark Brown
2022-04-07 11:02   ` Mark Brown
2022-04-07 11:23   ` Michael Walle [this message]
2022-04-07 11:23     ` Michael Walle
2022-04-07 11:31     ` Mark Brown
2022-04-07 11:31       ` Mark Brown
2022-04-07 11:41       ` Michael Walle
2022-04-07 11:41         ` Michael Walle
2022-04-07 12:04         ` Krzysztof Kozlowski
2022-04-07 12:04           ` Krzysztof Kozlowski
2022-04-07 12:05 ` Krzysztof Kozlowski
2022-04-07 12:05   ` Krzysztof Kozlowski
2022-04-07 12:54 ` Tudor.Ambarus
2022-04-07 12:54   ` Tudor.Ambarus
2022-04-08 11:52   ` Kavyasree.Kotagiri
2022-04-08 11:52     ` Kavyasree.Kotagiri
2022-04-11 14:46     ` Michael Walle
2022-04-11 14:46       ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220407112345.148316-1-michael@walle.cc \
    --to=michael@walle.cc \
    --cc=Manohar.Puri@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=claudiu.beznea@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kavyasree.kotagiri@microchip.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh+dt@kernel.org \
    --cc=tudor.ambarus@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.