* [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible
@ 2022-04-07 14:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-07 14:31 UTC (permalink / raw)
To: Nishanth Menon, Santosh Shilimkar, Rob Herring,
Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Vendor prefix in compatible should be lower-case.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +-
arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/keystone-k2e-evm.dts b/arch/arm/boot/dts/keystone-k2e-evm.dts
index 8f49883a675e..9e507293a8d7 100644
--- a/arch/arm/boot/dts/keystone-k2e-evm.dts
+++ b/arch/arm/boot/dts/keystone-k2e-evm.dts
@@ -140,7 +140,7 @@ &spi0 {
nor_flash: flash@0 {
#address-cells = <1>;
#size-cells = <1>;
- compatible = "Micron,n25q128a11";
+ compatible = "micron,n25q128a11";
spi-max-frequency = <54000000>;
m25p,fast-read;
reg = <0>;
diff --git a/arch/arm/boot/dts/keystone-k2hk-evm.dts b/arch/arm/boot/dts/keystone-k2hk-evm.dts
index f968af0bfad3..1a1a49c19a19 100644
--- a/arch/arm/boot/dts/keystone-k2hk-evm.dts
+++ b/arch/arm/boot/dts/keystone-k2hk-evm.dts
@@ -164,7 +164,7 @@ &spi0 {
nor_flash: flash@0 {
#address-cells = <1>;
#size-cells = <1>;
- compatible = "Micron,n25q128a11";
+ compatible = "micron,n25q128a11";
spi-max-frequency = <54000000>;
m25p,fast-read;
reg = <0>;
diff --git a/arch/arm/boot/dts/keystone-k2l-evm.dts b/arch/arm/boot/dts/keystone-k2l-evm.dts
index 32619b3c5804..06d55b89170d 100644
--- a/arch/arm/boot/dts/keystone-k2l-evm.dts
+++ b/arch/arm/boot/dts/keystone-k2l-evm.dts
@@ -113,7 +113,7 @@ &spi0 {
nor_flash: flash@0 {
#address-cells = <1>;
#size-cells = <1>;
- compatible = "Micron,n25q128a11";
+ compatible = "micron,n25q128a11";
spi-max-frequency = <54000000>;
m25p,fast-read;
reg = <0>;
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible
2022-04-07 14:31 ` Krzysztof Kozlowski
@ 2022-04-08 9:58 ` Grygorii Strashko
-1 siblings, 0 replies; 12+ messages in thread
From: Grygorii Strashko @ 2022-04-08 9:58 UTC (permalink / raw)
To: Krzysztof Kozlowski, Nishanth Menon, Santosh Shilimkar,
Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree,
linux-kernel
Cc: Roger Quadros
On 07/04/2022 17:31, Krzysztof Kozlowski wrote:
> Vendor prefix in compatible should be lower-case.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/keystone-k2e-evm.dts b/arch/arm/boot/dts/keystone-k2e-evm.dts
> index 8f49883a675e..9e507293a8d7 100644
> --- a/arch/arm/boot/dts/keystone-k2e-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2e-evm.dts
> @@ -140,7 +140,7 @@ &spi0 {
> nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "Micron,n25q128a11";
> + compatible = "micron,n25q128a11";
> spi-max-frequency = <54000000>;
> m25p,fast-read;
> reg = <0>;
> diff --git a/arch/arm/boot/dts/keystone-k2hk-evm.dts b/arch/arm/boot/dts/keystone-k2hk-evm.dts
> index f968af0bfad3..1a1a49c19a19 100644
> --- a/arch/arm/boot/dts/keystone-k2hk-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2hk-evm.dts
> @@ -164,7 +164,7 @@ &spi0 {
> nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "Micron,n25q128a11";
> + compatible = "micron,n25q128a11";
> spi-max-frequency = <54000000>;
> m25p,fast-read;
> reg = <0>;
> diff --git a/arch/arm/boot/dts/keystone-k2l-evm.dts b/arch/arm/boot/dts/keystone-k2l-evm.dts
> index 32619b3c5804..06d55b89170d 100644
> --- a/arch/arm/boot/dts/keystone-k2l-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2l-evm.dts
> @@ -113,7 +113,7 @@ &spi0 {
> nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "Micron,n25q128a11";
> + compatible = "micron,n25q128a11";
> spi-max-frequency = <54000000>;
> m25p,fast-read;
> reg = <0>;
Thanks you.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
Best regards,
Grygorii, Ukraine
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible
@ 2022-04-08 9:58 ` Grygorii Strashko
0 siblings, 0 replies; 12+ messages in thread
From: Grygorii Strashko @ 2022-04-08 9:58 UTC (permalink / raw)
To: Krzysztof Kozlowski, Nishanth Menon, Santosh Shilimkar,
Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree,
linux-kernel
Cc: Roger Quadros
On 07/04/2022 17:31, Krzysztof Kozlowski wrote:
> Vendor prefix in compatible should be lower-case.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/keystone-k2e-evm.dts b/arch/arm/boot/dts/keystone-k2e-evm.dts
> index 8f49883a675e..9e507293a8d7 100644
> --- a/arch/arm/boot/dts/keystone-k2e-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2e-evm.dts
> @@ -140,7 +140,7 @@ &spi0 {
> nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "Micron,n25q128a11";
> + compatible = "micron,n25q128a11";
> spi-max-frequency = <54000000>;
> m25p,fast-read;
> reg = <0>;
> diff --git a/arch/arm/boot/dts/keystone-k2hk-evm.dts b/arch/arm/boot/dts/keystone-k2hk-evm.dts
> index f968af0bfad3..1a1a49c19a19 100644
> --- a/arch/arm/boot/dts/keystone-k2hk-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2hk-evm.dts
> @@ -164,7 +164,7 @@ &spi0 {
> nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "Micron,n25q128a11";
> + compatible = "micron,n25q128a11";
> spi-max-frequency = <54000000>;
> m25p,fast-read;
> reg = <0>;
> diff --git a/arch/arm/boot/dts/keystone-k2l-evm.dts b/arch/arm/boot/dts/keystone-k2l-evm.dts
> index 32619b3c5804..06d55b89170d 100644
> --- a/arch/arm/boot/dts/keystone-k2l-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2l-evm.dts
> @@ -113,7 +113,7 @@ &spi0 {
> nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "Micron,n25q128a11";
> + compatible = "micron,n25q128a11";
> spi-max-frequency = <54000000>;
> m25p,fast-read;
> reg = <0>;
Thanks you.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
Best regards,
Grygorii, Ukraine
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible
2022-04-07 14:31 ` Krzysztof Kozlowski
@ 2022-04-15 18:54 ` Nishanth Menon
-1 siblings, 0 replies; 12+ messages in thread
From: Nishanth Menon @ 2022-04-15 18:54 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Santosh Shilimkar, Rob Herring, Krzysztof Kozlowski,
linux-arm-kernel, devicetree, linux-kernel
On 16:31-20220407, Krzysztof Kozlowski wrote:
> Vendor prefix in compatible should be lower-case.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/keystone-k2e-evm.dts b/arch/arm/boot/dts/keystone-k2e-evm.dts
> index 8f49883a675e..9e507293a8d7 100644
> --- a/arch/arm/boot/dts/keystone-k2e-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2e-evm.dts
> @@ -140,7 +140,7 @@ &spi0 {
> nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "Micron,n25q128a11";
> + compatible = "micron,n25q128a11";
> spi-max-frequency = <54000000>;
> m25p,fast-read;
> reg = <0>;
> diff --git a/arch/arm/boot/dts/keystone-k2hk-evm.dts b/arch/arm/boot/dts/keystone-k2hk-evm.dts
> index f968af0bfad3..1a1a49c19a19 100644
> --- a/arch/arm/boot/dts/keystone-k2hk-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2hk-evm.dts
> @@ -164,7 +164,7 @@ &spi0 {
> nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "Micron,n25q128a11";
> + compatible = "micron,n25q128a11";
> spi-max-frequency = <54000000>;
> m25p,fast-read;
> reg = <0>;
> diff --git a/arch/arm/boot/dts/keystone-k2l-evm.dts b/arch/arm/boot/dts/keystone-k2l-evm.dts
> index 32619b3c5804..06d55b89170d 100644
> --- a/arch/arm/boot/dts/keystone-k2l-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2l-evm.dts
> @@ -113,7 +113,7 @@ &spi0 {
> nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "Micron,n25q128a11";
> + compatible = "micron,n25q128a11";
> spi-max-frequency = <54000000>;
> m25p,fast-read;
> reg = <0>;
I have no idea how this works. There is no documentation for the
compatible, So I am guessing adding it to Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
is appropriate prior to replacing with "micron,n25q128a11", "jedec,spi-nor";
$ git grep micron,n25q128a11 .
arch/arm/boot/dts/imx6qdl-aristainetos.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor";
arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor";
arch/arm/boot/dts/keystone-k2e-evm.dts: compatible = "micron,n25q128a11";
arch/arm/boot/dts/keystone-k2hk-evm.dts: compatible = "micron,n25q128a11";
arch/arm/boot/dts/keystone-k2l-evm.dts: compatible = "micron,n25q128a11";
arch/powerpc/boot/dts/fsl/t1024qds.dts: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */
arch/powerpc/boot/dts/fsl/t104xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor";
arch/powerpc/boot/dts/fsl/t208xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible
@ 2022-04-15 18:54 ` Nishanth Menon
0 siblings, 0 replies; 12+ messages in thread
From: Nishanth Menon @ 2022-04-15 18:54 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Santosh Shilimkar, Rob Herring, Krzysztof Kozlowski,
linux-arm-kernel, devicetree, linux-kernel
On 16:31-20220407, Krzysztof Kozlowski wrote:
> Vendor prefix in compatible should be lower-case.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/keystone-k2e-evm.dts b/arch/arm/boot/dts/keystone-k2e-evm.dts
> index 8f49883a675e..9e507293a8d7 100644
> --- a/arch/arm/boot/dts/keystone-k2e-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2e-evm.dts
> @@ -140,7 +140,7 @@ &spi0 {
> nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "Micron,n25q128a11";
> + compatible = "micron,n25q128a11";
> spi-max-frequency = <54000000>;
> m25p,fast-read;
> reg = <0>;
> diff --git a/arch/arm/boot/dts/keystone-k2hk-evm.dts b/arch/arm/boot/dts/keystone-k2hk-evm.dts
> index f968af0bfad3..1a1a49c19a19 100644
> --- a/arch/arm/boot/dts/keystone-k2hk-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2hk-evm.dts
> @@ -164,7 +164,7 @@ &spi0 {
> nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "Micron,n25q128a11";
> + compatible = "micron,n25q128a11";
> spi-max-frequency = <54000000>;
> m25p,fast-read;
> reg = <0>;
> diff --git a/arch/arm/boot/dts/keystone-k2l-evm.dts b/arch/arm/boot/dts/keystone-k2l-evm.dts
> index 32619b3c5804..06d55b89170d 100644
> --- a/arch/arm/boot/dts/keystone-k2l-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2l-evm.dts
> @@ -113,7 +113,7 @@ &spi0 {
> nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "Micron,n25q128a11";
> + compatible = "micron,n25q128a11";
> spi-max-frequency = <54000000>;
> m25p,fast-read;
> reg = <0>;
I have no idea how this works. There is no documentation for the
compatible, So I am guessing adding it to Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
is appropriate prior to replacing with "micron,n25q128a11", "jedec,spi-nor";
$ git grep micron,n25q128a11 .
arch/arm/boot/dts/imx6qdl-aristainetos.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor";
arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor";
arch/arm/boot/dts/keystone-k2e-evm.dts: compatible = "micron,n25q128a11";
arch/arm/boot/dts/keystone-k2hk-evm.dts: compatible = "micron,n25q128a11";
arch/arm/boot/dts/keystone-k2l-evm.dts: compatible = "micron,n25q128a11";
arch/powerpc/boot/dts/fsl/t1024qds.dts: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */
arch/powerpc/boot/dts/fsl/t104xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor";
arch/powerpc/boot/dts/fsl/t208xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible
2022-04-15 18:54 ` Nishanth Menon
@ 2022-04-17 17:58 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-17 17:58 UTC (permalink / raw)
To: Nishanth Menon
Cc: Santosh Shilimkar, Rob Herring, Krzysztof Kozlowski,
linux-arm-kernel, devicetree, linux-kernel
On 15/04/2022 20:54, Nishanth Menon wrote:
>
> I have no idea how this works. There is no documentation for the
> compatible, So I am guessing adding it to Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> is appropriate prior to replacing with "micron,n25q128a11", "jedec,spi-nor";
Compatible is documented in jedec,spi-nor.yaml (through pattern),
although it should be followed by "jedec,spi-nor", according to schema.
I did not fix that missing compatible fallback, because I did not want
to break any setup (I cannot test it), but adding the fallback seems
harmless/safe.
>
> $ git grep micron,n25q128a11 .
> arch/arm/boot/dts/imx6qdl-aristainetos.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor";
> arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor";
> arch/arm/boot/dts/keystone-k2e-evm.dts: compatible = "micron,n25q128a11";
> arch/arm/boot/dts/keystone-k2hk-evm.dts: compatible = "micron,n25q128a11";
> arch/arm/boot/dts/keystone-k2l-evm.dts: compatible = "micron,n25q128a11";
> arch/powerpc/boot/dts/fsl/t1024qds.dts: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */
> arch/powerpc/boot/dts/fsl/t104xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor";
> arch/powerpc/boot/dts/fsl/t208xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */
>
>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible
@ 2022-04-17 17:58 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-17 17:58 UTC (permalink / raw)
To: Nishanth Menon
Cc: Santosh Shilimkar, Rob Herring, Krzysztof Kozlowski,
linux-arm-kernel, devicetree, linux-kernel
On 15/04/2022 20:54, Nishanth Menon wrote:
>
> I have no idea how this works. There is no documentation for the
> compatible, So I am guessing adding it to Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> is appropriate prior to replacing with "micron,n25q128a11", "jedec,spi-nor";
Compatible is documented in jedec,spi-nor.yaml (through pattern),
although it should be followed by "jedec,spi-nor", according to schema.
I did not fix that missing compatible fallback, because I did not want
to break any setup (I cannot test it), but adding the fallback seems
harmless/safe.
>
> $ git grep micron,n25q128a11 .
> arch/arm/boot/dts/imx6qdl-aristainetos.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor";
> arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor";
> arch/arm/boot/dts/keystone-k2e-evm.dts: compatible = "micron,n25q128a11";
> arch/arm/boot/dts/keystone-k2hk-evm.dts: compatible = "micron,n25q128a11";
> arch/arm/boot/dts/keystone-k2l-evm.dts: compatible = "micron,n25q128a11";
> arch/powerpc/boot/dts/fsl/t1024qds.dts: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */
> arch/powerpc/boot/dts/fsl/t104xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor";
> arch/powerpc/boot/dts/fsl/t208xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */
>
>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread