All of lore.kernel.org
 help / color / mirror / Atom feed
From: Coiby Xu <coxu@redhat.com>
To: "Baoquan He" <bhe@redhat.com>, "Michal Suchánek" <msuchanek@suse.de>
Cc: kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
	Dave Young <dyoung@redhat.com>, Will Deacon <will@kernel.org>,
	"Eric W . Biederman" <ebiederm@xmission.com>,
	akpm@linux-foundation.org
Subject: Re: [PATCH v5 0/3] use more system keyrings to verify arm64 kdump kernel image signature
Date: Mon, 11 Apr 2022 09:52:18 +0800	[thread overview]
Message-ID: <20220411015218.ckw42xx5rrhidhpd@Rk> (raw)
In-Reply-To: <YlOAvM4qpSlHczOd@MiWiFi-R3L-srv>

On Mon, Apr 11, 2022 at 09:13:32AM +0800, Baoquan He wrote:
>On 04/08/22 at 10:59am, Michal Suchánek wrote:
>> On Fri, Apr 08, 2022 at 03:17:19PM +0800, Baoquan He wrote:
>> > Hi Coiby,
>> >
>> > On 04/01/22 at 09:31am, Coiby Xu wrote:
>> > > Currently, a problem faced by arm64 is if a kernel image is signed by a
>> > > MOK key, loading it via the kexec_file_load() system call would be
>> > > rejected with the error "Lockdown: kexec: kexec of unsigned images is
>> > > restricted; see man kernel_lockdown.7".
>> > >
>> > > This patch set allows arm64 to use more system keyrings to verify kdump
>> > > kernel image signature by making the existing code in x64 public.
>> >
>> > Thanks for updating. It would be great to tell why the problem is
>> > met, then allow arm64 to use more system keyrings can solve it.
>>
>> The reason is that MOK keys are (if anywhere) linked to the secondary
                                                                ^^^^^^^^^
                                                                platform?
>> keyring, and only primary keyring is used on arm64.

Thanks Michal for providing the info! Btw, I think you made a typo
because MOK keys are linked to the platform keyring, right?

>
>Thanks for explaining. This is valuable information and should
>be put into log for better understanding when reviewing or
>reading code later.

Thanks for the reminder! I'll include this info in the commit message.

>

-- 
Best regards,
Coiby


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Coiby Xu <coxu@redhat.com>
To: kexec@lists.infradead.org
Subject: [PATCH v5 0/3] use more system keyrings to verify arm64 kdump kernel image signature
Date: Mon, 11 Apr 2022 09:52:18 +0800	[thread overview]
Message-ID: <20220411015218.ckw42xx5rrhidhpd@Rk> (raw)
In-Reply-To: <YlOAvM4qpSlHczOd@MiWiFi-R3L-srv>

On Mon, Apr 11, 2022 at 09:13:32AM +0800, Baoquan He wrote:
>On 04/08/22 at 10:59am, Michal Such?nek wrote:
>> On Fri, Apr 08, 2022 at 03:17:19PM +0800, Baoquan He wrote:
>> > Hi Coiby,
>> >
>> > On 04/01/22 at 09:31am, Coiby Xu wrote:
>> > > Currently, a problem faced by arm64 is if a kernel image is signed by a
>> > > MOK key, loading it via the kexec_file_load() system call would be
>> > > rejected with the error "Lockdown: kexec: kexec of unsigned images is
>> > > restricted; see man kernel_lockdown.7".
>> > >
>> > > This patch set allows arm64 to use more system keyrings to verify kdump
>> > > kernel image signature by making the existing code in x64 public.
>> >
>> > Thanks for updating. It would be great to tell why the problem is
>> > met, then allow arm64 to use more system keyrings can solve it.
>>
>> The reason is that MOK keys are (if anywhere) linked to the secondary
                                                                ^^^^^^^^^
                                                                platform?
>> keyring, and only primary keyring is used on arm64.

Thanks Michal for providing the info! Btw, I think you made a typo
because MOK keys are linked to the platform keyring, right?

>
>Thanks for explaining. This is valuable information and should
>be put into log for better understanding when reviewing or
>reading code later.

Thanks for the reminder! I'll include this info in the commit message.

>

-- 
Best regards,
Coiby



  reply	other threads:[~2022-04-11  1:56 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-01  1:31 [PATCH v5 0/3] use more system keyrings to verify arm64 kdump kernel image signature Coiby Xu
2022-04-01  1:31 ` Coiby Xu
2022-04-01  1:31 ` [PATCH v5 1/3] kexec: clean up arch_kexec_kernel_verify_sig Coiby Xu
2022-04-01  1:31   ` Coiby Xu
2022-04-01  1:31   ` Coiby Xu
2022-04-11  9:01   ` Michal Suchánek
2022-04-11  9:01     ` Michal =?unknown-8bit?q?Such=C3=A1nek?=
2022-04-11  9:01     ` Michal Suchánek
2022-04-01  1:31 ` [PATCH v5 2/3] kexec, KEYS: make the code in bzImage64_verify_sig generic Coiby Xu
2022-04-01  1:31   ` Coiby Xu
2022-04-01  1:31   ` Coiby Xu
2022-04-11  8:54   ` Michal Suchánek
2022-04-11  8:54     ` Michal =?unknown-8bit?q?Such=C3=A1nek?=
2022-04-11  8:54     ` Michal Suchánek
2022-04-14  1:46     ` Coiby Xu
2022-04-14  1:46       ` Coiby Xu
2022-04-14  1:46       ` Coiby Xu
2022-04-01  1:31 ` [PATCH v5 3/3] arm64: kexec_file: use more system keyrings to verify kernel image signature Coiby Xu
2022-04-01  1:31   ` Coiby Xu
2022-04-01  1:31   ` Coiby Xu
2022-04-11  8:59   ` Michal Suchánek
2022-04-11  8:59     ` Michal =?unknown-8bit?q?Such=C3=A1nek?=
2022-04-11  8:59     ` Michal Suchánek
2022-04-14  1:44     ` Coiby Xu
2022-04-14  1:44       ` Coiby Xu
2022-04-14  1:44       ` Coiby Xu
2022-04-08  7:17 ` [PATCH v5 0/3] use more system keyrings to verify arm64 kdump " Baoquan He
2022-04-08  7:17   ` Baoquan He
2022-04-08  8:59   ` Michal Suchánek
2022-04-08  8:59     ` Michal =?unknown-8bit?q?Such=C3=A1nek?=
2022-04-11  1:13     ` Baoquan He
2022-04-11  1:13       ` Baoquan He
2022-04-11  1:52       ` Coiby Xu [this message]
2022-04-11  1:52         ` Coiby Xu
2022-04-11  8:43         ` Michal Suchánek
2022-04-11  8:43           ` Michal =?unknown-8bit?q?Such=C3=A1nek?=
2022-04-13  9:32           ` Coiby Xu
2022-04-13  9:32             ` Coiby Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220411015218.ckw42xx5rrhidhpd@Rk \
    --to=coxu@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=msuchanek@suse.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.