From: Javier Martinez Canillas <javierm@redhat.com> To: linux-kernel@vger.kernel.org Cc: Rob Herring <robh@kernel.org>, dri-devel@lists.freedesktop.org, Neil Armstrong <narmstrong@baylibre.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Mark Brown <broonie@kernel.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Chen-Yu Tsai <wens@kernel.org>, Javier Martinez Canillas <javierm@redhat.com>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Maxime Ripard <mripard@kernel.org>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org Subject: [PATCH v2 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings Date: Mon, 11 Apr 2022 23:12:39 +0200 [thread overview] Message-ID: <20220411211243.11121-2-javierm@redhat.com> (raw) In-Reply-To: <20220411211243.11121-1-javierm@redhat.com> The current compatible strings for SSD130x I2C controllers contain both an "fb" and "-i2c" suffixes. It seems to indicate that are for a fbdev driver and also that are for devices that can be accessed over an I2C bus. But a DT is supposed to describe the hardware and not Linux implementation details. So let's deprecate those compatible strings and add new ones that only contain the vendor and device name, without any of these suffixes. These will just describe the device and can be matched by both I2C and SPI DRM drivers. Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Acked-by: Mark Brown <broonie@kernel.org> --- Changes in v2: - Drop the -i2c suffixes from the compatible strings too (Geert Uytterhoeven). .../bindings/display/solomon,ssd1307fb.yaml | 37 ++++++++++++------- 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml index ade61d502edd..6b9d0c72739a 100644 --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml @@ -12,12 +12,23 @@ maintainers: properties: compatible: - enum: - - sinowealth,sh1106-i2c - - solomon,ssd1305fb-i2c - - solomon,ssd1306fb-i2c - - solomon,ssd1307fb-i2c - - solomon,ssd1309fb-i2c + oneOf: + # Deprecated compatible strings + - items: + - enum: + - sinowealth,sh1106-i2c + - solomon,ssd1305fb-i2c + - solomon,ssd1306fb-i2c + - solomon,ssd1307fb-i2c + - solomon,ssd1309fb-i2c + deprecated: true + - items: + - enum: + - sinowealth,sh1106 + - solomon,ssd1305 + - solomon,ssd1306 + - solomon,ssd1307 + - solomon,ssd1309 reg: maxItems: 1 @@ -136,7 +147,7 @@ allOf: properties: compatible: contains: - const: sinowealth,sh1106-i2c + const: sinowealth,sh1106 then: properties: solomon,dclk-div: @@ -148,7 +159,7 @@ allOf: properties: compatible: contains: - const: solomon,ssd1305fb-i2c + const: solomon,ssd1305 then: properties: solomon,dclk-div: @@ -160,7 +171,7 @@ allOf: properties: compatible: contains: - const: solomon,ssd1306fb-i2c + const: solomon,ssd1306 then: properties: solomon,dclk-div: @@ -172,7 +183,7 @@ allOf: properties: compatible: contains: - const: solomon,ssd1307fb-i2c + const: solomon,ssd1307 then: properties: solomon,dclk-div: @@ -186,7 +197,7 @@ allOf: properties: compatible: contains: - const: solomon,ssd1309fb-i2c + const: solomon,ssd1309 then: properties: solomon,dclk-div: @@ -203,14 +214,14 @@ examples: #size-cells = <0>; ssd1307: oled@3c { - compatible = "solomon,ssd1307fb-i2c"; + compatible = "solomon,ssd1307"; reg = <0x3c>; pwms = <&pwm 4 3000>; reset-gpios = <&gpio2 7>; }; ssd1306: oled@3d { - compatible = "solomon,ssd1306fb-i2c"; + compatible = "solomon,ssd1306"; reg = <0x3c>; pwms = <&pwm 4 3000>; reset-gpios = <&gpio2 7>; -- 2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javierm@redhat.com> To: linux-kernel@vger.kernel.org Cc: Chen-Yu Tsai <wens@kernel.org>, Neil Armstrong <narmstrong@baylibre.com>, David Airlie <airlied@linux.ie>, Javier Martinez Canillas <javierm@redhat.com>, dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org, Mark Brown <broonie@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: [PATCH v2 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings Date: Mon, 11 Apr 2022 23:12:39 +0200 [thread overview] Message-ID: <20220411211243.11121-2-javierm@redhat.com> (raw) In-Reply-To: <20220411211243.11121-1-javierm@redhat.com> The current compatible strings for SSD130x I2C controllers contain both an "fb" and "-i2c" suffixes. It seems to indicate that are for a fbdev driver and also that are for devices that can be accessed over an I2C bus. But a DT is supposed to describe the hardware and not Linux implementation details. So let's deprecate those compatible strings and add new ones that only contain the vendor and device name, without any of these suffixes. These will just describe the device and can be matched by both I2C and SPI DRM drivers. Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Acked-by: Mark Brown <broonie@kernel.org> --- Changes in v2: - Drop the -i2c suffixes from the compatible strings too (Geert Uytterhoeven). .../bindings/display/solomon,ssd1307fb.yaml | 37 ++++++++++++------- 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml index ade61d502edd..6b9d0c72739a 100644 --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml @@ -12,12 +12,23 @@ maintainers: properties: compatible: - enum: - - sinowealth,sh1106-i2c - - solomon,ssd1305fb-i2c - - solomon,ssd1306fb-i2c - - solomon,ssd1307fb-i2c - - solomon,ssd1309fb-i2c + oneOf: + # Deprecated compatible strings + - items: + - enum: + - sinowealth,sh1106-i2c + - solomon,ssd1305fb-i2c + - solomon,ssd1306fb-i2c + - solomon,ssd1307fb-i2c + - solomon,ssd1309fb-i2c + deprecated: true + - items: + - enum: + - sinowealth,sh1106 + - solomon,ssd1305 + - solomon,ssd1306 + - solomon,ssd1307 + - solomon,ssd1309 reg: maxItems: 1 @@ -136,7 +147,7 @@ allOf: properties: compatible: contains: - const: sinowealth,sh1106-i2c + const: sinowealth,sh1106 then: properties: solomon,dclk-div: @@ -148,7 +159,7 @@ allOf: properties: compatible: contains: - const: solomon,ssd1305fb-i2c + const: solomon,ssd1305 then: properties: solomon,dclk-div: @@ -160,7 +171,7 @@ allOf: properties: compatible: contains: - const: solomon,ssd1306fb-i2c + const: solomon,ssd1306 then: properties: solomon,dclk-div: @@ -172,7 +183,7 @@ allOf: properties: compatible: contains: - const: solomon,ssd1307fb-i2c + const: solomon,ssd1307 then: properties: solomon,dclk-div: @@ -186,7 +197,7 @@ allOf: properties: compatible: contains: - const: solomon,ssd1309fb-i2c + const: solomon,ssd1309 then: properties: solomon,dclk-div: @@ -203,14 +214,14 @@ examples: #size-cells = <0>; ssd1307: oled@3c { - compatible = "solomon,ssd1307fb-i2c"; + compatible = "solomon,ssd1307"; reg = <0x3c>; pwms = <&pwm 4 3000>; reset-gpios = <&gpio2 7>; }; ssd1306: oled@3d { - compatible = "solomon,ssd1306fb-i2c"; + compatible = "solomon,ssd1306"; reg = <0x3c>; pwms = <&pwm 4 3000>; reset-gpios = <&gpio2 7>; -- 2.35.1
next prev parent reply other threads:[~2022-04-11 21:13 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-11 21:12 [PATCH v2 0/5] drm/solomon: Add SSD130x OLED displays SPI support Javier Martinez Canillas 2022-04-11 21:12 ` Javier Martinez Canillas 2022-04-11 21:12 ` Javier Martinez Canillas [this message] 2022-04-11 21:12 ` [PATCH v2 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings Javier Martinez Canillas 2022-04-12 7:13 ` Geert Uytterhoeven 2022-04-12 7:13 ` Geert Uytterhoeven 2022-04-12 11:28 ` Maxime Ripard 2022-04-12 11:28 ` Maxime Ripard 2022-04-12 12:48 ` Javier Martinez Canillas 2022-04-12 12:48 ` Javier Martinez Canillas 2022-04-12 12:07 ` Chen-Yu Tsai 2022-04-12 12:07 ` Chen-Yu Tsai 2022-04-12 12:49 ` Javier Martinez Canillas 2022-04-12 12:49 ` Javier Martinez Canillas 2022-04-11 21:12 ` [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers Javier Martinez Canillas 2022-04-11 21:12 ` Javier Martinez Canillas 2022-04-12 7:16 ` Geert Uytterhoeven 2022-04-12 7:16 ` Geert Uytterhoeven 2022-04-12 8:01 ` Javier Martinez Canillas 2022-04-12 8:01 ` Javier Martinez Canillas 2022-04-12 8:07 ` Geert Uytterhoeven 2022-04-12 8:07 ` Geert Uytterhoeven 2022-04-12 8:12 ` Javier Martinez Canillas 2022-04-12 8:12 ` Javier Martinez Canillas 2022-04-12 18:16 ` Rob Herring 2022-04-12 18:16 ` Rob Herring 2022-04-11 21:12 ` [PATCH v2 3/5] drm/solomon: Add ssd130x new compatible strings and deprecate old ones Javier Martinez Canillas 2022-04-11 21:12 ` Javier Martinez Canillas 2022-04-12 7:19 ` Geert Uytterhoeven 2022-04-12 7:19 ` Geert Uytterhoeven 2022-04-12 8:03 ` Javier Martinez Canillas 2022-04-12 8:03 ` Javier Martinez Canillas 2022-04-11 21:12 ` [PATCH v2 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver Javier Martinez Canillas 2022-04-11 21:12 ` Javier Martinez Canillas 2022-04-12 7:23 ` Geert Uytterhoeven 2022-04-12 7:23 ` Geert Uytterhoeven 2022-04-12 8:07 ` Javier Martinez Canillas 2022-04-12 8:07 ` Javier Martinez Canillas 2022-04-12 11:21 ` Andy Shevchenko 2022-04-12 11:21 ` Andy Shevchenko 2022-04-12 11:22 ` Andy Shevchenko 2022-04-12 11:22 ` Andy Shevchenko 2022-04-12 12:47 ` Javier Martinez Canillas 2022-04-12 12:45 ` Javier Martinez Canillas 2022-04-12 12:45 ` Javier Martinez Canillas 2022-04-12 7:25 ` kernel test robot 2022-04-12 7:25 ` kernel test robot 2022-04-11 21:12 ` [PATCH v2 5/5] drm/solomon: Add SSD130x OLED displays SPI support Javier Martinez Canillas 2022-04-11 21:12 ` Javier Martinez Canillas 2022-04-12 7:31 ` Geert Uytterhoeven 2022-04-12 7:31 ` Geert Uytterhoeven 2022-04-12 8:07 ` Javier Martinez Canillas 2022-04-12 8:07 ` Javier Martinez Canillas 2022-04-12 8:17 ` kernel test robot 2022-04-12 8:17 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220411211243.11121-2-javierm@redhat.com \ --to=javierm@redhat.com \ --cc=airlied@linux.ie \ --cc=andriy.shevchenko@linux.intel.com \ --cc=broonie@kernel.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert@linux-m68k.org \ --cc=krzk+dt@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mripard@kernel.org \ --cc=narmstrong@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=robh@kernel.org \ --cc=wens@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.