From: Javier Martinez Canillas <javierm@redhat.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Chen-Yu Tsai <wens@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings
Date: Tue, 12 Apr 2022 14:48:49 +0200 [thread overview]
Message-ID: <d25cfc04-8ee5-ea6d-a353-6b0ac1fd58be@redhat.com> (raw)
In-Reply-To: <20220412112855.uccrkoqgjim2dbts@houat>
Hello Maxime,
On 4/12/22 13:28, Maxime Ripard wrote:
> On Mon, Apr 11, 2022 at 11:12:39PM +0200, Javier Martinez Canillas wrote:
[snip]
>>
>> reg:
>> maxItems: 1
>> @@ -136,7 +147,7 @@ allOf:
>> properties:
>> compatible:
>> contains:
>> - const: sinowealth,sh1106-i2c
>> + const: sinowealth,sh1106
>
> I think we should have both in the condition here, but it looks good
> otherwise.
>
Right, we want to keep enforcing for the deprecated compatible strings.
> Maxime
>
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javierm@redhat.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
dri-devel@lists.freedesktop.org,
Neil Armstrong <narmstrong@baylibre.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Mark Brown <broonie@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Chen-Yu Tsai <wens@kernel.org>, Daniel Vetter <daniel@ffwll.ch>,
David Airlie <airlied@linux.ie>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings
Date: Tue, 12 Apr 2022 14:48:49 +0200 [thread overview]
Message-ID: <d25cfc04-8ee5-ea6d-a353-6b0ac1fd58be@redhat.com> (raw)
In-Reply-To: <20220412112855.uccrkoqgjim2dbts@houat>
Hello Maxime,
On 4/12/22 13:28, Maxime Ripard wrote:
> On Mon, Apr 11, 2022 at 11:12:39PM +0200, Javier Martinez Canillas wrote:
[snip]
>>
>> reg:
>> maxItems: 1
>> @@ -136,7 +147,7 @@ allOf:
>> properties:
>> compatible:
>> contains:
>> - const: sinowealth,sh1106-i2c
>> + const: sinowealth,sh1106
>
> I think we should have both in the condition here, but it looks good
> otherwise.
>
Right, we want to keep enforcing for the deprecated compatible strings.
> Maxime
>
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-04-12 12:48 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 21:12 [PATCH v2 0/5] drm/solomon: Add SSD130x OLED displays SPI support Javier Martinez Canillas
2022-04-11 21:12 ` Javier Martinez Canillas
2022-04-11 21:12 ` [PATCH v2 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings Javier Martinez Canillas
2022-04-11 21:12 ` Javier Martinez Canillas
2022-04-12 7:13 ` Geert Uytterhoeven
2022-04-12 7:13 ` Geert Uytterhoeven
2022-04-12 11:28 ` Maxime Ripard
2022-04-12 11:28 ` Maxime Ripard
2022-04-12 12:48 ` Javier Martinez Canillas [this message]
2022-04-12 12:48 ` Javier Martinez Canillas
2022-04-12 12:07 ` Chen-Yu Tsai
2022-04-12 12:07 ` Chen-Yu Tsai
2022-04-12 12:49 ` Javier Martinez Canillas
2022-04-12 12:49 ` Javier Martinez Canillas
2022-04-11 21:12 ` [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers Javier Martinez Canillas
2022-04-11 21:12 ` Javier Martinez Canillas
2022-04-12 7:16 ` Geert Uytterhoeven
2022-04-12 7:16 ` Geert Uytterhoeven
2022-04-12 8:01 ` Javier Martinez Canillas
2022-04-12 8:01 ` Javier Martinez Canillas
2022-04-12 8:07 ` Geert Uytterhoeven
2022-04-12 8:07 ` Geert Uytterhoeven
2022-04-12 8:12 ` Javier Martinez Canillas
2022-04-12 8:12 ` Javier Martinez Canillas
2022-04-12 18:16 ` Rob Herring
2022-04-12 18:16 ` Rob Herring
2022-04-11 21:12 ` [PATCH v2 3/5] drm/solomon: Add ssd130x new compatible strings and deprecate old ones Javier Martinez Canillas
2022-04-11 21:12 ` Javier Martinez Canillas
2022-04-12 7:19 ` Geert Uytterhoeven
2022-04-12 7:19 ` Geert Uytterhoeven
2022-04-12 8:03 ` Javier Martinez Canillas
2022-04-12 8:03 ` Javier Martinez Canillas
2022-04-11 21:12 ` [PATCH v2 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver Javier Martinez Canillas
2022-04-11 21:12 ` Javier Martinez Canillas
2022-04-12 7:23 ` Geert Uytterhoeven
2022-04-12 7:23 ` Geert Uytterhoeven
2022-04-12 8:07 ` Javier Martinez Canillas
2022-04-12 8:07 ` Javier Martinez Canillas
2022-04-12 11:21 ` Andy Shevchenko
2022-04-12 11:21 ` Andy Shevchenko
2022-04-12 11:22 ` Andy Shevchenko
2022-04-12 11:22 ` Andy Shevchenko
2022-04-12 12:47 ` Javier Martinez Canillas
2022-04-12 12:45 ` Javier Martinez Canillas
2022-04-12 12:45 ` Javier Martinez Canillas
2022-04-12 7:25 ` kernel test robot
2022-04-12 7:25 ` kernel test robot
2022-04-11 21:12 ` [PATCH v2 5/5] drm/solomon: Add SSD130x OLED displays SPI support Javier Martinez Canillas
2022-04-11 21:12 ` Javier Martinez Canillas
2022-04-12 7:31 ` Geert Uytterhoeven
2022-04-12 7:31 ` Geert Uytterhoeven
2022-04-12 8:07 ` Javier Martinez Canillas
2022-04-12 8:07 ` Javier Martinez Canillas
2022-04-12 8:17 ` kernel test robot
2022-04-12 8:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d25cfc04-8ee5-ea6d-a353-6b0ac1fd58be@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.