From: Richard Cochran <richardcochran@gmail.com> To: Tan Tee Min <tee.min.tan@intel.com> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandre Torgue <alexandre.torgue@st.com>, Jose Abreu <joabreu@synopsys.com>, "David S . Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Rayagond Kokatanur <rayagond@vayavyalabs.com>, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Voon Wei Feng <weifeng.voon@intel.com>, Wong Vee Khee <vee.khee.wong@intel.com>, Song Yoong Siang <yoong.siang.song@intel.com> Subject: Re: [PATCH net 1/1] net: stmmac: add fsleep() in HW Rx timestamp checking loop Date: Wed, 13 Apr 2022 05:59:15 -0700 [thread overview] Message-ID: <20220413125915.GA667752@hoboy.vegasvil.org> (raw) In-Reply-To: <20220413040115.2351987-1-tee.min.tan@intel.com> On Wed, Apr 13, 2022 at 12:01:15PM +0800, Tan Tee Min wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > index d3b4765c1a5b..289bf26a6105 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > @@ -279,10 +279,11 @@ static int dwmac4_wrback_get_rx_timestamp_status(void *desc, void *next_desc, > /* Check if timestamp is OK from context descriptor */ > do { > ret = dwmac4_rx_check_timestamp(next_desc); > - if (ret < 0) > + if (ret <= 0) > goto exit; > i++; > > + fsleep(1); This is nutty. Why isn't this code using proper deferral mechanisms like work or kthread? > } while ((ret == 1) && (i < 10)); > > if (i == 10) > -- > 2.25.1 > Thanks, Richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com> To: Tan Tee Min <tee.min.tan@intel.com> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandre Torgue <alexandre.torgue@st.com>, Jose Abreu <joabreu@synopsys.com>, "David S . Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Rayagond Kokatanur <rayagond@vayavyalabs.com>, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Voon Wei Feng <weifeng.voon@intel.com>, Wong Vee Khee <vee.khee.wong@intel.com>, Song Yoong Siang <yoong.siang.song@intel.com> Subject: Re: [PATCH net 1/1] net: stmmac: add fsleep() in HW Rx timestamp checking loop Date: Wed, 13 Apr 2022 05:59:15 -0700 [thread overview] Message-ID: <20220413125915.GA667752@hoboy.vegasvil.org> (raw) In-Reply-To: <20220413040115.2351987-1-tee.min.tan@intel.com> On Wed, Apr 13, 2022 at 12:01:15PM +0800, Tan Tee Min wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > index d3b4765c1a5b..289bf26a6105 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > @@ -279,10 +279,11 @@ static int dwmac4_wrback_get_rx_timestamp_status(void *desc, void *next_desc, > /* Check if timestamp is OK from context descriptor */ > do { > ret = dwmac4_rx_check_timestamp(next_desc); > - if (ret < 0) > + if (ret <= 0) > goto exit; > i++; > > + fsleep(1); This is nutty. Why isn't this code using proper deferral mechanisms like work or kthread? > } while ((ret == 1) && (i < 10)); > > if (i == 10) > -- > 2.25.1 > Thanks, Richard _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-13 12:59 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-13 4:01 [PATCH net 1/1] net: stmmac: add fsleep() in HW Rx timestamp checking loop Tan Tee Min 2022-04-13 4:01 ` Tan Tee Min 2022-04-13 12:59 ` Richard Cochran [this message] 2022-04-13 12:59 ` Richard Cochran 2022-04-14 7:29 ` Tan Tee Min 2022-04-14 7:29 ` Tan Tee Min 2022-04-14 8:42 ` Jakub Kicinski 2022-04-14 8:42 ` Jakub Kicinski 2022-04-19 0:52 ` Tan Tee Min 2022-04-19 0:52 ` Tan Tee Min 2022-04-19 13:28 ` Richard Cochran 2022-04-19 13:28 ` Richard Cochran 2022-04-20 5:15 ` Tan Tee Min 2022-04-20 5:15 ` Tan Tee Min 2022-04-20 12:54 ` Richard Cochran 2022-04-20 12:54 ` Richard Cochran
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220413125915.GA667752@hoboy.vegasvil.org \ --to=richardcochran@gmail.com \ --cc=alexandre.torgue@st.com \ --cc=davem@davemloft.net \ --cc=joabreu@synopsys.com \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=peppe.cavallaro@st.com \ --cc=rayagond@vayavyalabs.com \ --cc=stable@vger.kernel.org \ --cc=tee.min.tan@intel.com \ --cc=vee.khee.wong@intel.com \ --cc=weifeng.voon@intel.com \ --cc=yoong.siang.song@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.