Re: [PATCH v3 4/4] mtd: phram: Allow cached mappings

From: kernel test robot <lkp@intel.com>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>,
	vigneshr@ti.com, richard@nod.at, miquel.raynal@bootlin.com,
	joern@lazybastard.org
Cc: kbuild-all@lists.01.org, kernel@axis.com,
	Vincent Whitchurch <vincent.whitchurch@axis.com>,
	linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	robh+dt@kernel.org, krzk+dt@kernel.org, frowand.list@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] mtd: phram: Allow cached mappings
Date: Wed, 13 Apr 2022 14:45:59 +0800	[thread overview]
Message-ID: <202204131446.omJ5mC54-lkp@intel.com> (raw)
In-Reply-To: <20220412135302.1682890-5-vincent.whitchurch@axis.com>

Hi Vincent,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mtd/mtd/next]
[also build test ERROR on mtd/mtd/fixes robh/for-next v5.18-rc2 next-20220412]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Vincent-Whitchurch/mtd-phram-improvements/20220412-215547
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220413/202204131446.omJ5mC54-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/188069fe016214c257926df29c84b97859850720
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Vincent-Whitchurch/mtd-phram-improvements/20220412-215547
        git checkout 188069fe016214c257926df29c84b97859850720
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/mtd/devices/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/io.h:13,
                    from drivers/mtd/devices/phram.c:21:
   drivers/mtd/devices/phram.c: In function 'register_device':
>> arch/sh/include/asm/io.h:274:33: error: expected expression before 'do'
     274 | #define iounmap(addr)           do { } while (0)
         |                                 ^~
   drivers/mtd/devices/phram.c:150:44: note: in expansion of macro 'iounmap'
     150 |         cached ? memunmap(new->mtd.priv) : iounmap(new->mtd.priv);
         |                                            ^~~~~~~
   drivers/mtd/devices/phram.c: In function 'phram_remove':
>> arch/sh/include/asm/io.h:274:33: error: expected expression before 'do'
     274 | #define iounmap(addr)           do { } while (0)
         |                                 ^~
   drivers/mtd/devices/phram.c:372:53: note: in expansion of macro 'iounmap'
     372 |         phram->cached ? memunmap(phram->mtd.priv) : iounmap(phram->mtd.priv);
         |                                                     ^~~~~~~

vim +/do +274 arch/sh/include/asm/io.h

d57d64080ddc0f Paul Mundt        2010-01-19  272  
13f1fc870dd747 Christoph Hellwig 2020-07-14  273  #else /* CONFIG_MMU */
13f1fc870dd747 Christoph Hellwig 2020-07-14 @274  #define iounmap(addr)		do { } while (0)
13f1fc870dd747 Christoph Hellwig 2020-07-14  275  #define ioremap(offset, size)	((void __iomem *)(unsigned long)(offset))
13f1fc870dd747 Christoph Hellwig 2020-07-14  276  #endif /* CONFIG_MMU */
d627a2ebd1a303 Paul Mundt        2010-01-28  277  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp