All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>,
	vigneshr@ti.com, richard@nod.at, miquel.raynal@bootlin.com,
	joern@lazybastard.org
Cc: kernel@axis.com, linux-mtd@lists.infradead.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	krzk+dt@kernel.org, frowand.list@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] mtd: phram: Allow cached mappings
Date: Thu, 21 Apr 2022 09:35:57 +0200	[thread overview]
Message-ID: <20220421073557.72082-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20220412135302.1682890-5-vincent.whitchurch@axis.com>

On Tue, 2022-04-12 at 13:53:02 UTC, Vincent Whitchurch wrote:
> Currently phram always uses ioremap(), but this is unnecessary when
> normal memory is used.  If the reserved-memory node does not specify the
> no-map property, indicating it should be mapped as system RAM and
> ioremap() cannot be used on it, use a cached mapping using
> memremap(MEMREMAP_WB) instead.
> 
> On one of my systems this improves read performance by ~70%.
> 
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
> Reported-by: kernel test robot <lkp@intel.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>,
	vigneshr@ti.com, richard@nod.at, miquel.raynal@bootlin.com,
	joern@lazybastard.org
Cc: kernel@axis.com, linux-mtd@lists.infradead.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	krzk+dt@kernel.org, frowand.list@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] mtd: phram: Allow cached mappings
Date: Thu, 21 Apr 2022 09:35:57 +0200	[thread overview]
Message-ID: <20220421073557.72082-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20220412135302.1682890-5-vincent.whitchurch@axis.com>

On Tue, 2022-04-12 at 13:53:02 UTC, Vincent Whitchurch wrote:
> Currently phram always uses ioremap(), but this is unnecessary when
> normal memory is used.  If the reserved-memory node does not specify the
> no-map property, indicating it should be mapped as system RAM and
> ioremap() cannot be used on it, use a cached mapping using
> memremap(MEMREMAP_WB) instead.
> 
> On one of my systems this improves read performance by ~70%.
> 
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
> Reported-by: kernel test robot <lkp@intel.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel

  parent reply	other threads:[~2022-04-21  7:36 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12 13:52 [PATCH v3 0/4] mtd: phram improvements Vincent Whitchurch
2022-04-12 13:52 ` Vincent Whitchurch
2022-04-12 13:52 ` [PATCH v3 1/4] mtd: core: Check devicetree alias for index Vincent Whitchurch
2022-04-12 13:52   ` Vincent Whitchurch
2022-04-21  7:36   ` Miquel Raynal
2022-04-21  7:36     ` Miquel Raynal
2022-04-12 13:53 ` [PATCH v3 2/4] dt-bindings: reserved-memory: Support MTD/block device Vincent Whitchurch
2022-04-12 13:53   ` Vincent Whitchurch
2022-04-14 16:00   ` Rob Herring
2022-04-14 16:00     ` Rob Herring
2022-04-21  7:36   ` Miquel Raynal
2022-04-21  7:36     ` Miquel Raynal
2022-04-12 13:53 ` [PATCH v3 3/4] mtd: phram: Allow probing via reserved-memory Vincent Whitchurch
2022-04-12 13:53   ` Vincent Whitchurch
2022-04-14 16:02   ` Rob Herring
2022-04-14 16:02     ` Rob Herring
2022-04-21  7:36   ` Miquel Raynal
2022-04-21  7:36     ` Miquel Raynal
2022-04-12 13:53 ` [PATCH v3 4/4] mtd: phram: Allow cached mappings Vincent Whitchurch
2022-04-12 13:53   ` Vincent Whitchurch
2022-04-13  6:45   ` kernel test robot
2022-04-13  6:45     ` kernel test robot
2022-04-14  9:04     ` Vincent Whitchurch
2022-04-14  9:04       ` Vincent Whitchurch
2022-04-14  9:04       ` Vincent Whitchurch
2022-04-25  8:28       ` Miquel Raynal
2022-04-25  8:28         ` Miquel Raynal
2022-04-25  8:28         ` Miquel Raynal
2022-04-25  8:30         ` Miquel Raynal
2022-04-25  8:30           ` Miquel Raynal
2022-04-25  8:30           ` Miquel Raynal
2022-05-10 15:26           ` Vincent Whitchurch
2022-05-10 15:26             ` Vincent Whitchurch
2022-05-10 15:26             ` Vincent Whitchurch
2022-04-21  7:35   ` Miquel Raynal [this message]
2022-04-21  7:35     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220421073557.72082-1-miquel.raynal@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=joern@lazybastard.org \
    --cc=kernel@axis.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    --cc=vincent.whitchurch@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.