All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Baoquan He <bhe@redhat.com>
Cc: akpm@linux-foundation.org, willy@infradead.org,
	linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
	hch@lst.de, yangtiezhu@loongson.cn, amit.kachhap@arm.com,
	linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH v5 RESEND 2/3] vmcore: Convert __read_vmcore to use an iov_iter
Date: Wed, 13 Apr 2022 18:40:52 +0200	[thread overview]
Message-ID: <20220413164052.GB31487@lst.de> (raw)
In-Reply-To: <20220408090636.560886-3-bhe@redhat.com>

On Fri, Apr 08, 2022 at 05:06:35PM +0800, Baoquan He wrote:
> From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> 
> This gets rid of copy_to() and let us use proc_read_iter() instead
> of proc_read().
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Signed-off-by: Baoquan He <bhe@redhat.com>

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: kexec@lists.infradead.org
Subject: [PATCH v5 RESEND 2/3] vmcore: Convert __read_vmcore to use an iov_iter
Date: Wed, 13 Apr 2022 18:40:52 +0200	[thread overview]
Message-ID: <20220413164052.GB31487@lst.de> (raw)
In-Reply-To: <20220408090636.560886-3-bhe@redhat.com>

On Fri, Apr 08, 2022 at 05:06:35PM +0800, Baoquan He wrote:
> From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> 
> This gets rid of copy_to() and let us use proc_read_iter() instead
> of proc_read().
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Signed-off-by: Baoquan He <bhe@redhat.com>

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>


  reply	other threads:[~2022-04-13 16:40 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  9:06 [PATCH v5 RESEND 0/3] Convert vmcore to use an iov_iter Baoquan He
2022-04-08  9:06 ` Baoquan He
2022-04-08  9:06 ` [PATCH v5 RESEND 1/3] vmcore: Convert copy_oldmem_page() to take " Baoquan He
2022-04-08  9:06   ` Baoquan He
2022-04-08 13:17   ` kernel test robot
2022-04-08 13:17     ` kernel test robot
2022-04-09  1:02     ` Baoquan He
2022-04-09  1:02       ` Baoquan He
2022-04-09  1:02       ` Baoquan He
2022-04-09  1:24       ` [kbuild-all] " Philip Li
2022-04-09  1:24         ` Philip Li
2022-04-09  1:44       ` Matthew Wilcox
2022-04-09  1:44         ` Matthew Wilcox
2022-04-09  1:44         ` Matthew Wilcox
2022-04-11  0:32         ` Baoquan He
2022-04-11  0:32           ` Baoquan He
2022-04-11  0:32           ` Baoquan He
2022-04-11  1:32           ` Matthew Wilcox
2022-04-11  1:32             ` Matthew Wilcox
2022-04-11  1:32             ` Matthew Wilcox
2022-04-11  1:58             ` Baoquan He
2022-04-11  1:58               ` Baoquan He
2022-04-11  1:58               ` Baoquan He
2022-04-13 16:40   ` Christoph Hellwig
2022-04-13 16:40     ` Christoph Hellwig
2022-04-08  9:06 ` [PATCH v5 RESEND 2/3] vmcore: Convert __read_vmcore to use " Baoquan He
2022-04-08  9:06   ` Baoquan He
2022-04-13 16:40   ` Christoph Hellwig [this message]
2022-04-13 16:40     ` Christoph Hellwig
2022-04-08  9:06 ` [PATCH v5 RESEND 3/3] vmcore: Convert read_from_oldmem() to take " Baoquan He
2022-04-08  9:06   ` Baoquan He
2022-04-13 16:41   ` Christoph Hellwig
2022-04-13 16:41     ` Christoph Hellwig
2022-04-08  9:24 ` [PATCH v5 RESEND 0/3] Convert vmcore to use " Baoquan He
2022-04-08  9:24   ` Baoquan He
2022-04-11  8:59   ` Heiko Carstens
2022-04-11  8:59     ` Heiko Carstens
2022-04-13  9:29     ` Baoquan He
2022-04-13  9:29       ` Baoquan He
2022-04-25  3:40 ` Baoquan He
2022-04-25  3:40   ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220413164052.GB31487@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=amit.kachhap@arm.com \
    --cc=bhe@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.