All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Baoquan He <bhe@redhat.com>
Cc: kernel test robot <lkp@intel.com>,
	akpm@linux-foundation.org, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
	hch@lst.de, yangtiezhu@loongson.cn, amit.kachhap@arm.com,
	linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH v5 RESEND 1/3] vmcore: Convert copy_oldmem_page() to take an iov_iter
Date: Sat, 9 Apr 2022 02:44:37 +0100	[thread overview]
Message-ID: <YlDlBQYr9ldLWpFz@casper.infradead.org> (raw)
In-Reply-To: <YlDbJSy4AI3/cODr@MiWiFi-R3L-srv>

On Sat, Apr 09, 2022 at 09:02:29AM +0800, Baoquan He wrote:
> I tried on x86_64 system, for the 1st step, I got this:
> 
> [ ~]# wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> /root/bin/make.cross: No such file or directory

... I don't think we need to reproduce it to see the problem.

> > sparse warnings: (new ones prefixed by >>)
> > >> arch/sh/kernel/crash_dump.c:23:36: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const *addr @@     got void [noderef] __iomem * @@
> >    arch/sh/kernel/crash_dump.c:23:36: sparse:     expected void const *addr
> >    arch/sh/kernel/crash_dump.c:23:36: sparse:     got void [noderef] __iomem *
> > 
> > vim +23 arch/sh/kernel/crash_dump.c
> > 
> >     13	
> >     14	ssize_t copy_oldmem_page(struct iov_iter *iter, unsigned long pfn,
> >     15				 size_t csize, unsigned long offset)
> >     16	{
> >     17		void  __iomem *vaddr;
> >     18	
> >     19		if (!csize)
> >     20			return 0;
> >     21	
> >     22		vaddr = ioremap(pfn << PAGE_SHIFT, PAGE_SIZE);
> >   > 23		csize = copy_to_iter(vaddr + offset, csize, iter);

Unlike other architectures, sh4 does this by calling ioremap().
That gives us an __iomem qualified pointer, which it then warns about
passing to copy_to_iter().

There are a bunch of hacky things we could do to fix it, but for such an
unmaintained arch as sh, I'm inclined to do nothing.  We're more likely
to break something while fixing the warning.  Someone who knows the arch
can figure out what to do properly.

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: kexec@lists.infradead.org
Subject: [PATCH v5 RESEND 1/3] vmcore: Convert copy_oldmem_page() to take an iov_iter
Date: Sat, 9 Apr 2022 02:44:37 +0100	[thread overview]
Message-ID: <YlDlBQYr9ldLWpFz@casper.infradead.org> (raw)
In-Reply-To: <YlDbJSy4AI3/cODr@MiWiFi-R3L-srv>

On Sat, Apr 09, 2022 at 09:02:29AM +0800, Baoquan He wrote:
> I tried on x86_64 system, for the 1st step, I got this:
> 
> [ ~]# wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> /root/bin/make.cross: No such file or directory

... I don't think we need to reproduce it to see the problem.

> > sparse warnings: (new ones prefixed by >>)
> > >> arch/sh/kernel/crash_dump.c:23:36: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const *addr @@     got void [noderef] __iomem * @@
> >    arch/sh/kernel/crash_dump.c:23:36: sparse:     expected void const *addr
> >    arch/sh/kernel/crash_dump.c:23:36: sparse:     got void [noderef] __iomem *
> > 
> > vim +23 arch/sh/kernel/crash_dump.c
> > 
> >     13	
> >     14	ssize_t copy_oldmem_page(struct iov_iter *iter, unsigned long pfn,
> >     15				 size_t csize, unsigned long offset)
> >     16	{
> >     17		void  __iomem *vaddr;
> >     18	
> >     19		if (!csize)
> >     20			return 0;
> >     21	
> >     22		vaddr = ioremap(pfn << PAGE_SHIFT, PAGE_SIZE);
> >   > 23		csize = copy_to_iter(vaddr + offset, csize, iter);

Unlike other architectures, sh4 does this by calling ioremap().
That gives us an __iomem qualified pointer, which it then warns about
passing to copy_to_iter().

There are a bunch of hacky things we could do to fix it, but for such an
unmaintained arch as sh, I'm inclined to do nothing.  We're more likely
to break something while fixing the warning.  Someone who knows the arch
can figure out what to do properly.


WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v5 RESEND 1/3] vmcore: Convert copy_oldmem_page() to take an iov_iter
Date: Sat, 09 Apr 2022 02:44:37 +0100	[thread overview]
Message-ID: <YlDlBQYr9ldLWpFz@casper.infradead.org> (raw)
In-Reply-To: <YlDbJSy4AI3/cODr@MiWiFi-R3L-srv>

[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]

On Sat, Apr 09, 2022 at 09:02:29AM +0800, Baoquan He wrote:
> I tried on x86_64 system, for the 1st step, I got this:
> 
> [ ~]# wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> /root/bin/make.cross: No such file or directory

... I don't think we need to reproduce it to see the problem.

> > sparse warnings: (new ones prefixed by >>)
> > >> arch/sh/kernel/crash_dump.c:23:36: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const *addr @@     got void [noderef] __iomem * @@
> >    arch/sh/kernel/crash_dump.c:23:36: sparse:     expected void const *addr
> >    arch/sh/kernel/crash_dump.c:23:36: sparse:     got void [noderef] __iomem *
> > 
> > vim +23 arch/sh/kernel/crash_dump.c
> > 
> >     13	
> >     14	ssize_t copy_oldmem_page(struct iov_iter *iter, unsigned long pfn,
> >     15				 size_t csize, unsigned long offset)
> >     16	{
> >     17		void  __iomem *vaddr;
> >     18	
> >     19		if (!csize)
> >     20			return 0;
> >     21	
> >     22		vaddr = ioremap(pfn << PAGE_SHIFT, PAGE_SIZE);
> >   > 23		csize = copy_to_iter(vaddr + offset, csize, iter);

Unlike other architectures, sh4 does this by calling ioremap().
That gives us an __iomem qualified pointer, which it then warns about
passing to copy_to_iter().

There are a bunch of hacky things we could do to fix it, but for such an
unmaintained arch as sh, I'm inclined to do nothing.  We're more likely
to break something while fixing the warning.  Someone who knows the arch
can figure out what to do properly.

  parent reply	other threads:[~2022-04-09  1:44 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  9:06 [PATCH v5 RESEND 0/3] Convert vmcore to use an iov_iter Baoquan He
2022-04-08  9:06 ` Baoquan He
2022-04-08  9:06 ` [PATCH v5 RESEND 1/3] vmcore: Convert copy_oldmem_page() to take " Baoquan He
2022-04-08  9:06   ` Baoquan He
2022-04-08 13:17   ` kernel test robot
2022-04-08 13:17     ` kernel test robot
2022-04-09  1:02     ` Baoquan He
2022-04-09  1:02       ` Baoquan He
2022-04-09  1:02       ` Baoquan He
2022-04-09  1:24       ` [kbuild-all] " Philip Li
2022-04-09  1:24         ` Philip Li
2022-04-09  1:44       ` Matthew Wilcox [this message]
2022-04-09  1:44         ` Matthew Wilcox
2022-04-09  1:44         ` Matthew Wilcox
2022-04-11  0:32         ` Baoquan He
2022-04-11  0:32           ` Baoquan He
2022-04-11  0:32           ` Baoquan He
2022-04-11  1:32           ` Matthew Wilcox
2022-04-11  1:32             ` Matthew Wilcox
2022-04-11  1:32             ` Matthew Wilcox
2022-04-11  1:58             ` Baoquan He
2022-04-11  1:58               ` Baoquan He
2022-04-11  1:58               ` Baoquan He
2022-04-13 16:40   ` Christoph Hellwig
2022-04-13 16:40     ` Christoph Hellwig
2022-04-08  9:06 ` [PATCH v5 RESEND 2/3] vmcore: Convert __read_vmcore to use " Baoquan He
2022-04-08  9:06   ` Baoquan He
2022-04-13 16:40   ` Christoph Hellwig
2022-04-13 16:40     ` Christoph Hellwig
2022-04-08  9:06 ` [PATCH v5 RESEND 3/3] vmcore: Convert read_from_oldmem() to take " Baoquan He
2022-04-08  9:06   ` Baoquan He
2022-04-13 16:41   ` Christoph Hellwig
2022-04-13 16:41     ` Christoph Hellwig
2022-04-08  9:24 ` [PATCH v5 RESEND 0/3] Convert vmcore to use " Baoquan He
2022-04-08  9:24   ` Baoquan He
2022-04-11  8:59   ` Heiko Carstens
2022-04-11  8:59     ` Heiko Carstens
2022-04-13  9:29     ` Baoquan He
2022-04-13  9:29       ` Baoquan He
2022-04-25  3:40 ` Baoquan He
2022-04-25  3:40   ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlDlBQYr9ldLWpFz@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=amit.kachhap@arm.com \
    --cc=bhe@redhat.com \
    --cc=hch@lst.de \
    --cc=kbuild-all@lists.01.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.