* [PATCH] ARM: imx35: Fix refcount leak in mx35_read_cpu_rev
@ 2022-04-21 11:03 ` Miaoqian Lin
0 siblings, 0 replies; 2+ messages in thread
From: Miaoqian Lin @ 2022-04-21 11:03 UTC (permalink / raw)
To: Russell King, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Miaoqian Lin, Arnd Bergmann,
linux-arm-kernel, linux-kernel
The of_find_compatible_node() function returns a node pointer with
refcount incremented, We should use of_node_put() on it when done
Add the missing of_node_put() to release the refcount.
Fixes: f68ea682d1da ("ARM: imx35: Retrieve the IIM base address from devicetree")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
arch/arm/mach-imx/cpu-imx35.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-imx/cpu-imx35.c b/arch/arm/mach-imx/cpu-imx35.c
index 80e7d8ab9f1b..3ae4a3dc44fb 100644
--- a/arch/arm/mach-imx/cpu-imx35.c
+++ b/arch/arm/mach-imx/cpu-imx35.c
@@ -22,6 +22,7 @@ static int mx35_read_cpu_rev(void)
np = of_find_compatible_node(NULL, NULL, "fsl,imx35-iim");
iim_base = of_iomap(np, 0);
BUG_ON(!iim_base);
+ of_node_put(np);
rev = imx_readl(iim_base + MXC_IIMSREV);
switch (rev) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: imx35: Fix refcount leak in mx35_read_cpu_rev
@ 2022-04-21 11:03 ` Miaoqian Lin
0 siblings, 0 replies; 2+ messages in thread
From: Miaoqian Lin @ 2022-04-21 11:03 UTC (permalink / raw)
To: Russell King, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Miaoqian Lin, Arnd Bergmann,
linux-arm-kernel, linux-kernel
The of_find_compatible_node() function returns a node pointer with
refcount incremented, We should use of_node_put() on it when done
Add the missing of_node_put() to release the refcount.
Fixes: f68ea682d1da ("ARM: imx35: Retrieve the IIM base address from devicetree")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
arch/arm/mach-imx/cpu-imx35.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-imx/cpu-imx35.c b/arch/arm/mach-imx/cpu-imx35.c
index 80e7d8ab9f1b..3ae4a3dc44fb 100644
--- a/arch/arm/mach-imx/cpu-imx35.c
+++ b/arch/arm/mach-imx/cpu-imx35.c
@@ -22,6 +22,7 @@ static int mx35_read_cpu_rev(void)
np = of_find_compatible_node(NULL, NULL, "fsl,imx35-iim");
iim_base = of_iomap(np, 0);
BUG_ON(!iim_base);
+ of_node_put(np);
rev = imx_readl(iim_base + MXC_IIMSREV);
switch (rev) {
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-21 11:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 11:03 [PATCH] ARM: imx35: Fix refcount leak in mx35_read_cpu_rev Miaoqian Lin
2022-04-21 11:03 ` Miaoqian Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.