All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vernet <void@manifault.com>
To: Roman Gushchin <roman.gushchin@linux.dev>
Cc: akpm@linux-foundation.org, tj@kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	cgroups@vger.kernel.org, hannes@cmpxchg.org, mhocko@kernel.org,
	shakeelb@google.com, kernel-team@fb.com
Subject: Re: [PATCH 1/5] cgroups: Refactor children cgroups in memcg tests
Date: Sat, 23 Apr 2022 08:33:21 -0700	[thread overview]
Message-ID: <20220423153321.cts6qhlybkghoe2o@dev0025.ash9.facebook.com> (raw)
In-Reply-To: <EEC47283-0467-4C97-AAB2-73F17A97CE15@linux.dev>

On Sat, Apr 23, 2022 at 08:19:12AM -0700, Roman Gushchin wrote:
> 
> > On Apr 23, 2022, at 4:30 AM, David Vernet <void@manifault.com> wrote:
> > 
> > On Fri, Apr 22, 2022 at 04:04:15PM -0700, Roman Gushchin wrote:
> >> 
> > 
> > Thanks for the reviews on this patchset, Roman. FYI I think Andrew already
> > merged these patches to the -mm tree. I'll send out a follow-on patch that
> > fixes everything you pointed out, both here and on the other patches in the
> > set.
> 
> The mm tree isn’t a git tree, but a collection of the text patches, managed by Andrew. So you can send a new version and Andrew can update it in place. It’s happening all the time: mostly for adding reviewed-by/acked-by tags etc, but for code updates as well.
> It’s not uncommon for some patchset to mature while being in the mm tree, this allows to include them into linux-next and give some more testing, but without doing many reverts/fixups (Andrew is often squashing fixups into the original patch too). So long story short, you can just send a new version, especially because all changes all minor.

Ah, that makes sense. Thanks for explaining that. I'll send out a v2 of the
patches shortly, then!

WARNING: multiple messages have this Message-ID (diff)
From: David Vernet <void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
To: Roman Gushchin <roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
	mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	kernel-team-b10kYP2dOMg@public.gmane.org
Subject: Re: [PATCH 1/5] cgroups: Refactor children cgroups in memcg tests
Date: Sat, 23 Apr 2022 08:33:21 -0700	[thread overview]
Message-ID: <20220423153321.cts6qhlybkghoe2o@dev0025.ash9.facebook.com> (raw)
In-Reply-To: <EEC47283-0467-4C97-AAB2-73F17A97CE15-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>

On Sat, Apr 23, 2022 at 08:19:12AM -0700, Roman Gushchin wrote:
> 
> > On Apr 23, 2022, at 4:30 AM, David Vernet <void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org> wrote:
> > 
> > On Fri, Apr 22, 2022 at 04:04:15PM -0700, Roman Gushchin wrote:
> >> 
> > 
> > Thanks for the reviews on this patchset, Roman. FYI I think Andrew already
> > merged these patches to the -mm tree. I'll send out a follow-on patch that
> > fixes everything you pointed out, both here and on the other patches in the
> > set.
> 
> The mm tree isn’t a git tree, but a collection of the text patches, managed by Andrew. So you can send a new version and Andrew can update it in place. It’s happening all the time: mostly for adding reviewed-by/acked-by tags etc, but for code updates as well.
> It’s not uncommon for some patchset to mature while being in the mm tree, this allows to include them into linux-next and give some more testing, but without doing many reverts/fixups (Andrew is often squashing fixups into the original patch too). So long story short, you can just send a new version, especially because all changes all minor.

Ah, that makes sense. Thanks for explaining that. I'll send out a v2 of the
patches shortly, then!

  reply	other threads:[~2022-04-23 15:33 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22 15:57 [PATCH 0/5] Fix bugs in memcontroller cgroup tests David Vernet
2022-04-22 15:57 ` David Vernet
2022-04-22 15:57 ` [PATCH 1/5] cgroups: Refactor children cgroups in memcg tests David Vernet
2022-04-22 15:57   ` David Vernet
2022-04-22 23:04   ` Roman Gushchin
2022-04-22 23:04     ` Roman Gushchin
2022-04-23 11:30     ` David Vernet
2022-04-23 11:30       ` David Vernet
2022-04-23 15:19       ` Roman Gushchin
2022-04-23 15:19         ` Roman Gushchin
2022-04-23 15:33         ` David Vernet [this message]
2022-04-23 15:33           ` David Vernet
2022-04-22 15:57 ` [PATCH 2/5] cgroup: Account for memory_recursiveprot in test_memcg_low() David Vernet
2022-04-22 15:57   ` David Vernet
2022-04-22 23:06   ` Roman Gushchin
2022-04-22 23:06     ` Roman Gushchin
2022-04-23 11:33     ` David Vernet
2022-04-23 11:33       ` David Vernet
2022-04-22 15:57 ` [PATCH 3/5] cgroup: Account for memory_localevents in test_memcg_oom_group_leaf_events() David Vernet
2022-04-22 15:57   ` David Vernet
2022-04-22 23:14   ` Roman Gushchin
2022-04-22 23:14     ` Roman Gushchin
2022-04-23 11:36     ` David Vernet
2022-04-23 11:36       ` David Vernet
2022-04-22 15:57 ` [PATCH 4/5] cgroup: Removing racy check in test_memcg_sock() David Vernet
2022-04-22 15:57   ` David Vernet
2022-04-22 23:50   ` Roman Gushchin
2022-04-22 23:50     ` Roman Gushchin
2022-04-23 11:50     ` David Vernet
2022-04-23 11:50       ` David Vernet
2022-04-22 15:57 ` [PATCH 5/5] cgroup: Fix racy check in alloc_pagecache_max_30M() helper function David Vernet
2022-04-22 15:57   ` David Vernet
2022-04-22 23:56   ` Roman Gushchin
2022-04-22 23:56     ` Roman Gushchin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220423153321.cts6qhlybkghoe2o@dev0025.ash9.facebook.com \
    --to=void@manifault.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeelb@google.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.