All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
To: <ath11k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<robh@kernel.org>, <mka@chromium.org>,
	Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Subject: [PATCH v5 09/12] ath11k: Do not put HW in DBS mode for WCN6750
Date: Tue, 26 Apr 2022 20:24:53 +0530	[thread overview]
Message-ID: <20220426145456.8055-10-quic_mpubbise@quicinc.com> (raw)
In-Reply-To: <20220426145456.8055-1-quic_mpubbise@quicinc.com>

Though WCN6750 is a single PDEV device, it is not a
DBS solution. So, do not put HW in DBS mode for WCN6750.

Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1

Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
---
 drivers/net/wireless/ath/ath11k/core.c | 2 +-
 drivers/net/wireless/ath/ath11k/wmi.c  | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index 9fa4d08fbf97..f57758d72f29 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -1285,7 +1285,7 @@ static int ath11k_core_start(struct ath11k_base *ab,
 	}
 
 	/* put hardware to DBS mode */
-	if (ab->hw_params.single_pdev_only) {
+	if (ab->hw_params.single_pdev_only && ab->hw_params.num_rxmda_per_pdev > 1) {
 		ret = ath11k_wmi_set_hw_mode(ab, WMI_HOST_HW_MODE_DBS);
 		if (ret) {
 			ath11k_err(ab, "failed to send dbs mode: %d\n", ret);
diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index dcf31bdad47e..d7243819d9bd 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: BSD-3-Clause-Clear
 /*
  * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2021, Qualcomm Innovation Center, Inc. All rights reserved.
  */
 #include <linux/skbuff.h>
 #include <linux/ctype.h>
@@ -8225,7 +8226,7 @@ int ath11k_wmi_attach(struct ath11k_base *ab)
 	ab->wmi_ab.preferred_hw_mode = WMI_HOST_HW_MODE_MAX;
 
 	/* It's overwritten when service_ext_ready is handled */
-	if (ab->hw_params.single_pdev_only)
+	if (ab->hw_params.single_pdev_only && ab->hw_params.num_rxmda_per_pdev > 1)
 		ab->wmi_ab.preferred_hw_mode = WMI_HOST_HW_MODE_SINGLE;
 
 	/* TODO: Init remaining wmi soc resources required */
-- 
2.35.1


-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
To: <ath11k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<robh@kernel.org>, <mka@chromium.org>,
	Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Subject: [PATCH v5 09/12] ath11k: Do not put HW in DBS mode for WCN6750
Date: Tue, 26 Apr 2022 20:24:53 +0530	[thread overview]
Message-ID: <20220426145456.8055-10-quic_mpubbise@quicinc.com> (raw)
In-Reply-To: <20220426145456.8055-1-quic_mpubbise@quicinc.com>

Though WCN6750 is a single PDEV device, it is not a
DBS solution. So, do not put HW in DBS mode for WCN6750.

Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1

Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
---
 drivers/net/wireless/ath/ath11k/core.c | 2 +-
 drivers/net/wireless/ath/ath11k/wmi.c  | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index 9fa4d08fbf97..f57758d72f29 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -1285,7 +1285,7 @@ static int ath11k_core_start(struct ath11k_base *ab,
 	}
 
 	/* put hardware to DBS mode */
-	if (ab->hw_params.single_pdev_only) {
+	if (ab->hw_params.single_pdev_only && ab->hw_params.num_rxmda_per_pdev > 1) {
 		ret = ath11k_wmi_set_hw_mode(ab, WMI_HOST_HW_MODE_DBS);
 		if (ret) {
 			ath11k_err(ab, "failed to send dbs mode: %d\n", ret);
diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index dcf31bdad47e..d7243819d9bd 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: BSD-3-Clause-Clear
 /*
  * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2021, Qualcomm Innovation Center, Inc. All rights reserved.
  */
 #include <linux/skbuff.h>
 #include <linux/ctype.h>
@@ -8225,7 +8226,7 @@ int ath11k_wmi_attach(struct ath11k_base *ab)
 	ab->wmi_ab.preferred_hw_mode = WMI_HOST_HW_MODE_MAX;
 
 	/* It's overwritten when service_ext_ready is handled */
-	if (ab->hw_params.single_pdev_only)
+	if (ab->hw_params.single_pdev_only && ab->hw_params.num_rxmda_per_pdev > 1)
 		ab->wmi_ab.preferred_hw_mode = WMI_HOST_HW_MODE_SINGLE;
 
 	/* TODO: Init remaining wmi soc resources required */
-- 
2.35.1


  parent reply	other threads:[~2022-04-26 14:55 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 14:54 [PATCH v5 00/12] add support for WCN6750 Manikanta Pubbisetty
2022-04-26 14:54 ` Manikanta Pubbisetty
2022-04-26 14:54 ` [PATCH v5 01/12] dt: bindings: net: add bindings of WCN6750 for ath11k Manikanta Pubbisetty
2022-04-26 14:54   ` Manikanta Pubbisetty
2022-04-26 14:54 ` [PATCH v5 02/12] ath11k: Add HW params for WCN6750 Manikanta Pubbisetty
2022-04-26 14:54   ` Manikanta Pubbisetty
2022-04-26 14:54 ` [PATCH v5 03/12] ath11k: Add bus " Manikanta Pubbisetty
2022-04-26 14:54   ` Manikanta Pubbisetty
2022-04-26 14:54 ` [PATCH v5 04/12] ath11k: Add register access logic " Manikanta Pubbisetty
2022-04-26 14:54   ` Manikanta Pubbisetty
2022-04-26 14:54 ` [PATCH v5 05/12] ath11k: Fetch device information via QMI " Manikanta Pubbisetty
2022-04-26 14:54   ` Manikanta Pubbisetty
2022-04-26 14:54 ` [PATCH v5 06/12] ath11k: Add QMI changes " Manikanta Pubbisetty
2022-04-26 14:54   ` Manikanta Pubbisetty
2022-04-26 14:54 ` [PATCH v5 07/12] ath11k: HAL changes to support WCN6750 Manikanta Pubbisetty
2022-04-26 14:54   ` Manikanta Pubbisetty
2022-04-26 14:54 ` [PATCH v5 08/12] ath11k: Datapath " Manikanta Pubbisetty
2022-04-26 14:54   ` Manikanta Pubbisetty
2022-04-26 14:54 ` Manikanta Pubbisetty [this message]
2022-04-26 14:54   ` [PATCH v5 09/12] ath11k: Do not put HW in DBS mode for WCN6750 Manikanta Pubbisetty
2022-04-26 14:54 ` [PATCH v5 10/12] ath11k: WMI changes to support WCN6750 Manikanta Pubbisetty
2022-04-26 14:54   ` Manikanta Pubbisetty
2022-04-26 14:54 ` [PATCH v5 11/12] ath11k: Update WBM idle ring HP after FW mode on Manikanta Pubbisetty
2022-04-26 14:54   ` Manikanta Pubbisetty
2022-04-26 14:54 ` [PATCH v5 12/12] ath11k: Add support for WCN6750 device Manikanta Pubbisetty
2022-04-26 14:54   ` Manikanta Pubbisetty
2022-04-27  5:14 ` [PATCH v5 00/12] add support for WCN6750 Kalle Valo
2022-04-27  5:14   ` Kalle Valo
2022-04-27  5:16   ` Kalle Valo
2022-04-27  5:16     ` Kalle Valo
2022-04-27  5:32     ` Manikanta Pubbisetty
2022-04-27  5:32       ` Manikanta Pubbisetty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220426145456.8055-10-quic_mpubbise@quicinc.com \
    --to=quic_mpubbise@quicinc.com \
    --cc=ath11k@lists.infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.