* [PATCH] efi_loader: Select EVENT as well
@ 2022-04-27 5:47 Jan Kiszka
2022-04-27 5:55 ` AKASHI Takahiro
2022-05-07 20:34 ` Heinrich Schuchardt
0 siblings, 2 replies; 6+ messages in thread
From: Jan Kiszka @ 2022-04-27 5:47 UTC (permalink / raw)
To: AKASHI Takahiro, Heinrich Schuchardt, U-Boot Mailing List
From: Jan Kiszka <jan.kiszka@siemens.com>
Fixes
WARNING: unmet direct dependencies detected for EVENT_DYNAMIC
Depends on [n]: EVENT [=n]
Selected by [y]:
- EFI_LOADER [=y] && OF_LIBFDT [=y] && ...
and the succeeding build breakage.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
lib/efi_loader/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
index 6b245f50a72..1bfb9ddbda9 100644
--- a/lib/efi_loader/Kconfig
+++ b/lib/efi_loader/Kconfig
@@ -15,6 +15,7 @@ config EFI_LOADER
depends on !EFI_APP
default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
select DM_EVENT
+ select EVENT
select EVENT_DYNAMIC
select LIB_UUID
imply PARTITION_UUIDS
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] efi_loader: Select EVENT as well
2022-04-27 5:47 [PATCH] efi_loader: Select EVENT as well Jan Kiszka
@ 2022-04-27 5:55 ` AKASHI Takahiro
2022-04-28 10:03 ` Jan Kiszka
2022-05-07 20:34 ` Heinrich Schuchardt
1 sibling, 1 reply; 6+ messages in thread
From: AKASHI Takahiro @ 2022-04-27 5:55 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Heinrich Schuchardt, U-Boot Mailing List
On Wed, Apr 27, 2022 at 07:47:15AM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Fixes
>
> WARNING: unmet direct dependencies detected for EVENT_DYNAMIC
> Depends on [n]: EVENT [=n]
> Selected by [y]:
> - EFI_LOADER [=y] && OF_LIBFDT [=y] && ...
>
> and the succeeding build breakage.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> lib/efi_loader/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index 6b245f50a72..1bfb9ddbda9 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -15,6 +15,7 @@ config EFI_LOADER
> depends on !EFI_APP
> default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
> select DM_EVENT
> + select EVENT
I wonder why DM_EVENT does not *select*, but implies EVENT.
Should any subsystem relying on DM_EVENT work without EVENT?
-> Simon?
-Takahiro Akashi
> select EVENT_DYNAMIC
> select LIB_UUID
> imply PARTITION_UUIDS
> --
> 2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] efi_loader: Select EVENT as well
2022-04-27 5:55 ` AKASHI Takahiro
@ 2022-04-28 10:03 ` Jan Kiszka
2022-04-28 11:04 ` Heinrich Schuchardt
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2022-04-28 10:03 UTC (permalink / raw)
To: AKASHI Takahiro, Heinrich Schuchardt, U-Boot Mailing List, Simon Glass
On 27.04.22 07:55, AKASHI Takahiro wrote:
> On Wed, Apr 27, 2022 at 07:47:15AM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Fixes
>>
>> WARNING: unmet direct dependencies detected for EVENT_DYNAMIC
>> Depends on [n]: EVENT [=n]
>> Selected by [y]:
>> - EFI_LOADER [=y] && OF_LIBFDT [=y] && ...
>>
>> and the succeeding build breakage.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> lib/efi_loader/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
>> index 6b245f50a72..1bfb9ddbda9 100644
>> --- a/lib/efi_loader/Kconfig
>> +++ b/lib/efi_loader/Kconfig
>> @@ -15,6 +15,7 @@ config EFI_LOADER
>> depends on !EFI_APP
>> default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
>> select DM_EVENT
>> + select EVENT
>
> I wonder why DM_EVENT does not *select*, but implies EVENT.
> Should any subsystem relying on DM_EVENT work without EVENT?
> -> Simon?
>
Looks like you forgot to CC him.
Jan
> -Takahiro Akashi
>
>> select EVENT_DYNAMIC
>> select LIB_UUID
>> imply PARTITION_UUIDS
>> --
>> 2.34.1
--
Siemens AG, Technology
Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] efi_loader: Select EVENT as well
2022-04-28 10:03 ` Jan Kiszka
@ 2022-04-28 11:04 ` Heinrich Schuchardt
2022-05-03 5:00 ` Jan Kiszka
0 siblings, 1 reply; 6+ messages in thread
From: Heinrich Schuchardt @ 2022-04-28 11:04 UTC (permalink / raw)
To: Jan Kiszka; +Cc: AKASHI Takahiro, U-Boot Mailing List, Simon Glass
On 4/28/22 12:03, Jan Kiszka wrote:
> On 27.04.22 07:55, AKASHI Takahiro wrote:
>> On Wed, Apr 27, 2022 at 07:47:15AM +0200, Jan Kiszka wrote:
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> Fixes
>>>
>>> WARNING: unmet direct dependencies detected for EVENT_DYNAMIC
>>> Depends on [n]: EVENT [=n]
>>> Selected by [y]:
>>> - EFI_LOADER [=y] && OF_LIBFDT [=y] && ...
>>>
>>> and the succeeding build breakage.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>> lib/efi_loader/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
>>> index 6b245f50a72..1bfb9ddbda9 100644
>>> --- a/lib/efi_loader/Kconfig
>>> +++ b/lib/efi_loader/Kconfig
>>> @@ -15,6 +15,7 @@ config EFI_LOADER
>>> depends on !EFI_APP
>>> default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
>>> select DM_EVENT
>>> + select EVENT
event_notify_null() used for the DM_EVENT implementation is not
available without EVENT.
Please, let DM_EVENT select on EVENT (drivers/core/Kconfig).
Best regards
Heinrich
>>
>> I wonder why DM_EVENT does not *select*, but implies EVENT.
>> Should any subsystem relying on DM_EVENT work without EVENT?
>> -> Simon?
>>
>
> Looks like you forgot to CC him.
>
> Jan
>
>> -Takahiro Akashi
>>
>>> select EVENT_DYNAMIC
>>> select LIB_UUID
>>> imply PARTITION_UUIDS
>>> --
>>> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] efi_loader: Select EVENT as well
2022-04-28 11:04 ` Heinrich Schuchardt
@ 2022-05-03 5:00 ` Jan Kiszka
0 siblings, 0 replies; 6+ messages in thread
From: Jan Kiszka @ 2022-05-03 5:00 UTC (permalink / raw)
To: Heinrich Schuchardt, Jan Kiszka
Cc: AKASHI Takahiro, U-Boot Mailing List, Simon Glass
On 28.04.22 13:04, Heinrich Schuchardt wrote:
> On 4/28/22 12:03, Jan Kiszka wrote:
>> On 27.04.22 07:55, AKASHI Takahiro wrote:
>>> On Wed, Apr 27, 2022 at 07:47:15AM +0200, Jan Kiszka wrote:
>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>
>>>> Fixes
>>>>
>>>> WARNING: unmet direct dependencies detected for EVENT_DYNAMIC
>>>> Depends on [n]: EVENT [=n]
>>>> Selected by [y]:
>>>> - EFI_LOADER [=y] && OF_LIBFDT [=y] && ...
>>>>
>>>> and the succeeding build breakage.
>>>>
>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>>> ---
>>>> lib/efi_loader/Kconfig | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
>>>> index 6b245f50a72..1bfb9ddbda9 100644
>>>> --- a/lib/efi_loader/Kconfig
>>>> +++ b/lib/efi_loader/Kconfig
>>>> @@ -15,6 +15,7 @@ config EFI_LOADER
>>>> depends on !EFI_APP
>>>> default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
>>>> select DM_EVENT
>>>> + select EVENT
>
> event_notify_null() used for the DM_EVENT implementation is not
> available without EVENT.
It is a static inline stub in that case.
>
> Please, let DM_EVENT select on EVENT (drivers/core/Kconfig).
>
Just tested with a qemu target, and there is no generic build dependency
of DM_EVENT on EVENT.
The problem here is that EFI_LOADER selects EVENT_DYNAMIC but not EVENT,
and that cannot work because the former depends on the latter.
Jan
--
Siemens AG, Technology
Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] efi_loader: Select EVENT as well
2022-04-27 5:47 [PATCH] efi_loader: Select EVENT as well Jan Kiszka
2022-04-27 5:55 ` AKASHI Takahiro
@ 2022-05-07 20:34 ` Heinrich Schuchardt
1 sibling, 0 replies; 6+ messages in thread
From: Heinrich Schuchardt @ 2022-05-07 20:34 UTC (permalink / raw)
To: Jan Kiszka, AKASHI Takahiro, U-Boot Mailing List
On 4/27/22 07:47, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Fixes
>
> WARNING: unmet direct dependencies detected for EVENT_DYNAMIC
> Depends on [n]: EVENT [=n]
> Selected by [y]:
> - EFI_LOADER [=y] && OF_LIBFDT [=y] && ...
>
> and the succeeding build breakage.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> lib/efi_loader/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index 6b245f50a72..1bfb9ddbda9 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -15,6 +15,7 @@ config EFI_LOADER
> depends on !EFI_APP
> default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
> select DM_EVENT
> + select EVENT
> select EVENT_DYNAMIC
> select LIB_UUID
> imply PARTITION_UUIDS
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-07 20:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27 5:47 [PATCH] efi_loader: Select EVENT as well Jan Kiszka
2022-04-27 5:55 ` AKASHI Takahiro
2022-04-28 10:03 ` Jan Kiszka
2022-04-28 11:04 ` Heinrich Schuchardt
2022-05-03 5:00 ` Jan Kiszka
2022-05-07 20:34 ` Heinrich Schuchardt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.