From: Javier Martinez Canillas <javierm@redhat.com> To: linux-kernel@vger.kernel.org Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Thomas Zimmermann <tzimmermann@suse.de>, Daniel Vetter <daniel.vetter@ffwll.ch>, Javier Martinez Canillas <javierm@redhat.com>, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Subject: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup() Date: Mon, 2 May 2022 17:38:58 +0200 [thread overview] Message-ID: <20220502153900.408522-2-javierm@redhat.com> (raw) In-Reply-To: <20220502153900.408522-1-javierm@redhat.com> The drm_fbdev_generic_setup() function already sets the preferred bits per pixel for the device to dev->mode_config.preferred_depth, if preferred_bpp value is zero. Passing the same value to the function is unnecessary. Let's cleanup that in the two drivers that do it. Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> --- (no changes since v1) drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 +- drivers/gpu/drm/tiny/cirrus.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c index fe4269c5aa0a..ace92459e462 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c @@ -349,7 +349,7 @@ static int hibmc_pci_probe(struct pci_dev *pdev, goto err_unload; } - drm_fbdev_generic_setup(dev, dev->mode_config.preferred_depth); + drm_fbdev_generic_setup(dev, 0); return 0; diff --git a/drivers/gpu/drm/tiny/cirrus.c b/drivers/gpu/drm/tiny/cirrus.c index c8e791840862..ed5a2e14894a 100644 --- a/drivers/gpu/drm/tiny/cirrus.c +++ b/drivers/gpu/drm/tiny/cirrus.c @@ -601,7 +601,7 @@ static int cirrus_pci_probe(struct pci_dev *pdev, if (ret) return ret; - drm_fbdev_generic_setup(dev, dev->mode_config.preferred_depth); + drm_fbdev_generic_setup(dev, 0); return 0; } -- 2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javierm@redhat.com> To: linux-kernel@vger.kernel.org Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Javier Martinez Canillas <javierm@redhat.com>, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Thomas Zimmermann <tzimmermann@suse.de> Subject: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup() Date: Mon, 2 May 2022 17:38:58 +0200 [thread overview] Message-ID: <20220502153900.408522-2-javierm@redhat.com> (raw) In-Reply-To: <20220502153900.408522-1-javierm@redhat.com> The drm_fbdev_generic_setup() function already sets the preferred bits per pixel for the device to dev->mode_config.preferred_depth, if preferred_bpp value is zero. Passing the same value to the function is unnecessary. Let's cleanup that in the two drivers that do it. Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> --- (no changes since v1) drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 +- drivers/gpu/drm/tiny/cirrus.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c index fe4269c5aa0a..ace92459e462 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c @@ -349,7 +349,7 @@ static int hibmc_pci_probe(struct pci_dev *pdev, goto err_unload; } - drm_fbdev_generic_setup(dev, dev->mode_config.preferred_depth); + drm_fbdev_generic_setup(dev, 0); return 0; diff --git a/drivers/gpu/drm/tiny/cirrus.c b/drivers/gpu/drm/tiny/cirrus.c index c8e791840862..ed5a2e14894a 100644 --- a/drivers/gpu/drm/tiny/cirrus.c +++ b/drivers/gpu/drm/tiny/cirrus.c @@ -601,7 +601,7 @@ static int cirrus_pci_probe(struct pci_dev *pdev, if (ret) return ret; - drm_fbdev_generic_setup(dev, dev->mode_config.preferred_depth); + drm_fbdev_generic_setup(dev, 0); return 0; } -- 2.35.1
next prev parent reply other threads:[~2022-05-02 15:39 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-02 15:38 [PATCH v2 0/3] drm: Allow simpledrm to setup its emulated FB as firmware provided Javier Martinez Canillas 2022-05-02 15:38 ` Javier Martinez Canillas 2022-05-02 15:38 ` Javier Martinez Canillas 2022-05-02 15:38 ` Javier Martinez Canillas 2022-05-02 15:38 ` Javier Martinez Canillas 2022-05-02 15:38 ` Javier Martinez Canillas [this message] 2022-05-02 15:38 ` [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup() Javier Martinez Canillas 2022-05-02 16:06 ` Laurent Pinchart 2022-05-02 16:06 ` Laurent Pinchart 2022-05-02 16:06 ` Laurent Pinchart 2022-05-02 16:55 ` Javier Martinez Canillas 2022-05-02 16:55 ` Javier Martinez Canillas 2022-05-02 17:15 ` Javier Martinez Canillas 2022-05-02 17:15 ` Javier Martinez Canillas 2022-05-02 18:36 ` Laurent Pinchart 2022-05-02 18:36 ` Laurent Pinchart 2022-05-02 18:36 ` Laurent Pinchart 2022-05-02 19:28 ` Javier Martinez Canillas 2022-05-02 19:28 ` Javier Martinez Canillas 2022-05-02 19:41 ` Laurent Pinchart 2022-05-02 19:41 ` Laurent Pinchart 2022-05-02 19:41 ` Laurent Pinchart 2022-05-02 15:38 ` [PATCH v2 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter Javier Martinez Canillas 2022-05-02 15:38 ` Javier Martinez Canillas 2022-05-02 15:38 ` Javier Martinez Canillas 2022-05-02 15:38 ` Javier Martinez Canillas 2022-05-02 15:38 ` Javier Martinez Canillas 2022-05-02 16:07 ` Laurent Pinchart 2022-05-02 16:07 ` Laurent Pinchart 2022-05-02 16:07 ` Laurent Pinchart 2022-05-02 16:07 ` Laurent Pinchart 2022-05-02 16:07 ` Laurent Pinchart 2022-05-02 16:07 ` Laurent Pinchart 2022-05-02 16:57 ` Javier Martinez Canillas 2022-05-02 16:57 ` Javier Martinez Canillas 2022-05-02 16:57 ` Javier Martinez Canillas 2022-05-02 16:57 ` Javier Martinez Canillas 2022-05-02 16:57 ` Javier Martinez Canillas 2022-05-02 15:39 ` [PATCH v2 3/3] drm: Allow simpledrm to setup its emulated FB as firmware provided Javier Martinez Canillas 2022-05-02 15:39 ` Javier Martinez Canillas 2022-05-02 16:17 ` Laurent Pinchart 2022-05-02 16:17 ` Laurent Pinchart 2022-05-02 17:09 ` Javier Martinez Canillas 2022-05-02 17:09 ` Javier Martinez Canillas 2022-05-02 18:01 ` Laurent Pinchart 2022-05-02 18:01 ` Laurent Pinchart 2022-05-02 19:32 ` Javier Martinez Canillas 2022-05-02 19:32 ` Javier Martinez Canillas 2022-05-02 21:40 ` kernel test robot 2022-05-02 21:40 ` kernel test robot 2022-05-03 1:05 ` kernel test robot 2022-05-03 1:05 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220502153900.408522-2-javierm@redhat.com \ --to=javierm@redhat.com \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=tzimmermann@suse.de \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.