From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup()
Date: Mon, 2 May 2022 22:41:28 +0300 [thread overview]
Message-ID: <YnAz6HPPfWpYcZvF@pendragon.ideasonboard.com> (raw)
In-Reply-To: <21db3772-b85a-59ff-df17-9056b3099977@redhat.com>
On Mon, May 02, 2022 at 09:28:45PM +0200, Javier Martinez Canillas wrote:
> On 5/2/22 20:36, Laurent Pinchart wrote:
> > On Mon, May 02, 2022 at 07:15:16PM +0200, Javier Martinez Canillas wrote:
> >> On 5/2/22 18:55, Javier Martinez Canillas wrote:
> >>
> >> [snip]
> >>
> >>>> drop the depth option to drm_fbdev_generic_setup() ? There's a FIXME
> >>>> comment in drm_fbdev_generic_setup() that could be related.
> >>>
> >>> A FIXME makes sense, I'll add that to when posting a v3.
> >>
> >> There's actually a FIXME already in drm_fbdev_generic_setup(), so it's
> >> a documented issue [0]:
> >
> > That's what I meant by "there's a FIXME" :-) It doesn't have to be
> > addressed by this series, but it would be good to fix it.
>
> doh, I misread your original email. Yes, it's the same issue as you
> said and something that I plan to look at some point as a follow-up.
>
> I hope that we could just replace fbcon with a kms/systemd-consoled/foo
> user-space implementation before fixing all the stuff in the DRM fbdev
> emulation layer :)
If you can do that, I'll provide champagne :-)
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup()
Date: Mon, 2 May 2022 22:41:28 +0300 [thread overview]
Message-ID: <YnAz6HPPfWpYcZvF@pendragon.ideasonboard.com> (raw)
In-Reply-To: <21db3772-b85a-59ff-df17-9056b3099977@redhat.com>
On Mon, May 02, 2022 at 09:28:45PM +0200, Javier Martinez Canillas wrote:
> On 5/2/22 20:36, Laurent Pinchart wrote:
> > On Mon, May 02, 2022 at 07:15:16PM +0200, Javier Martinez Canillas wrote:
> >> On 5/2/22 18:55, Javier Martinez Canillas wrote:
> >>
> >> [snip]
> >>
> >>>> drop the depth option to drm_fbdev_generic_setup() ? There's a FIXME
> >>>> comment in drm_fbdev_generic_setup() that could be related.
> >>>
> >>> A FIXME makes sense, I'll add that to when posting a v3.
> >>
> >> There's actually a FIXME already in drm_fbdev_generic_setup(), so it's
> >> a documented issue [0]:
> >
> > That's what I meant by "there's a FIXME" :-) It doesn't have to be
> > addressed by this series, but it would be good to fix it.
>
> doh, I misread your original email. Yes, it's the same issue as you
> said and something that I plan to look at some point as a follow-up.
>
> I hope that we could just replace fbcon with a kms/systemd-consoled/foo
> user-space implementation before fixing all the stuff in the DRM fbdev
> emulation layer :)
If you can do that, I'll provide champagne :-)
--
Regards,
Laurent Pinchart
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup()
Date: Mon, 2 May 2022 22:41:28 +0300 [thread overview]
Message-ID: <YnAz6HPPfWpYcZvF@pendragon.ideasonboard.com> (raw)
In-Reply-To: <21db3772-b85a-59ff-df17-9056b3099977@redhat.com>
On Mon, May 02, 2022 at 09:28:45PM +0200, Javier Martinez Canillas wrote:
> On 5/2/22 20:36, Laurent Pinchart wrote:
> > On Mon, May 02, 2022 at 07:15:16PM +0200, Javier Martinez Canillas wrote:
> >> On 5/2/22 18:55, Javier Martinez Canillas wrote:
> >>
> >> [snip]
> >>
> >>>> drop the depth option to drm_fbdev_generic_setup() ? There's a FIXME
> >>>> comment in drm_fbdev_generic_setup() that could be related.
> >>>
> >>> A FIXME makes sense, I'll add that to when posting a v3.
> >>
> >> There's actually a FIXME already in drm_fbdev_generic_setup(), so it's
> >> a documented issue [0]:
> >
> > That's what I meant by "there's a FIXME" :-) It doesn't have to be
> > addressed by this series, but it would be good to fix it.
>
> doh, I misread your original email. Yes, it's the same issue as you
> said and something that I plan to look at some point as a follow-up.
>
> I hope that we could just replace fbcon with a kms/systemd-consoled/foo
> user-space implementation before fixing all the stuff in the DRM fbdev
> emulation layer :)
If you can do that, I'll provide champagne :-)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-05-02 19:41 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 15:38 [PATCH v2 0/3] drm: Allow simpledrm to setup its emulated FB as firmware provided Javier Martinez Canillas
2022-05-02 15:38 ` Javier Martinez Canillas
2022-05-02 15:38 ` Javier Martinez Canillas
2022-05-02 15:38 ` Javier Martinez Canillas
2022-05-02 15:38 ` Javier Martinez Canillas
2022-05-02 15:38 ` [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup() Javier Martinez Canillas
2022-05-02 15:38 ` Javier Martinez Canillas
2022-05-02 16:06 ` Laurent Pinchart
2022-05-02 16:06 ` Laurent Pinchart
2022-05-02 16:06 ` Laurent Pinchart
2022-05-02 16:55 ` Javier Martinez Canillas
2022-05-02 16:55 ` Javier Martinez Canillas
2022-05-02 17:15 ` Javier Martinez Canillas
2022-05-02 17:15 ` Javier Martinez Canillas
2022-05-02 18:36 ` Laurent Pinchart
2022-05-02 18:36 ` Laurent Pinchart
2022-05-02 18:36 ` Laurent Pinchart
2022-05-02 19:28 ` Javier Martinez Canillas
2022-05-02 19:28 ` Javier Martinez Canillas
2022-05-02 19:41 ` Laurent Pinchart [this message]
2022-05-02 19:41 ` Laurent Pinchart
2022-05-02 19:41 ` Laurent Pinchart
2022-05-02 15:38 ` [PATCH v2 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter Javier Martinez Canillas
2022-05-02 15:38 ` Javier Martinez Canillas
2022-05-02 15:38 ` Javier Martinez Canillas
2022-05-02 15:38 ` Javier Martinez Canillas
2022-05-02 15:38 ` Javier Martinez Canillas
2022-05-02 16:07 ` Laurent Pinchart
2022-05-02 16:07 ` Laurent Pinchart
2022-05-02 16:07 ` Laurent Pinchart
2022-05-02 16:07 ` Laurent Pinchart
2022-05-02 16:07 ` Laurent Pinchart
2022-05-02 16:07 ` Laurent Pinchart
2022-05-02 16:57 ` Javier Martinez Canillas
2022-05-02 16:57 ` Javier Martinez Canillas
2022-05-02 16:57 ` Javier Martinez Canillas
2022-05-02 16:57 ` Javier Martinez Canillas
2022-05-02 16:57 ` Javier Martinez Canillas
2022-05-02 15:39 ` [PATCH v2 3/3] drm: Allow simpledrm to setup its emulated FB as firmware provided Javier Martinez Canillas
2022-05-02 15:39 ` Javier Martinez Canillas
2022-05-02 16:17 ` Laurent Pinchart
2022-05-02 16:17 ` Laurent Pinchart
2022-05-02 17:09 ` Javier Martinez Canillas
2022-05-02 17:09 ` Javier Martinez Canillas
2022-05-02 18:01 ` Laurent Pinchart
2022-05-02 18:01 ` Laurent Pinchart
2022-05-02 19:32 ` Javier Martinez Canillas
2022-05-02 19:32 ` Javier Martinez Canillas
2022-05-02 21:40 ` kernel test robot
2022-05-02 21:40 ` kernel test robot
2022-05-03 1:05 ` kernel test robot
2022-05-03 1:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnAz6HPPfWpYcZvF@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.