All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 0/2] Bump sysdig to 0.29.2
@ 2022-05-03 14:26 Francis Laniel
  2022-05-03 14:27 ` [Buildroot] [PATCH 1/2] package/sysdig: fix DRIVER_NAME definition Francis Laniel
  2022-05-03 14:27 ` [Buildroot] [PATCH 2/2] package/sysdig: bump to version 0.29.2 Francis Laniel
  0 siblings, 2 replies; 6+ messages in thread
From: Francis Laniel @ 2022-05-03 14:26 UTC (permalink / raw)
  To: buildroot; +Cc: Francis Laniel, Angelo Compagnucci

Hi.


In my last contribution, I wrote a mistake in sysdig.mk which leaded DRIVER_NAME
to be empty [1]...
(The machine where I built is not the same than the one where I wrote and send
the patch...)
So, in this series, I fixed my previous error and bumped sysdig to its latest
version.

I was, of course, able to build and run sysdig within a VM based on
qemu_x86_64_defconfig:
Welcome to Buildroot
buildroot login: root
# sysdig --version
sysdig version 0.29.2
# sysdig | head
scap: loading out-of-tree module taints kernel.
scap: driver loading, scap
scap: adding new consumer (____ptrval____)
scap: initializing ring buffer for CPU 0
scap: CPU buffer initialized, size=8388608
scap: starting capture
4 14:21:45.440896991 0 <NA> (114) > switch next=10 pgft_maj=7 pgft_min=1300 vm_size=45464 vm_rss=18460 vm_swap=0
...
91 14:21:45.449639600 0 <NA> (0) > switch next=114(<NA>) pgft_maj=0 pgft_min=0 vm_size=0 vm_rss=0 vm_swap=0
scap: deallocating consumer (____ptrval____)
scap: no more consumers, stopping capture

If you see any way to improve this contribution, feel free to share it!

Francis Laniel (2):
  package/sysdig: fix DRIVER_NAME definition
  package/sysdig: bump to version 0.29.2

 package/sysdig/sysdig.hash | 2 +-
 package/sysdig/sysdig.mk   | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)


Best regards and thank you in advance.
---
[1] https://git.buildroot.net/buildroot/commit/?id=ea86757e51cf424566f79896335d31d15b89d0d9
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/sysdig: fix DRIVER_NAME definition
  2022-05-03 14:26 [Buildroot] [PATCH 0/2] Bump sysdig to 0.29.2 Francis Laniel
@ 2022-05-03 14:27 ` Francis Laniel
  2022-05-03 19:15   ` Yann E. MORIN
  2022-05-03 14:27 ` [Buildroot] [PATCH 2/2] package/sysdig: bump to version 0.29.2 Francis Laniel
  1 sibling, 1 reply; 6+ messages in thread
From: Francis Laniel @ 2022-05-03 14:27 UTC (permalink / raw)
  To: buildroot; +Cc: Francis Laniel, Angelo Compagnucci

When I wrote the previous commit, I was not fully focused and wrote:
-DDRIVER_NAME=$(FALCOSECURITY_LIBS_DRIVER_NAME.)
Which leaded to DRIVER_NAME to be empty.
So, it was not possible to use sysdig due to the following error message:
error opening device /dev/0. Make sure you have root credentials and that the  module is loaded.

Fixes: ea86757e51cf ("package/sysdig: bump to 0.29.1")
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
---
 package/sysdig/sysdig.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/sysdig/sysdig.mk b/package/sysdig/sysdig.mk
index 76cabcaeca..318746d44a 100644
--- a/package/sysdig/sysdig.mk
+++ b/package/sysdig/sysdig.mk
@@ -28,7 +28,7 @@ SYSDIG_DEPENDENCIES = \
 SYSDIG_CONF_OPTS += -DFALCOSECURITY_LIBS_SOURCE_DIR=$(FALCOSECURITY_LIBS_SRCDIR) \
 	-DBUILD_DRIVER=OFF \
 	-DGRPC_CPP_PLUGIN=$(HOST_DIR)/bin/grpc_cpp_plugin \
-	-DDRIVER_NAME=$(FALCOSECURITY_LIBS_DRIVER_NAME.) \
+	-DDRIVER_NAME=$(FALCOSECURITY_LIBS_DRIVER_NAME) \
 	-DENABLE_DKMS=OFF \
 	-DUSE_BUNDLED_DEPS=OFF \
 	-DWITH_CHISEL=ON \
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/sysdig: bump to version 0.29.2
  2022-05-03 14:26 [Buildroot] [PATCH 0/2] Bump sysdig to 0.29.2 Francis Laniel
  2022-05-03 14:27 ` [Buildroot] [PATCH 1/2] package/sysdig: fix DRIVER_NAME definition Francis Laniel
@ 2022-05-03 14:27 ` Francis Laniel
  2022-05-03 19:22   ` Yann E. MORIN
  1 sibling, 1 reply; 6+ messages in thread
From: Francis Laniel @ 2022-05-03 14:27 UTC (permalink / raw)
  To: buildroot; +Cc: Francis Laniel, Angelo Compagnucci

Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
---
 package/sysdig/sysdig.hash | 2 +-
 package/sysdig/sysdig.mk   | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/package/sysdig/sysdig.hash b/package/sysdig/sysdig.hash
index 380c9dce1e..c953421f27 100644
--- a/package/sysdig/sysdig.hash
+++ b/package/sysdig/sysdig.hash
@@ -1,3 +1,3 @@
 # sha256 locally computed
-sha256  3721c97f0da43c1a68d2962d30363525d8532ab5f2534dfefc86d175e17e423e  sysdig-0.29.1.tar.gz
+sha256  38ea602085f706af5d07630189216fa240064122650a81456cb092579313ae8e  sysdig-0.29.2.tar.gz
 sha256  a88fbf820b38b1c7fabc6efe291b8259e02ae21326f56fe31c6c9adf374b2702  COPYING
diff --git a/package/sysdig/sysdig.mk b/package/sysdig/sysdig.mk
index 318746d44a..2d57c0043f 100644
--- a/package/sysdig/sysdig.mk
+++ b/package/sysdig/sysdig.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-SYSDIG_VERSION = 0.29.1
+SYSDIG_VERSION = 0.29.2
 SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
 SYSDIG_LICENSE = Apache-2.0
 SYSDIG_LICENSE_FILE = COPYING
@@ -32,6 +32,7 @@ SYSDIG_CONF_OPTS += -DFALCOSECURITY_LIBS_SOURCE_DIR=$(FALCOSECURITY_LIBS_SRCDIR)
 	-DENABLE_DKMS=OFF \
 	-DUSE_BUNDLED_DEPS=OFF \
 	-DWITH_CHISEL=ON \
-	-DVALIJSON_INCLUDE=$(BUILD_DIR)/valijson-0.6/include/valijson
+	-DVALIJSON_INCLUDE=$(BUILD_DIR)/valijson-0.6/include/valijson \
+	-DSYSDIG_VERSION=$(SYSDIG_VERSION)
 
 $(eval $(cmake-package))
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/sysdig: fix DRIVER_NAME definition
  2022-05-03 14:27 ` [Buildroot] [PATCH 1/2] package/sysdig: fix DRIVER_NAME definition Francis Laniel
@ 2022-05-03 19:15   ` Yann E. MORIN
  0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2022-05-03 19:15 UTC (permalink / raw)
  To: Francis Laniel; +Cc: Angelo Compagnucci, buildroot

Francis, All,

On 2022-05-03 15:27 +0100, Francis Laniel spake thusly:
> When I wrote the previous commit, I was not fully focused and wrote:
> -DDRIVER_NAME=$(FALCOSECURITY_LIBS_DRIVER_NAME.)
> Which leaded to DRIVER_NAME to be empty.
> So, it was not possible to use sysdig due to the following error message:
> error opening device /dev/0. Make sure you have root credentials and that the  module is loaded.
> 
> Fixes: ea86757e51cf ("package/sysdig: bump to 0.29.1")
> Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/sysdig/sysdig.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/sysdig/sysdig.mk b/package/sysdig/sysdig.mk
> index 76cabcaeca..318746d44a 100644
> --- a/package/sysdig/sysdig.mk
> +++ b/package/sysdig/sysdig.mk
> @@ -28,7 +28,7 @@ SYSDIG_DEPENDENCIES = \
>  SYSDIG_CONF_OPTS += -DFALCOSECURITY_LIBS_SOURCE_DIR=$(FALCOSECURITY_LIBS_SRCDIR) \
>  	-DBUILD_DRIVER=OFF \
>  	-DGRPC_CPP_PLUGIN=$(HOST_DIR)/bin/grpc_cpp_plugin \
> -	-DDRIVER_NAME=$(FALCOSECURITY_LIBS_DRIVER_NAME.) \
> +	-DDRIVER_NAME=$(FALCOSECURITY_LIBS_DRIVER_NAME) \
>  	-DENABLE_DKMS=OFF \
>  	-DUSE_BUNDLED_DEPS=OFF \
>  	-DWITH_CHISEL=ON \
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/sysdig: bump to version 0.29.2
  2022-05-03 14:27 ` [Buildroot] [PATCH 2/2] package/sysdig: bump to version 0.29.2 Francis Laniel
@ 2022-05-03 19:22   ` Yann E. MORIN
  2022-05-04 12:28     ` Francis Laniel
  0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2022-05-03 19:22 UTC (permalink / raw)
  To: Francis Laniel; +Cc: Angelo Compagnucci, buildroot

Francis, All,

On 2022-05-03 15:27 +0100, Francis Laniel spake thusly:
> Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
> ---
>  package/sysdig/sysdig.hash | 2 +-
>  package/sysdig/sysdig.mk   | 5 +++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/package/sysdig/sysdig.hash b/package/sysdig/sysdig.hash
> index 380c9dce1e..c953421f27 100644
> --- a/package/sysdig/sysdig.hash
> +++ b/package/sysdig/sysdig.hash
> @@ -1,3 +1,3 @@
>  # sha256 locally computed
> -sha256  3721c97f0da43c1a68d2962d30363525d8532ab5f2534dfefc86d175e17e423e  sysdig-0.29.1.tar.gz
> +sha256  38ea602085f706af5d07630189216fa240064122650a81456cb092579313ae8e  sysdig-0.29.2.tar.gz
>  sha256  a88fbf820b38b1c7fabc6efe291b8259e02ae21326f56fe31c6c9adf374b2702  COPYING
> diff --git a/package/sysdig/sysdig.mk b/package/sysdig/sysdig.mk
> index 318746d44a..2d57c0043f 100644
> --- a/package/sysdig/sysdig.mk
> +++ b/package/sysdig/sysdig.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -SYSDIG_VERSION = 0.29.1
> +SYSDIG_VERSION = 0.29.2
>  SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
>  SYSDIG_LICENSE = Apache-2.0
>  SYSDIG_LICENSE_FILE = COPYING
> @@ -32,6 +32,7 @@ SYSDIG_CONF_OPTS += -DFALCOSECURITY_LIBS_SOURCE_DIR=$(FALCOSECURITY_LIBS_SRCDIR)
>  	-DENABLE_DKMS=OFF \
>  	-DUSE_BUNDLED_DEPS=OFF \
>  	-DWITH_CHISEL=ON \
> -	-DVALIJSON_INCLUDE=$(BUILD_DIR)/valijson-0.6/include/valijson
> +	-DVALIJSON_INCLUDE=$(BUILD_DIR)/valijson-0.6/include/valijson \
> +	-DSYSDIG_VERSION=$(SYSDIG_VERSION)

I've extended the commit log to explain why we need to explicitly set
the version string.

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  $(eval $(cmake-package))
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/sysdig: bump to version 0.29.2
  2022-05-03 19:22   ` Yann E. MORIN
@ 2022-05-04 12:28     ` Francis Laniel
  0 siblings, 0 replies; 6+ messages in thread
From: Francis Laniel @ 2022-05-04 12:28 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: Angelo Compagnucci, buildroot

Hi!

Le mardi 3 mai 2022, 20:22:16 BST Yann E. MORIN a écrit :
> Francis, All,
> 
> On 2022-05-03 15:27 +0100, Francis Laniel spake thusly:
> > Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
> > ---
> > 
> >  package/sysdig/sysdig.hash | 2 +-
> >  package/sysdig/sysdig.mk   | 5 +++--
> >  2 files changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/package/sysdig/sysdig.hash b/package/sysdig/sysdig.hash
> > index 380c9dce1e..c953421f27 100644
> > --- a/package/sysdig/sysdig.hash
> > +++ b/package/sysdig/sysdig.hash
> > @@ -1,3 +1,3 @@
> > 
> >  # sha256 locally computed
> > 
> > -sha256  3721c97f0da43c1a68d2962d30363525d8532ab5f2534dfefc86d175e17e423e 
> > sysdig-0.29.1.tar.gz +sha256 
> > 38ea602085f706af5d07630189216fa240064122650a81456cb092579313ae8e 
> > sysdig-0.29.2.tar.gz> 
> >  sha256  a88fbf820b38b1c7fabc6efe291b8259e02ae21326f56fe31c6c9adf374b2702 
> >  COPYING> 
> > diff --git a/package/sysdig/sysdig.mk b/package/sysdig/sysdig.mk
> > index 318746d44a..2d57c0043f 100644
> > --- a/package/sysdig/sysdig.mk
> > +++ b/package/sysdig/sysdig.mk
> > @@ -4,7 +4,7 @@
> > 
> >  #
> >  #########################################################################
> >  #######> 
> > -SYSDIG_VERSION = 0.29.1
> > +SYSDIG_VERSION = 0.29.2
> > 
> >  SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
> >  SYSDIG_LICENSE = Apache-2.0
> >  SYSDIG_LICENSE_FILE = COPYING
> > 
> > @@ -32,6 +32,7 @@ SYSDIG_CONF_OPTS +=
> > -DFALCOSECURITY_LIBS_SOURCE_DIR=$(FALCOSECURITY_LIBS_SRCDIR)> 
> >  	-DENABLE_DKMS=OFF \
> >  	-DUSE_BUNDLED_DEPS=OFF \
> >  	-DWITH_CHISEL=ON \
> > 
> > -	-DVALIJSON_INCLUDE=$(BUILD_DIR)/valijson-0.6/include/valijson
> > +	-DVALIJSON_INCLUDE=$(BUILD_DIR)/valijson-0.6/include/valijson \
> > +	-DSYSDIG_VERSION=$(SYSDIG_VERSION)
> 
> I've extended the commit log to explain why we need to explicitly set
> the version string.
> 
> Applied to master, thanks.

Thank you a lot for the merges and still sorry for the nit in previous 
commit...
I will take more care next time!

> Regards,
> Yann E. MORIN.
> 
> >  $(eval $(cmake-package))




_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-04 12:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-03 14:26 [Buildroot] [PATCH 0/2] Bump sysdig to 0.29.2 Francis Laniel
2022-05-03 14:27 ` [Buildroot] [PATCH 1/2] package/sysdig: fix DRIVER_NAME definition Francis Laniel
2022-05-03 19:15   ` Yann E. MORIN
2022-05-03 14:27 ` [Buildroot] [PATCH 2/2] package/sysdig: bump to version 0.29.2 Francis Laniel
2022-05-03 19:22   ` Yann E. MORIN
2022-05-04 12:28     ` Francis Laniel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.