From: kernel test robot <lkp@intel.com> To: Matthias Kaehlcke <mka@chromium.org>, Alasdair Kergon <agk@redhat.com>, Mike Snitzer <snitzer@kernel.org>, Kees Cook <keescook@chromium.org>, James Morris <jmorris@namei.org>, "Serge E . Hallyn" <serge@hallyn.com> Cc: kbuild-all@lists.01.org, dm-devel@redhat.com, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, Song Liu <song@kernel.org>, Douglas Anderson <dianders@chromium.org>, linux-security-module@vger.kernel.org, Matthias Kaehlcke <mka@chromium.org> Subject: Re: [PATCH v3 2/3] LoadPin: Enable loading from trusted dm-verity devices Date: Thu, 5 May 2022 06:26:58 +0800 [thread overview] Message-ID: <202205050636.VNgSDFVz-lkp@intel.com> (raw) In-Reply-To: <20220504125404.v3.2.I01c67af41d2f6525c6d023101671d7339a9bc8b5@changeid> Hi Matthias, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on device-mapper-dm/for-next] [also build test WARNING on song-md/md-next kees/for-next/pstore linus/master v5.18-rc5 next-20220504] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Matthias-Kaehlcke/LoadPin-Enable-loading-from-trusted-dm-verity-devices/20220505-035620 base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220505/202205050636.VNgSDFVz-lkp@intel.com/config) compiler: arceb-elf-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/56f912dcbb302f9a7e6694493529abd4e3f337af git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Matthias-Kaehlcke/LoadPin-Enable-loading-from-trusted-dm-verity-devices/20220505-035620 git checkout 56f912dcbb302f9a7e6694493529abd4e3f337af # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash security/loadpin/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): In file included from include/linux/kernel.h:29, from include/linux/cpumask.h:10, from include/linux/mm_types_task.h:14, from include/linux/mm_types.h:5, from include/linux/buildid.h:5, from include/linux/module.h:14, from security/loadpin/loadpin.c:12: security/loadpin/loadpin.c: In function 'init_loadpin_securityfs': >> include/linux/kern_levels.h:5:25: warning: format '%d' expects argument of type 'int', but argument 2 has type 'long int' [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/printk.h:418:25: note: in definition of macro 'printk_index_wrap' 418 | _p_func(_fmt, ##__VA_ARGS__); \ | ^~~~ include/linux/printk.h:489:9: note: in expansion of macro 'printk' 489 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~ include/linux/kern_levels.h:11:25: note: in expansion of macro 'KERN_SOH' 11 | #define KERN_ERR KERN_SOH "3" /* error conditions */ | ^~~~~~~~ include/linux/printk.h:489:16: note: in expansion of macro 'KERN_ERR' 489 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~ security/loadpin/loadpin.c:413:17: note: in expansion of macro 'pr_err' 413 | pr_err("LoadPin: could not create securityfs dir: %d\n", | ^~~~~~ >> include/linux/kern_levels.h:5:25: warning: format '%d' expects argument of type 'int', but argument 2 has type 'long int' [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/printk.h:418:25: note: in definition of macro 'printk_index_wrap' 418 | _p_func(_fmt, ##__VA_ARGS__); \ | ^~~~ include/linux/printk.h:489:9: note: in expansion of macro 'printk' 489 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~ include/linux/kern_levels.h:11:25: note: in expansion of macro 'KERN_SOH' 11 | #define KERN_ERR KERN_SOH "3" /* error conditions */ | ^~~~~~~~ include/linux/printk.h:489:16: note: in expansion of macro 'KERN_ERR' 489 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~ security/loadpin/loadpin.c:421:17: note: in expansion of macro 'pr_err' 421 | pr_err("LoadPin: could not create securityfs entry 'dm-verity': %d\n", | ^~~~~~ vim +5 include/linux/kern_levels.h 314ba3520e513a Joe Perches 2012-07-30 4 04d2c8c83d0e3a Joe Perches 2012-07-30 @5 #define KERN_SOH "\001" /* ASCII Start Of Header */ 04d2c8c83d0e3a Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII '\001' 04d2c8c83d0e3a Joe Perches 2012-07-30 7 -- 0-DAY CI Kernel Test Service https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: Matthias Kaehlcke <mka@chromium.org>, Alasdair Kergon <agk@redhat.com>, Mike Snitzer <snitzer@kernel.org>, Kees Cook <keescook@chromium.org>, James Morris <jmorris@namei.org>, "Serge E . Hallyn" <serge@hallyn.com> Cc: linux-security-module@vger.kernel.org, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Douglas Anderson <dianders@chromium.org>, linux-raid@vger.kernel.org, Song Liu <song@kernel.org>, dm-devel@redhat.com, Matthias Kaehlcke <mka@chromium.org> Subject: Re: [dm-devel] [PATCH v3 2/3] LoadPin: Enable loading from trusted dm-verity devices Date: Thu, 5 May 2022 06:26:58 +0800 [thread overview] Message-ID: <202205050636.VNgSDFVz-lkp@intel.com> (raw) In-Reply-To: <20220504125404.v3.2.I01c67af41d2f6525c6d023101671d7339a9bc8b5@changeid> Hi Matthias, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on device-mapper-dm/for-next] [also build test WARNING on song-md/md-next kees/for-next/pstore linus/master v5.18-rc5 next-20220504] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Matthias-Kaehlcke/LoadPin-Enable-loading-from-trusted-dm-verity-devices/20220505-035620 base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220505/202205050636.VNgSDFVz-lkp@intel.com/config) compiler: arceb-elf-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/56f912dcbb302f9a7e6694493529abd4e3f337af git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Matthias-Kaehlcke/LoadPin-Enable-loading-from-trusted-dm-verity-devices/20220505-035620 git checkout 56f912dcbb302f9a7e6694493529abd4e3f337af # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash security/loadpin/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): In file included from include/linux/kernel.h:29, from include/linux/cpumask.h:10, from include/linux/mm_types_task.h:14, from include/linux/mm_types.h:5, from include/linux/buildid.h:5, from include/linux/module.h:14, from security/loadpin/loadpin.c:12: security/loadpin/loadpin.c: In function 'init_loadpin_securityfs': >> include/linux/kern_levels.h:5:25: warning: format '%d' expects argument of type 'int', but argument 2 has type 'long int' [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/printk.h:418:25: note: in definition of macro 'printk_index_wrap' 418 | _p_func(_fmt, ##__VA_ARGS__); \ | ^~~~ include/linux/printk.h:489:9: note: in expansion of macro 'printk' 489 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~ include/linux/kern_levels.h:11:25: note: in expansion of macro 'KERN_SOH' 11 | #define KERN_ERR KERN_SOH "3" /* error conditions */ | ^~~~~~~~ include/linux/printk.h:489:16: note: in expansion of macro 'KERN_ERR' 489 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~ security/loadpin/loadpin.c:413:17: note: in expansion of macro 'pr_err' 413 | pr_err("LoadPin: could not create securityfs dir: %d\n", | ^~~~~~ >> include/linux/kern_levels.h:5:25: warning: format '%d' expects argument of type 'int', but argument 2 has type 'long int' [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/printk.h:418:25: note: in definition of macro 'printk_index_wrap' 418 | _p_func(_fmt, ##__VA_ARGS__); \ | ^~~~ include/linux/printk.h:489:9: note: in expansion of macro 'printk' 489 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~ include/linux/kern_levels.h:11:25: note: in expansion of macro 'KERN_SOH' 11 | #define KERN_ERR KERN_SOH "3" /* error conditions */ | ^~~~~~~~ include/linux/printk.h:489:16: note: in expansion of macro 'KERN_ERR' 489 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~ security/loadpin/loadpin.c:421:17: note: in expansion of macro 'pr_err' 421 | pr_err("LoadPin: could not create securityfs entry 'dm-verity': %d\n", | ^~~~~~ vim +5 include/linux/kern_levels.h 314ba3520e513a Joe Perches 2012-07-30 4 04d2c8c83d0e3a Joe Perches 2012-07-30 @5 #define KERN_SOH "\001" /* ASCII Start Of Header */ 04d2c8c83d0e3a Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII '\001' 04d2c8c83d0e3a Joe Perches 2012-07-30 7 -- 0-DAY CI Kernel Test Service https://01.org/lkp -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-05-04 22:27 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-04 19:54 [PATCH v3 0/3] LoadPin: Enable loading from trusted dm-verity devices Matthias Kaehlcke 2022-05-04 19:54 ` [dm-devel] " Matthias Kaehlcke 2022-05-04 19:54 ` [PATCH v3 1/3] dm: Add verity helpers for LoadPin Matthias Kaehlcke 2022-05-04 19:54 ` [dm-devel] " Matthias Kaehlcke 2022-05-11 20:54 ` Matthias Kaehlcke 2022-05-11 20:54 ` [dm-devel] " Matthias Kaehlcke 2022-05-12 17:19 ` Mike Snitzer 2022-05-12 17:19 ` [dm-devel] " Mike Snitzer 2022-05-12 18:14 ` Matthias Kaehlcke 2022-05-12 18:14 ` [dm-devel] " Matthias Kaehlcke 2022-05-12 20:44 ` Matthias Kaehlcke 2022-05-12 20:44 ` [dm-devel] " Matthias Kaehlcke 2022-05-13 16:29 ` Mike Snitzer 2022-05-13 16:29 ` [dm-devel] " Mike Snitzer 2022-05-13 16:53 ` Matthias Kaehlcke 2022-05-13 16:53 ` Matthias Kaehlcke 2022-05-13 22:15 ` Kees Cook 2022-05-13 22:15 ` [dm-devel] " Kees Cook 2022-05-16 18:51 ` Matthias Kaehlcke 2022-05-16 18:51 ` [dm-devel] " Matthias Kaehlcke 2022-05-17 3:38 ` Kees Cook 2022-05-17 3:38 ` [dm-devel] " Kees Cook 2022-05-04 19:54 ` [PATCH v3 2/3] LoadPin: Enable loading from trusted dm-verity devices Matthias Kaehlcke 2022-05-04 19:54 ` [dm-devel] " Matthias Kaehlcke 2022-05-04 22:26 ` kernel test robot [this message] 2022-05-04 22:26 ` kernel test robot 2022-05-13 16:32 ` Mike Snitzer 2022-05-13 16:32 ` [dm-devel] " Mike Snitzer 2022-05-13 17:01 ` Matthias Kaehlcke 2022-05-13 17:01 ` [dm-devel] " Matthias Kaehlcke 2022-05-13 18:26 ` Kees Cook 2022-05-13 18:26 ` [dm-devel] " Kees Cook 2022-05-13 22:36 ` Kees Cook 2022-05-13 22:36 ` [dm-devel] " Kees Cook 2022-05-16 18:17 ` Matthias Kaehlcke 2022-05-16 18:17 ` [dm-devel] " Matthias Kaehlcke 2022-05-17 3:44 ` Kees Cook 2022-05-17 3:44 ` [dm-devel] " Kees Cook 2022-05-17 19:28 ` Matthias Kaehlcke 2022-05-17 19:28 ` [dm-devel] " Matthias Kaehlcke 2022-05-04 19:54 ` [PATCH v3 3/3] dm: verity-loadpin: Use CONFIG_SECURITY_LOADPIN_VERITY for conditional compilation Matthias Kaehlcke 2022-05-04 19:54 ` [dm-devel] " Matthias Kaehlcke
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202205050636.VNgSDFVz-lkp@intel.com \ --to=lkp@intel.com \ --cc=agk@redhat.com \ --cc=dianders@chromium.org \ --cc=dm-devel@redhat.com \ --cc=jmorris@namei.org \ --cc=kbuild-all@lists.01.org \ --cc=keescook@chromium.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-raid@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=mka@chromium.org \ --cc=serge@hallyn.com \ --cc=snitzer@kernel.org \ --cc=song@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.