All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: jasowang@redhat.com, mst@redhat.com,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, peterz@infradead.org, paulmck@kernel.org,
	maz@kernel.org, pasic@linux.ibm.com, cohuck@redhat.com,
	eperezma@redhat.com, lulu@redhat.com, sgarzare@redhat.com,
	xuanzhuo@linux.alibaba.com
Subject: [PATCH V4 2/9] virtio: use virtio_reset_device() when possible
Date: Sat,  7 May 2022 15:19:47 +0800	[thread overview]
Message-ID: <20220507071954.14455-3-jasowang@redhat.com> (raw)
In-Reply-To: <20220507071954.14455-1-jasowang@redhat.com>

This allows us to do common extension without duplicating code.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Halil Pasic <pasic@linux.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 drivers/virtio/virtio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index 75c8d560bbd3..8dde44ea044a 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -430,7 +430,7 @@ int register_virtio_device(struct virtio_device *dev)
 
 	/* We always start by resetting the device, in case a previous
 	 * driver messed it up.  This also tests that code path a little. */
-	dev->config->reset(dev);
+	virtio_reset_device(dev);
 
 	/* Acknowledge that we've seen the device. */
 	virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
@@ -496,7 +496,7 @@ int virtio_device_restore(struct virtio_device *dev)
 
 	/* We always start by resetting the device, in case a previous
 	 * driver messed it up. */
-	dev->config->reset(dev);
+	virtio_reset_device(dev);
 
 	/* Acknowledge that we've seen the device. */
 	virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: jasowang@redhat.com, mst@redhat.com,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Cc: lulu@redhat.com, paulmck@kernel.org, peterz@infradead.org,
	maz@kernel.org, cohuck@redhat.com, pasic@linux.ibm.com,
	eperezma@redhat.com, tglx@linutronix.de
Subject: [PATCH V4 2/9] virtio: use virtio_reset_device() when possible
Date: Sat,  7 May 2022 15:19:47 +0800	[thread overview]
Message-ID: <20220507071954.14455-3-jasowang@redhat.com> (raw)
In-Reply-To: <20220507071954.14455-1-jasowang@redhat.com>

This allows us to do common extension without duplicating code.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Halil Pasic <pasic@linux.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 drivers/virtio/virtio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index 75c8d560bbd3..8dde44ea044a 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -430,7 +430,7 @@ int register_virtio_device(struct virtio_device *dev)
 
 	/* We always start by resetting the device, in case a previous
 	 * driver messed it up.  This also tests that code path a little. */
-	dev->config->reset(dev);
+	virtio_reset_device(dev);
 
 	/* Acknowledge that we've seen the device. */
 	virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
@@ -496,7 +496,7 @@ int virtio_device_restore(struct virtio_device *dev)
 
 	/* We always start by resetting the device, in case a previous
 	 * driver messed it up. */
-	dev->config->reset(dev);
+	virtio_reset_device(dev);
 
 	/* Acknowledge that we've seen the device. */
 	virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
-- 
2.25.1

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2022-05-07  7:20 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-07  7:19 [PATCH V4 0/9] rework on the IRQ hardening of virtio Jason Wang
2022-05-07  7:19 ` Jason Wang
2022-05-07  7:19 ` [PATCH V4 1/9] virtio: use virtio_device_ready() in virtio_device_restore() Jason Wang
2022-05-07  7:19   ` Jason Wang
2022-05-09 15:22   ` Cornelia Huck
2022-05-09 15:22     ` Cornelia Huck
2022-05-10  1:50     ` Jason Wang
2022-05-10  1:50       ` Jason Wang
2022-05-07  7:19 ` Jason Wang [this message]
2022-05-07  7:19   ` [PATCH V4 2/9] virtio: use virtio_reset_device() when possible Jason Wang
2022-05-07  7:19 ` [PATCH V4 3/9] virtio: introduce config op to synchronize vring callbacks Jason Wang
2022-05-07  7:19   ` Jason Wang
2022-05-09 15:24   ` Cornelia Huck
2022-05-09 15:24     ` Cornelia Huck
2022-05-07  7:19 ` [PATCH V4 4/9] virtio-pci: implement synchronize_cbs() Jason Wang
2022-05-07  7:19   ` Jason Wang
2022-05-09 15:26   ` Cornelia Huck
2022-05-09 15:26     ` Cornelia Huck
2022-05-07  7:19 ` [PATCH V4 5/9] virtio-mmio: " Jason Wang
2022-05-07  7:19   ` Jason Wang
2022-05-09 15:34   ` Cornelia Huck
2022-05-09 15:34     ` Cornelia Huck
2022-05-07  7:19 ` [PATCH V4 6/9] virtio-ccw: " Jason Wang
2022-05-07  7:19   ` Jason Wang
2022-05-10 11:27   ` Michael S. Tsirkin
2022-05-10 11:27     ` Michael S. Tsirkin
2022-05-11  2:41     ` Jason Wang
2022-05-11  2:41       ` Jason Wang
2022-05-11  8:17       ` Cornelia Huck
2022-05-11  8:17         ` Cornelia Huck
2022-05-11  8:58         ` Jason Wang
2022-05-11  8:58           ` Jason Wang
2022-05-11  9:13           ` Cornelia Huck
2022-05-11  9:13             ` Cornelia Huck
2022-05-11  9:28             ` Jason Wang
2022-05-11  9:28               ` Jason Wang
2022-05-11 14:52               ` Vineeth Vijayan
2022-05-12  3:29                 ` Jason Wang
2022-05-12  3:29                   ` Jason Wang
2022-05-07  7:19 ` [PATCH V4 7/9] virtio: allow to unbreak virtqueue Jason Wang
2022-05-07  7:19   ` Jason Wang
2022-05-07  7:19 ` [PATCH V4 8/9] virtio: harden vring IRQ Jason Wang
2022-05-07  7:19   ` Jason Wang
2022-05-10 11:32   ` Michael S. Tsirkin
2022-05-10 11:32     ` Michael S. Tsirkin
2022-05-11  2:40     ` Jason Wang
2022-05-11  2:40       ` Jason Wang
2022-05-11  8:44       ` Cornelia Huck
2022-05-11  8:44         ` Cornelia Huck
2022-05-11  9:27         ` Jason Wang
2022-05-11  9:27           ` Jason Wang
2022-05-11 12:49           ` Halil Pasic
2022-05-11 12:49             ` Halil Pasic
2022-05-12  3:27             ` Jason Wang
2022-05-12  3:27               ` Jason Wang
2022-05-07  7:19 ` [PATCH V4 9/9] virtio: use WARN_ON() to warning illegal status value Jason Wang
2022-05-07  7:19   ` Jason Wang
2022-05-10  9:29 ` [PATCH V4 0/9] rework on the IRQ hardening of virtio Cornelia Huck
2022-05-10  9:29   ` Cornelia Huck
2022-05-11  2:22   ` Jason Wang
2022-05-11  2:22     ` Jason Wang
2022-05-11 14:01     ` Halil Pasic
2022-05-11 14:01       ` Halil Pasic
2022-05-12  3:31       ` Jason Wang
2022-05-12  3:31         ` Jason Wang
2022-05-16 11:20         ` Halil Pasic
2022-05-16 11:20           ` Halil Pasic
2022-05-16 14:25           ` Michael S. Tsirkin
2022-05-16 14:25             ` Michael S. Tsirkin
2022-05-17  1:00             ` Jason Wang
2022-05-17  1:00               ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220507071954.14455-3-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lulu@redhat.com \
    --cc=maz@kernel.org \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sgarzare@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.