From: Jason Wang <jasowang@redhat.com> To: Halil Pasic <pasic@linux.ibm.com> Cc: Cornelia Huck <cohuck@redhat.com>, mst <mst@redhat.com>, virtualization <virtualization@lists.linux-foundation.org>, linux-kernel <linux-kernel@vger.kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Peter Zijlstra <peterz@infradead.org>, "Paul E. McKenney" <paulmck@kernel.org>, Marc Zyngier <maz@kernel.org>, eperezma <eperezma@redhat.com>, Cindy Lu <lulu@redhat.com>, Stefano Garzarella <sgarzare@redhat.com>, Xuan Zhuo <xuanzhuo@linux.alibaba.com> Subject: Re: [PATCH V4 0/9] rework on the IRQ hardening of virtio Date: Thu, 12 May 2022 11:31:08 +0800 [thread overview] Message-ID: <CACGkMEtaN6tZrwp3rsxu4Hn1Rev2P06X3BaR4X1cqDxnRdPCKg@mail.gmail.com> (raw) In-Reply-To: <20220511160147.46cbf2fb.pasic@linux.ibm.com> On Wed, May 11, 2022 at 10:02 PM Halil Pasic <pasic@linux.ibm.com> wrote: > > On Wed, 11 May 2022 10:22:59 +0800 > Jason Wang <jasowang@redhat.com> wrote: > > > > CPU0 > > > ---- > > > lock(&vcdev->irq_lock); > > > <Interrupt> > > > lock(&vcdev->irq_lock); > > > > > > *** DEADLOCK *** > > > > It looks to me we need to use write_lock_irq()/write_unlock_irq() to > > do the synchronization. > > > > And we probably need to keep the > > read_lock_irqsave()/read_lock_irqrestore() logic since I can see the > > virtio_ccw_int_handler() to be called from process context (e.g from > > the io_subchannel_quiesce()). > > > > Sounds correct. As Cornelia and Vineeth pointed out, all the paths the vring_interrupt is called with irq disabled. So I will use spin_lock()/spin_unlock() in the next version. Thanks > > Regards, > Halil >
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Halil Pasic <pasic@linux.ibm.com> Cc: Cindy Lu <lulu@redhat.com>, "Paul E. McKenney" <paulmck@kernel.org>, mst <mst@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Marc Zyngier <maz@kernel.org>, Cornelia Huck <cohuck@redhat.com>, linux-kernel <linux-kernel@vger.kernel.org>, virtualization <virtualization@lists.linux-foundation.org>, eperezma <eperezma@redhat.com>, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [PATCH V4 0/9] rework on the IRQ hardening of virtio Date: Thu, 12 May 2022 11:31:08 +0800 [thread overview] Message-ID: <CACGkMEtaN6tZrwp3rsxu4Hn1Rev2P06X3BaR4X1cqDxnRdPCKg@mail.gmail.com> (raw) In-Reply-To: <20220511160147.46cbf2fb.pasic@linux.ibm.com> On Wed, May 11, 2022 at 10:02 PM Halil Pasic <pasic@linux.ibm.com> wrote: > > On Wed, 11 May 2022 10:22:59 +0800 > Jason Wang <jasowang@redhat.com> wrote: > > > > CPU0 > > > ---- > > > lock(&vcdev->irq_lock); > > > <Interrupt> > > > lock(&vcdev->irq_lock); > > > > > > *** DEADLOCK *** > > > > It looks to me we need to use write_lock_irq()/write_unlock_irq() to > > do the synchronization. > > > > And we probably need to keep the > > read_lock_irqsave()/read_lock_irqrestore() logic since I can see the > > virtio_ccw_int_handler() to be called from process context (e.g from > > the io_subchannel_quiesce()). > > > > Sounds correct. As Cornelia and Vineeth pointed out, all the paths the vring_interrupt is called with irq disabled. So I will use spin_lock()/spin_unlock() in the next version. Thanks > > Regards, > Halil > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-05-12 3:31 UTC|newest] Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-07 7:19 [PATCH V4 0/9] rework on the IRQ hardening of virtio Jason Wang 2022-05-07 7:19 ` Jason Wang 2022-05-07 7:19 ` [PATCH V4 1/9] virtio: use virtio_device_ready() in virtio_device_restore() Jason Wang 2022-05-07 7:19 ` Jason Wang 2022-05-09 15:22 ` Cornelia Huck 2022-05-09 15:22 ` Cornelia Huck 2022-05-10 1:50 ` Jason Wang 2022-05-10 1:50 ` Jason Wang 2022-05-07 7:19 ` [PATCH V4 2/9] virtio: use virtio_reset_device() when possible Jason Wang 2022-05-07 7:19 ` Jason Wang 2022-05-07 7:19 ` [PATCH V4 3/9] virtio: introduce config op to synchronize vring callbacks Jason Wang 2022-05-07 7:19 ` Jason Wang 2022-05-09 15:24 ` Cornelia Huck 2022-05-09 15:24 ` Cornelia Huck 2022-05-07 7:19 ` [PATCH V4 4/9] virtio-pci: implement synchronize_cbs() Jason Wang 2022-05-07 7:19 ` Jason Wang 2022-05-09 15:26 ` Cornelia Huck 2022-05-09 15:26 ` Cornelia Huck 2022-05-07 7:19 ` [PATCH V4 5/9] virtio-mmio: " Jason Wang 2022-05-07 7:19 ` Jason Wang 2022-05-09 15:34 ` Cornelia Huck 2022-05-09 15:34 ` Cornelia Huck 2022-05-07 7:19 ` [PATCH V4 6/9] virtio-ccw: " Jason Wang 2022-05-07 7:19 ` Jason Wang 2022-05-10 11:27 ` Michael S. Tsirkin 2022-05-10 11:27 ` Michael S. Tsirkin 2022-05-11 2:41 ` Jason Wang 2022-05-11 2:41 ` Jason Wang 2022-05-11 8:17 ` Cornelia Huck 2022-05-11 8:17 ` Cornelia Huck 2022-05-11 8:58 ` Jason Wang 2022-05-11 8:58 ` Jason Wang 2022-05-11 9:13 ` Cornelia Huck 2022-05-11 9:13 ` Cornelia Huck 2022-05-11 9:28 ` Jason Wang 2022-05-11 9:28 ` Jason Wang 2022-05-11 14:52 ` Vineeth Vijayan 2022-05-12 3:29 ` Jason Wang 2022-05-12 3:29 ` Jason Wang 2022-05-07 7:19 ` [PATCH V4 7/9] virtio: allow to unbreak virtqueue Jason Wang 2022-05-07 7:19 ` Jason Wang 2022-05-07 7:19 ` [PATCH V4 8/9] virtio: harden vring IRQ Jason Wang 2022-05-07 7:19 ` Jason Wang 2022-05-10 11:32 ` Michael S. Tsirkin 2022-05-10 11:32 ` Michael S. Tsirkin 2022-05-11 2:40 ` Jason Wang 2022-05-11 2:40 ` Jason Wang 2022-05-11 8:44 ` Cornelia Huck 2022-05-11 8:44 ` Cornelia Huck 2022-05-11 9:27 ` Jason Wang 2022-05-11 9:27 ` Jason Wang 2022-05-11 12:49 ` Halil Pasic 2022-05-11 12:49 ` Halil Pasic 2022-05-12 3:27 ` Jason Wang 2022-05-12 3:27 ` Jason Wang 2022-05-07 7:19 ` [PATCH V4 9/9] virtio: use WARN_ON() to warning illegal status value Jason Wang 2022-05-07 7:19 ` Jason Wang 2022-05-10 9:29 ` [PATCH V4 0/9] rework on the IRQ hardening of virtio Cornelia Huck 2022-05-10 9:29 ` Cornelia Huck 2022-05-11 2:22 ` Jason Wang 2022-05-11 2:22 ` Jason Wang 2022-05-11 14:01 ` Halil Pasic 2022-05-11 14:01 ` Halil Pasic 2022-05-12 3:31 ` Jason Wang [this message] 2022-05-12 3:31 ` Jason Wang 2022-05-16 11:20 ` Halil Pasic 2022-05-16 11:20 ` Halil Pasic 2022-05-16 14:25 ` Michael S. Tsirkin 2022-05-16 14:25 ` Michael S. Tsirkin 2022-05-17 1:00 ` Jason Wang 2022-05-17 1:00 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACGkMEtaN6tZrwp3rsxu4Hn1Rev2P06X3BaR4X1cqDxnRdPCKg@mail.gmail.com \ --to=jasowang@redhat.com \ --cc=cohuck@redhat.com \ --cc=eperezma@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lulu@redhat.com \ --cc=maz@kernel.org \ --cc=mst@redhat.com \ --cc=pasic@linux.ibm.com \ --cc=paulmck@kernel.org \ --cc=peterz@infradead.org \ --cc=sgarzare@redhat.com \ --cc=tglx@linutronix.de \ --cc=virtualization@lists.linux-foundation.org \ --cc=xuanzhuo@linux.alibaba.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.