Re: [v3 2/3] phy: qcom-snps: Add support for overriding phy tuning parameters

From: kernel test robot <lkp@intel.com>
To: Krishna Kurapati <quic_kriskura@quicinc.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Doug Anderson <dianders@chromium.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Wesley Cheng <wcheng@codeaurora.org>
Cc: kbuild-all@lists.01.org, devicetree@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
	quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com,
	quic_vpulyala@quicinc.com,
	Krishna Kurapati <quic_kriskura@quicinc.com>
Subject: Re: [v3 2/3] phy: qcom-snps: Add support for overriding phy tuning parameters
Date: Sun, 8 May 2022 21:22:50 +0800	[thread overview]
Message-ID: <202205082118.cd3B5WOH-lkp@intel.com> (raw)
In-Reply-To: <1652011947-18575-3-git-send-email-quic_kriskura@quicinc.com>

Hi Krishna,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on krzk/for-next linus/master v5.18-rc5 next-20220506]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Krishna-Kurapati/Add-QCOM-SNPS-PHY-overriding-params-support/20220508-201506
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220508/202205082118.cd3B5WOH-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/4f3771418951e9e3fcb6357959dbd668cdb54fb1
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Krishna-Kurapati/Add-QCOM-SNPS-PHY-overriding-params-support/20220508-201506
        git checkout 4f3771418951e9e3fcb6357959dbd668cdb54fb1
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/phy/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c: In function 'phy_read_param_override_seq':
>> drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c:530:33: warning: variable 'hsphy' set but not used [-Wunused-but-set-variable]
     530 |         struct qcom_snps_hsphy *hsphy;
         |                                 ^~~~~

vim +/hsphy +530 drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c

   524	
   525	static void phy_read_param_override_seq(struct device *dev)
   526	{
   527		struct device_node *node = dev->of_node;
   528		s32 val;
   529		int ret, i;
 > 530		struct qcom_snps_hsphy *hsphy;
   531		struct override_param_map *cfg = (struct override_param_map* ) of_device_get_match_data(dev);
   532		hsphy = dev_get_drvdata(dev);
   533	
   534		for (i = 0; i < ARRAY_SIZE(phy_seq_props); i++) {
   535			ret = of_property_read_s32(node, phy_seq_props[i], &val);
   536			if (!ret)
   537				hsphy_override_param_update_val(cfg[i], val, &update_seq_cfg[i]);
   538		}
   539	}
   540	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy