From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
To: Pavan Kondeti <quic_pkondeti@quicinc.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Boyd <swboyd@chromium.org>,
"Doug Anderson" <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Wesley Cheng <wcheng@codeaurora.org>,
<devicetree@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-phy@lists.infradead.org>, <quic_ppratap@quicinc.com>,
<quic_vpulyala@quicinc.com>
Subject: Re: [v3 3/3] arm64: dts: qcom: sc7280: Update SNPS Phy params for SC7280 IDP device
Date: Tue, 10 May 2022 23:05:42 +0530 [thread overview]
Message-ID: <7ef88262-4292-3077-00a1-dc06b2483b10@quicinc.com> (raw)
In-Reply-To: <20220509032005.GJ4640@hu-pkondeti-hyd.qualcomm.com>
On 5/9/2022 8:50 AM, Pavan Kondeti wrote:
> Hi Krishna,
>
> On Sun, May 08, 2022 at 05:42:27PM +0530, Krishna Kurapati wrote:
>> Overriding the SNPS Phy tuning parameters for SC7280 IDP device.
>>
>> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> index 5eb6689..ad85ffb 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> @@ -325,6 +325,12 @@
>> vdda-pll-supply = <&vreg_l10c_0p8>;
>> vdda33-supply = <&vreg_l2b_3p0>;
>> vdda18-supply = <&vreg_l1c_1p8>;
>> + qcom,hs-rise-fall-time-bps = <0>;
>> + qcom,squelch-detector-bps = <(-2090)>;
>> + qcom,hs-disconnect-bps = <1743>;
>> + qcom,hs-amplitude-bps = <1780>;
>> + qcom,hs-crossover-voltage = <(-31)>;
>> + qcom,hs-output-impedance = <2600>;
>> };
> Is this an example change or do we see any HS electrical compliance failures
> on SC7280 IDP that will get fixed with these override sequence?
>
> Thanks,
> Pavan
Hi Pavan,
These results were based on compliance testing results.
WARNING: multiple messages have this Message-ID (diff)
From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
To: Pavan Kondeti <quic_pkondeti@quicinc.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Boyd <swboyd@chromium.org>,
"Doug Anderson" <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Wesley Cheng <wcheng@codeaurora.org>,
<devicetree@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-phy@lists.infradead.org>, <quic_ppratap@quicinc.com>,
<quic_vpulyala@quicinc.com>
Subject: Re: [v3 3/3] arm64: dts: qcom: sc7280: Update SNPS Phy params for SC7280 IDP device
Date: Tue, 10 May 2022 23:05:42 +0530 [thread overview]
Message-ID: <7ef88262-4292-3077-00a1-dc06b2483b10@quicinc.com> (raw)
In-Reply-To: <20220509032005.GJ4640@hu-pkondeti-hyd.qualcomm.com>
On 5/9/2022 8:50 AM, Pavan Kondeti wrote:
> Hi Krishna,
>
> On Sun, May 08, 2022 at 05:42:27PM +0530, Krishna Kurapati wrote:
>> Overriding the SNPS Phy tuning parameters for SC7280 IDP device.
>>
>> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> index 5eb6689..ad85ffb 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> @@ -325,6 +325,12 @@
>> vdda-pll-supply = <&vreg_l10c_0p8>;
>> vdda33-supply = <&vreg_l2b_3p0>;
>> vdda18-supply = <&vreg_l1c_1p8>;
>> + qcom,hs-rise-fall-time-bps = <0>;
>> + qcom,squelch-detector-bps = <(-2090)>;
>> + qcom,hs-disconnect-bps = <1743>;
>> + qcom,hs-amplitude-bps = <1780>;
>> + qcom,hs-crossover-voltage = <(-31)>;
>> + qcom,hs-output-impedance = <2600>;
>> };
> Is this an example change or do we see any HS electrical compliance failures
> on SC7280 IDP that will get fixed with these override sequence?
>
> Thanks,
> Pavan
Hi Pavan,
These results were based on compliance testing results.
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-05-10 17:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-08 12:12 [v3 0/3] Add QCOM SNPS PHY overriding params support Krishna Kurapati
2022-05-08 12:12 ` Krishna Kurapati
2022-05-08 12:12 ` [v3 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params bindings Krishna Kurapati
2022-05-08 12:12 ` [v3 1/3] dt-bindings: phy: qcom, usb-snps-femto-v2: " Krishna Kurapati
2022-05-09 2:52 ` [v3 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: " Pavan Kondeti
2022-05-09 2:52 ` Pavan Kondeti
2022-05-08 12:12 ` [v3 2/3] phy: qcom-snps: Add support for overriding phy tuning parameters Krishna Kurapati
2022-05-08 12:12 ` Krishna Kurapati
2022-05-08 13:22 ` kernel test robot
2022-05-08 13:22 ` kernel test robot
2022-05-09 3:18 ` Pavan Kondeti
2022-05-09 3:18 ` Pavan Kondeti
2022-05-10 17:34 ` Krishna Kurapati PSSNV
2022-05-10 17:34 ` Krishna Kurapati PSSNV
2022-05-08 12:12 ` [v3 3/3] arm64: dts: qcom: sc7280: Update SNPS Phy params for SC7280 IDP device Krishna Kurapati
2022-05-08 12:12 ` Krishna Kurapati
2022-05-09 3:20 ` Pavan Kondeti
2022-05-09 3:20 ` Pavan Kondeti
2022-05-10 17:35 ` Krishna Kurapati PSSNV [this message]
2022-05-10 17:35 ` Krishna Kurapati PSSNV
2022-05-11 2:31 ` Pavan Kondeti
2022-05-11 2:31 ` Pavan Kondeti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ef88262-4292-3077-00a1-dc06b2483b10@quicinc.com \
--to=quic_kriskura@quicinc.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_vpulyala@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.