From: Lu Baolu <baolu.lu@linux.intel.com> To: Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@nvidia.com>, Christoph Hellwig <hch@infradead.org>, Kevin Tian <kevin.tian@intel.com>, Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Jean-Philippe Brucker <jean-philippe@linaro.com>, Dave Jiang <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org> Cc: Eric Auger <eric.auger@redhat.com>, Liu Yi L <yi.l.liu@intel.com>, Jacob jun Pan <jacob.jun.pan@intel.com>, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com> Subject: [PATCH v6 00/12] iommu: SVA and IOPF refactoring Date: Tue, 10 May 2022 14:17:26 +0800 [thread overview] Message-ID: <20220510061738.2761430-1-baolu.lu@linux.intel.com> (raw) Hi folks, The former part of this series refactors the IOMMU SVA code by assigning an SVA type of iommu_domain to a shared virtual address and replacing sva_bind/unbind iommu ops with attach/detach_dev_pasid domain ops. The latter part changes the existing I/O page fault handling framework from only serving SVA to a generic one. Any driver or component could handle the I/O page faults for its domain in its own way by installing an I/O page fault handler. This series has been functionally tested on an x86 machine and compile tested for other architectures. This series is also available on github: [2] https://github.com/LuBaolu/intel-iommu/commits/iommu-sva-refactoring-v6 Please review and suggest. Best regards, baolu Change log: v6: - Refine the SVA basic data structures. Link: https://lore.kernel.org/linux-iommu/YnFv0ps0Ad8v+7uH@myrica/ - Refine arm smmuv3 sva domain allocation. - Fix a possible lock issue. Link: https://lore.kernel.org/linux-iommu/YnFydE8j8l7Q4m+b@myrica/ v5: - https://lore.kernel.org/linux-iommu/20220502014842.991097-1-baolu.lu@linux.intel.com/ - Address review comments from Jean-Philippe Brucker. Very appreciated! - Remove redundant pci aliases check in device_group_immutable_singleton(). - Treat all buses exept PCI as static in immutable singleton check. - As the sva_bind/unbind() have already guaranteed sva domain free only after iopf_queue_flush_dev(), remove the unnecessary domain refcount. - Move domain get() out of the list iteration in iopf_handle_group(). v4: - https://lore.kernel.org/linux-iommu/20220421052121.3464100-1-baolu.lu@linux.intel.com/ - Solve the overlap with another series and make this series self-contained. - No objection to the abstraction of data structure during v3 review. Hence remove the RFC subject prefix. - Refine the immutable singleton group code according to Kevin's comments. v3: - https://lore.kernel.org/linux-iommu/20220410102443.294128-1-baolu.lu@linux.intel.com/ - Rework iommu_group_singleton_lockdown() by adding a flag to the group that positively indicates the group can never have more than one member, even after hot plug. - Abstract the data structs used for iommu sva in a separated patches to make it easier for review. - I still keep the RFC prefix in this series as above two significant changes need at least another round review to be finalized. - Several misc refinements. v2: - https://lore.kernel.org/linux-iommu/20220329053800.3049561-1-baolu.lu@linux.intel.com/ - Add sva domain life cycle management to avoid race between unbind and page fault handling. - Use a single domain for each mm. - Return a single sva handler for the same binding. - Add a new helper to meet singleton group requirement. - Rework the SVA domain allocation for arm smmu v3 driver and move the pasid_bit initialization to device probe. - Drop the patch "iommu: Handle IO page faults directly". - Add mmget_not_zero(mm) in SVA page fault handler. v1: - https://lore.kernel.org/linux-iommu/20220320064030.2936936-1-baolu.lu@linux.intel.com/ - Initial post. Dave Jiang (1): dmaengine: idxd: Separate user and kernel pasid enabling Lu Baolu (11): iommu: Add pasid_bits field in struct dev_iommu iommu: Add attach/detach_dev_pasid domain ops iommu/sva: Basic data structures for SVA iommu/vt-d: Remove SVM_FLAG_SUPERVISOR_MODE support iommu/vt-d: Add SVA domain support arm-smmu-v3/sva: Add SVA domain support iommu/sva: Use attach/detach_pasid_dev in SVA interfaces iommu: Remove SVA related callbacks from iommu ops iommu: Prepare IOMMU domain for IOPF iommu: Per-domain I/O page fault handling iommu: Rename iommu-sva-lib.{c,h} include/linux/intel-iommu.h | 9 +- include/linux/iommu.h | 99 +++++-- drivers/dma/idxd/idxd.h | 6 + drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 19 +- .../iommu/{iommu-sva-lib.h => iommu-sva.h} | 3 - drivers/dma/idxd/cdev.c | 4 +- drivers/dma/idxd/init.c | 30 +- .../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 111 +++++--- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 10 +- drivers/iommu/intel/iommu.c | 12 +- drivers/iommu/intel/svm.c | 146 ++++------ drivers/iommu/io-pgfault.c | 73 +---- drivers/iommu/iommu-sva-lib.c | 71 ----- drivers/iommu/iommu-sva.c | 261 ++++++++++++++++++ drivers/iommu/iommu.c | 193 +++++++------ drivers/iommu/Makefile | 2 +- 16 files changed, 623 insertions(+), 426 deletions(-) rename drivers/iommu/{iommu-sva-lib.h => iommu-sva.h} (91%) delete mode 100644 drivers/iommu/iommu-sva-lib.c create mode 100644 drivers/iommu/iommu-sva.c -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu@linux.intel.com> To: Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@nvidia.com>, Christoph Hellwig <hch@infradead.org>, Kevin Tian <kevin.tian@intel.com>, Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Jean-Philippe Brucker <jean-philippe@linaro.com>, Dave Jiang <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org> Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Jacob jun Pan <jacob.jun.pan@intel.com> Subject: [PATCH v6 00/12] iommu: SVA and IOPF refactoring Date: Tue, 10 May 2022 14:17:26 +0800 [thread overview] Message-ID: <20220510061738.2761430-1-baolu.lu@linux.intel.com> (raw) Hi folks, The former part of this series refactors the IOMMU SVA code by assigning an SVA type of iommu_domain to a shared virtual address and replacing sva_bind/unbind iommu ops with attach/detach_dev_pasid domain ops. The latter part changes the existing I/O page fault handling framework from only serving SVA to a generic one. Any driver or component could handle the I/O page faults for its domain in its own way by installing an I/O page fault handler. This series has been functionally tested on an x86 machine and compile tested for other architectures. This series is also available on github: [2] https://github.com/LuBaolu/intel-iommu/commits/iommu-sva-refactoring-v6 Please review and suggest. Best regards, baolu Change log: v6: - Refine the SVA basic data structures. Link: https://lore.kernel.org/linux-iommu/YnFv0ps0Ad8v+7uH@myrica/ - Refine arm smmuv3 sva domain allocation. - Fix a possible lock issue. Link: https://lore.kernel.org/linux-iommu/YnFydE8j8l7Q4m+b@myrica/ v5: - https://lore.kernel.org/linux-iommu/20220502014842.991097-1-baolu.lu@linux.intel.com/ - Address review comments from Jean-Philippe Brucker. Very appreciated! - Remove redundant pci aliases check in device_group_immutable_singleton(). - Treat all buses exept PCI as static in immutable singleton check. - As the sva_bind/unbind() have already guaranteed sva domain free only after iopf_queue_flush_dev(), remove the unnecessary domain refcount. - Move domain get() out of the list iteration in iopf_handle_group(). v4: - https://lore.kernel.org/linux-iommu/20220421052121.3464100-1-baolu.lu@linux.intel.com/ - Solve the overlap with another series and make this series self-contained. - No objection to the abstraction of data structure during v3 review. Hence remove the RFC subject prefix. - Refine the immutable singleton group code according to Kevin's comments. v3: - https://lore.kernel.org/linux-iommu/20220410102443.294128-1-baolu.lu@linux.intel.com/ - Rework iommu_group_singleton_lockdown() by adding a flag to the group that positively indicates the group can never have more than one member, even after hot plug. - Abstract the data structs used for iommu sva in a separated patches to make it easier for review. - I still keep the RFC prefix in this series as above two significant changes need at least another round review to be finalized. - Several misc refinements. v2: - https://lore.kernel.org/linux-iommu/20220329053800.3049561-1-baolu.lu@linux.intel.com/ - Add sva domain life cycle management to avoid race between unbind and page fault handling. - Use a single domain for each mm. - Return a single sva handler for the same binding. - Add a new helper to meet singleton group requirement. - Rework the SVA domain allocation for arm smmu v3 driver and move the pasid_bit initialization to device probe. - Drop the patch "iommu: Handle IO page faults directly". - Add mmget_not_zero(mm) in SVA page fault handler. v1: - https://lore.kernel.org/linux-iommu/20220320064030.2936936-1-baolu.lu@linux.intel.com/ - Initial post. Dave Jiang (1): dmaengine: idxd: Separate user and kernel pasid enabling Lu Baolu (11): iommu: Add pasid_bits field in struct dev_iommu iommu: Add attach/detach_dev_pasid domain ops iommu/sva: Basic data structures for SVA iommu/vt-d: Remove SVM_FLAG_SUPERVISOR_MODE support iommu/vt-d: Add SVA domain support arm-smmu-v3/sva: Add SVA domain support iommu/sva: Use attach/detach_pasid_dev in SVA interfaces iommu: Remove SVA related callbacks from iommu ops iommu: Prepare IOMMU domain for IOPF iommu: Per-domain I/O page fault handling iommu: Rename iommu-sva-lib.{c,h} include/linux/intel-iommu.h | 9 +- include/linux/iommu.h | 99 +++++-- drivers/dma/idxd/idxd.h | 6 + drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 19 +- .../iommu/{iommu-sva-lib.h => iommu-sva.h} | 3 - drivers/dma/idxd/cdev.c | 4 +- drivers/dma/idxd/init.c | 30 +- .../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 111 +++++--- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 10 +- drivers/iommu/intel/iommu.c | 12 +- drivers/iommu/intel/svm.c | 146 ++++------ drivers/iommu/io-pgfault.c | 73 +---- drivers/iommu/iommu-sva-lib.c | 71 ----- drivers/iommu/iommu-sva.c | 261 ++++++++++++++++++ drivers/iommu/iommu.c | 193 +++++++------ drivers/iommu/Makefile | 2 +- 16 files changed, 623 insertions(+), 426 deletions(-) rename drivers/iommu/{iommu-sva-lib.h => iommu-sva.h} (91%) delete mode 100644 drivers/iommu/iommu-sva-lib.c create mode 100644 drivers/iommu/iommu-sva.c -- 2.25.1 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next reply other threads:[~2022-05-10 6:20 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-10 6:17 Lu Baolu [this message] 2022-05-10 6:17 ` [PATCH v6 00/12] iommu: SVA and IOPF refactoring Lu Baolu 2022-05-10 6:17 ` [PATCH v6 01/12] dmaengine: idxd: Separate user and kernel pasid enabling Lu Baolu 2022-05-10 6:17 ` Lu Baolu 2022-05-10 6:17 ` [PATCH v6 02/12] iommu: Add pasid_bits field in struct dev_iommu Lu Baolu 2022-05-10 6:17 ` Lu Baolu 2022-05-10 14:34 ` Jason Gunthorpe via iommu 2022-05-10 14:34 ` Jason Gunthorpe 2022-05-11 2:25 ` Baolu Lu 2022-05-11 2:25 ` Baolu Lu 2022-05-11 8:00 ` Jean-Philippe Brucker 2022-05-11 8:00 ` Jean-Philippe Brucker 2022-05-11 11:59 ` Jason Gunthorpe 2022-05-11 11:59 ` Jason Gunthorpe via iommu 2022-05-10 6:17 ` [PATCH v6 03/12] iommu: Add attach/detach_dev_pasid domain ops Lu Baolu 2022-05-10 6:17 ` Lu Baolu 2022-05-10 14:02 ` Jason Gunthorpe via iommu 2022-05-10 14:02 ` Jason Gunthorpe 2022-05-11 2:32 ` Baolu Lu 2022-05-11 2:32 ` Baolu Lu 2022-05-11 4:09 ` Tian, Kevin 2022-05-11 4:09 ` Tian, Kevin 2022-05-11 7:54 ` Jean-Philippe Brucker 2022-05-11 7:54 ` Jean-Philippe Brucker 2022-05-11 12:02 ` Jason Gunthorpe 2022-05-11 12:02 ` Jason Gunthorpe via iommu 2022-05-12 7:00 ` Jean-Philippe Brucker 2022-05-12 7:00 ` Jean-Philippe Brucker 2022-05-12 11:51 ` Jason Gunthorpe 2022-05-12 11:51 ` Jason Gunthorpe via iommu 2022-05-16 2:03 ` Baolu Lu 2022-05-16 2:03 ` Baolu Lu 2022-05-10 6:17 ` [PATCH v6 04/12] iommu/sva: Basic data structures for SVA Lu Baolu 2022-05-10 6:17 ` Lu Baolu 2022-05-10 6:17 ` [PATCH v6 05/12] iommu/vt-d: Remove SVM_FLAG_SUPERVISOR_MODE support Lu Baolu 2022-05-10 6:17 ` Lu Baolu 2022-05-10 14:35 ` Jason Gunthorpe via iommu 2022-05-10 14:35 ` Jason Gunthorpe 2022-05-10 6:17 ` [PATCH v6 06/12] iommu/vt-d: Add SVA domain support Lu Baolu 2022-05-10 6:17 ` Lu Baolu 2022-05-10 6:17 ` [PATCH v6 07/12] arm-smmu-v3/sva: " Lu Baolu 2022-05-10 6:17 ` Lu Baolu 2022-05-10 6:17 ` [PATCH v6 08/12] iommu/sva: Use attach/detach_pasid_dev in SVA interfaces Lu Baolu 2022-05-10 6:17 ` Lu Baolu 2022-05-10 15:23 ` Jason Gunthorpe via iommu 2022-05-10 15:23 ` Jason Gunthorpe 2022-05-11 7:21 ` Baolu Lu 2022-05-11 7:21 ` Baolu Lu 2022-05-11 14:53 ` Jason Gunthorpe 2022-05-11 14:53 ` Jason Gunthorpe via iommu 2022-05-12 3:02 ` Baolu Lu 2022-05-12 3:02 ` Baolu Lu 2022-05-12 5:01 ` Tian, Kevin 2022-05-12 5:01 ` Tian, Kevin 2022-05-12 5:17 ` Baolu Lu 2022-05-12 5:17 ` Baolu Lu 2022-05-12 5:44 ` Tian, Kevin 2022-05-12 5:44 ` Tian, Kevin 2022-05-12 6:16 ` Baolu Lu 2022-05-12 6:16 ` Baolu Lu 2022-05-12 11:48 ` Jason Gunthorpe 2022-05-12 11:48 ` Jason Gunthorpe via iommu 2022-05-12 11:59 ` Baolu Lu 2022-05-12 11:59 ` Baolu Lu 2022-05-12 12:03 ` Jason Gunthorpe 2022-05-12 12:03 ` Jason Gunthorpe via iommu 2022-05-12 12:47 ` Baolu Lu 2022-05-12 12:47 ` Baolu Lu 2022-05-12 11:51 ` Jason Gunthorpe 2022-05-12 11:51 ` Jason Gunthorpe via iommu 2022-05-12 12:39 ` Baolu Lu 2022-05-12 12:39 ` Baolu Lu 2022-05-10 6:17 ` [PATCH v6 09/12] iommu: Remove SVA related callbacks from iommu ops Lu Baolu 2022-05-10 6:17 ` Lu Baolu 2022-05-10 6:17 ` [PATCH v6 10/12] iommu: Prepare IOMMU domain for IOPF Lu Baolu 2022-05-10 6:17 ` Lu Baolu 2022-05-10 6:17 ` [PATCH v6 11/12] iommu: Per-domain I/O page fault handling Lu Baolu 2022-05-10 6:17 ` Lu Baolu 2022-05-10 6:17 ` [PATCH v6 12/12] iommu: Rename iommu-sva-lib.{c,h} Lu Baolu 2022-05-10 6:17 ` Lu Baolu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220510061738.2761430-1-baolu.lu@linux.intel.com \ --to=baolu.lu@linux.intel.com \ --cc=ashok.raj@intel.com \ --cc=dave.jiang@intel.com \ --cc=eric.auger@redhat.com \ --cc=hch@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@intel.com \ --cc=jean-philippe@linaro.com \ --cc=jgg@nvidia.com \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robin.murphy@arm.com \ --cc=vkoul@kernel.org \ --cc=will@kernel.org \ --cc=yi.l.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.