From: Tyrone Ting <warp5tw@gmail.com> To: avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski@canonical.com, wsa@kernel.org, andriy.shevchenko@linux.intel.com, jarkko.nikula@linux.intel.com, semen.protsenko@linaro.org, sven@svenpeter.dev, jie.deng@intel.com, jsd@semihalf.com, lukas.bulwahn@gmail.com, olof@lixom.net, arnd@arndb.de, warp5tw@gmail.com, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com Cc: openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 5/9] i2c: npcm: Add tx complete counter Date: Tue, 10 May 2022 17:16:50 +0800 [thread overview] Message-ID: <20220510091654.8498-6-warp5tw@gmail.com> (raw) In-Reply-To: <20220510091654.8498-1-warp5tw@gmail.com> From: Tali Perry <tali.perry1@gmail.com> tx_complete counter is used to indicate successful transaction count. Similar counters for failed tx were previously added. Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver") Signed-off-by: Tali Perry <tali.perry1@gmail.com> --- drivers/i2c/busses/i2c-npcm7xx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c index eaec051e080d..56af571f65c1 100644 --- a/drivers/i2c/busses/i2c-npcm7xx.c +++ b/drivers/i2c/busses/i2c-npcm7xx.c @@ -314,6 +314,7 @@ struct npcm_i2c { u64 rec_fail_cnt; u64 nack_cnt; u64 timeout_cnt; + u64 tx_complete_cnt; }; static inline void npcm_i2c_select_bank(struct npcm_i2c *bus, @@ -684,6 +685,8 @@ static void npcm_i2c_callback(struct npcm_i2c *bus, switch (op_status) { case I2C_MASTER_DONE_IND: bus->cmd_err = bus->msgs_num; + if (bus->tx_complete_cnt < ULLONG_MAX) + bus->tx_complete_cnt++; fallthrough; case I2C_BLOCK_BYTES_ERR_IND: /* Master tx finished and all transmit bytes were sent */ @@ -2223,6 +2226,7 @@ static void npcm_i2c_init_debugfs(struct platform_device *pdev, debugfs_create_u64("rec_succ_cnt", 0444, d, &bus->rec_succ_cnt); debugfs_create_u64("rec_fail_cnt", 0444, d, &bus->rec_fail_cnt); debugfs_create_u64("timeout_cnt", 0444, d, &bus->timeout_cnt); + debugfs_create_u64("tx_complete_cnt", 0444, d, &bus->tx_complete_cnt); bus->debugfs = d; } -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Tyrone Ting <warp5tw@gmail.com> To: avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski@canonical.com, wsa@kernel.org, andriy.shevchenko@linux.intel.com, jarkko.nikula@linux.intel.com, semen.protsenko@linaro.org, sven@svenpeter.dev, jie.deng@intel.com, jsd@semihalf.com, lukas.bulwahn@gmail.com, olof@lixom.net, arnd@arndb.de, warp5tw@gmail.com, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com Cc: devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 5/9] i2c: npcm: Add tx complete counter Date: Tue, 10 May 2022 17:16:50 +0800 [thread overview] Message-ID: <20220510091654.8498-6-warp5tw@gmail.com> (raw) In-Reply-To: <20220510091654.8498-1-warp5tw@gmail.com> From: Tali Perry <tali.perry1@gmail.com> tx_complete counter is used to indicate successful transaction count. Similar counters for failed tx were previously added. Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver") Signed-off-by: Tali Perry <tali.perry1@gmail.com> --- drivers/i2c/busses/i2c-npcm7xx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c index eaec051e080d..56af571f65c1 100644 --- a/drivers/i2c/busses/i2c-npcm7xx.c +++ b/drivers/i2c/busses/i2c-npcm7xx.c @@ -314,6 +314,7 @@ struct npcm_i2c { u64 rec_fail_cnt; u64 nack_cnt; u64 timeout_cnt; + u64 tx_complete_cnt; }; static inline void npcm_i2c_select_bank(struct npcm_i2c *bus, @@ -684,6 +685,8 @@ static void npcm_i2c_callback(struct npcm_i2c *bus, switch (op_status) { case I2C_MASTER_DONE_IND: bus->cmd_err = bus->msgs_num; + if (bus->tx_complete_cnt < ULLONG_MAX) + bus->tx_complete_cnt++; fallthrough; case I2C_BLOCK_BYTES_ERR_IND: /* Master tx finished and all transmit bytes were sent */ @@ -2223,6 +2226,7 @@ static void npcm_i2c_init_debugfs(struct platform_device *pdev, debugfs_create_u64("rec_succ_cnt", 0444, d, &bus->rec_succ_cnt); debugfs_create_u64("rec_fail_cnt", 0444, d, &bus->rec_fail_cnt); debugfs_create_u64("timeout_cnt", 0444, d, &bus->timeout_cnt); + debugfs_create_u64("tx_complete_cnt", 0444, d, &bus->tx_complete_cnt); bus->debugfs = d; } -- 2.17.1
next prev parent reply other threads:[~2022-05-10 9:18 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-10 9:16 [PATCH v4 0/9] i2c: npcm: Bug fixes timeout, spurious interrupts Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-10 9:16 ` [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-11 15:24 ` Rob Herring 2022-05-11 15:24 ` Rob Herring 2022-05-12 1:31 ` Tyrone Ting 2022-05-12 1:31 ` Tyrone Ting 2022-05-13 8:26 ` Krzysztof Kozlowski 2022-05-10 9:16 ` [PATCH v4 2/9] i2c: npcm: Change the way of getting GCR regmap Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-10 10:08 ` Andy Shevchenko 2022-05-10 10:08 ` Andy Shevchenko 2022-05-11 1:34 ` Tyrone Ting 2022-05-11 1:34 ` Tyrone Ting 2022-05-16 19:48 ` Wolfram Sang 2022-05-16 19:48 ` Wolfram Sang 2022-05-17 1:05 ` Tyrone Ting 2022-05-17 1:05 ` Tyrone Ting 2022-05-17 6:04 ` Wolfram Sang 2022-05-17 6:04 ` Wolfram Sang 2022-05-17 6:09 ` Tyrone Ting 2022-05-10 9:16 ` [PATCH v4 3/9] i2c: npcm: Remove unused variable clk_regmap Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-10 9:16 ` [PATCH v4 4/9] i2c: npcm: Fix timeout calculation Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting [this message] 2022-05-10 9:16 ` [PATCH v4 5/9] i2c: npcm: Add tx complete counter Tyrone Ting 2022-05-10 9:16 ` [PATCH v4 6/9] i2c: npcm: Correct register access width Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-10 9:16 ` [PATCH v4 7/9] i2c: npcm: Handle spurious interrupts Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-10 10:14 ` Andy Shevchenko 2022-05-10 10:14 ` Andy Shevchenko 2022-05-11 5:37 ` Tyrone Ting 2022-05-11 5:37 ` Tyrone Ting 2022-05-10 9:16 ` [PATCH v4 8/9] i2c: npcm: Remove own slave addresses 2:10 Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-10 10:19 ` Andy Shevchenko 2022-05-10 10:19 ` Andy Shevchenko 2022-05-11 1:39 ` Tyrone Ting 2022-05-11 1:39 ` Tyrone Ting 2022-05-16 1:23 ` Tyrone Ting 2022-05-16 1:23 ` Tyrone Ting 2022-05-10 9:16 ` [PATCH v4 9/9] i2c: npcm: Support NPCM845 Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220510091654.8498-6-warp5tw@gmail.com \ --to=warp5tw@gmail.com \ --cc=Avi.Fishman@nuvoton.com \ --cc=JJLIU0@nuvoton.com \ --cc=KWLIU@nuvoton.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=arnd@arndb.de \ --cc=avifishman70@gmail.com \ --cc=benjaminfair@google.com \ --cc=devicetree@vger.kernel.org \ --cc=jarkko.nikula@linux.intel.com \ --cc=jie.deng@intel.com \ --cc=jsd@semihalf.com \ --cc=kfting@nuvoton.com \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lukas.bulwahn@gmail.com \ --cc=olof@lixom.net \ --cc=openbmc@lists.ozlabs.org \ --cc=robh+dt@kernel.org \ --cc=semen.protsenko@linaro.org \ --cc=sven@svenpeter.dev \ --cc=tali.perry1@gmail.com \ --cc=tali.perry@nuvoton.com \ --cc=tmaimon77@gmail.com \ --cc=tomer.maimon@nuvoton.com \ --cc=venture@google.com \ --cc=wsa@kernel.org \ --cc=yuenn@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.