From: Tyrone Ting <warp5tw@gmail.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, wsa@kernel.org, jarkko.nikula@linux.intel.com, semen.protsenko@linaro.org, sven@svenpeter.dev, jsd@semihalf.com, lukas.bulwahn@gmail.com, olof@lixom.net, arnd@arndb.de, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com, openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 8/9] i2c: npcm: Remove own slave addresses 2:10 Date: Mon, 16 May 2022 09:23:25 +0800 [thread overview] Message-ID: <CACD3sJZxzs28Ruxifw1vjgKmOr0Z3WgC6SpciwjyvkRMZh8ykw@mail.gmail.com> (raw) In-Reply-To: <CACD3sJYVyV_fFJu9zXJGL1ro02KnkHoeNNSNB8O46FRwd6=-BA@mail.gmail.com> Hi Andy: I would like to have your comments about the "Fancy indentation" because I'm not sure if I get the point. I remove extra empty lines and reformat the commit message. Please see the details below. Thank you. Tyrone Ting <warp5tw@gmail.com> 於 2022年5月11日 週三 上午9:39寫道: > > Hi Andy: > > Thank you for your comments and they will be addressed. > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> 於 2022年5月10日 週二 下午6:19寫道: > > > > On Tue, May 10, 2022 at 05:16:53PM +0800, Tyrone Ting wrote: > > > From: Tali Perry <tali.perry1@gmail.com> > > > > > > NPCM can support up to 10 own slave addresses. > > > In practice, only one address is actually being used. > > > In order to access addresses 2 and above, need to switch > > > register banks. The switch needs spinlock. > > > To avoid using spinlock for this useless feature > > > removed support of SA >= 2. > > > > > Also fix returned slave event enum. > > > > > > Remove some comment since the bank selection is not > > > required. The bank selection is not required since > > > the supported slave addresses are reduced. > > > > Fancy indentation. Please fix it in all your commit messages where it applies. > > I modify the commit message as following: NPCM can support up to 10 own slave addresses. In practice, only one address is actually being used. In order to access addresses 2 and above, need to switch register banks. The switch needs spinlock. To avoid using spinlock for this useless feature removed support of SA >= 2. Also fix returned slave event enum. Remove some comment since the bank selection is not required. The bank selection is not required since the supported slave addresses are reduced. > > ... > > > > > + if (addr_type > I2C_SLAVE_ADDR2 && addr_type <= I2C_SLAVE_ADDR10) { > > > + dev_err(bus->dev, > > > + "try to enable more then 2 SA not supported\n"); > > > > Make it one line and drop {}. > > > > > + } > > > > ... > > > > > + if (addr_type > I2C_SLAVE_ADDR2 && addr_type <= I2C_SLAVE_ADDR10) { > > > + dev_err(bus->dev, > > > + "get slave: try to use more then 2 slave addresses not supported\n"); > > > > As per above be consistent with abbreviations ("SA" here, which makes line > > shorter) and follow the above recommendation. > > > > > + } > > > > -- > > With Best Regards, > > Andy Shevchenko > > > > > > Best Regards, > Tyrone Best Regards, Tyrone
WARNING: multiple messages have this Message-ID (diff)
From: Tyrone Ting <warp5tw@gmail.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: tmaimon77@gmail.com, devicetree@vger.kernel.org, tali.perry1@gmail.com, jsd@semihalf.com, krzysztof.kozlowski+dt@linaro.org, benjaminfair@google.com, openbmc@lists.ozlabs.org, JJLIU0@nuvoton.com, lukas.bulwahn@gmail.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, arnd@arndb.de, sven@svenpeter.dev, robh+dt@kernel.org, Avi.Fishman@nuvoton.com, semen.protsenko@linaro.org, avifishman70@gmail.com, venture@google.com, linux-kernel@vger.kernel.org, wsa@kernel.org, kfting@nuvoton.com, tali.perry@nuvoton.com, jarkko.nikula@linux.intel.com, olof@lixom.net, linux-i2c@vger.kernel.org Subject: Re: [PATCH v4 8/9] i2c: npcm: Remove own slave addresses 2:10 Date: Mon, 16 May 2022 09:23:25 +0800 [thread overview] Message-ID: <CACD3sJZxzs28Ruxifw1vjgKmOr0Z3WgC6SpciwjyvkRMZh8ykw@mail.gmail.com> (raw) In-Reply-To: <CACD3sJYVyV_fFJu9zXJGL1ro02KnkHoeNNSNB8O46FRwd6=-BA@mail.gmail.com> Hi Andy: I would like to have your comments about the "Fancy indentation" because I'm not sure if I get the point. I remove extra empty lines and reformat the commit message. Please see the details below. Thank you. Tyrone Ting <warp5tw@gmail.com> 於 2022年5月11日 週三 上午9:39寫道: > > Hi Andy: > > Thank you for your comments and they will be addressed. > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> 於 2022年5月10日 週二 下午6:19寫道: > > > > On Tue, May 10, 2022 at 05:16:53PM +0800, Tyrone Ting wrote: > > > From: Tali Perry <tali.perry1@gmail.com> > > > > > > NPCM can support up to 10 own slave addresses. > > > In practice, only one address is actually being used. > > > In order to access addresses 2 and above, need to switch > > > register banks. The switch needs spinlock. > > > To avoid using spinlock for this useless feature > > > removed support of SA >= 2. > > > > > Also fix returned slave event enum. > > > > > > Remove some comment since the bank selection is not > > > required. The bank selection is not required since > > > the supported slave addresses are reduced. > > > > Fancy indentation. Please fix it in all your commit messages where it applies. > > I modify the commit message as following: NPCM can support up to 10 own slave addresses. In practice, only one address is actually being used. In order to access addresses 2 and above, need to switch register banks. The switch needs spinlock. To avoid using spinlock for this useless feature removed support of SA >= 2. Also fix returned slave event enum. Remove some comment since the bank selection is not required. The bank selection is not required since the supported slave addresses are reduced. > > ... > > > > > + if (addr_type > I2C_SLAVE_ADDR2 && addr_type <= I2C_SLAVE_ADDR10) { > > > + dev_err(bus->dev, > > > + "try to enable more then 2 SA not supported\n"); > > > > Make it one line and drop {}. > > > > > + } > > > > ... > > > > > + if (addr_type > I2C_SLAVE_ADDR2 && addr_type <= I2C_SLAVE_ADDR10) { > > > + dev_err(bus->dev, > > > + "get slave: try to use more then 2 slave addresses not supported\n"); > > > > As per above be consistent with abbreviations ("SA" here, which makes line > > shorter) and follow the above recommendation. > > > > > + } > > > > -- > > With Best Regards, > > Andy Shevchenko > > > > > > Best Regards, > Tyrone Best Regards, Tyrone
next prev parent reply other threads:[~2022-05-16 1:23 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-10 9:16 [PATCH v4 0/9] i2c: npcm: Bug fixes timeout, spurious interrupts Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-10 9:16 ` [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-11 15:24 ` Rob Herring 2022-05-11 15:24 ` Rob Herring 2022-05-12 1:31 ` Tyrone Ting 2022-05-12 1:31 ` Tyrone Ting 2022-05-13 8:26 ` Krzysztof Kozlowski 2022-05-10 9:16 ` [PATCH v4 2/9] i2c: npcm: Change the way of getting GCR regmap Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-10 10:08 ` Andy Shevchenko 2022-05-10 10:08 ` Andy Shevchenko 2022-05-11 1:34 ` Tyrone Ting 2022-05-11 1:34 ` Tyrone Ting 2022-05-16 19:48 ` Wolfram Sang 2022-05-16 19:48 ` Wolfram Sang 2022-05-17 1:05 ` Tyrone Ting 2022-05-17 1:05 ` Tyrone Ting 2022-05-17 6:04 ` Wolfram Sang 2022-05-17 6:04 ` Wolfram Sang 2022-05-17 6:09 ` Tyrone Ting 2022-05-10 9:16 ` [PATCH v4 3/9] i2c: npcm: Remove unused variable clk_regmap Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-10 9:16 ` [PATCH v4 4/9] i2c: npcm: Fix timeout calculation Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-10 9:16 ` [PATCH v4 5/9] i2c: npcm: Add tx complete counter Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-10 9:16 ` [PATCH v4 6/9] i2c: npcm: Correct register access width Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-10 9:16 ` [PATCH v4 7/9] i2c: npcm: Handle spurious interrupts Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-10 10:14 ` Andy Shevchenko 2022-05-10 10:14 ` Andy Shevchenko 2022-05-11 5:37 ` Tyrone Ting 2022-05-11 5:37 ` Tyrone Ting 2022-05-10 9:16 ` [PATCH v4 8/9] i2c: npcm: Remove own slave addresses 2:10 Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting 2022-05-10 10:19 ` Andy Shevchenko 2022-05-10 10:19 ` Andy Shevchenko 2022-05-11 1:39 ` Tyrone Ting 2022-05-11 1:39 ` Tyrone Ting 2022-05-16 1:23 ` Tyrone Ting [this message] 2022-05-16 1:23 ` Tyrone Ting 2022-05-10 9:16 ` [PATCH v4 9/9] i2c: npcm: Support NPCM845 Tyrone Ting 2022-05-10 9:16 ` Tyrone Ting
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACD3sJZxzs28Ruxifw1vjgKmOr0Z3WgC6SpciwjyvkRMZh8ykw@mail.gmail.com \ --to=warp5tw@gmail.com \ --cc=Avi.Fishman@nuvoton.com \ --cc=JJLIU0@nuvoton.com \ --cc=KWLIU@nuvoton.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=arnd@arndb.de \ --cc=avifishman70@gmail.com \ --cc=benjaminfair@google.com \ --cc=devicetree@vger.kernel.org \ --cc=jarkko.nikula@linux.intel.com \ --cc=jsd@semihalf.com \ --cc=kfting@nuvoton.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lukas.bulwahn@gmail.com \ --cc=olof@lixom.net \ --cc=openbmc@lists.ozlabs.org \ --cc=robh+dt@kernel.org \ --cc=semen.protsenko@linaro.org \ --cc=sven@svenpeter.dev \ --cc=tali.perry1@gmail.com \ --cc=tali.perry@nuvoton.com \ --cc=tmaimon77@gmail.com \ --cc=tomer.maimon@nuvoton.com \ --cc=venture@google.com \ --cc=wsa@kernel.org \ --cc=yuenn@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.