Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "Rob Clark" <robdclark@chromium.org>,
	"Kalyan Thota" <quic_kalyant@quicinc.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Michel Dänzer" <michel@daenzer.net>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"DRI Development" <dri-devel@lists.freedesktop.org>,
	"Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>,
	"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
	"Daniel Vetter" <daniel.vetter@intel.com>,
	"Jessica Zhang" <quic_jesszhan@quicinc.com>,
	"Mikita Lipski" <mikita.lipski@amd.com>,
	"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks
Date: Thu, 12 May 2022 10:08:35 +0200	[thread overview]
Message-ID: <20220512080835.oy6cvqycgsfsjcly@houat> (raw)
In-Reply-To: <YmqEBB1m6W3XMwsR@phenom.ffwll.local>

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

Hi Daniel,

An update on this

On Thu, Apr 28, 2022 at 02:09:40PM +0200, Daniel Vetter wrote:
> > We integrated this in the (downstream) RaspberryPi kernel, and it seems
> > to trigger some weird regressions:
> > 
> >   - If we move the cursor under X, the primary plane update is stuck:
> >     https://github.com/raspberrypi/linux/issues/4988

So it turns out the upstream driver doesn't seem affected by this, but
only a downstream alternative.

> >   - Switching back and forth between VT gets the kernel stuck (with a
> >     locking issue in fb_release?)
> >     https://github.com/raspberrypi/linux/issues/5011

And this one turned out to be a separate issue fixed by Javier already.

So as far as I'm concerned, this patch seems to be working fine on vc4

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]