* [PATCH v4 0/4] Fix dtbs_check warning(s) for Qualcomm QMP PHY
@ 2022-05-16 6:31 ` Bhupesh Sharma
0 siblings, 0 replies; 12+ messages in thread
From: Bhupesh Sharma @ 2022-05-16 6:31 UTC (permalink / raw)
To: linux-arm-msm
Cc: bhupesh.sharma, bhupesh.linux, linux-kernel, bjorn.andersson,
robh, linux-phy, vkoul, konrad.dybcio
Changes since v3:
-----------------
- v3 can be found here: https://lore.kernel.org/linux-arm-msm/20220418205509.1102109-1-bhupesh.sharma@linaro.org/
- Addressed review comments from Bjorn.
- Dropped [PATCH 4/4] (sent in v3) from v4, as it is accepted in
linux-next now.
- Added a new [PATCH 3/4] which added 'power-domains' property
to the dt-binding.
Changes since v2:
-----------------
- v2 can be found here: https://lore.kernel.org/linux-arm-msm/20220228123019.382037-1-bhupesh.sharma@linaro.org/
- Addressed review comments from Rob and Shawn.
- Collected ACK from Rob on [PATCH 2/4].
- Since, Bjorn accepted 4 patches from v2 already, drop them for this series.
- This series is rebased on linux-next/master.
Changes since v1:
-----------------
- v1 can be found here: https://www.spinics.net/lists/linux-arm-msm/msg104871.html
- Addressed review comments from Dmitry.
- Addressed the remaining dtbs_check warnings rasied by Rob's bot on v1.
Shawn Guo recently fixed a large number of 'dtbs_check' warnings
on Qualcomm DTS files for qmp phys. However a few warnings are still left
(possibly due to new dts files being added over time).
So, I decided to clean them up.
After this series, '$ make dtbs_check' leads to only one warning for QCOM
QMP PHY bindings, which as discussed with Konrad (see [1]), will be sent as
a separate fix with Konrad's sm8350-sony-xperia-sagami regulator fixes.
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Herring <robh@kernel.org>
[1]. https://lore.kernel.org/linux-arm-msm/eb54c810-8121-7de1-e2cf-008bd59552ce@somainline.org/
Bhupesh Sharma (4):
dt-bindings: phy: qcom,qmp: Shift '#clock-cells' property to phy
(child) node
dt-bindings: phy: qcom,qmp: Describe phy@ subnode properly
dt-bindings: phy: qcom,qmp: Add 'power-domains' property
arm64: dts: qcom: Remove unused 'vdda-max-microamp' &
'vdda-pll-max-microamp' properties
.../devicetree/bindings/phy/qcom,qmp-phy.yaml | 24 +++++++++++++++----
.../qcom/sm8350-microsoft-surface-duo2.dts | 2 --
arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 2 --
arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 2 --
4 files changed, 19 insertions(+), 11 deletions(-)
--
2.35.3
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 0/4] Fix dtbs_check warning(s) for Qualcomm QMP PHY
@ 2022-05-16 6:31 ` Bhupesh Sharma
0 siblings, 0 replies; 12+ messages in thread
From: Bhupesh Sharma @ 2022-05-16 6:31 UTC (permalink / raw)
To: linux-arm-msm
Cc: bhupesh.sharma, bhupesh.linux, linux-kernel, bjorn.andersson,
robh, linux-phy, vkoul, konrad.dybcio
Changes since v3:
-----------------
- v3 can be found here: https://lore.kernel.org/linux-arm-msm/20220418205509.1102109-1-bhupesh.sharma@linaro.org/
- Addressed review comments from Bjorn.
- Dropped [PATCH 4/4] (sent in v3) from v4, as it is accepted in
linux-next now.
- Added a new [PATCH 3/4] which added 'power-domains' property
to the dt-binding.
Changes since v2:
-----------------
- v2 can be found here: https://lore.kernel.org/linux-arm-msm/20220228123019.382037-1-bhupesh.sharma@linaro.org/
- Addressed review comments from Rob and Shawn.
- Collected ACK from Rob on [PATCH 2/4].
- Since, Bjorn accepted 4 patches from v2 already, drop them for this series.
- This series is rebased on linux-next/master.
Changes since v1:
-----------------
- v1 can be found here: https://www.spinics.net/lists/linux-arm-msm/msg104871.html
- Addressed review comments from Dmitry.
- Addressed the remaining dtbs_check warnings rasied by Rob's bot on v1.
Shawn Guo recently fixed a large number of 'dtbs_check' warnings
on Qualcomm DTS files for qmp phys. However a few warnings are still left
(possibly due to new dts files being added over time).
So, I decided to clean them up.
After this series, '$ make dtbs_check' leads to only one warning for QCOM
QMP PHY bindings, which as discussed with Konrad (see [1]), will be sent as
a separate fix with Konrad's sm8350-sony-xperia-sagami regulator fixes.
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Herring <robh@kernel.org>
[1]. https://lore.kernel.org/linux-arm-msm/eb54c810-8121-7de1-e2cf-008bd59552ce@somainline.org/
Bhupesh Sharma (4):
dt-bindings: phy: qcom,qmp: Shift '#clock-cells' property to phy
(child) node
dt-bindings: phy: qcom,qmp: Describe phy@ subnode properly
dt-bindings: phy: qcom,qmp: Add 'power-domains' property
arm64: dts: qcom: Remove unused 'vdda-max-microamp' &
'vdda-pll-max-microamp' properties
.../devicetree/bindings/phy/qcom,qmp-phy.yaml | 24 +++++++++++++++----
.../qcom/sm8350-microsoft-surface-duo2.dts | 2 --
arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 2 --
arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 2 --
4 files changed, 19 insertions(+), 11 deletions(-)
--
2.35.3
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 1/4] dt-bindings: phy: qcom,qmp: Shift '#clock-cells' property to phy (child) node
2022-05-16 6:31 ` Bhupesh Sharma
@ 2022-05-16 6:31 ` Bhupesh Sharma
-1 siblings, 0 replies; 12+ messages in thread
From: Bhupesh Sharma @ 2022-05-16 6:31 UTC (permalink / raw)
To: linux-arm-msm
Cc: bhupesh.sharma, bhupesh.linux, linux-kernel, bjorn.andersson,
robh, linux-phy, vkoul, konrad.dybcio, Rob Herring
Since the clock comes out of the phy (child) node,
so clocks are actually not provided by the parent device.
The qmp-phy dt-bindings specify the same incorrectly at
present. Fix the same.
This change helps fix the following 'make dtbs_check' warning(s):
sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000:
'#clock-cells' is a required property
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
index 8b850c5ab116..c39ead81ecd7 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
@@ -66,9 +66,6 @@ properties:
- description: Address and length of PHY's common serdes block.
- description: Address and length of PHY's DP_COM control block.
- "#clock-cells":
- enum: [ 1, 2 ]
-
"#address-cells":
enum: [ 1, 2 ]
@@ -112,11 +109,13 @@ patternProperties:
description:
Each device node of QMP phy is required to have as many child nodes as
the number of lanes the PHY has.
+ properties:
+ "#clock-cells":
+ enum: [ 0, 1, 2 ]
required:
- compatible
- reg
- - "#clock-cells"
- "#address-cells"
- "#size-cells"
- ranges
@@ -468,7 +467,6 @@ examples:
usb_2_qmpphy: phy-wrapper@88eb000 {
compatible = "qcom,sdm845-qmp-usb3-uni-phy";
reg = <0x088eb000 0x18c>;
- #clock-cells = <1>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x0 0x088eb000 0x2000>;
--
2.35.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 1/4] dt-bindings: phy: qcom, qmp: Shift '#clock-cells' property to phy (child) node
@ 2022-05-16 6:31 ` Bhupesh Sharma
0 siblings, 0 replies; 12+ messages in thread
From: Bhupesh Sharma @ 2022-05-16 6:31 UTC (permalink / raw)
To: linux-arm-msm
Cc: bhupesh.sharma, bhupesh.linux, linux-kernel, bjorn.andersson,
robh, linux-phy, vkoul, konrad.dybcio, Rob Herring
Since the clock comes out of the phy (child) node,
so clocks are actually not provided by the parent device.
The qmp-phy dt-bindings specify the same incorrectly at
present. Fix the same.
This change helps fix the following 'make dtbs_check' warning(s):
sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000:
'#clock-cells' is a required property
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
index 8b850c5ab116..c39ead81ecd7 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
@@ -66,9 +66,6 @@ properties:
- description: Address and length of PHY's common serdes block.
- description: Address and length of PHY's DP_COM control block.
- "#clock-cells":
- enum: [ 1, 2 ]
-
"#address-cells":
enum: [ 1, 2 ]
@@ -112,11 +109,13 @@ patternProperties:
description:
Each device node of QMP phy is required to have as many child nodes as
the number of lanes the PHY has.
+ properties:
+ "#clock-cells":
+ enum: [ 0, 1, 2 ]
required:
- compatible
- reg
- - "#clock-cells"
- "#address-cells"
- "#size-cells"
- ranges
@@ -468,7 +467,6 @@ examples:
usb_2_qmpphy: phy-wrapper@88eb000 {
compatible = "qcom,sdm845-qmp-usb3-uni-phy";
reg = <0x088eb000 0x18c>;
- #clock-cells = <1>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x0 0x088eb000 0x2000>;
--
2.35.3
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 2/4] dt-bindings: phy: qcom,qmp: Describe phy@ subnode properly
2022-05-16 6:31 ` Bhupesh Sharma
@ 2022-05-16 6:31 ` Bhupesh Sharma
-1 siblings, 0 replies; 12+ messages in thread
From: Bhupesh Sharma @ 2022-05-16 6:31 UTC (permalink / raw)
To: linux-arm-msm
Cc: bhupesh.sharma, bhupesh.linux, linux-kernel, bjorn.andersson,
robh, linux-phy, vkoul, konrad.dybcio
Currently the qcom,qmp-phy dt-binding doesn't describe
the 'reg' and '#phy-cells' properties for the phy@ subnode.
Fix the same.
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
.../devicetree/bindings/phy/qcom,qmp-phy.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
index c39ead81ecd7..60ab494df975 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
@@ -110,6 +110,18 @@ patternProperties:
Each device node of QMP phy is required to have as many child nodes as
the number of lanes the PHY has.
properties:
+ reg:
+ minItems: 1
+ maxItems: 6
+ description: |
+ List of offset and length pairs of register sets for PHY blocks.
+ There are two possible cases::
+ - tx, rx, pcs and pcs_misc.
+ - tx, rx, pcs, tx2, rx2 and pcs_misc.
+
+ "#phy-cells":
+ const: 0
+
"#clock-cells":
enum: [ 0, 1, 2 ]
--
2.35.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 2/4] dt-bindings: phy: qcom, qmp: Describe phy@ subnode properly
@ 2022-05-16 6:31 ` Bhupesh Sharma
0 siblings, 0 replies; 12+ messages in thread
From: Bhupesh Sharma @ 2022-05-16 6:31 UTC (permalink / raw)
To: linux-arm-msm
Cc: bhupesh.sharma, bhupesh.linux, linux-kernel, bjorn.andersson,
robh, linux-phy, vkoul, konrad.dybcio
Currently the qcom,qmp-phy dt-binding doesn't describe
the 'reg' and '#phy-cells' properties for the phy@ subnode.
Fix the same.
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
.../devicetree/bindings/phy/qcom,qmp-phy.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
index c39ead81ecd7..60ab494df975 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
@@ -110,6 +110,18 @@ patternProperties:
Each device node of QMP phy is required to have as many child nodes as
the number of lanes the PHY has.
properties:
+ reg:
+ minItems: 1
+ maxItems: 6
+ description: |
+ List of offset and length pairs of register sets for PHY blocks.
+ There are two possible cases::
+ - tx, rx, pcs and pcs_misc.
+ - tx, rx, pcs, tx2, rx2 and pcs_misc.
+
+ "#phy-cells":
+ const: 0
+
"#clock-cells":
enum: [ 0, 1, 2 ]
--
2.35.3
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 3/4] dt-bindings: phy: qcom,qmp: Add 'power-domains' property
2022-05-16 6:31 ` Bhupesh Sharma
@ 2022-05-16 6:31 ` Bhupesh Sharma
-1 siblings, 0 replies; 12+ messages in thread
From: Bhupesh Sharma @ 2022-05-16 6:31 UTC (permalink / raw)
To: linux-arm-msm
Cc: bhupesh.sharma, bhupesh.linux, linux-kernel, bjorn.andersson,
robh, linux-phy, vkoul, konrad.dybcio
Fix the following 'make dtbs_check' error with the 'qcom,qmp-phy'
bindings:
arch/arm64/boot/dts/qcom/sm8150-mtp.dtb: phy@1d87000:
'power-domains' does not match any of the regexes:
'^phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
index 60ab494df975..c5d4c8152699 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
@@ -102,6 +102,10 @@ properties:
description:
Phandle to a regulator supply to any specific refclk pll block.
+ power-domains:
+ description: Phandle to the power domain node.
+ maxItems: 1
+
#Required nodes:
patternProperties:
"^phy@[0-9a-f]+$":
--
2.35.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 3/4] dt-bindings: phy: qcom, qmp: Add 'power-domains' property
@ 2022-05-16 6:31 ` Bhupesh Sharma
0 siblings, 0 replies; 12+ messages in thread
From: Bhupesh Sharma @ 2022-05-16 6:31 UTC (permalink / raw)
To: linux-arm-msm
Cc: bhupesh.sharma, bhupesh.linux, linux-kernel, bjorn.andersson,
robh, linux-phy, vkoul, konrad.dybcio
Fix the following 'make dtbs_check' error with the 'qcom,qmp-phy'
bindings:
arch/arm64/boot/dts/qcom/sm8150-mtp.dtb: phy@1d87000:
'power-domains' does not match any of the regexes:
'^phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
index 60ab494df975..c5d4c8152699 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
@@ -102,6 +102,10 @@ properties:
description:
Phandle to a regulator supply to any specific refclk pll block.
+ power-domains:
+ description: Phandle to the power domain node.
+ maxItems: 1
+
#Required nodes:
patternProperties:
"^phy@[0-9a-f]+$":
--
2.35.3
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 4/4] arm64: dts: qcom: Remove unused 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties
2022-05-16 6:31 ` Bhupesh Sharma
@ 2022-05-16 6:31 ` Bhupesh Sharma
-1 siblings, 0 replies; 12+ messages in thread
From: Bhupesh Sharma @ 2022-05-16 6:31 UTC (permalink / raw)
To: linux-arm-msm
Cc: bhupesh.sharma, bhupesh.linux, linux-kernel, bjorn.andersson,
robh, linux-phy, vkoul, konrad.dybcio
As Bjorn noted in [1], since the qmp phy driver doesn't
use the 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties
currently, let's remove them from the dts files as well.
Otherwise, it leads to the following '$ make dtbs_check'
warning(s):
sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000:
'vdda-max-microamp', 'vdda-pll-max-microamp' do not match any of
the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+
If later on the driver support is added, we can add these properties
back to the dts files.
[1]. https://lore.kernel.org/linux-arm-msm/YmQhpsmiYJzR99LK@ripper/
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts | 2 --
arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 2 --
arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 2 --
3 files changed, 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts b/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
index 9a6faa9393dc..9c4cfd995ff2 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
@@ -336,9 +336,7 @@ &ufs_mem_phy {
status = "okay";
vdda-phy-supply = <&vreg_l5b_0p88>;
- vdda-max-microamp = <91600>;
vdda-pll-supply = <&vreg_l6b_1p2>;
- vdda-pll-max-microamp = <19000>;
};
&usb_1 {
diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
index 4e51a9d6af98..38ccd44620d0 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
@@ -418,8 +418,6 @@ &ufs_mem_phy {
vdda-phy-supply = <&vreg_l5b_0p88>;
vdda-pll-supply = <&vreg_l6b_1p2>;
- vdda-max-microamp = <173000>;
- vdda-pll-max-microamp = <24900>;
};
&usb_1 {
diff --git a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
index 236e53974fdd..e58fc7399799 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
@@ -424,8 +424,6 @@ &ufs_mem_phy {
vdda-phy-supply = <&vreg_l5b_0p88>;
vdda-pll-supply = <&vreg_l6b_1p2>;
- vdda-max-microamp = <173000>;
- vdda-pll-max-microamp = <24900>;
};
&usb_1 {
--
2.35.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 4/4] arm64: dts: qcom: Remove unused 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties
@ 2022-05-16 6:31 ` Bhupesh Sharma
0 siblings, 0 replies; 12+ messages in thread
From: Bhupesh Sharma @ 2022-05-16 6:31 UTC (permalink / raw)
To: linux-arm-msm
Cc: bhupesh.sharma, bhupesh.linux, linux-kernel, bjorn.andersson,
robh, linux-phy, vkoul, konrad.dybcio
As Bjorn noted in [1], since the qmp phy driver doesn't
use the 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties
currently, let's remove them from the dts files as well.
Otherwise, it leads to the following '$ make dtbs_check'
warning(s):
sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000:
'vdda-max-microamp', 'vdda-pll-max-microamp' do not match any of
the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+
If later on the driver support is added, we can add these properties
back to the dts files.
[1]. https://lore.kernel.org/linux-arm-msm/YmQhpsmiYJzR99LK@ripper/
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts | 2 --
arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 2 --
arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 2 --
3 files changed, 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts b/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
index 9a6faa9393dc..9c4cfd995ff2 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
@@ -336,9 +336,7 @@ &ufs_mem_phy {
status = "okay";
vdda-phy-supply = <&vreg_l5b_0p88>;
- vdda-max-microamp = <91600>;
vdda-pll-supply = <&vreg_l6b_1p2>;
- vdda-pll-max-microamp = <19000>;
};
&usb_1 {
diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
index 4e51a9d6af98..38ccd44620d0 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
@@ -418,8 +418,6 @@ &ufs_mem_phy {
vdda-phy-supply = <&vreg_l5b_0p88>;
vdda-pll-supply = <&vreg_l6b_1p2>;
- vdda-max-microamp = <173000>;
- vdda-pll-max-microamp = <24900>;
};
&usb_1 {
diff --git a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
index 236e53974fdd..e58fc7399799 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
@@ -424,8 +424,6 @@ &ufs_mem_phy {
vdda-phy-supply = <&vreg_l5b_0p88>;
vdda-pll-supply = <&vreg_l6b_1p2>;
- vdda-max-microamp = <173000>;
- vdda-pll-max-microamp = <24900>;
};
&usb_1 {
--
2.35.3
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: (subset) [PATCH v4 4/4] arm64: dts: qcom: Remove unused 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties
2022-05-16 6:31 ` Bhupesh Sharma
@ 2022-07-03 3:55 ` Bjorn Andersson
-1 siblings, 0 replies; 12+ messages in thread
From: Bjorn Andersson @ 2022-07-03 3:55 UTC (permalink / raw)
To: linux-arm-msm, Bhupesh Sharma
Cc: linux-kernel, vkoul, bhupesh.linux, robh, linux-phy, konrad.dybcio
On Mon, 16 May 2022 12:01:55 +0530, Bhupesh Sharma wrote:
> As Bjorn noted in [1], since the qmp phy driver doesn't
> use the 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties
> currently, let's remove them from the dts files as well.
>
> Otherwise, it leads to the following '$ make dtbs_check'
> warning(s):
>
> [...]
Applied, thanks!
[4/4] arm64: dts: qcom: Remove unused 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties
commit: ddc35664a38e31034c3519de71c2dea52005bc2a
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: (subset) [PATCH v4 4/4] arm64: dts: qcom: Remove unused 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties
@ 2022-07-03 3:55 ` Bjorn Andersson
0 siblings, 0 replies; 12+ messages in thread
From: Bjorn Andersson @ 2022-07-03 3:55 UTC (permalink / raw)
To: linux-arm-msm, Bhupesh Sharma
Cc: linux-kernel, vkoul, bhupesh.linux, robh, linux-phy, konrad.dybcio
On Mon, 16 May 2022 12:01:55 +0530, Bhupesh Sharma wrote:
> As Bjorn noted in [1], since the qmp phy driver doesn't
> use the 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties
> currently, let's remove them from the dts files as well.
>
> Otherwise, it leads to the following '$ make dtbs_check'
> warning(s):
>
> [...]
Applied, thanks!
[4/4] arm64: dts: qcom: Remove unused 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties
commit: ddc35664a38e31034c3519de71c2dea52005bc2a
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-07-03 3:57 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 6:31 [PATCH v4 0/4] Fix dtbs_check warning(s) for Qualcomm QMP PHY Bhupesh Sharma
2022-05-16 6:31 ` Bhupesh Sharma
2022-05-16 6:31 ` [PATCH v4 1/4] dt-bindings: phy: qcom,qmp: Shift '#clock-cells' property to phy (child) node Bhupesh Sharma
2022-05-16 6:31 ` [PATCH v4 1/4] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma
2022-05-16 6:31 ` [PATCH v4 2/4] dt-bindings: phy: qcom,qmp: Describe phy@ subnode properly Bhupesh Sharma
2022-05-16 6:31 ` [PATCH v4 2/4] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma
2022-05-16 6:31 ` [PATCH v4 3/4] dt-bindings: phy: qcom,qmp: Add 'power-domains' property Bhupesh Sharma
2022-05-16 6:31 ` [PATCH v4 3/4] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma
2022-05-16 6:31 ` [PATCH v4 4/4] arm64: dts: qcom: Remove unused 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties Bhupesh Sharma
2022-05-16 6:31 ` Bhupesh Sharma
2022-07-03 3:55 ` (subset) " Bjorn Andersson
2022-07-03 3:55 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.