All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Kiper <dkiper@net-space.pl>
To: Glenn Washburn <development@efficientek.com>
Cc: grub-devel@gnu.org
Subject: Re: [PATCH] net: Fix incorrect condition for calling grub_net_tcp_retransmit()
Date: Tue, 17 May 2022 16:51:04 +0200	[thread overview]
Message-ID: <20220517145104.4l2g6r5wcm63xkrv@tomti.i.net-space.pl> (raw)
In-Reply-To: <20220512024401.3206077-1-development@efficientek.com>

On Wed, May 11, 2022 at 09:44:01PM -0500, Glenn Washburn wrote:
> The commit 848724273e4 (net/net: Avoid unnecessary calls to
> grub_net_tcp_retransmit()) needs to have its condition inverted to avoid
> unnecessary calls to grub_net_tcp_retransmit(). As it is, it creates many
> unnecessary calls and does not call grub_net_tcp_retransmit() when needed.
> The call to grub_net_tcp_retransmit() should only be made when
> grub_net_cards does _not_ equal NULL, meaning that there are potentially
> network cards that need tcp retransmission.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel


      reply	other threads:[~2022-05-17 14:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-12  2:44 [PATCH] net: Fix incorrect condition for calling grub_net_tcp_retransmit() Glenn Washburn
2022-05-17 14:51 ` Daniel Kiper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220517145104.4l2g6r5wcm63xkrv@tomti.i.net-space.pl \
    --to=dkiper@net-space.pl \
    --cc=development@efficientek.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.