[PATCH] net: Fix incorrect condition for calling grub_net_tcp_retransmit()

[PATCH] net: Fix incorrect condition for calling grub_net_tcp_retransmit()

[Glenn Washburn]

The commit 848724273e4 (net/net: Avoid unnecessary calls to
grub_net_tcp_retransmit()) needs to have its condition inverted to avoid
unnecessary calls to grub_net_tcp_retransmit(). As it is, it creates many
unnecessary calls and does not call grub_net_tcp_retransmit() when needed.
The call to grub_net_tcp_retransmit() should only be made when
grub_net_cards does _not_ equal NULL, meaning that there are potentially
network cards that need tcp retransmission.

Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 grub-core/net/net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/grub-core/net/net.c b/grub-core/net/net.c
index 88ea49fee..2b6771523 100644
--- a/grub-core/net/net.c
+++ b/grub-core/net/net.c
@@ -1634,7 +1634,7 @@ grub_net_poll_cards_idle_real (void)
 	|| ctime >= card->last_poll + card->idle_poll_delay_ms)
       receive_packets (card, 0);
   }
-  if (grub_net_cards == NULL)
+  if (grub_net_cards != NULL)
     grub_net_tcp_retransmit ();
 }
 
-- 
2.34.1

Re: [PATCH] net: Fix incorrect condition for calling grub_net_tcp_retransmit()

[Daniel Kiper]

On Wed, May 11, 2022 at 09:44:01PM -0500, Glenn Washburn wrote:
> The commit 848724273e4 (net/net: Avoid unnecessary calls to
> grub_net_tcp_retransmit()) needs to have its condition inverted to avoid
> unnecessary calls to grub_net_tcp_retransmit(). As it is, it creates many
> unnecessary calls and does not call grub_net_tcp_retransmit() when needed.
> The call to grub_net_tcp_retransmit() should only be made when
> grub_net_cards does _not_ equal NULL, meaning that there are potentially
> network cards that need tcp retransmission.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel