* [PATCH 0/6] dt-bindings: arm: MediaTek: Fix clock bindings
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for
which I've used the already upstreamed ones as a base, it was found that
these bindings have some issues.
This series is addressing the issues that were found by Rob on my series,
which are present on all of the already merged bindings.
[1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953
AngeloGioacchino Del Regno (6):
dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix
formatting
dt-bindings: arm: mt8186: Set #clock-cells as required property
dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix
formatting
dt-bindings: arm: mt8195: Set #clock-cells as required property
dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
dt-bindings: arm: mt8192: Set #clock-cells as required property
.../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++-----
.../mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
.../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++--------
.../mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
.../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++---------
.../mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
6 files changed, 71 insertions(+), 66 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 57+ messages in thread* [PATCH 0/6] dt-bindings: arm: MediaTek: Fix clock bindings
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for
which I've used the already upstreamed ones as a base, it was found that
these bindings have some issues.
This series is addressing the issues that were found by Rob on my series,
which are present on all of the already merged bindings.
[1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953
AngeloGioacchino Del Regno (6):
dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix
formatting
dt-bindings: arm: mt8186: Set #clock-cells as required property
dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix
formatting
dt-bindings: arm: mt8195: Set #clock-cells as required property
dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
dt-bindings: arm: mt8192: Set #clock-cells as required property
.../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++-----
.../mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
.../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++--------
.../mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
.../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++---------
.../mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
6 files changed, 71 insertions(+), 66 deletions(-)
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 57+ messages in thread* [PATCH 1/6] dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix formatting
2022-05-17 10:15 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
There's no need for 'items' when there's only one item; while at it,
also fix formatting by adding a blank line before specifying 'reg'.
Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../arm/mediatek/mediatek,mt8186-clock.yaml | 28 +++++++++----------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
index cf1002c3efa6..371eace6780b 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
@@ -21,20 +21,20 @@ description: |
properties:
compatible:
- items:
- - enum:
- - mediatek,mt8186-imp_iic_wrap
- - mediatek,mt8186-mfgsys
- - mediatek,mt8186-wpesys
- - mediatek,mt8186-imgsys1
- - mediatek,mt8186-imgsys2
- - mediatek,mt8186-vdecsys
- - mediatek,mt8186-vencsys
- - mediatek,mt8186-camsys
- - mediatek,mt8186-camsys_rawa
- - mediatek,mt8186-camsys_rawb
- - mediatek,mt8186-mdpsys
- - mediatek,mt8186-ipesys
+ enum:
+ - mediatek,mt8186-imp_iic_wrap
+ - mediatek,mt8186-mfgsys
+ - mediatek,mt8186-wpesys
+ - mediatek,mt8186-imgsys1
+ - mediatek,mt8186-imgsys2
+ - mediatek,mt8186-vdecsys
+ - mediatek,mt8186-vencsys
+ - mediatek,mt8186-camsys
+ - mediatek,mt8186-camsys_rawa
+ - mediatek,mt8186-camsys_rawb
+ - mediatek,mt8186-mdpsys
+ - mediatek,mt8186-ipesys
+
reg:
maxItems: 1
--
2.35.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH 1/6] dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix formatting
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
There's no need for 'items' when there's only one item; while at it,
also fix formatting by adding a blank line before specifying 'reg'.
Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../arm/mediatek/mediatek,mt8186-clock.yaml | 28 +++++++++----------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
index cf1002c3efa6..371eace6780b 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
@@ -21,20 +21,20 @@ description: |
properties:
compatible:
- items:
- - enum:
- - mediatek,mt8186-imp_iic_wrap
- - mediatek,mt8186-mfgsys
- - mediatek,mt8186-wpesys
- - mediatek,mt8186-imgsys1
- - mediatek,mt8186-imgsys2
- - mediatek,mt8186-vdecsys
- - mediatek,mt8186-vencsys
- - mediatek,mt8186-camsys
- - mediatek,mt8186-camsys_rawa
- - mediatek,mt8186-camsys_rawb
- - mediatek,mt8186-mdpsys
- - mediatek,mt8186-ipesys
+ enum:
+ - mediatek,mt8186-imp_iic_wrap
+ - mediatek,mt8186-mfgsys
+ - mediatek,mt8186-wpesys
+ - mediatek,mt8186-imgsys1
+ - mediatek,mt8186-imgsys2
+ - mediatek,mt8186-vdecsys
+ - mediatek,mt8186-vencsys
+ - mediatek,mt8186-camsys
+ - mediatek,mt8186-camsys_rawa
+ - mediatek,mt8186-camsys_rawb
+ - mediatek,mt8186-mdpsys
+ - mediatek,mt8186-ipesys
+
reg:
maxItems: 1
--
2.35.1
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH 1/6] dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix formatting
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
There's no need for 'items' when there's only one item; while at it,
also fix formatting by adding a blank line before specifying 'reg'.
Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../arm/mediatek/mediatek,mt8186-clock.yaml | 28 +++++++++----------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
index cf1002c3efa6..371eace6780b 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
@@ -21,20 +21,20 @@ description: |
properties:
compatible:
- items:
- - enum:
- - mediatek,mt8186-imp_iic_wrap
- - mediatek,mt8186-mfgsys
- - mediatek,mt8186-wpesys
- - mediatek,mt8186-imgsys1
- - mediatek,mt8186-imgsys2
- - mediatek,mt8186-vdecsys
- - mediatek,mt8186-vencsys
- - mediatek,mt8186-camsys
- - mediatek,mt8186-camsys_rawa
- - mediatek,mt8186-camsys_rawb
- - mediatek,mt8186-mdpsys
- - mediatek,mt8186-ipesys
+ enum:
+ - mediatek,mt8186-imp_iic_wrap
+ - mediatek,mt8186-mfgsys
+ - mediatek,mt8186-wpesys
+ - mediatek,mt8186-imgsys1
+ - mediatek,mt8186-imgsys2
+ - mediatek,mt8186-vdecsys
+ - mediatek,mt8186-vencsys
+ - mediatek,mt8186-camsys
+ - mediatek,mt8186-camsys_rawa
+ - mediatek,mt8186-camsys_rawb
+ - mediatek,mt8186-mdpsys
+ - mediatek,mt8186-ipesys
+
reg:
maxItems: 1
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 57+ messages in thread* Re: [PATCH 1/6] dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix formatting
2022-05-17 10:15 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-17 14:30 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:30 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> There's no need for 'items' when there's only one item; while at it,
> also fix formatting by adding a blank line before specifying 'reg'.
>
> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
The original code was not buggy, so it is not a fix. There is no single
reason to backport this patch (which you will cause with Fixes tag).
For the rest:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../arm/mediatek/mediatek,mt8186-clock.yaml | 28 +++++++++----------
> 1 file changed, 14 insertions(+), 14 deletions(-)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 1/6] dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix formatting
@ 2022-05-17 14:30 ` Krzysztof Kozlowski
0 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:30 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> There's no need for 'items' when there's only one item; while at it,
> also fix formatting by adding a blank line before specifying 'reg'.
>
> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
The original code was not buggy, so it is not a fix. There is no single
reason to backport this patch (which you will cause with Fixes tag).
For the rest:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../arm/mediatek/mediatek,mt8186-clock.yaml | 28 +++++++++----------
> 1 file changed, 14 insertions(+), 14 deletions(-)
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 1/6] dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix formatting
@ 2022-05-17 14:30 ` Krzysztof Kozlowski
0 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:30 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> There's no need for 'items' when there's only one item; while at it,
> also fix formatting by adding a blank line before specifying 'reg'.
>
> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
The original code was not buggy, so it is not a fix. There is no single
reason to backport this patch (which you will cause with Fixes tag).
For the rest:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../arm/mediatek/mediatek,mt8186-clock.yaml | 28 +++++++++----------
> 1 file changed, 14 insertions(+), 14 deletions(-)
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 57+ messages in thread
* [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property
2022-05-17 10:15 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
This is a clock-controller binding, so it needs #clock-cells, or
it would be of no use: add that to the list of required properties.
Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +
.../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
index 371eace6780b..70d7b393140e 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
@@ -44,6 +44,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml
index 0886e2e335bb..48ebd2112789 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml
@@ -42,6 +42,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
--
2.35.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
This is a clock-controller binding, so it needs #clock-cells, or
it would be of no use: add that to the list of required properties.
Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +
.../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
index 371eace6780b..70d7b393140e 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
@@ -44,6 +44,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml
index 0886e2e335bb..48ebd2112789 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml
@@ -42,6 +42,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
--
2.35.1
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
This is a clock-controller binding, so it needs #clock-cells, or
it would be of no use: add that to the list of required properties.
Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +
.../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
index 371eace6780b..70d7b393140e 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
@@ -44,6 +44,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml
index 0886e2e335bb..48ebd2112789 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml
@@ -42,6 +42,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 57+ messages in thread* Re: [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property
2022-05-17 10:15 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-17 14:34 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:34 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> This is a clock-controller binding, so it needs #clock-cells, or
> it would be of no use: add that to the list of required properties.
>
> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +
If these are clock controllers and new bindings, why they were added to
"arm" directory? arm is only for top-level stuff, not for devices.
In the future please put your bindings in respective subsystem matching
the hardware. Fallback is soc directory, not arm.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property
@ 2022-05-17 14:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:34 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> This is a clock-controller binding, so it needs #clock-cells, or
> it would be of no use: add that to the list of required properties.
>
> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +
If these are clock controllers and new bindings, why they were added to
"arm" directory? arm is only for top-level stuff, not for devices.
In the future please put your bindings in respective subsystem matching
the hardware. Fallback is soc directory, not arm.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property
@ 2022-05-17 14:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:34 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> This is a clock-controller binding, so it needs #clock-cells, or
> it would be of no use: add that to the list of required properties.
>
> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +
If these are clock controllers and new bindings, why they were added to
"arm" directory? arm is only for top-level stuff, not for devices.
In the future please put your bindings in respective subsystem matching
the hardware. Fallback is soc directory, not arm.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property
2022-05-17 14:34 ` Krzysztof Kozlowski
(?)
@ 2022-05-18 9:24 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-18 9:24 UTC (permalink / raw)
To: Krzysztof Kozlowski, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
Il 17/05/22 16:34, Krzysztof Kozlowski ha scritto:
> On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
>> This is a clock-controller binding, so it needs #clock-cells, or
>> it would be of no use: add that to the list of required properties.
>>
>> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +
>
> If these are clock controllers and new bindings, why they were added to
> "arm" directory? arm is only for top-level stuff, not for devices.
>
> In the future please put your bindings in respective subsystem matching
> the hardware. Fallback is soc directory, not arm.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Hello Krzysztof,
I agree with you about these bindings belonging to the clock directory.
Should I add a patch to this series that moves all of the mtxxxx-clock
and mtxxxx-sys-clock yaml files to the clock directory?
Regards,
Angelo
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property
@ 2022-05-18 9:24 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-18 9:24 UTC (permalink / raw)
To: Krzysztof Kozlowski, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
Il 17/05/22 16:34, Krzysztof Kozlowski ha scritto:
> On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
>> This is a clock-controller binding, so it needs #clock-cells, or
>> it would be of no use: add that to the list of required properties.
>>
>> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +
>
> If these are clock controllers and new bindings, why they were added to
> "arm" directory? arm is only for top-level stuff, not for devices.
>
> In the future please put your bindings in respective subsystem matching
> the hardware. Fallback is soc directory, not arm.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Hello Krzysztof,
I agree with you about these bindings belonging to the clock directory.
Should I add a patch to this series that moves all of the mtxxxx-clock
and mtxxxx-sys-clock yaml files to the clock directory?
Regards,
Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property
@ 2022-05-18 9:24 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-18 9:24 UTC (permalink / raw)
To: Krzysztof Kozlowski, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
Il 17/05/22 16:34, Krzysztof Kozlowski ha scritto:
> On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
>> This is a clock-controller binding, so it needs #clock-cells, or
>> it would be of no use: add that to the list of required properties.
>>
>> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +
>
> If these are clock controllers and new bindings, why they were added to
> "arm" directory? arm is only for top-level stuff, not for devices.
>
> In the future please put your bindings in respective subsystem matching
> the hardware. Fallback is soc directory, not arm.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Hello Krzysztof,
I agree with you about these bindings belonging to the clock directory.
Should I add a patch to this series that moves all of the mtxxxx-clock
and mtxxxx-sys-clock yaml files to the clock directory?
Regards,
Angelo
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property
2022-05-18 9:24 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-18 9:30 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-18 9:30 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 18/05/2022 11:24, AngeloGioacchino Del Regno wrote:
> Il 17/05/22 16:34, Krzysztof Kozlowski ha scritto:
>> On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
>>> This is a clock-controller binding, so it needs #clock-cells, or
>>> it would be of no use: add that to the list of required properties.
>>>
>>> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>> ---
>>> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +
>>
>> If these are clock controllers and new bindings, why they were added to
>> "arm" directory? arm is only for top-level stuff, not for devices.
>>
>> In the future please put your bindings in respective subsystem matching
>> the hardware. Fallback is soc directory, not arm.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>
> Hello Krzysztof,
>
> I agree with you about these bindings belonging to the clock directory.
> Should I add a patch to this series that moves all of the mtxxxx-clock
> and mtxxxx-sys-clock yaml files to the clock directory?
They should not be added there, but no need to shuffle things around...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property
@ 2022-05-18 9:30 ` Krzysztof Kozlowski
0 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-18 9:30 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 18/05/2022 11:24, AngeloGioacchino Del Regno wrote:
> Il 17/05/22 16:34, Krzysztof Kozlowski ha scritto:
>> On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
>>> This is a clock-controller binding, so it needs #clock-cells, or
>>> it would be of no use: add that to the list of required properties.
>>>
>>> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>> ---
>>> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +
>>
>> If these are clock controllers and new bindings, why they were added to
>> "arm" directory? arm is only for top-level stuff, not for devices.
>>
>> In the future please put your bindings in respective subsystem matching
>> the hardware. Fallback is soc directory, not arm.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>
> Hello Krzysztof,
>
> I agree with you about these bindings belonging to the clock directory.
> Should I add a patch to this series that moves all of the mtxxxx-clock
> and mtxxxx-sys-clock yaml files to the clock directory?
They should not be added there, but no need to shuffle things around...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property
@ 2022-05-18 9:30 ` Krzysztof Kozlowski
0 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-18 9:30 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 18/05/2022 11:24, AngeloGioacchino Del Regno wrote:
> Il 17/05/22 16:34, Krzysztof Kozlowski ha scritto:
>> On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
>>> This is a clock-controller binding, so it needs #clock-cells, or
>>> it would be of no use: add that to the list of required properties.
>>>
>>> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>> ---
>>> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +
>>
>> If these are clock controllers and new bindings, why they were added to
>> "arm" directory? arm is only for top-level stuff, not for devices.
>>
>> In the future please put your bindings in respective subsystem matching
>> the hardware. Fallback is soc directory, not arm.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>
> Hello Krzysztof,
>
> I agree with you about these bindings belonging to the clock directory.
> Should I add a patch to this series that moves all of the mtxxxx-clock
> and mtxxxx-sys-clock yaml files to the clock directory?
They should not be added there, but no need to shuffle things around...
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 57+ messages in thread
* [PATCH 3/6] dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix formatting
2022-05-17 10:15 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
There's no need for 'items' when there's only one item; while at it,
also fix formatting by adding a blank line before specifying 'reg'.
Fixes: 34d3ed3b9a00 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8195 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../arm/mediatek/mediatek,mt8195-clock.yaml | 58 +++++++++----------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
index 17fcbb45d121..0189aa0e34d4 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
@@ -22,35 +22,35 @@ description:
properties:
compatible:
- items:
- - enum:
- - mediatek,mt8195-scp_adsp
- - mediatek,mt8195-imp_iic_wrap_s
- - mediatek,mt8195-imp_iic_wrap_w
- - mediatek,mt8195-mfgcfg
- - mediatek,mt8195-vppsys0
- - mediatek,mt8195-wpesys
- - mediatek,mt8195-wpesys_vpp0
- - mediatek,mt8195-wpesys_vpp1
- - mediatek,mt8195-vppsys1
- - mediatek,mt8195-imgsys
- - mediatek,mt8195-imgsys1_dip_top
- - mediatek,mt8195-imgsys1_dip_nr
- - mediatek,mt8195-imgsys1_wpe
- - mediatek,mt8195-ipesys
- - mediatek,mt8195-camsys
- - mediatek,mt8195-camsys_rawa
- - mediatek,mt8195-camsys_yuva
- - mediatek,mt8195-camsys_rawb
- - mediatek,mt8195-camsys_yuvb
- - mediatek,mt8195-camsys_mraw
- - mediatek,mt8195-ccusys
- - mediatek,mt8195-vdecsys_soc
- - mediatek,mt8195-vdecsys
- - mediatek,mt8195-vdecsys_core1
- - mediatek,mt8195-vencsys
- - mediatek,mt8195-vencsys_core1
- - mediatek,mt8195-apusys_pll
+ enum:
+ - mediatek,mt8195-scp_adsp
+ - mediatek,mt8195-imp_iic_wrap_s
+ - mediatek,mt8195-imp_iic_wrap_w
+ - mediatek,mt8195-mfgcfg
+ - mediatek,mt8195-vppsys0
+ - mediatek,mt8195-wpesys
+ - mediatek,mt8195-wpesys_vpp0
+ - mediatek,mt8195-wpesys_vpp1
+ - mediatek,mt8195-vppsys1
+ - mediatek,mt8195-imgsys
+ - mediatek,mt8195-imgsys1_dip_top
+ - mediatek,mt8195-imgsys1_dip_nr
+ - mediatek,mt8195-imgsys1_wpe
+ - mediatek,mt8195-ipesys
+ - mediatek,mt8195-camsys
+ - mediatek,mt8195-camsys_rawa
+ - mediatek,mt8195-camsys_yuva
+ - mediatek,mt8195-camsys_rawb
+ - mediatek,mt8195-camsys_yuvb
+ - mediatek,mt8195-camsys_mraw
+ - mediatek,mt8195-ccusys
+ - mediatek,mt8195-vdecsys_soc
+ - mediatek,mt8195-vdecsys
+ - mediatek,mt8195-vdecsys_core1
+ - mediatek,mt8195-vencsys
+ - mediatek,mt8195-vencsys_core1
+ - mediatek,mt8195-apusys_pll
+
reg:
maxItems: 1
--
2.35.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH 3/6] dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix formatting
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
There's no need for 'items' when there's only one item; while at it,
also fix formatting by adding a blank line before specifying 'reg'.
Fixes: 34d3ed3b9a00 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8195 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../arm/mediatek/mediatek,mt8195-clock.yaml | 58 +++++++++----------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
index 17fcbb45d121..0189aa0e34d4 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
@@ -22,35 +22,35 @@ description:
properties:
compatible:
- items:
- - enum:
- - mediatek,mt8195-scp_adsp
- - mediatek,mt8195-imp_iic_wrap_s
- - mediatek,mt8195-imp_iic_wrap_w
- - mediatek,mt8195-mfgcfg
- - mediatek,mt8195-vppsys0
- - mediatek,mt8195-wpesys
- - mediatek,mt8195-wpesys_vpp0
- - mediatek,mt8195-wpesys_vpp1
- - mediatek,mt8195-vppsys1
- - mediatek,mt8195-imgsys
- - mediatek,mt8195-imgsys1_dip_top
- - mediatek,mt8195-imgsys1_dip_nr
- - mediatek,mt8195-imgsys1_wpe
- - mediatek,mt8195-ipesys
- - mediatek,mt8195-camsys
- - mediatek,mt8195-camsys_rawa
- - mediatek,mt8195-camsys_yuva
- - mediatek,mt8195-camsys_rawb
- - mediatek,mt8195-camsys_yuvb
- - mediatek,mt8195-camsys_mraw
- - mediatek,mt8195-ccusys
- - mediatek,mt8195-vdecsys_soc
- - mediatek,mt8195-vdecsys
- - mediatek,mt8195-vdecsys_core1
- - mediatek,mt8195-vencsys
- - mediatek,mt8195-vencsys_core1
- - mediatek,mt8195-apusys_pll
+ enum:
+ - mediatek,mt8195-scp_adsp
+ - mediatek,mt8195-imp_iic_wrap_s
+ - mediatek,mt8195-imp_iic_wrap_w
+ - mediatek,mt8195-mfgcfg
+ - mediatek,mt8195-vppsys0
+ - mediatek,mt8195-wpesys
+ - mediatek,mt8195-wpesys_vpp0
+ - mediatek,mt8195-wpesys_vpp1
+ - mediatek,mt8195-vppsys1
+ - mediatek,mt8195-imgsys
+ - mediatek,mt8195-imgsys1_dip_top
+ - mediatek,mt8195-imgsys1_dip_nr
+ - mediatek,mt8195-imgsys1_wpe
+ - mediatek,mt8195-ipesys
+ - mediatek,mt8195-camsys
+ - mediatek,mt8195-camsys_rawa
+ - mediatek,mt8195-camsys_yuva
+ - mediatek,mt8195-camsys_rawb
+ - mediatek,mt8195-camsys_yuvb
+ - mediatek,mt8195-camsys_mraw
+ - mediatek,mt8195-ccusys
+ - mediatek,mt8195-vdecsys_soc
+ - mediatek,mt8195-vdecsys
+ - mediatek,mt8195-vdecsys_core1
+ - mediatek,mt8195-vencsys
+ - mediatek,mt8195-vencsys_core1
+ - mediatek,mt8195-apusys_pll
+
reg:
maxItems: 1
--
2.35.1
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH 3/6] dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix formatting
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
There's no need for 'items' when there's only one item; while at it,
also fix formatting by adding a blank line before specifying 'reg'.
Fixes: 34d3ed3b9a00 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8195 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../arm/mediatek/mediatek,mt8195-clock.yaml | 58 +++++++++----------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
index 17fcbb45d121..0189aa0e34d4 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
@@ -22,35 +22,35 @@ description:
properties:
compatible:
- items:
- - enum:
- - mediatek,mt8195-scp_adsp
- - mediatek,mt8195-imp_iic_wrap_s
- - mediatek,mt8195-imp_iic_wrap_w
- - mediatek,mt8195-mfgcfg
- - mediatek,mt8195-vppsys0
- - mediatek,mt8195-wpesys
- - mediatek,mt8195-wpesys_vpp0
- - mediatek,mt8195-wpesys_vpp1
- - mediatek,mt8195-vppsys1
- - mediatek,mt8195-imgsys
- - mediatek,mt8195-imgsys1_dip_top
- - mediatek,mt8195-imgsys1_dip_nr
- - mediatek,mt8195-imgsys1_wpe
- - mediatek,mt8195-ipesys
- - mediatek,mt8195-camsys
- - mediatek,mt8195-camsys_rawa
- - mediatek,mt8195-camsys_yuva
- - mediatek,mt8195-camsys_rawb
- - mediatek,mt8195-camsys_yuvb
- - mediatek,mt8195-camsys_mraw
- - mediatek,mt8195-ccusys
- - mediatek,mt8195-vdecsys_soc
- - mediatek,mt8195-vdecsys
- - mediatek,mt8195-vdecsys_core1
- - mediatek,mt8195-vencsys
- - mediatek,mt8195-vencsys_core1
- - mediatek,mt8195-apusys_pll
+ enum:
+ - mediatek,mt8195-scp_adsp
+ - mediatek,mt8195-imp_iic_wrap_s
+ - mediatek,mt8195-imp_iic_wrap_w
+ - mediatek,mt8195-mfgcfg
+ - mediatek,mt8195-vppsys0
+ - mediatek,mt8195-wpesys
+ - mediatek,mt8195-wpesys_vpp0
+ - mediatek,mt8195-wpesys_vpp1
+ - mediatek,mt8195-vppsys1
+ - mediatek,mt8195-imgsys
+ - mediatek,mt8195-imgsys1_dip_top
+ - mediatek,mt8195-imgsys1_dip_nr
+ - mediatek,mt8195-imgsys1_wpe
+ - mediatek,mt8195-ipesys
+ - mediatek,mt8195-camsys
+ - mediatek,mt8195-camsys_rawa
+ - mediatek,mt8195-camsys_yuva
+ - mediatek,mt8195-camsys_rawb
+ - mediatek,mt8195-camsys_yuvb
+ - mediatek,mt8195-camsys_mraw
+ - mediatek,mt8195-ccusys
+ - mediatek,mt8195-vdecsys_soc
+ - mediatek,mt8195-vdecsys
+ - mediatek,mt8195-vdecsys_core1
+ - mediatek,mt8195-vencsys
+ - mediatek,mt8195-vencsys_core1
+ - mediatek,mt8195-apusys_pll
+
reg:
maxItems: 1
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 57+ messages in thread* Re: [PATCH 3/6] dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix formatting
2022-05-17 10:15 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-17 14:31 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:31 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> There's no need for 'items' when there's only one item; while at it,
> also fix formatting by adding a blank line before specifying 'reg'.
>
> Fixes: 34d3ed3b9a00 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8195 clock")
Squash it with first patch and remove the Fixes tag, please.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 3/6] dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix formatting
@ 2022-05-17 14:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:31 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> There's no need for 'items' when there's only one item; while at it,
> also fix formatting by adding a blank line before specifying 'reg'.
>
> Fixes: 34d3ed3b9a00 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8195 clock")
Squash it with first patch and remove the Fixes tag, please.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 3/6] dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix formatting
@ 2022-05-17 14:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:31 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> There's no need for 'items' when there's only one item; while at it,
> also fix formatting by adding a blank line before specifying 'reg'.
>
> Fixes: 34d3ed3b9a00 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8195 clock")
Squash it with first patch and remove the Fixes tag, please.
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 57+ messages in thread
* [PATCH 4/6] dt-bindings: arm: mt8195: Set #clock-cells as required property
2022-05-17 10:15 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
This is a clock-controller binding, so it needs #clock-cells, or
it would be of no use: add that to the list of required properties.
Fixes: 34d3ed3b9a00 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8195 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 +
.../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
index 0189aa0e34d4..aabd9f0df2de 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
@@ -60,6 +60,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml
index 95b6bdf99936..e2ba37830d4e 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml
@@ -43,6 +43,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
--
2.35.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH 4/6] dt-bindings: arm: mt8195: Set #clock-cells as required property
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
This is a clock-controller binding, so it needs #clock-cells, or
it would be of no use: add that to the list of required properties.
Fixes: 34d3ed3b9a00 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8195 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 +
.../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
index 0189aa0e34d4..aabd9f0df2de 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
@@ -60,6 +60,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml
index 95b6bdf99936..e2ba37830d4e 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml
@@ -43,6 +43,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
--
2.35.1
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH 4/6] dt-bindings: arm: mt8195: Set #clock-cells as required property
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
This is a clock-controller binding, so it needs #clock-cells, or
it would be of no use: add that to the list of required properties.
Fixes: 34d3ed3b9a00 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8195 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 +
.../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
index 0189aa0e34d4..aabd9f0df2de 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
@@ -60,6 +60,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml
index 95b6bdf99936..e2ba37830d4e 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml
@@ -43,6 +43,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 57+ messages in thread* Re: [PATCH 4/6] dt-bindings: arm: mt8195: Set #clock-cells as required property
2022-05-17 10:15 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-17 14:34 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:34 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> This is a clock-controller binding, so it needs #clock-cells, or
> it would be of no use: add that to the list of required properties.
>
> Fixes: 34d3ed3b9a00 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8195 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 4/6] dt-bindings: arm: mt8195: Set #clock-cells as required property
@ 2022-05-17 14:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:34 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> This is a clock-controller binding, so it needs #clock-cells, or
> it would be of no use: add that to the list of required properties.
>
> Fixes: 34d3ed3b9a00 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8195 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 4/6] dt-bindings: arm: mt8195: Set #clock-cells as required property
@ 2022-05-17 14:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:34 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> This is a clock-controller binding, so it needs #clock-cells, or
> it would be of no use: add that to the list of required properties.
>
> Fixes: 34d3ed3b9a00 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8195 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 57+ messages in thread
* [PATCH 5/6] dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
2022-05-17 10:15 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
There's no need for 'items' when there's only one item.
Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../arm/mediatek/mediatek,mt8192-clock.yaml | 45 +++++++++----------
1 file changed, 22 insertions(+), 23 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
index c8c67c033f8c..bb410b178f33 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
@@ -14,29 +14,28 @@ description:
properties:
compatible:
- items:
- - enum:
- - mediatek,mt8192-scp_adsp
- - mediatek,mt8192-imp_iic_wrap_c
- - mediatek,mt8192-imp_iic_wrap_e
- - mediatek,mt8192-imp_iic_wrap_s
- - mediatek,mt8192-imp_iic_wrap_ws
- - mediatek,mt8192-imp_iic_wrap_w
- - mediatek,mt8192-imp_iic_wrap_n
- - mediatek,mt8192-msdc_top
- - mediatek,mt8192-msdc
- - mediatek,mt8192-mfgcfg
- - mediatek,mt8192-imgsys
- - mediatek,mt8192-imgsys2
- - mediatek,mt8192-vdecsys_soc
- - mediatek,mt8192-vdecsys
- - mediatek,mt8192-vencsys
- - mediatek,mt8192-camsys
- - mediatek,mt8192-camsys_rawa
- - mediatek,mt8192-camsys_rawb
- - mediatek,mt8192-camsys_rawc
- - mediatek,mt8192-ipesys
- - mediatek,mt8192-mdpsys
+ enum:
+ - mediatek,mt8192-scp_adsp
+ - mediatek,mt8192-imp_iic_wrap_c
+ - mediatek,mt8192-imp_iic_wrap_e
+ - mediatek,mt8192-imp_iic_wrap_s
+ - mediatek,mt8192-imp_iic_wrap_ws
+ - mediatek,mt8192-imp_iic_wrap_w
+ - mediatek,mt8192-imp_iic_wrap_n
+ - mediatek,mt8192-msdc_top
+ - mediatek,mt8192-msdc
+ - mediatek,mt8192-mfgcfg
+ - mediatek,mt8192-imgsys
+ - mediatek,mt8192-imgsys2
+ - mediatek,mt8192-vdecsys_soc
+ - mediatek,mt8192-vdecsys
+ - mediatek,mt8192-vencsys
+ - mediatek,mt8192-camsys
+ - mediatek,mt8192-camsys_rawa
+ - mediatek,mt8192-camsys_rawb
+ - mediatek,mt8192-camsys_rawc
+ - mediatek,mt8192-ipesys
+ - mediatek,mt8192-mdpsys
reg:
maxItems: 1
--
2.35.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH 5/6] dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
There's no need for 'items' when there's only one item.
Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../arm/mediatek/mediatek,mt8192-clock.yaml | 45 +++++++++----------
1 file changed, 22 insertions(+), 23 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
index c8c67c033f8c..bb410b178f33 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
@@ -14,29 +14,28 @@ description:
properties:
compatible:
- items:
- - enum:
- - mediatek,mt8192-scp_adsp
- - mediatek,mt8192-imp_iic_wrap_c
- - mediatek,mt8192-imp_iic_wrap_e
- - mediatek,mt8192-imp_iic_wrap_s
- - mediatek,mt8192-imp_iic_wrap_ws
- - mediatek,mt8192-imp_iic_wrap_w
- - mediatek,mt8192-imp_iic_wrap_n
- - mediatek,mt8192-msdc_top
- - mediatek,mt8192-msdc
- - mediatek,mt8192-mfgcfg
- - mediatek,mt8192-imgsys
- - mediatek,mt8192-imgsys2
- - mediatek,mt8192-vdecsys_soc
- - mediatek,mt8192-vdecsys
- - mediatek,mt8192-vencsys
- - mediatek,mt8192-camsys
- - mediatek,mt8192-camsys_rawa
- - mediatek,mt8192-camsys_rawb
- - mediatek,mt8192-camsys_rawc
- - mediatek,mt8192-ipesys
- - mediatek,mt8192-mdpsys
+ enum:
+ - mediatek,mt8192-scp_adsp
+ - mediatek,mt8192-imp_iic_wrap_c
+ - mediatek,mt8192-imp_iic_wrap_e
+ - mediatek,mt8192-imp_iic_wrap_s
+ - mediatek,mt8192-imp_iic_wrap_ws
+ - mediatek,mt8192-imp_iic_wrap_w
+ - mediatek,mt8192-imp_iic_wrap_n
+ - mediatek,mt8192-msdc_top
+ - mediatek,mt8192-msdc
+ - mediatek,mt8192-mfgcfg
+ - mediatek,mt8192-imgsys
+ - mediatek,mt8192-imgsys2
+ - mediatek,mt8192-vdecsys_soc
+ - mediatek,mt8192-vdecsys
+ - mediatek,mt8192-vencsys
+ - mediatek,mt8192-camsys
+ - mediatek,mt8192-camsys_rawa
+ - mediatek,mt8192-camsys_rawb
+ - mediatek,mt8192-camsys_rawc
+ - mediatek,mt8192-ipesys
+ - mediatek,mt8192-mdpsys
reg:
maxItems: 1
--
2.35.1
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH 5/6] dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
There's no need for 'items' when there's only one item.
Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../arm/mediatek/mediatek,mt8192-clock.yaml | 45 +++++++++----------
1 file changed, 22 insertions(+), 23 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
index c8c67c033f8c..bb410b178f33 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
@@ -14,29 +14,28 @@ description:
properties:
compatible:
- items:
- - enum:
- - mediatek,mt8192-scp_adsp
- - mediatek,mt8192-imp_iic_wrap_c
- - mediatek,mt8192-imp_iic_wrap_e
- - mediatek,mt8192-imp_iic_wrap_s
- - mediatek,mt8192-imp_iic_wrap_ws
- - mediatek,mt8192-imp_iic_wrap_w
- - mediatek,mt8192-imp_iic_wrap_n
- - mediatek,mt8192-msdc_top
- - mediatek,mt8192-msdc
- - mediatek,mt8192-mfgcfg
- - mediatek,mt8192-imgsys
- - mediatek,mt8192-imgsys2
- - mediatek,mt8192-vdecsys_soc
- - mediatek,mt8192-vdecsys
- - mediatek,mt8192-vencsys
- - mediatek,mt8192-camsys
- - mediatek,mt8192-camsys_rawa
- - mediatek,mt8192-camsys_rawb
- - mediatek,mt8192-camsys_rawc
- - mediatek,mt8192-ipesys
- - mediatek,mt8192-mdpsys
+ enum:
+ - mediatek,mt8192-scp_adsp
+ - mediatek,mt8192-imp_iic_wrap_c
+ - mediatek,mt8192-imp_iic_wrap_e
+ - mediatek,mt8192-imp_iic_wrap_s
+ - mediatek,mt8192-imp_iic_wrap_ws
+ - mediatek,mt8192-imp_iic_wrap_w
+ - mediatek,mt8192-imp_iic_wrap_n
+ - mediatek,mt8192-msdc_top
+ - mediatek,mt8192-msdc
+ - mediatek,mt8192-mfgcfg
+ - mediatek,mt8192-imgsys
+ - mediatek,mt8192-imgsys2
+ - mediatek,mt8192-vdecsys_soc
+ - mediatek,mt8192-vdecsys
+ - mediatek,mt8192-vencsys
+ - mediatek,mt8192-camsys
+ - mediatek,mt8192-camsys_rawa
+ - mediatek,mt8192-camsys_rawb
+ - mediatek,mt8192-camsys_rawc
+ - mediatek,mt8192-ipesys
+ - mediatek,mt8192-mdpsys
reg:
maxItems: 1
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 57+ messages in thread* Re: [PATCH 5/6] dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
2022-05-17 10:15 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-17 14:31 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:31 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> There's no need for 'items' when there's only one item.
>
> Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
The same - no bugs to fix here and this can be squashed.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 5/6] dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
@ 2022-05-17 14:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:31 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> There's no need for 'items' when there's only one item.
>
> Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
The same - no bugs to fix here and this can be squashed.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 5/6] dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
@ 2022-05-17 14:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:31 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> There's no need for 'items' when there's only one item.
>
> Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
The same - no bugs to fix here and this can be squashed.
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [PATCH 5/6] dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
2022-05-17 10:15 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-17 15:04 ` Nícolas F. R. A. Prado
-1 siblings, 0 replies; 57+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-05-17 15:04 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: robh+dt, krzysztof.kozlowski+dt, matthias.bgg, sboyd,
chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel
On Tue, May 17, 2022 at 12:15:13PM +0200, AngeloGioacchino Del Regno wrote:
> There's no need for 'items' when there's only one item.
>
> Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../arm/mediatek/mediatek,mt8192-clock.yaml | 45 +++++++++----------
> 1 file changed, 22 insertions(+), 23 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> index c8c67c033f8c..bb410b178f33 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> @@ -14,29 +14,28 @@ description:
>
> properties:
> compatible:
> - items:
> - - enum:
> - - mediatek,mt8192-scp_adsp
> - - mediatek,mt8192-imp_iic_wrap_c
> - - mediatek,mt8192-imp_iic_wrap_e
> - - mediatek,mt8192-imp_iic_wrap_s
> - - mediatek,mt8192-imp_iic_wrap_ws
> - - mediatek,mt8192-imp_iic_wrap_w
> - - mediatek,mt8192-imp_iic_wrap_n
> - - mediatek,mt8192-msdc_top
> - - mediatek,mt8192-msdc
> - - mediatek,mt8192-mfgcfg
> - - mediatek,mt8192-imgsys
> - - mediatek,mt8192-imgsys2
> - - mediatek,mt8192-vdecsys_soc
> - - mediatek,mt8192-vdecsys
> - - mediatek,mt8192-vencsys
> - - mediatek,mt8192-camsys
> - - mediatek,mt8192-camsys_rawa
> - - mediatek,mt8192-camsys_rawb
> - - mediatek,mt8192-camsys_rawc
> - - mediatek,mt8192-ipesys
> - - mediatek,mt8192-mdpsys
> + enum:
> + - mediatek,mt8192-scp_adsp
> + - mediatek,mt8192-imp_iic_wrap_c
> + - mediatek,mt8192-imp_iic_wrap_e
> + - mediatek,mt8192-imp_iic_wrap_s
> + - mediatek,mt8192-imp_iic_wrap_ws
> + - mediatek,mt8192-imp_iic_wrap_w
> + - mediatek,mt8192-imp_iic_wrap_n
> + - mediatek,mt8192-msdc_top
> + - mediatek,mt8192-msdc
> + - mediatek,mt8192-mfgcfg
> + - mediatek,mt8192-imgsys
> + - mediatek,mt8192-imgsys2
> + - mediatek,mt8192-vdecsys_soc
> + - mediatek,mt8192-vdecsys
> + - mediatek,mt8192-vencsys
> + - mediatek,mt8192-camsys
> + - mediatek,mt8192-camsys_rawa
> + - mediatek,mt8192-camsys_rawb
> + - mediatek,mt8192-camsys_rawc
> + - mediatek,mt8192-ipesys
> + - mediatek,mt8192-mdpsys
This will conflict with the patch removing msdc:
[1] https://lore.kernel.org/all/20220429123133.28869-1-matthias.bgg@kernel.org/
Although if this series is merged before that one, it should be fine.
Thanks,
Nícolas
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 5/6] dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
@ 2022-05-17 15:04 ` Nícolas F. R. A. Prado
0 siblings, 0 replies; 57+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-05-17 15:04 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: robh+dt, krzysztof.kozlowski+dt, matthias.bgg, sboyd,
chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel
On Tue, May 17, 2022 at 12:15:13PM +0200, AngeloGioacchino Del Regno wrote:
> There's no need for 'items' when there's only one item.
>
> Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../arm/mediatek/mediatek,mt8192-clock.yaml | 45 +++++++++----------
> 1 file changed, 22 insertions(+), 23 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> index c8c67c033f8c..bb410b178f33 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> @@ -14,29 +14,28 @@ description:
>
> properties:
> compatible:
> - items:
> - - enum:
> - - mediatek,mt8192-scp_adsp
> - - mediatek,mt8192-imp_iic_wrap_c
> - - mediatek,mt8192-imp_iic_wrap_e
> - - mediatek,mt8192-imp_iic_wrap_s
> - - mediatek,mt8192-imp_iic_wrap_ws
> - - mediatek,mt8192-imp_iic_wrap_w
> - - mediatek,mt8192-imp_iic_wrap_n
> - - mediatek,mt8192-msdc_top
> - - mediatek,mt8192-msdc
> - - mediatek,mt8192-mfgcfg
> - - mediatek,mt8192-imgsys
> - - mediatek,mt8192-imgsys2
> - - mediatek,mt8192-vdecsys_soc
> - - mediatek,mt8192-vdecsys
> - - mediatek,mt8192-vencsys
> - - mediatek,mt8192-camsys
> - - mediatek,mt8192-camsys_rawa
> - - mediatek,mt8192-camsys_rawb
> - - mediatek,mt8192-camsys_rawc
> - - mediatek,mt8192-ipesys
> - - mediatek,mt8192-mdpsys
> + enum:
> + - mediatek,mt8192-scp_adsp
> + - mediatek,mt8192-imp_iic_wrap_c
> + - mediatek,mt8192-imp_iic_wrap_e
> + - mediatek,mt8192-imp_iic_wrap_s
> + - mediatek,mt8192-imp_iic_wrap_ws
> + - mediatek,mt8192-imp_iic_wrap_w
> + - mediatek,mt8192-imp_iic_wrap_n
> + - mediatek,mt8192-msdc_top
> + - mediatek,mt8192-msdc
> + - mediatek,mt8192-mfgcfg
> + - mediatek,mt8192-imgsys
> + - mediatek,mt8192-imgsys2
> + - mediatek,mt8192-vdecsys_soc
> + - mediatek,mt8192-vdecsys
> + - mediatek,mt8192-vencsys
> + - mediatek,mt8192-camsys
> + - mediatek,mt8192-camsys_rawa
> + - mediatek,mt8192-camsys_rawb
> + - mediatek,mt8192-camsys_rawc
> + - mediatek,mt8192-ipesys
> + - mediatek,mt8192-mdpsys
This will conflict with the patch removing msdc:
[1] https://lore.kernel.org/all/20220429123133.28869-1-matthias.bgg@kernel.org/
Although if this series is merged before that one, it should be fine.
Thanks,
Nícolas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 5/6] dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
@ 2022-05-17 15:04 ` Nícolas F. R. A. Prado
0 siblings, 0 replies; 57+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-05-17 15:04 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: robh+dt, krzysztof.kozlowski+dt, matthias.bgg, sboyd,
chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel
On Tue, May 17, 2022 at 12:15:13PM +0200, AngeloGioacchino Del Regno wrote:
> There's no need for 'items' when there's only one item.
>
> Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../arm/mediatek/mediatek,mt8192-clock.yaml | 45 +++++++++----------
> 1 file changed, 22 insertions(+), 23 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> index c8c67c033f8c..bb410b178f33 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> @@ -14,29 +14,28 @@ description:
>
> properties:
> compatible:
> - items:
> - - enum:
> - - mediatek,mt8192-scp_adsp
> - - mediatek,mt8192-imp_iic_wrap_c
> - - mediatek,mt8192-imp_iic_wrap_e
> - - mediatek,mt8192-imp_iic_wrap_s
> - - mediatek,mt8192-imp_iic_wrap_ws
> - - mediatek,mt8192-imp_iic_wrap_w
> - - mediatek,mt8192-imp_iic_wrap_n
> - - mediatek,mt8192-msdc_top
> - - mediatek,mt8192-msdc
> - - mediatek,mt8192-mfgcfg
> - - mediatek,mt8192-imgsys
> - - mediatek,mt8192-imgsys2
> - - mediatek,mt8192-vdecsys_soc
> - - mediatek,mt8192-vdecsys
> - - mediatek,mt8192-vencsys
> - - mediatek,mt8192-camsys
> - - mediatek,mt8192-camsys_rawa
> - - mediatek,mt8192-camsys_rawb
> - - mediatek,mt8192-camsys_rawc
> - - mediatek,mt8192-ipesys
> - - mediatek,mt8192-mdpsys
> + enum:
> + - mediatek,mt8192-scp_adsp
> + - mediatek,mt8192-imp_iic_wrap_c
> + - mediatek,mt8192-imp_iic_wrap_e
> + - mediatek,mt8192-imp_iic_wrap_s
> + - mediatek,mt8192-imp_iic_wrap_ws
> + - mediatek,mt8192-imp_iic_wrap_w
> + - mediatek,mt8192-imp_iic_wrap_n
> + - mediatek,mt8192-msdc_top
> + - mediatek,mt8192-msdc
> + - mediatek,mt8192-mfgcfg
> + - mediatek,mt8192-imgsys
> + - mediatek,mt8192-imgsys2
> + - mediatek,mt8192-vdecsys_soc
> + - mediatek,mt8192-vdecsys
> + - mediatek,mt8192-vencsys
> + - mediatek,mt8192-camsys
> + - mediatek,mt8192-camsys_rawa
> + - mediatek,mt8192-camsys_rawb
> + - mediatek,mt8192-camsys_rawc
> + - mediatek,mt8192-ipesys
> + - mediatek,mt8192-mdpsys
This will conflict with the patch removing msdc:
[1] https://lore.kernel.org/all/20220429123133.28869-1-matthias.bgg@kernel.org/
Although if this series is merged before that one, it should be fine.
Thanks,
Nícolas
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 57+ messages in thread
* [PATCH 6/6] dt-bindings: arm: mt8192: Set #clock-cells as required property
2022-05-17 10:15 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
This is a clock-controller binding, so it needs #clock-cells, or
it would be of no use: add that to the list of required properties.
Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 +
.../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
index bb410b178f33..b61d7635dfdd 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
@@ -46,6 +46,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml
index 27f79175c678..580450e94c02 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml
@@ -35,6 +35,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
--
2.35.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH 6/6] dt-bindings: arm: mt8192: Set #clock-cells as required property
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
This is a clock-controller binding, so it needs #clock-cells, or
it would be of no use: add that to the list of required properties.
Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 +
.../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
index bb410b178f33..b61d7635dfdd 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
@@ -46,6 +46,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml
index 27f79175c678..580450e94c02 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml
@@ -35,6 +35,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
--
2.35.1
^ permalink raw reply related [flat|nested] 57+ messages in thread* [PATCH 6/6] dt-bindings: arm: mt8192: Set #clock-cells as required property
@ 2022-05-17 10:15 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 10:15 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno,
sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
This is a clock-controller binding, so it needs #clock-cells, or
it would be of no use: add that to the list of required properties.
Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 +
.../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
index bb410b178f33..b61d7635dfdd 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
@@ -46,6 +46,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml
index 27f79175c678..580450e94c02 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml
@@ -35,6 +35,7 @@ properties:
required:
- compatible
- reg
+ - '#clock-cells'
additionalProperties: false
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 57+ messages in thread* Re: [PATCH 6/6] dt-bindings: arm: mt8192: Set #clock-cells as required property
2022-05-17 10:15 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-17 14:34 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:34 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> This is a clock-controller binding, so it needs #clock-cells, or
> it would be of no use: add that to the list of required properties.
>
> Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 6/6] dt-bindings: arm: mt8192: Set #clock-cells as required property
@ 2022-05-17 14:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:34 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> This is a clock-controller binding, so it needs #clock-cells, or
> it would be of no use: add that to the list of required properties.
>
> Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 57+ messages in thread* Re: [PATCH 6/6] dt-bindings: arm: mt8192: Set #clock-cells as required property
@ 2022-05-17 14:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 57+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-17 14:34 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen,
rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> This is a clock-controller binding, so it needs #clock-cells, or
> it would be of no use: add that to the list of required properties.
>
> Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [PATCH 0/6] dt-bindings: arm: MediaTek: Fix clock bindings
2022-05-17 10:15 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-17 13:39 ` Matthias Brugger
-1 siblings, 0 replies; 57+ messages in thread
From: Matthias Brugger @ 2022-05-17 13:39 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, sboyd, chun-jie.chen, rex-bc.chen, wenst,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for
> which I've used the already upstreamed ones as a base, it was found that
> these bindings have some issues.
> This series is addressing the issues that were found by Rob on my series,
> which are present on all of the already merged bindings.
>
> [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953
I would say we could squash patches here and make it 3 instead of 6.
In any case for the whole series:
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> AngeloGioacchino Del Regno (6):
> dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix
> formatting
> dt-bindings: arm: mt8186: Set #clock-cells as required property
> dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix
> formatting
> dt-bindings: arm: mt8195: Set #clock-cells as required property
> dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
> dt-bindings: arm: mt8192: Set #clock-cells as required property
>
> .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++-----
> .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
> .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++--------
> .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
> .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++---------
> .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
> 6 files changed, 71 insertions(+), 66 deletions(-)
>
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [PATCH 0/6] dt-bindings: arm: MediaTek: Fix clock bindings
@ 2022-05-17 13:39 ` Matthias Brugger
0 siblings, 0 replies; 57+ messages in thread
From: Matthias Brugger @ 2022-05-17 13:39 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, sboyd, chun-jie.chen, rex-bc.chen, wenst,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for
> which I've used the already upstreamed ones as a base, it was found that
> these bindings have some issues.
> This series is addressing the issues that were found by Rob on my series,
> which are present on all of the already merged bindings.
>
> [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953
I would say we could squash patches here and make it 3 instead of 6.
In any case for the whole series:
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> AngeloGioacchino Del Regno (6):
> dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix
> formatting
> dt-bindings: arm: mt8186: Set #clock-cells as required property
> dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix
> formatting
> dt-bindings: arm: mt8195: Set #clock-cells as required property
> dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
> dt-bindings: arm: mt8192: Set #clock-cells as required property
>
> .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++-----
> .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
> .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++--------
> .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
> .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++---------
> .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
> 6 files changed, 71 insertions(+), 66 deletions(-)
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [PATCH 0/6] dt-bindings: arm: MediaTek: Fix clock bindings
@ 2022-05-17 13:39 ` Matthias Brugger
0 siblings, 0 replies; 57+ messages in thread
From: Matthias Brugger @ 2022-05-17 13:39 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: krzysztof.kozlowski+dt, sboyd, chun-jie.chen, rex-bc.chen, wenst,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
> As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for
> which I've used the already upstreamed ones as a base, it was found that
> these bindings have some issues.
> This series is addressing the issues that were found by Rob on my series,
> which are present on all of the already merged bindings.
>
> [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953
I would say we could squash patches here and make it 3 instead of 6.
In any case for the whole series:
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> AngeloGioacchino Del Regno (6):
> dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix
> formatting
> dt-bindings: arm: mt8186: Set #clock-cells as required property
> dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix
> formatting
> dt-bindings: arm: mt8195: Set #clock-cells as required property
> dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
> dt-bindings: arm: mt8192: Set #clock-cells as required property
>
> .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++-----
> .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
> .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++--------
> .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
> .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++---------
> .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
> 6 files changed, 71 insertions(+), 66 deletions(-)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [PATCH 0/6] dt-bindings: arm: MediaTek: Fix clock bindings
2022-05-17 13:39 ` Matthias Brugger
(?)
@ 2022-05-17 13:43 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 13:43 UTC (permalink / raw)
To: Matthias Brugger, robh+dt
Cc: krzysztof.kozlowski+dt, sboyd, chun-jie.chen, rex-bc.chen, wenst,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
Il 17/05/22 15:39, Matthias Brugger ha scritto:
>
>
> On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
>> As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for
>> which I've used the already upstreamed ones as a base, it was found that
>> these bindings have some issues.
>> This series is addressing the issues that were found by Rob on my series,
>> which are present on all of the already merged bindings.
>>
>> [1]:
>> https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953
>>
>
> I would say we could squash patches here and make it 3 instead of 6.
> In any case for the whole series:
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
I had the same initial idea, but chose to do it in 6 patches because otherwise
the titles would be too generic and not really effectual in the end...
If anyone wants them squashed, now you know what was my difficulty and my
reasons :-)
By the way, thank you!
>>
>> AngeloGioacchino Del Regno (6):
>> dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix
>> formatting
>> dt-bindings: arm: mt8186: Set #clock-cells as required property
>> dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix
>> formatting
>> dt-bindings: arm: mt8195: Set #clock-cells as required property
>> dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
>> dt-bindings: arm: mt8192: Set #clock-cells as required property
>>
>> .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++-----
>> .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
>> .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++--------
>> .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
>> .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++---------
>> .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
>> 6 files changed, 71 insertions(+), 66 deletions(-)
>>
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [PATCH 0/6] dt-bindings: arm: MediaTek: Fix clock bindings
@ 2022-05-17 13:43 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 13:43 UTC (permalink / raw)
To: Matthias Brugger, robh+dt
Cc: krzysztof.kozlowski+dt, sboyd, chun-jie.chen, rex-bc.chen, wenst,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
Il 17/05/22 15:39, Matthias Brugger ha scritto:
>
>
> On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
>> As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for
>> which I've used the already upstreamed ones as a base, it was found that
>> these bindings have some issues.
>> This series is addressing the issues that were found by Rob on my series,
>> which are present on all of the already merged bindings.
>>
>> [1]:
>> https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953
>>
>
> I would say we could squash patches here and make it 3 instead of 6.
> In any case for the whole series:
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
I had the same initial idea, but chose to do it in 6 patches because otherwise
the titles would be too generic and not really effectual in the end...
If anyone wants them squashed, now you know what was my difficulty and my
reasons :-)
By the way, thank you!
>>
>> AngeloGioacchino Del Regno (6):
>> dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix
>> formatting
>> dt-bindings: arm: mt8186: Set #clock-cells as required property
>> dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix
>> formatting
>> dt-bindings: arm: mt8195: Set #clock-cells as required property
>> dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
>> dt-bindings: arm: mt8192: Set #clock-cells as required property
>>
>> .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++-----
>> .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
>> .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++--------
>> .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
>> .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++---------
>> .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
>> 6 files changed, 71 insertions(+), 66 deletions(-)
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [PATCH 0/6] dt-bindings: arm: MediaTek: Fix clock bindings
@ 2022-05-17 13:43 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 57+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-17 13:43 UTC (permalink / raw)
To: Matthias Brugger, robh+dt
Cc: krzysztof.kozlowski+dt, sboyd, chun-jie.chen, rex-bc.chen, wenst,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
Il 17/05/22 15:39, Matthias Brugger ha scritto:
>
>
> On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
>> As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for
>> which I've used the already upstreamed ones as a base, it was found that
>> these bindings have some issues.
>> This series is addressing the issues that were found by Rob on my series,
>> which are present on all of the already merged bindings.
>>
>> [1]:
>> https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953
>>
>
> I would say we could squash patches here and make it 3 instead of 6.
> In any case for the whole series:
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
I had the same initial idea, but chose to do it in 6 patches because otherwise
the titles would be too generic and not really effectual in the end...
If anyone wants them squashed, now you know what was my difficulty and my
reasons :-)
By the way, thank you!
>>
>> AngeloGioacchino Del Regno (6):
>> dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix
>> formatting
>> dt-bindings: arm: mt8186: Set #clock-cells as required property
>> dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix
>> formatting
>> dt-bindings: arm: mt8195: Set #clock-cells as required property
>> dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
>> dt-bindings: arm: mt8192: Set #clock-cells as required property
>>
>> .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++-----
>> .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
>> .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++--------
>> .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
>> .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++---------
>> .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
>> 6 files changed, 71 insertions(+), 66 deletions(-)
>>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [PATCH 0/6] dt-bindings: arm: MediaTek: Fix clock bindings
2022-05-17 10:15 ` AngeloGioacchino Del Regno
(?)
@ 2022-05-17 15:05 ` Nícolas F. R. A. Prado
-1 siblings, 0 replies; 57+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-05-17 15:05 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: robh+dt, krzysztof.kozlowski+dt, matthias.bgg, sboyd,
chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel
On Tue, May 17, 2022 at 12:15:08PM +0200, AngeloGioacchino Del Regno wrote:
> As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for
> which I've used the already upstreamed ones as a base, it was found that
> these bindings have some issues.
> This series is addressing the issues that were found by Rob on my series,
> which are present on all of the already merged bindings.
>
> [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953
>
> AngeloGioacchino Del Regno (6):
> dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix
> formatting
> dt-bindings: arm: mt8186: Set #clock-cells as required property
> dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix
> formatting
> dt-bindings: arm: mt8195: Set #clock-cells as required property
> dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
> dt-bindings: arm: mt8192: Set #clock-cells as required property
For the whole series,
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Thanks,
Nícolas
>
> .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++-----
> .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
> .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++--------
> .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
> .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++---------
> .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
> 6 files changed, 71 insertions(+), 66 deletions(-)
>
> --
> 2.35.1
>
>
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [PATCH 0/6] dt-bindings: arm: MediaTek: Fix clock bindings
@ 2022-05-17 15:05 ` Nícolas F. R. A. Prado
0 siblings, 0 replies; 57+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-05-17 15:05 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: robh+dt, krzysztof.kozlowski+dt, matthias.bgg, sboyd,
chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel
On Tue, May 17, 2022 at 12:15:08PM +0200, AngeloGioacchino Del Regno wrote:
> As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for
> which I've used the already upstreamed ones as a base, it was found that
> these bindings have some issues.
> This series is addressing the issues that were found by Rob on my series,
> which are present on all of the already merged bindings.
>
> [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953
>
> AngeloGioacchino Del Regno (6):
> dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix
> formatting
> dt-bindings: arm: mt8186: Set #clock-cells as required property
> dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix
> formatting
> dt-bindings: arm: mt8195: Set #clock-cells as required property
> dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
> dt-bindings: arm: mt8192: Set #clock-cells as required property
For the whole series,
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Thanks,
Nícolas
>
> .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++-----
> .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
> .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++--------
> .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
> .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++---------
> .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
> 6 files changed, 71 insertions(+), 66 deletions(-)
>
> --
> 2.35.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [PATCH 0/6] dt-bindings: arm: MediaTek: Fix clock bindings
@ 2022-05-17 15:05 ` Nícolas F. R. A. Prado
0 siblings, 0 replies; 57+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-05-17 15:05 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: robh+dt, krzysztof.kozlowski+dt, matthias.bgg, sboyd,
chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel
On Tue, May 17, 2022 at 12:15:08PM +0200, AngeloGioacchino Del Regno wrote:
> As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for
> which I've used the already upstreamed ones as a base, it was found that
> these bindings have some issues.
> This series is addressing the issues that were found by Rob on my series,
> which are present on all of the already merged bindings.
>
> [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953
>
> AngeloGioacchino Del Regno (6):
> dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix
> formatting
> dt-bindings: arm: mt8186: Set #clock-cells as required property
> dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix
> formatting
> dt-bindings: arm: mt8195: Set #clock-cells as required property
> dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
> dt-bindings: arm: mt8192: Set #clock-cells as required property
For the whole series,
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Thanks,
Nícolas
>
> .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++-----
> .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
> .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++--------
> .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
> .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++---------
> .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
> 6 files changed, 71 insertions(+), 66 deletions(-)
>
> --
> 2.35.1
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 57+ messages in thread