[PATCH] usb: dwc3: Fix support for usb3-phy PHY configuration

[PATCH] usb: dwc3: Fix support for usb3-phy PHY configuration

[Marek Vasut]

The dev_read_stringlist_search() in generic_phy_get_by_name()
returns -ENODATA in case of missing "phy-names", which is the
case on everything except ZynqMP. Handle this -ENODATA instead
of failing outright, which fixes the glue on everything else.

Fixes: 142d50fbce7 ("usb: dwc3: Add support for usb3-phy PHY configuration")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Michal Simek <michal.simek@xilinx.com>
---
 drivers/usb/dwc3/dwc3-generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c
index 6e1a1d066b4..9608c5c599a 100644
--- a/drivers/usb/dwc3/dwc3-generic.c
+++ b/drivers/usb/dwc3/dwc3-generic.c
@@ -468,7 +468,7 @@ static int dwc3_glue_probe(struct udevice *dev)
 		ret = generic_phy_init(&phy);
 		if (ret)
 			return ret;
-	} else if (ret != -ENOENT) {
+	} else if (ret != -ENOENT && ret != -ENODATA) {
 		debug("could not get phy (err %d)\n", ret);
 		return ret;
 	}
-- 
2.35.1

Re: [PATCH] usb: dwc3: Fix support for usb3-phy PHY configuration

[Michal Simek]

On 5/19/22 23:03, Marek Vasut wrote:
> The dev_read_stringlist_search() in generic_phy_get_by_name()
> returns -ENODATA in case of missing "phy-names", which is the
> case on everything except ZynqMP. Handle this -ENODATA instead
> of failing outright, which fixes the glue on everything else.
> 
> Fixes: 142d50fbce7 ("usb: dwc3: Add support for usb3-phy PHY configuration")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Michal Simek <michal.simek@xilinx.com>
> ---
>   drivers/usb/dwc3/dwc3-generic.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c
> index 6e1a1d066b4..9608c5c599a 100644
> --- a/drivers/usb/dwc3/dwc3-generic.c
> +++ b/drivers/usb/dwc3/dwc3-generic.c
> @@ -468,7 +468,7 @@ static int dwc3_glue_probe(struct udevice *dev)
>   		ret = generic_phy_init(&phy);
>   		if (ret)
>   			return ret;
> -	} else if (ret != -ENOENT) {
> +	} else if (ret != -ENOENT && ret != -ENODATA) {
>   		debug("could not get phy (err %d)\n", ret);
>   		return ret;
>   	}

Is already handle by one of these in queue.

https://lore.kernel.org/all/c5a71c30-e55d-c8ab-d372-e5aaa859cf2a@siemens.com/
https://lore.kernel.org/all/360eefb2-b835-840e-8513-6e9e35a002ec@xilinx.com

Thanks,
Michal