* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
@ 2022-05-03 21:48 ` Rob Herring
0 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2022-05-03 21:48 UTC (permalink / raw)
To: matthias.bgg
Cc: mturquette, sboyd, allen-kh.cheng, weiyi.lu, chun-jie.chen,
linux-kernel, ikjn, miles.chen, linux-mediatek,
krzysztof.kozlowski+dt, linux-clk, linux-arm-kernel,
angelogioacchino.delregno, Matthias Brugger, Krzysztof Kozlowski,
devicetree
On Fri, Apr 29, 2022 at 02:31:31PM +0200, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
> The msdc gate is part of the MMC driver. Delete the binding description
> of this node.
An ABI break is okay because ...?
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> ---
>
> Changes in v2:
> - Delete compatible in binding descprition as well
>
> .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> index c8c67c033f8c..b57cc2e69efb 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> @@ -24,7 +24,6 @@ properties:
> - mediatek,mt8192-imp_iic_wrap_w
> - mediatek,mt8192-imp_iic_wrap_n
> - mediatek,mt8192-msdc_top
> - - mediatek,mt8192-msdc
> - mediatek,mt8192-mfgcfg
> - mediatek,mt8192-imgsys
> - mediatek,mt8192-imgsys2
> @@ -107,13 +106,6 @@ examples:
> #clock-cells = <1>;
> };
>
> - - |
> - msdc: clock-controller@11f60000 {
> - compatible = "mediatek,mt8192-msdc";
> - reg = <0x11f60000 0x1000>;
> - #clock-cells = <1>;
> - };
> -
> - |
> mfgcfg: clock-controller@13fbf000 {
> compatible = "mediatek,mt8192-mfgcfg";
> --
> 2.34.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
@ 2022-05-03 21:48 ` Rob Herring
0 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2022-05-03 21:48 UTC (permalink / raw)
To: matthias.bgg
Cc: mturquette, sboyd, allen-kh.cheng, weiyi.lu, chun-jie.chen,
linux-kernel, ikjn, miles.chen, linux-mediatek,
krzysztof.kozlowski+dt, linux-clk, linux-arm-kernel,
angelogioacchino.delregno, Matthias Brugger, Krzysztof Kozlowski,
devicetree
On Fri, Apr 29, 2022 at 02:31:31PM +0200, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
> The msdc gate is part of the MMC driver. Delete the binding description
> of this node.
An ABI break is okay because ...?
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> ---
>
> Changes in v2:
> - Delete compatible in binding descprition as well
>
> .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> index c8c67c033f8c..b57cc2e69efb 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> @@ -24,7 +24,6 @@ properties:
> - mediatek,mt8192-imp_iic_wrap_w
> - mediatek,mt8192-imp_iic_wrap_n
> - mediatek,mt8192-msdc_top
> - - mediatek,mt8192-msdc
> - mediatek,mt8192-mfgcfg
> - mediatek,mt8192-imgsys
> - mediatek,mt8192-imgsys2
> @@ -107,13 +106,6 @@ examples:
> #clock-cells = <1>;
> };
>
> - - |
> - msdc: clock-controller@11f60000 {
> - compatible = "mediatek,mt8192-msdc";
> - reg = <0x11f60000 0x1000>;
> - #clock-cells = <1>;
> - };
> -
> - |
> mfgcfg: clock-controller@13fbf000 {
> compatible = "mediatek,mt8192-mfgcfg";
> --
> 2.34.1
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock
2022-05-03 21:48 ` Rob Herring
(?)
@ 2022-05-05 5:31 ` Miles Chen
-1 siblings, 0 replies; 36+ messages in thread
From: Miles Chen @ 2022-05-05 5:31 UTC (permalink / raw)
To: robh
Cc: allen-kh.cheng, angelogioacchino.delregno, chun-jie.chen,
devicetree, ikjn, krzk+dt, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-clk, linux-kernel, linux-mediatek,
matthias.bgg, matthias.bgg, miles.chen, mturquette, sboyd
Hi Rob,
>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> The msdc gate is part of the MMC driver. Delete the binding description
>> of this node.
>
>An ABI break is okay because ...?
Sorry for that,
If the mediatek,mt8192-msdc part is removed from the driver,
Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or
we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.
e.g.,
- mediatek,mt8192-msdc # deprecated
thanks,
Miles
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> ---
>
> Changes in v2:
> - Delete compatible in binding descprition as well
>
> .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> index c8c67c033f8c..b57cc2e69efb 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> @@ -24,7 +24,6 @@ properties:
> - mediatek,mt8192-imp_iic_wrap_w
> - mediatek,mt8192-imp_iic_wrap_n
> - mediatek,mt8192-msdc_top
> - - mediatek,mt8192-msdc
> - mediatek,mt8192-mfgcfg
> - mediatek,mt8192-imgsys
> - mediatek,mt8192-imgsys2
> @@ -107,13 +106,6 @@ examples:
> #clock-cells = <1>;
> };
>
> - - |
> - msdc: clock-controller@11f60000 {
> - compatible = "mediatek,mt8192-msdc";
> - reg = <0x11f60000 0x1000>;
> - #clock-cells = <1>;
> - };
> -
> - |
> mfgcfg: clock-controller@13fbf000 {
> compatible = "mediatek,mt8192-mfgcfg";
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock
@ 2022-05-05 5:31 ` Miles Chen
0 siblings, 0 replies; 36+ messages in thread
From: Miles Chen @ 2022-05-05 5:31 UTC (permalink / raw)
To: robh
Cc: allen-kh.cheng, angelogioacchino.delregno, chun-jie.chen,
devicetree, ikjn, krzk+dt, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-clk, linux-kernel, linux-mediatek,
matthias.bgg, matthias.bgg, miles.chen, mturquette, sboyd
Hi Rob,
>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> The msdc gate is part of the MMC driver. Delete the binding description
>> of this node.
>
>An ABI break is okay because ...?
Sorry for that,
If the mediatek,mt8192-msdc part is removed from the driver,
Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or
we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.
e.g.,
- mediatek,mt8192-msdc # deprecated
thanks,
Miles
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> ---
>
> Changes in v2:
> - Delete compatible in binding descprition as well
>
> .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> index c8c67c033f8c..b57cc2e69efb 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> @@ -24,7 +24,6 @@ properties:
> - mediatek,mt8192-imp_iic_wrap_w
> - mediatek,mt8192-imp_iic_wrap_n
> - mediatek,mt8192-msdc_top
> - - mediatek,mt8192-msdc
> - mediatek,mt8192-mfgcfg
> - mediatek,mt8192-imgsys
> - mediatek,mt8192-imgsys2
> @@ -107,13 +106,6 @@ examples:
> #clock-cells = <1>;
> };
>
> - - |
> - msdc: clock-controller@11f60000 {
> - compatible = "mediatek,mt8192-msdc";
> - reg = <0x11f60000 0x1000>;
> - #clock-cells = <1>;
> - };
> -
> - |
> mfgcfg: clock-controller@13fbf000 {
> compatible = "mediatek,mt8192-mfgcfg";
> --
> 2.34.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock
@ 2022-05-05 5:31 ` Miles Chen
0 siblings, 0 replies; 36+ messages in thread
From: Miles Chen @ 2022-05-05 5:31 UTC (permalink / raw)
To: robh
Cc: allen-kh.cheng, angelogioacchino.delregno, chun-jie.chen,
devicetree, ikjn, krzk+dt, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-clk, linux-kernel, linux-mediatek,
matthias.bgg, matthias.bgg, miles.chen, mturquette, sboyd
Hi Rob,
>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> The msdc gate is part of the MMC driver. Delete the binding description
>> of this node.
>
>An ABI break is okay because ...?
Sorry for that,
If the mediatek,mt8192-msdc part is removed from the driver,
Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or
we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.
e.g.,
- mediatek,mt8192-msdc # deprecated
thanks,
Miles
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> ---
>
> Changes in v2:
> - Delete compatible in binding descprition as well
>
> .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> index c8c67c033f8c..b57cc2e69efb 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> @@ -24,7 +24,6 @@ properties:
> - mediatek,mt8192-imp_iic_wrap_w
> - mediatek,mt8192-imp_iic_wrap_n
> - mediatek,mt8192-msdc_top
> - - mediatek,mt8192-msdc
> - mediatek,mt8192-mfgcfg
> - mediatek,mt8192-imgsys
> - mediatek,mt8192-imgsys2
> @@ -107,13 +106,6 @@ examples:
> #clock-cells = <1>;
> };
>
> - - |
> - msdc: clock-controller@11f60000 {
> - compatible = "mediatek,mt8192-msdc";
> - reg = <0x11f60000 0x1000>;
> - #clock-cells = <1>;
> - };
> -
> - |
> mfgcfg: clock-controller@13fbf000 {
> compatible = "mediatek,mt8192-mfgcfg";
> --
> 2.34.1
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock
2022-05-05 5:31 ` Miles Chen
(?)
@ 2022-05-09 22:36 ` Rob Herring
-1 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2022-05-09 22:36 UTC (permalink / raw)
To: Miles Chen
Cc: allen-kh.cheng, angelogioacchino.delregno, chun-jie.chen,
devicetree, ikjn, krzk+dt, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-clk, linux-kernel, linux-mediatek,
matthias.bgg, matthias.bgg, mturquette, sboyd
On Thu, May 05, 2022 at 01:31:11PM +0800, Miles Chen wrote:
> Hi Rob,
>
> >> From: Matthias Brugger <matthias.bgg@gmail.com>
> >>
> >> The msdc gate is part of the MMC driver. Delete the binding description
> >> of this node.
> >
> >An ABI break is okay because ...?
>
> Sorry for that,
>
> If the mediatek,mt8192-msdc part is removed from the driver,
That's an ABI break too. You just need to explain why as Matthias did in
the commit message if the ABI break is okay.
> Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or
> we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.
We do that sometimes, but depends on the situation.
Rob
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock
@ 2022-05-09 22:36 ` Rob Herring
0 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2022-05-09 22:36 UTC (permalink / raw)
To: Miles Chen
Cc: allen-kh.cheng, angelogioacchino.delregno, chun-jie.chen,
devicetree, ikjn, krzk+dt, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-clk, linux-kernel, linux-mediatek,
matthias.bgg, matthias.bgg, mturquette, sboyd
On Thu, May 05, 2022 at 01:31:11PM +0800, Miles Chen wrote:
> Hi Rob,
>
> >> From: Matthias Brugger <matthias.bgg@gmail.com>
> >>
> >> The msdc gate is part of the MMC driver. Delete the binding description
> >> of this node.
> >
> >An ABI break is okay because ...?
>
> Sorry for that,
>
> If the mediatek,mt8192-msdc part is removed from the driver,
That's an ABI break too. You just need to explain why as Matthias did in
the commit message if the ABI break is okay.
> Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or
> we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.
We do that sometimes, but depends on the situation.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock
@ 2022-05-09 22:36 ` Rob Herring
0 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2022-05-09 22:36 UTC (permalink / raw)
To: Miles Chen
Cc: allen-kh.cheng, angelogioacchino.delregno, chun-jie.chen,
devicetree, ikjn, krzk+dt, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-clk, linux-kernel, linux-mediatek,
matthias.bgg, matthias.bgg, mturquette, sboyd
On Thu, May 05, 2022 at 01:31:11PM +0800, Miles Chen wrote:
> Hi Rob,
>
> >> From: Matthias Brugger <matthias.bgg@gmail.com>
> >>
> >> The msdc gate is part of the MMC driver. Delete the binding description
> >> of this node.
> >
> >An ABI break is okay because ...?
>
> Sorry for that,
>
> If the mediatek,mt8192-msdc part is removed from the driver,
That's an ABI break too. You just need to explain why as Matthias did in
the commit message if the ABI break is okay.
> Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or
> we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.
We do that sometimes, but depends on the situation.
Rob
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock
2022-05-09 22:36 ` Rob Herring
(?)
@ 2022-05-09 23:18 ` Miles Chen
-1 siblings, 0 replies; 36+ messages in thread
From: Miles Chen @ 2022-05-09 23:18 UTC (permalink / raw)
To: robh
Cc: allen-kh.cheng, angelogioacchino.delregno, chun-jie.chen,
devicetree, ikjn, krzk+dt, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-clk, linux-kernel, linux-mediatek,
matthias.bgg, matthias.bgg, miles.chen, mturquette, sboyd
Hi Rob,
>On Thu, May 05, 2022 at 01:31:11PM +0800, Miles Chen wrote:
>> Hi Rob,
>>
>> >> From: Matthias Brugger <matthias.bgg@gmail.com>
>> >>
>> >> The msdc gate is part of the MMC driver. Delete the binding description
>> >> of this node.
>> >
>> >An ABI break is okay because ...?
>>
>> Sorry for that,
>>
>> If the mediatek,mt8192-msdc part is removed from the driver,
>
>That's an ABI break too. You just need to explain why as Matthias did in
>the commit message if the ABI break is okay.
Thanks for your explanation.
I would like to learn more about this. In this case
If there was a user (say xxx.c) but the user was removed, can I remove mediatek,mt8192-msdc?
thanks,
Miles
>
>> Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or
>> we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.
>
>We do that sometimes, but depends on the situation.
>
>Rob
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock
@ 2022-05-09 23:18 ` Miles Chen
0 siblings, 0 replies; 36+ messages in thread
From: Miles Chen @ 2022-05-09 23:18 UTC (permalink / raw)
To: robh
Cc: allen-kh.cheng, angelogioacchino.delregno, chun-jie.chen,
devicetree, ikjn, krzk+dt, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-clk, linux-kernel, linux-mediatek,
matthias.bgg, matthias.bgg, miles.chen, mturquette, sboyd
Hi Rob,
>On Thu, May 05, 2022 at 01:31:11PM +0800, Miles Chen wrote:
>> Hi Rob,
>>
>> >> From: Matthias Brugger <matthias.bgg@gmail.com>
>> >>
>> >> The msdc gate is part of the MMC driver. Delete the binding description
>> >> of this node.
>> >
>> >An ABI break is okay because ...?
>>
>> Sorry for that,
>>
>> If the mediatek,mt8192-msdc part is removed from the driver,
>
>That's an ABI break too. You just need to explain why as Matthias did in
>the commit message if the ABI break is okay.
Thanks for your explanation.
I would like to learn more about this. In this case
If there was a user (say xxx.c) but the user was removed, can I remove mediatek,mt8192-msdc?
thanks,
Miles
>
>> Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or
>> we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.
>
>We do that sometimes, but depends on the situation.
>
>Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock
@ 2022-05-09 23:18 ` Miles Chen
0 siblings, 0 replies; 36+ messages in thread
From: Miles Chen @ 2022-05-09 23:18 UTC (permalink / raw)
To: robh
Cc: allen-kh.cheng, angelogioacchino.delregno, chun-jie.chen,
devicetree, ikjn, krzk+dt, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-clk, linux-kernel, linux-mediatek,
matthias.bgg, matthias.bgg, miles.chen, mturquette, sboyd
Hi Rob,
>On Thu, May 05, 2022 at 01:31:11PM +0800, Miles Chen wrote:
>> Hi Rob,
>>
>> >> From: Matthias Brugger <matthias.bgg@gmail.com>
>> >>
>> >> The msdc gate is part of the MMC driver. Delete the binding description
>> >> of this node.
>> >
>> >An ABI break is okay because ...?
>>
>> Sorry for that,
>>
>> If the mediatek,mt8192-msdc part is removed from the driver,
>
>That's an ABI break too. You just need to explain why as Matthias did in
>the commit message if the ABI break is okay.
Thanks for your explanation.
I would like to learn more about this. In this case
If there was a user (say xxx.c) but the user was removed, can I remove mediatek,mt8192-msdc?
thanks,
Miles
>
>> Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or
>> we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.
>
>We do that sometimes, but depends on the situation.
>
>Rob
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
2022-05-03 21:48 ` Rob Herring
(?)
@ 2022-05-05 16:47 ` Matthias Brugger
-1 siblings, 0 replies; 36+ messages in thread
From: Matthias Brugger @ 2022-05-05 16:47 UTC (permalink / raw)
To: Rob Herring, matthias.bgg
Cc: mturquette, sboyd, allen-kh.cheng, weiyi.lu, chun-jie.chen,
linux-kernel, ikjn, miles.chen, linux-mediatek,
krzysztof.kozlowski+dt, linux-clk, linux-arm-kernel,
angelogioacchino.delregno, Krzysztof Kozlowski, devicetree
On 03/05/2022 23:48, Rob Herring wrote:
> On Fri, Apr 29, 2022 at 02:31:31PM +0200, matthias.bgg@kernel.org wrote:
>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> The msdc gate is part of the MMC driver. Delete the binding description
>> of this node.
>
> An ABI break is okay because ...?
>
Because the code controlling the clock gate was moved to the consumer. This node
did never ever represent any working implementation of a peripheral. Just a
lonely clock gate that wasn't used.
Regards,
Matthias
>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - Delete compatible in binding descprition as well
>>
>> .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> index c8c67c033f8c..b57cc2e69efb 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> @@ -24,7 +24,6 @@ properties:
>> - mediatek,mt8192-imp_iic_wrap_w
>> - mediatek,mt8192-imp_iic_wrap_n
>> - mediatek,mt8192-msdc_top
>> - - mediatek,mt8192-msdc
>> - mediatek,mt8192-mfgcfg
>> - mediatek,mt8192-imgsys
>> - mediatek,mt8192-imgsys2
>> @@ -107,13 +106,6 @@ examples:
>> #clock-cells = <1>;
>> };
>>
>> - - |
>> - msdc: clock-controller@11f60000 {
>> - compatible = "mediatek,mt8192-msdc";
>> - reg = <0x11f60000 0x1000>;
>> - #clock-cells = <1>;
>> - };
>> -
>> - |
>> mfgcfg: clock-controller@13fbf000 {
>> compatible = "mediatek,mt8192-mfgcfg";
>> --
>> 2.34.1
>>
>>
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
@ 2022-05-05 16:47 ` Matthias Brugger
0 siblings, 0 replies; 36+ messages in thread
From: Matthias Brugger @ 2022-05-05 16:47 UTC (permalink / raw)
To: Rob Herring, matthias.bgg
Cc: mturquette, sboyd, allen-kh.cheng, weiyi.lu, chun-jie.chen,
linux-kernel, ikjn, miles.chen, linux-mediatek,
krzysztof.kozlowski+dt, linux-clk, linux-arm-kernel,
angelogioacchino.delregno, Krzysztof Kozlowski, devicetree
On 03/05/2022 23:48, Rob Herring wrote:
> On Fri, Apr 29, 2022 at 02:31:31PM +0200, matthias.bgg@kernel.org wrote:
>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> The msdc gate is part of the MMC driver. Delete the binding description
>> of this node.
>
> An ABI break is okay because ...?
>
Because the code controlling the clock gate was moved to the consumer. This node
did never ever represent any working implementation of a peripheral. Just a
lonely clock gate that wasn't used.
Regards,
Matthias
>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - Delete compatible in binding descprition as well
>>
>> .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> index c8c67c033f8c..b57cc2e69efb 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> @@ -24,7 +24,6 @@ properties:
>> - mediatek,mt8192-imp_iic_wrap_w
>> - mediatek,mt8192-imp_iic_wrap_n
>> - mediatek,mt8192-msdc_top
>> - - mediatek,mt8192-msdc
>> - mediatek,mt8192-mfgcfg
>> - mediatek,mt8192-imgsys
>> - mediatek,mt8192-imgsys2
>> @@ -107,13 +106,6 @@ examples:
>> #clock-cells = <1>;
>> };
>>
>> - - |
>> - msdc: clock-controller@11f60000 {
>> - compatible = "mediatek,mt8192-msdc";
>> - reg = <0x11f60000 0x1000>;
>> - #clock-cells = <1>;
>> - };
>> -
>> - |
>> mfgcfg: clock-controller@13fbf000 {
>> compatible = "mediatek,mt8192-mfgcfg";
>> --
>> 2.34.1
>>
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
@ 2022-05-05 16:47 ` Matthias Brugger
0 siblings, 0 replies; 36+ messages in thread
From: Matthias Brugger @ 2022-05-05 16:47 UTC (permalink / raw)
To: Rob Herring, matthias.bgg
Cc: mturquette, sboyd, allen-kh.cheng, weiyi.lu, chun-jie.chen,
linux-kernel, ikjn, miles.chen, linux-mediatek,
krzysztof.kozlowski+dt, linux-clk, linux-arm-kernel,
angelogioacchino.delregno, Krzysztof Kozlowski, devicetree
On 03/05/2022 23:48, Rob Herring wrote:
> On Fri, Apr 29, 2022 at 02:31:31PM +0200, matthias.bgg@kernel.org wrote:
>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> The msdc gate is part of the MMC driver. Delete the binding description
>> of this node.
>
> An ABI break is okay because ...?
>
Because the code controlling the clock gate was moved to the consumer. This node
did never ever represent any working implementation of a peripheral. Just a
lonely clock gate that wasn't used.
Regards,
Matthias
>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - Delete compatible in binding descprition as well
>>
>> .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> index c8c67c033f8c..b57cc2e69efb 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> @@ -24,7 +24,6 @@ properties:
>> - mediatek,mt8192-imp_iic_wrap_w
>> - mediatek,mt8192-imp_iic_wrap_n
>> - mediatek,mt8192-msdc_top
>> - - mediatek,mt8192-msdc
>> - mediatek,mt8192-mfgcfg
>> - mediatek,mt8192-imgsys
>> - mediatek,mt8192-imgsys2
>> @@ -107,13 +106,6 @@ examples:
>> #clock-cells = <1>;
>> };
>>
>> - - |
>> - msdc: clock-controller@11f60000 {
>> - compatible = "mediatek,mt8192-msdc";
>> - reg = <0x11f60000 0x1000>;
>> - #clock-cells = <1>;
>> - };
>> -
>> - |
>> mfgcfg: clock-controller@13fbf000 {
>> compatible = "mediatek,mt8192-mfgcfg";
>> --
>> 2.34.1
>>
>>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
2022-05-05 16:47 ` Matthias Brugger
(?)
@ 2022-05-20 22:21 ` Stephen Boyd
-1 siblings, 0 replies; 36+ messages in thread
From: Stephen Boyd @ 2022-05-20 22:21 UTC (permalink / raw)
To: Matthias Brugger, Rob Herring, matthias.bgg
Cc: mturquette, allen-kh.cheng, weiyi.lu, chun-jie.chen,
linux-kernel, ikjn, miles.chen, linux-mediatek,
krzysztof.kozlowski+dt, linux-clk, linux-arm-kernel,
angelogioacchino.delregno, Krzysztof Kozlowski, devicetree
Quoting Matthias Brugger (2022-05-05 09:47:30)
>
>
> On 03/05/2022 23:48, Rob Herring wrote:
> > On Fri, Apr 29, 2022 at 02:31:31PM +0200, matthias.bgg@kernel.org wrote:
> >> From: Matthias Brugger <matthias.bgg@gmail.com>
> >>
> >> The msdc gate is part of the MMC driver. Delete the binding description
> >> of this node.
> >
> > An ABI break is okay because ...?
> >
>
> Because the code controlling the clock gate was moved to the consumer. This node
> did never ever represent any working implementation of a peripheral. Just a
> lonely clock gate that wasn't used.
Can you add that to the description and resend?
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
@ 2022-05-20 22:21 ` Stephen Boyd
0 siblings, 0 replies; 36+ messages in thread
From: Stephen Boyd @ 2022-05-20 22:21 UTC (permalink / raw)
To: Matthias Brugger, Rob Herring, matthias.bgg
Cc: mturquette, allen-kh.cheng, weiyi.lu, chun-jie.chen,
linux-kernel, ikjn, miles.chen, linux-mediatek,
krzysztof.kozlowski+dt, linux-clk, linux-arm-kernel,
angelogioacchino.delregno, Krzysztof Kozlowski, devicetree
Quoting Matthias Brugger (2022-05-05 09:47:30)
>
>
> On 03/05/2022 23:48, Rob Herring wrote:
> > On Fri, Apr 29, 2022 at 02:31:31PM +0200, matthias.bgg@kernel.org wrote:
> >> From: Matthias Brugger <matthias.bgg@gmail.com>
> >>
> >> The msdc gate is part of the MMC driver. Delete the binding description
> >> of this node.
> >
> > An ABI break is okay because ...?
> >
>
> Because the code controlling the clock gate was moved to the consumer. This node
> did never ever represent any working implementation of a peripheral. Just a
> lonely clock gate that wasn't used.
Can you add that to the description and resend?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
@ 2022-05-20 22:21 ` Stephen Boyd
0 siblings, 0 replies; 36+ messages in thread
From: Stephen Boyd @ 2022-05-20 22:21 UTC (permalink / raw)
To: Matthias Brugger, Rob Herring, matthias.bgg
Cc: mturquette, allen-kh.cheng, weiyi.lu, chun-jie.chen,
linux-kernel, ikjn, miles.chen, linux-mediatek,
krzysztof.kozlowski+dt, linux-clk, linux-arm-kernel,
angelogioacchino.delregno, Krzysztof Kozlowski, devicetree
Quoting Matthias Brugger (2022-05-05 09:47:30)
>
>
> On 03/05/2022 23:48, Rob Herring wrote:
> > On Fri, Apr 29, 2022 at 02:31:31PM +0200, matthias.bgg@kernel.org wrote:
> >> From: Matthias Brugger <matthias.bgg@gmail.com>
> >>
> >> The msdc gate is part of the MMC driver. Delete the binding description
> >> of this node.
> >
> > An ABI break is okay because ...?
> >
>
> Because the code controlling the clock gate was moved to the consumer. This node
> did never ever represent any working implementation of a peripheral. Just a
> lonely clock gate that wasn't used.
Can you add that to the description and resend?
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 36+ messages in thread