All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "Måns Rullgård" <mans@mansr.com>,
	"Pantelis Antoniou" <pantelis.antoniou@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Vitaly Bordug" <vbordug@ru.mvista.com>,
	"Dan Malek" <dan@embeddededge.com>,
	"Joakim Tjernlund" <joakim.tjernlund@lumentis.se>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: fs_enet: sync rx dma buffer before reading
Date: Mon, 23 May 2022 13:23:36 -0700	[thread overview]
Message-ID: <20220523132336.073965a5@kernel.org> (raw)
In-Reply-To: <20220521104430.1212bed5@kernel.org>

On Sat, 21 May 2022 10:44:30 -0700 Jakub Kicinski wrote:
> > Well, I say the contrary.
> > 
> > On the mainline the patch may be applied as is, it won't harm.
> > 
> > However, it is gets applied to kernel 4.9 (based on the fixes: tag), it 
> > will break the driver for at least powerpc 8xx.  
> 
> I see, we should make a note of that in the commit message so it doesn't
> get sucked into stable.
> 
> > I don't know how SWIOTLB works or even what it is, does any of the 
> > microcontrollers embedding freescale ethernet uses that at all ?  
> 
> AFAIU SWIOTLB basically forces the use of bounce buffers even if the
> device can reach the entire DRAM. I think some people also use it for
> added security? IDK. I mostly use it to check if I'm using the DMA API
> "right" :)

If what I said makes sense please repost the patch, the current version
has been dropped from patchwork already.

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "Måns Rullgård" <mans@mansr.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"Dan Malek" <dan@embeddededge.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Eric Dumazet" <edumazet@google.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Vitaly Bordug" <vbordug@ru.mvista.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Joakim Tjernlund" <joakim.tjernlund@lumentis.se>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: fs_enet: sync rx dma buffer before reading
Date: Mon, 23 May 2022 13:23:36 -0700	[thread overview]
Message-ID: <20220523132336.073965a5@kernel.org> (raw)
In-Reply-To: <20220521104430.1212bed5@kernel.org>

On Sat, 21 May 2022 10:44:30 -0700 Jakub Kicinski wrote:
> > Well, I say the contrary.
> > 
> > On the mainline the patch may be applied as is, it won't harm.
> > 
> > However, it is gets applied to kernel 4.9 (based on the fixes: tag), it 
> > will break the driver for at least powerpc 8xx.  
> 
> I see, we should make a note of that in the commit message so it doesn't
> get sucked into stable.
> 
> > I don't know how SWIOTLB works or even what it is, does any of the 
> > microcontrollers embedding freescale ethernet uses that at all ?  
> 
> AFAIU SWIOTLB basically forces the use of bounce buffers even if the
> device can reach the entire DRAM. I think some people also use it for
> added security? IDK. I mostly use it to check if I'm using the DMA API
> "right" :)

If what I said makes sense please repost the patch, the current version
has been dropped from patchwork already.

  reply	other threads:[~2022-05-23 20:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 19:24 [PATCH] net: fs_enet: sync rx dma buffer before reading Mans Rullgard
2022-05-20  5:39 ` Christophe Leroy
2022-05-20 12:35   ` Måns Rullgård
2022-05-20 12:35     ` Måns Rullgård
2022-05-20 12:54     ` Christophe Leroy
2022-05-20 12:54       ` Christophe Leroy
2022-05-20 17:43       ` Jakub Kicinski
2022-05-20 17:43         ` Jakub Kicinski
2022-05-21  6:44         ` Christophe Leroy
2022-05-21  6:44           ` Christophe Leroy
2022-05-21 17:44           ` Jakub Kicinski
2022-05-21 17:44             ` Jakub Kicinski
2022-05-23 20:23             ` Jakub Kicinski [this message]
2022-05-23 20:23               ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220523132336.073965a5@kernel.org \
    --to=kuba@kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=dan@embeddededge.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=joakim.tjernlund@lumentis.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mans@mansr.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pantelis.antoniou@gmail.com \
    --cc=vbordug@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.