* [PATCH] ceph: remove useless CEPHFS_FEATURES_CLIENT_REQUIRED
@ 2022-05-26 6:07 Xiubo Li
2022-05-26 10:37 ` Jeff Layton
0 siblings, 1 reply; 3+ messages in thread
From: Xiubo Li @ 2022-05-26 6:07 UTC (permalink / raw)
To: jlayton, idryomov; +Cc: lhenriques, vshankar, ceph-devel, Xiubo Li
This macro was added but never be used. And check the ceph code
there has another CEPHFS_FEATURES_MDS_REQUIRED but always be empty.
We should clean up all this related code, which make no sense but
introducing confusion.
Signed-off-by: Xiubo Li <xiubli@redhat.com>
---
fs/ceph/mds_client.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h
index 636fcf4503e0..d8ec2ac93da3 100644
--- a/fs/ceph/mds_client.h
+++ b/fs/ceph/mds_client.h
@@ -42,7 +42,6 @@ enum ceph_feature_type {
CEPHFS_FEATURE_DELEG_INO, \
CEPHFS_FEATURE_METRIC_COLLECT, \
}
-#define CEPHFS_FEATURES_CLIENT_REQUIRED {}
/*
* Some lock dependencies:
--
2.36.0.rc1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ceph: remove useless CEPHFS_FEATURES_CLIENT_REQUIRED
2022-05-26 6:07 [PATCH] ceph: remove useless CEPHFS_FEATURES_CLIENT_REQUIRED Xiubo Li
@ 2022-05-26 10:37 ` Jeff Layton
2022-05-27 9:20 ` Luís Henriques
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Layton @ 2022-05-26 10:37 UTC (permalink / raw)
To: Xiubo Li, idryomov; +Cc: lhenriques, vshankar, ceph-devel
On Thu, 2022-05-26 at 14:07 +0800, Xiubo Li wrote:
> This macro was added but never be used. And check the ceph code
> there has another CEPHFS_FEATURES_MDS_REQUIRED but always be empty.
>
> We should clean up all this related code, which make no sense but
> introducing confusion.
>
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
> fs/ceph/mds_client.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h
> index 636fcf4503e0..d8ec2ac93da3 100644
> --- a/fs/ceph/mds_client.h
> +++ b/fs/ceph/mds_client.h
> @@ -42,7 +42,6 @@ enum ceph_feature_type {
> CEPHFS_FEATURE_DELEG_INO, \
> CEPHFS_FEATURE_METRIC_COLLECT, \
> }
> -#define CEPHFS_FEATURES_CLIENT_REQUIRED {}
>
> /*
> * Some lock dependencies:
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ceph: remove useless CEPHFS_FEATURES_CLIENT_REQUIRED
2022-05-26 10:37 ` Jeff Layton
@ 2022-05-27 9:20 ` Luís Henriques
0 siblings, 0 replies; 3+ messages in thread
From: Luís Henriques @ 2022-05-27 9:20 UTC (permalink / raw)
To: Jeff Layton; +Cc: Xiubo Li, idryomov, vshankar, ceph-devel
Jeff Layton <jlayton@kernel.org> writes:
> On Thu, 2022-05-26 at 14:07 +0800, Xiubo Li wrote:
>> This macro was added but never be used. And check the ceph code
>> there has another CEPHFS_FEATURES_MDS_REQUIRED but always be empty.
>>
>> We should clean up all this related code, which make no sense but
>> introducing confusion.
>>
>> Signed-off-by: Xiubo Li <xiubli@redhat.com>
>> ---
>> fs/ceph/mds_client.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h
>> index 636fcf4503e0..d8ec2ac93da3 100644
>> --- a/fs/ceph/mds_client.h
>> +++ b/fs/ceph/mds_client.h
>> @@ -42,7 +42,6 @@ enum ceph_feature_type {
>> CEPHFS_FEATURE_DELEG_INO, \
>> CEPHFS_FEATURE_METRIC_COLLECT, \
>> }
>> -#define CEPHFS_FEATURES_CLIENT_REQUIRED {}
>>
>> /*
>> * Some lock dependencies:
>
> Reviewed-by: Jeff Layton <jlayton@kernel.org>
Yep, this makes sense.
Reviewed-by: Luís Henriques <lhenriques@suse.de>
Cheers,
--
Luís
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-27 9:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-26 6:07 [PATCH] ceph: remove useless CEPHFS_FEATURES_CLIENT_REQUIRED Xiubo Li
2022-05-26 10:37 ` Jeff Layton
2022-05-27 9:20 ` Luís Henriques
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.