From: Charles Keepax <ckeepax@opensource.cirrus.com> To: Takashi Iwai <tiwai@suse.de> Cc: Vitaly Rodionov <vitalyr@opensource.cirrus.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>, <alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v4 00/17] ALSA: hda: cirrus: Add initial DSP support and firmware loading Date: Mon, 30 May 2022 09:08:46 +0000 [thread overview] Message-ID: <20220530090846.GS38351@ediswmail.ad.cirrus.com> (raw) In-Reply-To: <871qwf0x8t.wl-tiwai@suse.de> On Fri, May 27, 2022 at 06:13:38PM +0200, Takashi Iwai wrote: > On Wed, 25 May 2022 15:16:21 +0200, > Vitaly Rodionov wrote: > The idea to add / delete controls by the control element change > doesn't sound good; as already mentioned in my reply to the previous > patch set, the change of the control elements can be triggered too > easily by any normal users who have the access to the sound devices. > It means thousands of additions and removals per second could be > attacked by any user. > This I am a little less sure how we handle. I mean arn't there already a few ways to do this? Both the existing ASoC wm_adsp stuff, and the topology stuff (used on all new Intel platforms, so very widely deployed) let you create controls by loading a firmware file. Also within ALSA itself can't user-space create user ALSA controls? Is there some rate limiting on that? How is this issue tackled there? > Moreover, the new controls with TLV controls don't look following the > standard TLV syntax (type-length-value). My previous questions about > the TLV usages are still unanswered, so I'm not sure what impact this > would have, though. At least, alsactl behavior must be checked > beforehand. If this is really device-specific (non-)TLV usages, it has > to be clearly documented. > The TLV stuff should be completely removed once my latest comments have been updated. I don't think we need this for the amps and I would also rather keep the usage to a minimum until one of us finally gets around to resolving the large control issues in a way that is more acceptable to everyone (likely with a new IOCTL). Thanks, Charles
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.cirrus.com> To: Takashi Iwai <tiwai@suse.de> Cc: alsa-devel@alsa-project.org, Vitaly Rodionov <vitalyr@opensource.cirrus.com>, patches@opensource.cirrus.com, Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 00/17] ALSA: hda: cirrus: Add initial DSP support and firmware loading Date: Mon, 30 May 2022 09:08:46 +0000 [thread overview] Message-ID: <20220530090846.GS38351@ediswmail.ad.cirrus.com> (raw) In-Reply-To: <871qwf0x8t.wl-tiwai@suse.de> On Fri, May 27, 2022 at 06:13:38PM +0200, Takashi Iwai wrote: > On Wed, 25 May 2022 15:16:21 +0200, > Vitaly Rodionov wrote: > The idea to add / delete controls by the control element change > doesn't sound good; as already mentioned in my reply to the previous > patch set, the change of the control elements can be triggered too > easily by any normal users who have the access to the sound devices. > It means thousands of additions and removals per second could be > attacked by any user. > This I am a little less sure how we handle. I mean arn't there already a few ways to do this? Both the existing ASoC wm_adsp stuff, and the topology stuff (used on all new Intel platforms, so very widely deployed) let you create controls by loading a firmware file. Also within ALSA itself can't user-space create user ALSA controls? Is there some rate limiting on that? How is this issue tackled there? > Moreover, the new controls with TLV controls don't look following the > standard TLV syntax (type-length-value). My previous questions about > the TLV usages are still unanswered, so I'm not sure what impact this > would have, though. At least, alsactl behavior must be checked > beforehand. If this is really device-specific (non-)TLV usages, it has > to be clearly documented. > The TLV stuff should be completely removed once my latest comments have been updated. I don't think we need this for the amps and I would also rather keep the usage to a minimum until one of us finally gets around to resolving the large control issues in a way that is more acceptable to everyone (likely with a new IOCTL). Thanks, Charles
next prev parent reply other threads:[~2022-05-30 9:09 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-25 13:16 [PATCH v4 00/17] ALSA: hda: cirrus: Add initial DSP support and firmware loading Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 01/17] ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS_DSP ALSA controls Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-26 9:30 ` Charles Keepax 2022-05-26 9:30 ` Charles Keepax 2022-05-25 13:16 ` [PATCH v4 02/17] ALSA: hda: hda_cs_dsp_ctl: Add apis to write the controls directly Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-26 9:36 ` Charles Keepax 2022-05-26 9:36 ` Charles Keepax 2022-05-25 13:16 ` [PATCH v4 03/17] ALSA: hda: cs35l41: Save codec object inside component struct Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 04/17] ALSA: hda: cs35l41: Add initial DSP support and firmware loading Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 05/17] ALSA: hda: cs35l41: Save Subsystem ID inside CS35L41 Driver Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 06/17] ALSA: hda: cs35l41: Support reading subsystem id from ACPI Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 07/17] ALSA: hda: cs35l41: Support multiple load paths for firmware Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 08/17] ALSA: hda: cs35l41: Support Speaker ID for laptops Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 09/17] ASoC: cs35l41: Move cs35l41 exit hibernate function into shared code Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 10/17] ASoC: cs35l41: Do not print error when waking from hibernation Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-26 9:08 ` Charles Keepax 2022-05-26 9:08 ` Charles Keepax 2022-05-25 13:16 ` [PATCH v4 11/17] ASoC: cs35l41: Add common cs35l41 enter hibernate function Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 12/17] ALSA: hda: cs35l41: Support Hibernation during Suspend Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 13/17] ALSA: hda: cs35l41: Read Speaker Calibration data from UEFI variables Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 14/17] ALSA: hda: hda_cs_dsp_ctl: Add fw id strings Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 15/17] ALSA: hda: cs35l41: Add defaulted values into dsp bypass config sequence Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 16/17] ALSA: hda: cs35l41: Support Firmware switching and reloading Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-30 11:31 ` Jaroslav Kysela 2022-05-30 11:31 ` Jaroslav Kysela 2022-05-25 13:16 ` [PATCH v4 17/17] ALSA: hda: cs35l41: Add module parameter to control firmware load Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-27 16:13 ` [PATCH v4 00/17] ALSA: hda: cirrus: Add initial DSP support and firmware loading Takashi Iwai 2022-05-27 16:13 ` Takashi Iwai 2022-05-30 9:08 ` Charles Keepax [this message] 2022-05-30 9:08 ` Charles Keepax 2022-05-30 9:18 ` Takashi Iwai 2022-05-30 9:18 ` Takashi Iwai 2022-05-30 9:36 ` Charles Keepax 2022-05-30 9:36 ` Charles Keepax 2022-05-30 10:14 ` Takashi Iwai 2022-05-30 10:14 ` Takashi Iwai 2022-05-30 10:34 ` Charles Keepax 2022-05-30 10:34 ` Charles Keepax 2022-05-30 10:45 ` Takashi Iwai 2022-05-30 10:45 ` Takashi Iwai 2022-05-30 10:53 ` Charles Keepax 2022-05-30 10:53 ` Charles Keepax 2022-05-30 11:07 ` Takashi Iwai 2022-05-30 11:07 ` Takashi Iwai 2022-05-30 11:40 ` Jaroslav Kysela 2022-05-30 11:40 ` Jaroslav Kysela 2022-06-01 16:43 ` Richard Fitzgerald 2022-06-01 16:43 ` Richard Fitzgerald 2022-06-01 19:13 ` Takashi Iwai 2022-06-01 19:13 ` Takashi Iwai 2022-06-07 10:55 ` (subset) " Mark Brown 2022-06-07 10:55 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220530090846.GS38351@ediswmail.ad.cirrus.com \ --to=ckeepax@opensource.cirrus.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=patches@opensource.cirrus.com \ --cc=perex@perex.cz \ --cc=tiwai@suse.com \ --cc=tiwai@suse.de \ --cc=vitalyr@opensource.cirrus.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.