From: Takashi Iwai <tiwai@suse.de> To: Charles Keepax <ckeepax@opensource.cirrus.com> Cc: alsa-devel@alsa-project.org, Vitaly Rodionov <vitalyr@opensource.cirrus.com>, patches@opensource.cirrus.com, Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 00/17] ALSA: hda: cirrus: Add initial DSP support and firmware loading Date: Mon, 30 May 2022 12:45:08 +0200 [thread overview] Message-ID: <871qwbxpsb.wl-tiwai@suse.de> (raw) In-Reply-To: <20220530103415.GU38351@ediswmail.ad.cirrus.com> On Mon, 30 May 2022 12:34:15 +0200, Charles Keepax wrote: > > On Mon, May 30, 2022 at 12:14:26PM +0200, Takashi Iwai wrote: > > On Mon, 30 May 2022 11:36:39 +0200, > > Charles Keepax wrote: > > > On Mon, May 30, 2022 at 11:18:43AM +0200, Takashi Iwai wrote: > > > > On Mon, 30 May 2022 11:08:46 +0200, > > > > Charles Keepax wrote: > > > > > On Fri, May 27, 2022 at 06:13:38PM +0200, Takashi Iwai wrote: > > > > > > On Wed, 25 May 2022 15:16:21 +0200, > > > > > > Vitaly Rodionov wrote: > > > Yeah that should be what is happening here. Although it looks > > > like this code might be removing all the controls if the firmware > > > is unloaded. I will discuss that with the guys, we normal just > > > disable the controls on the wm_adsp stuff. > > > > OK, that sounds good. Basically my concern came up from the code > > snippet doing asynchronous addition/removal via work. This showed > > some yellow signal, as such a pattern doesn't appear in the normal > > implementation. If this is (still) really necessary, it has to be > > clarified as an exception. > > > > Hm... ok we will think about that. I think that part will > probably still be necessary. Because there is an ALSA control > that selects the firmware, then it is necesarry to defer creating > the controls to some work, since you are already holding the > lock. Well, if an ALSA control can trigger the firmware loading, that's already fragile. A firmware loading is a heavy task, which should happen only at probing and/or resuming in general. Do we have other drivers doing the f/w loading triggered by a kctl...? > I guess we could look at adding locked versions of the add > control functions as well if that might be preferred? If the patterns of additional kctls (specific for firmware?) are fixed, we may create all such kctls beforehand and let them inactive unless the corresponding firmware is really loaded, too. thanks, Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de> To: Charles Keepax <ckeepax@opensource.cirrus.com> Cc: Vitaly Rodionov <vitalyr@opensource.cirrus.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>, <alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v4 00/17] ALSA: hda: cirrus: Add initial DSP support and firmware loading Date: Mon, 30 May 2022 12:45:08 +0200 [thread overview] Message-ID: <871qwbxpsb.wl-tiwai@suse.de> (raw) In-Reply-To: <20220530103415.GU38351@ediswmail.ad.cirrus.com> On Mon, 30 May 2022 12:34:15 +0200, Charles Keepax wrote: > > On Mon, May 30, 2022 at 12:14:26PM +0200, Takashi Iwai wrote: > > On Mon, 30 May 2022 11:36:39 +0200, > > Charles Keepax wrote: > > > On Mon, May 30, 2022 at 11:18:43AM +0200, Takashi Iwai wrote: > > > > On Mon, 30 May 2022 11:08:46 +0200, > > > > Charles Keepax wrote: > > > > > On Fri, May 27, 2022 at 06:13:38PM +0200, Takashi Iwai wrote: > > > > > > On Wed, 25 May 2022 15:16:21 +0200, > > > > > > Vitaly Rodionov wrote: > > > Yeah that should be what is happening here. Although it looks > > > like this code might be removing all the controls if the firmware > > > is unloaded. I will discuss that with the guys, we normal just > > > disable the controls on the wm_adsp stuff. > > > > OK, that sounds good. Basically my concern came up from the code > > snippet doing asynchronous addition/removal via work. This showed > > some yellow signal, as such a pattern doesn't appear in the normal > > implementation. If this is (still) really necessary, it has to be > > clarified as an exception. > > > > Hm... ok we will think about that. I think that part will > probably still be necessary. Because there is an ALSA control > that selects the firmware, then it is necesarry to defer creating > the controls to some work, since you are already holding the > lock. Well, if an ALSA control can trigger the firmware loading, that's already fragile. A firmware loading is a heavy task, which should happen only at probing and/or resuming in general. Do we have other drivers doing the f/w loading triggered by a kctl...? > I guess we could look at adding locked versions of the add > control functions as well if that might be preferred? If the patterns of additional kctls (specific for firmware?) are fixed, we may create all such kctls beforehand and let them inactive unless the corresponding firmware is really loaded, too. thanks, Takashi
next prev parent reply other threads:[~2022-05-30 10:46 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-25 13:16 [PATCH v4 00/17] ALSA: hda: cirrus: Add initial DSP support and firmware loading Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 01/17] ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS_DSP ALSA controls Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-26 9:30 ` Charles Keepax 2022-05-26 9:30 ` Charles Keepax 2022-05-25 13:16 ` [PATCH v4 02/17] ALSA: hda: hda_cs_dsp_ctl: Add apis to write the controls directly Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-26 9:36 ` Charles Keepax 2022-05-26 9:36 ` Charles Keepax 2022-05-25 13:16 ` [PATCH v4 03/17] ALSA: hda: cs35l41: Save codec object inside component struct Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 04/17] ALSA: hda: cs35l41: Add initial DSP support and firmware loading Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 05/17] ALSA: hda: cs35l41: Save Subsystem ID inside CS35L41 Driver Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 06/17] ALSA: hda: cs35l41: Support reading subsystem id from ACPI Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 07/17] ALSA: hda: cs35l41: Support multiple load paths for firmware Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 08/17] ALSA: hda: cs35l41: Support Speaker ID for laptops Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 09/17] ASoC: cs35l41: Move cs35l41 exit hibernate function into shared code Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 10/17] ASoC: cs35l41: Do not print error when waking from hibernation Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-26 9:08 ` Charles Keepax 2022-05-26 9:08 ` Charles Keepax 2022-05-25 13:16 ` [PATCH v4 11/17] ASoC: cs35l41: Add common cs35l41 enter hibernate function Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 12/17] ALSA: hda: cs35l41: Support Hibernation during Suspend Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 13/17] ALSA: hda: cs35l41: Read Speaker Calibration data from UEFI variables Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 14/17] ALSA: hda: hda_cs_dsp_ctl: Add fw id strings Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 15/17] ALSA: hda: cs35l41: Add defaulted values into dsp bypass config sequence Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-25 13:16 ` [PATCH v4 16/17] ALSA: hda: cs35l41: Support Firmware switching and reloading Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-30 11:31 ` Jaroslav Kysela 2022-05-30 11:31 ` Jaroslav Kysela 2022-05-25 13:16 ` [PATCH v4 17/17] ALSA: hda: cs35l41: Add module parameter to control firmware load Vitaly Rodionov 2022-05-25 13:16 ` Vitaly Rodionov 2022-05-27 16:13 ` [PATCH v4 00/17] ALSA: hda: cirrus: Add initial DSP support and firmware loading Takashi Iwai 2022-05-27 16:13 ` Takashi Iwai 2022-05-30 9:08 ` Charles Keepax 2022-05-30 9:08 ` Charles Keepax 2022-05-30 9:18 ` Takashi Iwai 2022-05-30 9:18 ` Takashi Iwai 2022-05-30 9:36 ` Charles Keepax 2022-05-30 9:36 ` Charles Keepax 2022-05-30 10:14 ` Takashi Iwai 2022-05-30 10:14 ` Takashi Iwai 2022-05-30 10:34 ` Charles Keepax 2022-05-30 10:34 ` Charles Keepax 2022-05-30 10:45 ` Takashi Iwai [this message] 2022-05-30 10:45 ` Takashi Iwai 2022-05-30 10:53 ` Charles Keepax 2022-05-30 10:53 ` Charles Keepax 2022-05-30 11:07 ` Takashi Iwai 2022-05-30 11:07 ` Takashi Iwai 2022-05-30 11:40 ` Jaroslav Kysela 2022-05-30 11:40 ` Jaroslav Kysela 2022-06-01 16:43 ` Richard Fitzgerald 2022-06-01 16:43 ` Richard Fitzgerald 2022-06-01 19:13 ` Takashi Iwai 2022-06-01 19:13 ` Takashi Iwai 2022-06-07 10:55 ` (subset) " Mark Brown 2022-06-07 10:55 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=871qwbxpsb.wl-tiwai@suse.de \ --to=tiwai@suse.de \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=ckeepax@opensource.cirrus.com \ --cc=linux-kernel@vger.kernel.org \ --cc=patches@opensource.cirrus.com \ --cc=tiwai@suse.com \ --cc=vitalyr@opensource.cirrus.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.