From: Miaoqian Lin <linmq006@gmail.com> To: Liviu Dudau <liviu.dudau@arm.com>, Sudeep Holla <sudeep.holla@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Miaoqian Lin <linmq006@gmail.com>, Rob Herring <robh@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] bus: vexpress-config: Fix refcount leak in vexpress_syscfg_probe Date: Thu, 2 Jun 2022 15:24:26 +0400 [thread overview] Message-ID: <20220602112428.3002-1-linmq006@gmail.com> (raw) of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: a5a38765ac79 ("bus: vexpress-config: simplify config bus probing") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/bus/vexpress-config.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c index a58ac0c8e282..b368e2f01f8b 100644 --- a/drivers/bus/vexpress-config.c +++ b/drivers/bus/vexpress-config.c @@ -395,10 +395,13 @@ static int vexpress_syscfg_probe(struct platform_device *pdev) struct device_node *bridge_np; bridge_np = of_parse_phandle(node, "arm,vexpress,config-bridge", 0); - if (bridge_np != pdev->dev.parent->of_node) + if (bridge_np != pdev->dev.parent->of_node) { + of_node_put(bridge_np); continue; + } of_platform_populate(node, NULL, NULL, &pdev->dev); + of_node_put(bridge_np); } return 0; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Miaoqian Lin <linmq006@gmail.com> To: Liviu Dudau <liviu.dudau@arm.com>, Sudeep Holla <sudeep.holla@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Miaoqian Lin <linmq006@gmail.com>, Rob Herring <robh@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] bus: vexpress-config: Fix refcount leak in vexpress_syscfg_probe Date: Thu, 2 Jun 2022 15:24:26 +0400 [thread overview] Message-ID: <20220602112428.3002-1-linmq006@gmail.com> (raw) of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: a5a38765ac79 ("bus: vexpress-config: simplify config bus probing") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/bus/vexpress-config.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c index a58ac0c8e282..b368e2f01f8b 100644 --- a/drivers/bus/vexpress-config.c +++ b/drivers/bus/vexpress-config.c @@ -395,10 +395,13 @@ static int vexpress_syscfg_probe(struct platform_device *pdev) struct device_node *bridge_np; bridge_np = of_parse_phandle(node, "arm,vexpress,config-bridge", 0); - if (bridge_np != pdev->dev.parent->of_node) + if (bridge_np != pdev->dev.parent->of_node) { + of_node_put(bridge_np); continue; + } of_platform_populate(node, NULL, NULL, &pdev->dev); + of_node_put(bridge_np); } return 0; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2022-06-02 11:24 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-02 11:24 Miaoqian Lin [this message] 2022-06-02 11:24 ` [PATCH] bus: vexpress-config: Fix refcount leak in vexpress_syscfg_probe Miaoqian Lin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220602112428.3002-1-linmq006@gmail.com \ --to=linmq006@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=liviu.dudau@arm.com \ --cc=lorenzo.pieralisi@arm.com \ --cc=robh@kernel.org \ --cc=sudeep.holla@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.