* [PATCH 0/2] Update external mclk name
@ 2022-06-02 11:26 Srinivasa Rao Mandadapu
2022-06-02 11:26 ` [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name Srinivasa Rao Mandadapu
2022-06-02 11:26 ` [PATCH 2/2] ASoC: qcom: lpass-sc7280: Update external mclk0 name Srinivasa Rao Mandadapu
0 siblings, 2 replies; 9+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-06-02 11:26 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, quic_rohkumar,
linux-arm-msm, alsa-devel, linux-kernel, swboyd, judyhsiao,
devicetree
Cc: Srinivasa Rao Mandadapu
This patch set is to update external mclk name.
Srinivasa Rao Mandadapu (2):
ASoC: dt-bindings: lpass-cpu: Update external mclck0 name
ASoC: qcom: lpass-sc7280: Update external mclk0 name
Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml | 2 +-
sound/soc/qcom/lpass-sc7280.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name
2022-06-02 11:26 [PATCH 0/2] Update external mclk name Srinivasa Rao Mandadapu
@ 2022-06-02 11:26 ` Srinivasa Rao Mandadapu
2022-06-02 14:32 ` Rob Herring
2022-06-02 11:26 ` [PATCH 2/2] ASoC: qcom: lpass-sc7280: Update external mclk0 name Srinivasa Rao Mandadapu
1 sibling, 1 reply; 9+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-06-02 11:26 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, quic_rohkumar,
linux-arm-msm, alsa-devel, linux-kernel, swboyd, judyhsiao,
devicetree
Cc: Srinivasa Rao Mandadapu
Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0",
as MI2S mclk is being used is from lpass core cc.
Fixes: 98b7630a583f ("ASoC: dt-bindings: lpass-cpu: Update clocks and power domain names for sc7280 platform")
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
---
Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
index e9a5330..8438ef77 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
@@ -195,7 +195,7 @@ allOf:
oneOf:
- items: #for I2S
- const: aon_cc_audio_hm_h
- - const: audio_cc_ext_mclk0
+ - const: core_cc_ext_mclk0
- const: core_cc_sysnoc_mport_core
- const: core_cc_ext_if0_ibit
- const: core_cc_ext_if1_ibit
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name
2022-06-02 11:26 ` [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name Srinivasa Rao Mandadapu
@ 2022-06-02 14:32 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2022-06-02 14:32 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: agross, bjorn.andersson, lgirdwood, broonie, quic_plai, bgoswami,
perex, tiwai, srinivas.kandagatla, quic_rohkumar, linux-arm-msm,
alsa-devel, linux-kernel, swboyd, judyhsiao, devicetree
On Thu, Jun 02, 2022 at 04:56:45PM +0530, Srinivasa Rao Mandadapu wrote:
> Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0",
> as MI2S mclk is being used is from lpass core cc.
This is safe to change breaking the ABI because ...
Names are supposed to be local to the module, not based on their source.
>
> Fixes: 98b7630a583f ("ASoC: dt-bindings: lpass-cpu: Update clocks and power domain names for sc7280 platform")
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> ---
> Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> index e9a5330..8438ef77 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> @@ -195,7 +195,7 @@ allOf:
> oneOf:
> - items: #for I2S
> - const: aon_cc_audio_hm_h
> - - const: audio_cc_ext_mclk0
> + - const: core_cc_ext_mclk0
> - const: core_cc_sysnoc_mport_core
> - const: core_cc_ext_if0_ibit
> - const: core_cc_ext_if1_ibit
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name
@ 2022-06-02 14:32 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2022-06-02 14:32 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: devicetree, alsa-devel, quic_rohkumar, linux-arm-msm, swboyd,
tiwai, agross, lgirdwood, broonie, srinivas.kandagatla, bgoswami,
quic_plai, bjorn.andersson, judyhsiao, linux-kernel
On Thu, Jun 02, 2022 at 04:56:45PM +0530, Srinivasa Rao Mandadapu wrote:
> Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0",
> as MI2S mclk is being used is from lpass core cc.
This is safe to change breaking the ABI because ...
Names are supposed to be local to the module, not based on their source.
>
> Fixes: 98b7630a583f ("ASoC: dt-bindings: lpass-cpu: Update clocks and power domain names for sc7280 platform")
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> ---
> Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> index e9a5330..8438ef77 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> @@ -195,7 +195,7 @@ allOf:
> oneOf:
> - items: #for I2S
> - const: aon_cc_audio_hm_h
> - - const: audio_cc_ext_mclk0
> + - const: core_cc_ext_mclk0
> - const: core_cc_sysnoc_mport_core
> - const: core_cc_ext_if0_ibit
> - const: core_cc_ext_if1_ibit
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name
2022-06-02 14:32 ` Rob Herring
@ 2022-06-02 14:40 ` Mark Brown
-1 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2022-06-02 14:40 UTC (permalink / raw)
To: Rob Herring
Cc: Srinivasa Rao Mandadapu, agross, bjorn.andersson, lgirdwood,
quic_plai, bgoswami, perex, tiwai, srinivas.kandagatla,
quic_rohkumar, linux-arm-msm, alsa-devel, linux-kernel, swboyd,
judyhsiao, devicetree
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
On Thu, Jun 02, 2022 at 09:32:45AM -0500, Rob Herring wrote:
> On Thu, Jun 02, 2022 at 04:56:45PM +0530, Srinivasa Rao Mandadapu wrote:
> > Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0",
> > as MI2S mclk is being used is from lpass core cc.
> This is safe to change breaking the ABI because ...
The driver was only just merged so didn't make it into a full
release.
> Names are supposed to be local to the module, not based on their source.
Indeed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name
@ 2022-06-02 14:40 ` Mark Brown
0 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2022-06-02 14:40 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, alsa-devel, quic_rohkumar, linux-arm-msm, swboyd,
tiwai, lgirdwood, bjorn.andersson, agross, srinivas.kandagatla,
bgoswami, quic_plai, judyhsiao, linux-kernel,
Srinivasa Rao Mandadapu
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
On Thu, Jun 02, 2022 at 09:32:45AM -0500, Rob Herring wrote:
> On Thu, Jun 02, 2022 at 04:56:45PM +0530, Srinivasa Rao Mandadapu wrote:
> > Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0",
> > as MI2S mclk is being used is from lpass core cc.
> This is safe to change breaking the ABI because ...
The driver was only just merged so didn't make it into a full
release.
> Names are supposed to be local to the module, not based on their source.
Indeed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name
2022-06-02 14:40 ` Mark Brown
@ 2022-06-13 10:55 ` Srinivasa Rao Mandadapu
-1 siblings, 0 replies; 9+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-06-13 10:55 UTC (permalink / raw)
To: Mark Brown, Rob Herring
Cc: devicetree, alsa-devel, quic_rohkumar, linux-arm-msm, swboyd,
tiwai, lgirdwood, agross, srinivas.kandagatla, bgoswami,
quic_plai, bjorn.andersson, judyhsiao, linux-kernel
On 6/2/2022 8:10 PM, Mark Brown wrote:
Thanks for your time Mark Brown and Rob Herring!!!
> On Thu, Jun 02, 2022 at 09:32:45AM -0500, Rob Herring wrote:
>> On Thu, Jun 02, 2022 at 04:56:45PM +0530, Srinivasa Rao Mandadapu wrote:
>>> Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0",
>>> as MI2S mclk is being used is from lpass core cc.
>> This is safe to change breaking the ABI because ...
> The driver was only just merged so didn't make it into a full
> release.
yes. DTS changes are still in review state.
>
>> Names are supposed to be local to the module, not based on their source.
> Indeed.
Okay. Will take care next time. As external MCLK is supported from both
modules, audio cc and core cc,
for now it's mandatory to change the name to avoid confusion.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name
@ 2022-06-13 10:55 ` Srinivasa Rao Mandadapu
0 siblings, 0 replies; 9+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-06-13 10:55 UTC (permalink / raw)
To: Mark Brown, Rob Herring
Cc: agross, bjorn.andersson, lgirdwood, quic_plai, bgoswami, perex,
tiwai, srinivas.kandagatla, quic_rohkumar, linux-arm-msm,
alsa-devel, linux-kernel, swboyd, judyhsiao, devicetree
On 6/2/2022 8:10 PM, Mark Brown wrote:
Thanks for your time Mark Brown and Rob Herring!!!
> On Thu, Jun 02, 2022 at 09:32:45AM -0500, Rob Herring wrote:
>> On Thu, Jun 02, 2022 at 04:56:45PM +0530, Srinivasa Rao Mandadapu wrote:
>>> Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0",
>>> as MI2S mclk is being used is from lpass core cc.
>> This is safe to change breaking the ABI because ...
> The driver was only just merged so didn't make it into a full
> release.
yes. DTS changes are still in review state.
>
>> Names are supposed to be local to the module, not based on their source.
> Indeed.
Okay. Will take care next time. As external MCLK is supported from both
modules, audio cc and core cc,
for now it's mandatory to change the name to avoid confusion.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] ASoC: qcom: lpass-sc7280: Update external mclk0 name
2022-06-02 11:26 [PATCH 0/2] Update external mclk name Srinivasa Rao Mandadapu
2022-06-02 11:26 ` [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name Srinivasa Rao Mandadapu
@ 2022-06-02 11:26 ` Srinivasa Rao Mandadapu
1 sibling, 0 replies; 9+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-06-02 11:26 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, quic_rohkumar,
linux-arm-msm, alsa-devel, linux-kernel, swboyd, judyhsiao,
devicetree
Cc: Srinivasa Rao Mandadapu
Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0",
as MI2S mclk is being used is from lpass core cc.
Fixes: b62c4e5fba2f ("ASoC: qcom: lpass-sc7280: Add platform driver for lpass audio")
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
---
sound/soc/qcom/lpass-sc7280.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-sc7280.c b/sound/soc/qcom/lpass-sc7280.c
index 70c4df8..e65bf7e 100644
--- a/sound/soc/qcom/lpass-sc7280.c
+++ b/sound/soc/qcom/lpass-sc7280.c
@@ -403,7 +403,7 @@ static struct lpass_variant sc7280_data = {
.dai_driver = sc7280_lpass_cpu_dai_driver,
.num_dai = ARRAY_SIZE(sc7280_lpass_cpu_dai_driver),
.dai_osr_clk_names = (const char *[]) {
- "audio_cc_ext_mclk0",
+ "core_cc_ext_mclk0",
"null"
},
.dai_bit_clk_names = (const char *[]) {
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-06-13 11:56 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-02 11:26 [PATCH 0/2] Update external mclk name Srinivasa Rao Mandadapu
2022-06-02 11:26 ` [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name Srinivasa Rao Mandadapu
2022-06-02 14:32 ` Rob Herring
2022-06-02 14:32 ` Rob Herring
2022-06-02 14:40 ` Mark Brown
2022-06-02 14:40 ` Mark Brown
2022-06-13 10:55 ` Srinivasa Rao Mandadapu
2022-06-13 10:55 ` Srinivasa Rao Mandadapu
2022-06-02 11:26 ` [PATCH 2/2] ASoC: qcom: lpass-sc7280: Update external mclk0 name Srinivasa Rao Mandadapu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.