Re: [PATCH v2 06/12] drm/msm/hdmi: drop unused GPIO support

From: kernel test robot <lkp@intel.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Stephen Boyd <swboyd@chromium.org>,
	freedreno@lists.freedesktop.org
Subject: Re: [PATCH v2 06/12] drm/msm/hdmi: drop unused GPIO support
Date: Wed, 8 Jun 2022 23:57:36 +0800	[thread overview]
Message-ID: <202206082312.XB745jWy-lkp@intel.com> (raw)
In-Reply-To: <20220608120723.2987843-7-dmitry.baryshkov@linaro.org>

Hi Dmitry,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm/drm-next]
[also build test WARNING on robh/for-next linus/master v5.19-rc1 next-20220608]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Dmitry-Baryshkov/drm-msm-hdmi-YAML-ify-schema-and-cleanup-some-platform-properties/20220608-200925
base:   git://anongit.freedesktop.org/drm/drm drm-next
config: hexagon-randconfig-r045-20220608 (https://download.01.org/0day-ci/archive/20220608/202206082312.XB745jWy-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b92436efcb7813fc481b30f2593a4907568d917a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/c3e263fe0a077b382c2a76911c8ace385bd59a4c
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Dmitry-Baryshkov/drm-msm-hdmi-YAML-ify-schema-and-cleanup-some-platform-properties/20220608-200925
        git checkout c3e263fe0a077b382c2a76911c8ace385bd59a4c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/gpu/drm/msm/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/msm/hdmi/hdmi.c:532:2: warning: variable 'hdmi' is uninitialized when used here [-Wuninitialized]
           hdmi->hpd_gpiod = devm_gpiod_get_optional(dev, "hpd", GPIOD_IN);
           ^~~~
   drivers/gpu/drm/msm/hdmi/hdmi.c:518:19: note: initialize the variable 'hdmi' to silence this warning
           struct hdmi *hdmi;
                            ^
                             = NULL
   1 warning generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS
   Depends on HAS_IOMEM && DRM && OF
   Selected by
   - DRM_MSM && HAS_IOMEM && DRM && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST && COMMON_CLK && IOMMU_SUPPORT && (QCOM_OCMEM || QCOM_OCMEM && (QCOM_LLCC || QCOM_LLCC && (QCOM_COMMAND_DB || QCOM_COMMAND_DB

vim +/hdmi +532 drivers/gpu/drm/msm/hdmi/hdmi.c

   513	
   514	static int msm_hdmi_bind(struct device *dev, struct device *master, void *data)
   515	{
   516		struct msm_drm_private *priv = dev_get_drvdata(master);
   517		struct hdmi_platform_config *hdmi_cfg;
   518		struct hdmi *hdmi;
   519		struct device_node *of_node = dev->of_node;
   520		int err;
   521	
   522		hdmi_cfg = (struct hdmi_platform_config *)
   523				of_device_get_match_data(dev);
   524		if (!hdmi_cfg) {
   525			DRM_DEV_ERROR(dev, "unknown hdmi_cfg: %pOFn\n", of_node);
   526			return -ENXIO;
   527		}
   528	
   529		hdmi_cfg->mmio_name     = "core_physical";
   530		hdmi_cfg->qfprom_mmio_name = "qfprom_physical";
   531	
 > 532		hdmi->hpd_gpiod = devm_gpiod_get_optional(dev, "hpd", GPIOD_IN);
   533		/* This will catch e.g. -PROBE_DEFER */
   534		if (IS_ERR(hdmi->hpd_gpiod))
   535			return PTR_ERR(hdmi->hpd_gpiod);
   536	
   537		if (!hdmi->hpd_gpiod)
   538			DBG("failed to get HPD gpio");
   539	
   540		if (hdmi->hpd_gpiod)
   541			gpiod_set_consumer_name(hdmi->hpd_gpiod, "HDMI_HPD");
   542	
   543		dev->platform_data = hdmi_cfg;
   544	
   545		hdmi = msm_hdmi_init(to_platform_device(dev));
   546		if (IS_ERR(hdmi))
   547			return PTR_ERR(hdmi);
   548		priv->hdmi = hdmi;
   549	
   550		err = msm_hdmi_register_audio_driver(hdmi, dev);
   551		if (err) {
   552			DRM_ERROR("Failed to attach an audio codec %d\n", err);
   553			hdmi->audio_pdev = NULL;
   554		}
   555	
   556		return 0;
   557	}
   558	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp