From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Stephen Boyd <swboyd@chromium.org>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Clark <robdclark@gmail.com>, Rob Herring <robh+dt@kernel.org>, Sean Paul <sean@poorly.run> Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v2 06/12] drm/msm/hdmi: drop unused GPIO support Date: Thu, 9 Jun 2022 09:27:02 +0300 [thread overview] Message-ID: <89941420-717a-c311-54fe-cd8fcd0b0a06@linaro.org> (raw) In-Reply-To: <CAE-0n53z_nWsgVVn-4LbsP1GuzTgCa+DDDDE0y8k3+s-t=eSBA@mail.gmail.com> On 08/06/2022 23:59, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2022-06-08 05:07:17) >> @@ -543,41 +529,16 @@ static int msm_hdmi_bind(struct device *dev, struct device *master, void *data) >> hdmi_cfg->mmio_name = "core_physical"; >> hdmi_cfg->qfprom_mmio_name = "qfprom_physical"; >> >> - for (i = 0; i < HDMI_MAX_NUM_GPIO; i++) { > [...] >> - if (gpiod) >> - gpiod_set_consumer_name(gpiod, msm_hdmi_gpio_pdata[i].label); >> - hdmi_cfg->gpios[i].output = msm_hdmi_gpio_pdata[i].output; >> - hdmi_cfg->gpios[i].value = msm_hdmi_gpio_pdata[i].value; >> - } >> + hdmi->hpd_gpiod = devm_gpiod_get_optional(dev, "hpd", GPIOD_IN); >> + /* This will catch e.g. -PROBE_DEFER */ > > EPROBE_DEFER? Ack. > >> + if (IS_ERR(hdmi->hpd_gpiod)) >> + return PTR_ERR(hdmi->hpd_gpiod); >> + >> + if (!hdmi->hpd_gpiod) >> + DBG("failed to get HPD gpio"); > > Does DBG() add newlines? Yes, it does. > >> + >> + if (hdmi->hpd_gpiod) >> + gpiod_set_consumer_name(hdmi->hpd_gpiod, "HDMI_HPD"); >> >> dev->platform_data = hdmi_cfg; >> -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Stephen Boyd <swboyd@chromium.org>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Clark <robdclark@gmail.com>, Rob Herring <robh+dt@kernel.org>, Sean Paul <sean@poorly.run> Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v2 06/12] drm/msm/hdmi: drop unused GPIO support Date: Thu, 9 Jun 2022 09:27:02 +0300 [thread overview] Message-ID: <89941420-717a-c311-54fe-cd8fcd0b0a06@linaro.org> (raw) In-Reply-To: <CAE-0n53z_nWsgVVn-4LbsP1GuzTgCa+DDDDE0y8k3+s-t=eSBA@mail.gmail.com> On 08/06/2022 23:59, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2022-06-08 05:07:17) >> @@ -543,41 +529,16 @@ static int msm_hdmi_bind(struct device *dev, struct device *master, void *data) >> hdmi_cfg->mmio_name = "core_physical"; >> hdmi_cfg->qfprom_mmio_name = "qfprom_physical"; >> >> - for (i = 0; i < HDMI_MAX_NUM_GPIO; i++) { > [...] >> - if (gpiod) >> - gpiod_set_consumer_name(gpiod, msm_hdmi_gpio_pdata[i].label); >> - hdmi_cfg->gpios[i].output = msm_hdmi_gpio_pdata[i].output; >> - hdmi_cfg->gpios[i].value = msm_hdmi_gpio_pdata[i].value; >> - } >> + hdmi->hpd_gpiod = devm_gpiod_get_optional(dev, "hpd", GPIOD_IN); >> + /* This will catch e.g. -PROBE_DEFER */ > > EPROBE_DEFER? Ack. > >> + if (IS_ERR(hdmi->hpd_gpiod)) >> + return PTR_ERR(hdmi->hpd_gpiod); >> + >> + if (!hdmi->hpd_gpiod) >> + DBG("failed to get HPD gpio"); > > Does DBG() add newlines? Yes, it does. > >> + >> + if (hdmi->hpd_gpiod) >> + gpiod_set_consumer_name(hdmi->hpd_gpiod, "HDMI_HPD"); >> >> dev->platform_data = hdmi_cfg; >> -- With best wishes Dmitry
next prev parent reply other threads:[~2022-06-09 6:27 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-08 12:07 [PATCH v2 00/12] drm/msm/hdmi: YAML-ify schema and cleanup some platform properties Dmitry Baryshkov 2022-06-08 12:07 ` Dmitry Baryshkov 2022-06-08 12:07 ` [PATCH v2 01/12] dt-bindings: display/msm: hdmi: split and convert to yaml Dmitry Baryshkov 2022-06-08 12:07 ` Dmitry Baryshkov 2022-06-08 12:37 ` Krzysztof Kozlowski 2022-06-08 12:37 ` Krzysztof Kozlowski 2022-06-08 22:45 ` David Heidelberg 2022-06-08 22:45 ` David Heidelberg 2022-06-09 12:09 ` Dmitry Baryshkov 2022-06-09 12:09 ` Dmitry Baryshkov 2022-06-09 12:10 ` Dmitry Baryshkov 2022-06-09 12:10 ` Dmitry Baryshkov 2022-06-08 12:07 ` [PATCH v2 02/12] dt-bindings: display/msm: hdmi: mark old GPIO properties as deprecated Dmitry Baryshkov 2022-06-08 12:07 ` Dmitry Baryshkov 2022-06-08 12:37 ` Krzysztof Kozlowski 2022-06-08 12:37 ` Krzysztof Kozlowski 2022-06-08 20:56 ` Stephen Boyd 2022-06-08 20:56 ` Stephen Boyd 2022-06-08 12:07 ` [PATCH v2 03/12] dt-bindings: display/msm: hdmi: mark hdmi-mux-supply " Dmitry Baryshkov 2022-06-08 12:07 ` Dmitry Baryshkov 2022-06-08 12:38 ` Krzysztof Kozlowski 2022-06-08 12:38 ` Krzysztof Kozlowski 2022-06-08 20:56 ` Stephen Boyd 2022-06-08 20:56 ` Stephen Boyd 2022-06-08 12:07 ` [PATCH v2 04/12] arm: dts: qcom: apq8064-ifc6410: drop hdmi-mux-supply Dmitry Baryshkov 2022-06-08 12:07 ` Dmitry Baryshkov 2022-06-08 20:57 ` Stephen Boyd 2022-06-08 20:57 ` Stephen Boyd 2022-06-08 12:07 ` [PATCH v2 05/12] drm/msm/hdmi: drop the hdmi-mux support Dmitry Baryshkov 2022-06-08 12:07 ` Dmitry Baryshkov 2022-06-08 20:57 ` Stephen Boyd 2022-06-08 20:57 ` Stephen Boyd 2022-06-08 12:07 ` [PATCH v2 06/12] drm/msm/hdmi: drop unused GPIO support Dmitry Baryshkov 2022-06-08 12:07 ` Dmitry Baryshkov 2022-06-08 15:57 ` kernel test robot 2022-06-08 15:57 ` kernel test robot 2022-06-08 20:59 ` Stephen Boyd 2022-06-08 20:59 ` Stephen Boyd 2022-06-09 6:27 ` Dmitry Baryshkov [this message] 2022-06-09 6:27 ` Dmitry Baryshkov 2022-06-08 12:07 ` [PATCH v2 07/12] drm/msm/hdmi: enable core-vcc/core-vdda-supply for 8996 platform Dmitry Baryshkov 2022-06-08 12:07 ` Dmitry Baryshkov 2022-06-08 21:02 ` Stephen Boyd 2022-06-08 21:02 ` Stephen Boyd 2022-06-08 22:58 ` Dmitry Baryshkov 2022-06-08 22:58 ` Dmitry Baryshkov 2022-06-08 12:07 ` [PATCH v2 08/12] drm/msm/hdmi: drop empty 'none' regulator lists Dmitry Baryshkov 2022-06-08 12:07 ` Dmitry Baryshkov 2022-06-08 21:00 ` Stephen Boyd 2022-06-08 21:00 ` Stephen Boyd 2022-06-08 12:07 ` [PATCH v2 09/12] drm/msm/hdmi: drop hpd_regs usage on 8x74/8084 Dmitry Baryshkov 2022-06-08 12:07 ` Dmitry Baryshkov 2022-06-08 21:03 ` Stephen Boyd 2022-06-08 21:03 ` Stephen Boyd 2022-06-08 12:07 ` [PATCH v2 10/12] drm/msm/hdmi: merge platform config for 8974/8084/8994/8996 Dmitry Baryshkov 2022-06-08 12:07 ` Dmitry Baryshkov 2022-06-08 21:04 ` Stephen Boyd 2022-06-08 21:04 ` Stephen Boyd 2022-06-08 12:07 ` [PATCH v2 11/12] drm/msm/hdmi: reuse MSM8960's config for MSM8660 Dmitry Baryshkov 2022-06-08 12:07 ` Dmitry Baryshkov 2022-06-08 21:04 ` Stephen Boyd 2022-06-08 21:04 ` Stephen Boyd 2022-06-08 12:07 ` [PATCH v2 12/12] drm/msm/hdmi-phy: populate 8x60 HDMI PHY requirements Dmitry Baryshkov 2022-06-08 12:07 ` Dmitry Baryshkov 2022-06-08 21:05 ` Stephen Boyd 2022-06-08 21:05 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=89941420-717a-c311-54fe-cd8fcd0b0a06@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=agross@kernel.org \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.