[PATCH] drm/amdgpu: remove redundant enable_mes/enable_mes_kiq setting

[PATCH] drm/amdgpu: remove redundant enable_mes/enable_mes_kiq setting

[Yifan Zhang]

enable_mes and enable_mes_kiq are set in both device init and
MES IP init. Leave the ones in MES IP init, since it is
a more accurate way to judge from GC IP version.

Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 68a53528089f..2b92281dd0c1 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -3614,14 +3614,6 @@ int amdgpu_device_init(struct amdgpu_device *adev,
 	if (amdgpu_mcbp)
 		DRM_INFO("MCBP is enabled\n");
 
-	if (adev->asic_type >= CHIP_NAVI10) {
-		if (amdgpu_mes || amdgpu_mes_kiq)
-			adev->enable_mes = true;
-
-		if (amdgpu_mes_kiq)
-			adev->enable_mes_kiq = true;
-	}
-
 	/*
 	 * Reset domain needs to be present early, before XGMI hive discovered
 	 * (if any) and intitialized to use reset sem and in_gpu reset flag
-- 
2.35.1

Re: [PATCH] drm/amdgpu: remove redundant enable_mes/enable_mes_kiq setting

[Deucher, Alexander]

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

[Public]

Acked-by: Alex Deucher <alexander.deucher@amd.com>
________________________________
From: Zhang, Yifan <Yifan1.Zhang@amd.com>
Sent: Sunday, June 12, 2022 12:31 AM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>
Subject: [PATCH] drm/amdgpu: remove redundant enable_mes/enable_mes_kiq setting

enable_mes and enable_mes_kiq are set in both device init and
MES IP init. Leave the ones in MES IP init, since it is
a more accurate way to judge from GC IP version.

Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 68a53528089f..2b92281dd0c1 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -3614,14 +3614,6 @@ int amdgpu_device_init(struct amdgpu_device *adev,
         if (amdgpu_mcbp)
                 DRM_INFO("MCBP is enabled\n");

-       if (adev->asic_type >= CHIP_NAVI10) {
-               if (amdgpu_mes || amdgpu_mes_kiq)
-                       adev->enable_mes = true;
-
-               if (amdgpu_mes_kiq)
-                       adev->enable_mes_kiq = true;
-       }
-
         /*
          * Reset domain needs to be present early, before XGMI hive discovered
          * (if any) and intitialized to use reset sem and in_gpu reset flag
--
2.35.1


[-- Attachment #2: Type: text/html, Size: 3272 bytes --]

Re: [PATCH] drm/amdgpu: remove redundant enable_mes/enable_mes_kiq setting

[Xiao, Jack]

[-- Attachment #1: Type: text/plain, Size: 1670 bytes --]

[AMD Official Use Only - General]


Reviewed-by: Jack Xiao <Jack.Xiao@amd.com>

Regards,
Jack
________________________________
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Yifan Zhang <yifan1.zhang@amd.com>
Sent: Sunday, 12 June 2022 12:31
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>
Subject: [PATCH] drm/amdgpu: remove redundant enable_mes/enable_mes_kiq setting

enable_mes and enable_mes_kiq are set in both device init and
MES IP init. Leave the ones in MES IP init, since it is
a more accurate way to judge from GC IP version.

Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 68a53528089f..2b92281dd0c1 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -3614,14 +3614,6 @@ int amdgpu_device_init(struct amdgpu_device *adev,
         if (amdgpu_mcbp)
                 DRM_INFO("MCBP is enabled\n");

-       if (adev->asic_type >= CHIP_NAVI10) {
-               if (amdgpu_mes || amdgpu_mes_kiq)
-                       adev->enable_mes = true;
-
-               if (amdgpu_mes_kiq)
-                       adev->enable_mes_kiq = true;
-       }
-
         /*
          * Reset domain needs to be present early, before XGMI hive discovered
          * (if any) and intitialized to use reset sem and in_gpu reset flag
--
2.35.1


[-- Attachment #2: Type: text/html, Size: 3831 bytes --]