From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz
Date: Wed, 22 Jun 2022 08:51:55 +0200 [thread overview]
Message-ID: <20220622065155.uoo2matz36a45nfa@pengutronix.de> (raw)
In-Reply-To: <7d04c05771ded0f8302d716fa5289d94df27c8eb.camel@toradex.com>
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
On 22.06.2022 08:38:04, Andrejs Cainikovs wrote:
> > > > can1: can@0 {
> > > > compatible = "microchip,mcp251xfd";
> > > > - clocks = <&clk20m>;
> > > > + clocks = <&clk40m>;
> > > > interrupts-extended = <&gpio1 6
> > > > IRQ_TYPE_EDGE_FALLING>;
> >
> > You don't want to use an edge triggered interrupt with the mcp251xfd
> > chip. You will be losing interrupts, better use IRQ_TYPE_LEVEL_LOW.
>
> This particular change is not about interrupts.
Sure, I just noticed it.
> But thanks for a hint, I'll make sure this is addressed.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz
Date: Wed, 22 Jun 2022 08:51:55 +0200 [thread overview]
Message-ID: <20220622065155.uoo2matz36a45nfa@pengutronix.de> (raw)
In-Reply-To: <7d04c05771ded0f8302d716fa5289d94df27c8eb.camel@toradex.com>
[-- Attachment #1.1: Type: text/plain, Size: 978 bytes --]
On 22.06.2022 08:38:04, Andrejs Cainikovs wrote:
> > > > can1: can@0 {
> > > > compatible = "microchip,mcp251xfd";
> > > > - clocks = <&clk20m>;
> > > > + clocks = <&clk40m>;
> > > > interrupts-extended = <&gpio1 6
> > > > IRQ_TYPE_EDGE_FALLING>;
> >
> > You don't want to use an edge triggered interrupt with the mcp251xfd
> > chip. You will be losing interrupts, better use IRQ_TYPE_LEVEL_LOW.
>
> This particular change is not about interrupts.
Sure, I just noticed it.
> But thanks for a hint, I'll make sure this is addressed.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-22 6:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 10:40 [PATCH v1] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz Andrejs Cainikovs
2022-05-12 10:40 ` Andrejs Cainikovs
2022-05-12 13:41 ` Marcel Ziswiler
2022-05-12 13:41 ` Marcel Ziswiler
2022-06-21 18:07 ` Francesco Dolcini
2022-06-21 18:07 ` Francesco Dolcini
2022-06-21 19:50 ` Marc Kleine-Budde
2022-06-21 19:50 ` Marc Kleine-Budde
2022-06-22 6:38 ` Andrejs Cainikovs
2022-06-22 6:38 ` Andrejs Cainikovs
2022-06-22 6:51 ` Marc Kleine-Budde [this message]
2022-06-22 6:51 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220622065155.uoo2matz36a45nfa@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=andrejs.cainikovs@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.