[PATCH 1/2] drm/amdgpu/display: drop set but unused variable

[PATCH 1/2] drm/amdgpu/display: drop set but unused variable

[Alex Deucher]

No longer used so drop it.

Fixes: ec457f837890 ("drm/amd/display: Drop unnecessary detect link code")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index 1206a3dd746f..86a553757d14 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -1022,7 +1022,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,
 	struct dc_sink *prev_sink = NULL;
 	struct dpcd_caps prev_dpcd_caps;
 	enum dc_connection_type new_connection_type = dc_connection_none;
-	enum dc_connection_type pre_connection_type = dc_connection_none;
 	const uint32_t post_oui_delay = 30; // 30ms
 
 	DC_LOGGER_INIT(link->ctx->logger);
@@ -1059,7 +1058,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,
 
 	link_disconnect_sink(link);
 	if (new_connection_type != dc_connection_none) {
-		pre_connection_type = link->type;
 		link->type = new_connection_type;
 		link->link_state_valid = false;
 
-- 
2.35.3

[PATCH 2/2] drm/amdgpu: fix documentation warning

[Alex Deucher]

Fixes this issue:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:5094: warning: expecting prototype for amdgpu_device_gpu_recover_imp(). Prototype was for amdgpu_device_gpu_recover() instead

Fixes: cf727044144d ("drm/amdgpu: Rename amdgpu_device_gpu_recover_imp back to amdgpu_device_gpu_recover")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index f2a4c268ac72..6c0fbc662b3a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -5079,7 +5079,7 @@ static inline void amdggpu_device_stop_pedning_resets(struct amdgpu_device *adev
 
 
 /**
- * amdgpu_device_gpu_recover_imp - reset the asic and recover scheduler
+ * amdgpu_device_gpu_recover - reset the asic and recover scheduler
  *
  * @adev: amdgpu_device pointer
  * @job: which job trigger hang
-- 
2.35.3

Re: [PATCH 2/2] drm/amdgpu: fix documentation warning

[Alex Deucher]

Ping?

On Thu, Jun 23, 2022 at 12:41 PM Alex Deucher <alexander.deucher@amd.com> wrote:
>
> Fixes this issue:
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:5094: warning: expecting prototype for amdgpu_device_gpu_recover_imp(). Prototype was for amdgpu_device_gpu_recover() instead
>
> Fixes: cf727044144d ("drm/amdgpu: Rename amdgpu_device_gpu_recover_imp back to amdgpu_device_gpu_recover")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index f2a4c268ac72..6c0fbc662b3a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -5079,7 +5079,7 @@ static inline void amdggpu_device_stop_pedning_resets(struct amdgpu_device *adev
>
>
>  /**
> - * amdgpu_device_gpu_recover_imp - reset the asic and recover scheduler
> + * amdgpu_device_gpu_recover - reset the asic and recover scheduler
>   *
>   * @adev: amdgpu_device pointer
>   * @job: which job trigger hang
> --
> 2.35.3
>

RE: [PATCH 2/2] drm/amdgpu: fix documentation warning

[Russell, Kent]

[AMD Official Use Only - General]

Not sure why no one responded, but this is something even I can RB.

Reviewed-by: Kent Russell <kent.russell@amd.com>



> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex
> Deucher
> Sent: Monday, June 27, 2022 5:41 PM
> To: Deucher, Alexander <Alexander.Deucher@amd.com>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>; amd-gfx list <amd-
> gfx@lists.freedesktop.org>
> Subject: Re: [PATCH 2/2] drm/amdgpu: fix documentation warning
> 
> Ping?
> 
> On Thu, Jun 23, 2022 at 12:41 PM Alex Deucher <alexander.deucher@amd.com>
> wrote:
> >
> > Fixes this issue:
> > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:5094: warning: expecting
> prototype for amdgpu_device_gpu_recover_imp(). Prototype was for
> amdgpu_device_gpu_recover() instead
> >
> > Fixes: cf727044144d ("drm/amdgpu: Rename
> amdgpu_device_gpu_recover_imp back to amdgpu_device_gpu_recover")
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > index f2a4c268ac72..6c0fbc662b3a 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > @@ -5079,7 +5079,7 @@ static inline void
> amdggpu_device_stop_pedning_resets(struct amdgpu_device *adev
> >
> >
> >  /**
> > - * amdgpu_device_gpu_recover_imp - reset the asic and recover scheduler
> > + * amdgpu_device_gpu_recover - reset the asic and recover scheduler
> >   *
> >   * @adev: amdgpu_device pointer
> >   * @job: which job trigger hang
> > --
> > 2.35.3
> >

Re: [PATCH 1/2] drm/amdgpu/display: drop set but unused variable

[Harry Wentland]

On 6/23/22 12:41, Alex Deucher wrote:
> No longer used so drop it.
> 
> Fixes: ec457f837890 ("drm/amd/display: Drop unnecessary detect link code")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index 1206a3dd746f..86a553757d14 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -1022,7 +1022,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,
>  	struct dc_sink *prev_sink = NULL;
>  	struct dpcd_caps prev_dpcd_caps;
>  	enum dc_connection_type new_connection_type = dc_connection_none;
> -	enum dc_connection_type pre_connection_type = dc_connection_none;
>  	const uint32_t post_oui_delay = 30; // 30ms
>  
>  	DC_LOGGER_INIT(link->ctx->logger);
> @@ -1059,7 +1058,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,
>  
>  	link_disconnect_sink(link);
>  	if (new_connection_type != dc_connection_none) {
> -		pre_connection_type = link->type;
>  		link->type = new_connection_type;
>  		link->link_state_valid = false;
>