* [PATCH v2] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG SX6000LNP (AKA SPECTRIX S40G)
@ 2022-06-25 12:15 ` Pablo Greco
0 siblings, 0 replies; 5+ messages in thread
From: Pablo Greco @ 2022-06-25 12:15 UTC (permalink / raw)
Cc: Pablo Greco, stable, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, linux-nvme, linux-kernel
ADATA XPG SPECTRIX S40G drives report bogus eui64 values that appear to
be the same across drives in one system. Quirk them out so they are
not marked as "non globally unique" duplicates.
Before:
[ 2.258919] nvme nvme1: pci function 0000:06:00.0
[ 2.264898] nvme nvme2: pci function 0000:05:00.0
[ 2.323235] nvme nvme1: failed to set APST feature (2)
[ 2.326153] nvme nvme2: failed to set APST feature (2)
[ 2.333935] nvme nvme1: allocated 64 MiB host memory buffer.
[ 2.336492] nvme nvme2: allocated 64 MiB host memory buffer.
[ 2.339611] nvme nvme1: 7/0/0 default/read/poll queues
[ 2.341805] nvme nvme2: 7/0/0 default/read/poll queues
[ 2.346114] nvme1n1: p1
[ 2.347197] nvme nvme2: globally duplicate IDs for nsid 1
After:
[ 2.427715] nvme nvme1: pci function 0000:06:00.0
[ 2.427771] nvme nvme2: pci function 0000:05:00.0
[ 2.488154] nvme nvme2: failed to set APST feature (2)
[ 2.489895] nvme nvme1: failed to set APST feature (2)
[ 2.498773] nvme nvme2: allocated 64 MiB host memory buffer.
[ 2.500587] nvme nvme1: allocated 64 MiB host memory buffer.
[ 2.504113] nvme nvme2: 7/0/0 default/read/poll queues
[ 2.507026] nvme nvme1: 7/0/0 default/read/poll queues
[ 2.509467] nvme nvme2: Ignoring bogus Namespace Identifiers
[ 2.512804] nvme nvme1: Ignoring bogus Namespace Identifiers
[ 2.513698] nvme1n1: p1
Signed-off-by: Pablo Greco <pgreco@centosproject.org>
Cc: <stable@vger.kernel.org>
---
drivers/nvme/host/pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index d7b24ee17285..c9ebe6072498 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3470,7 +3470,8 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_NO_NS_DESC_LIST |
NVME_QUIRK_IGNORE_DEV_SUBNQN, },
{ PCI_DEVICE(0x10ec, 0x5762), /* ADATA SX6000LNP */
- .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, },
+ .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
+ NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x1cc1, 0x8201), /* ADATA SX8200PNP 512GB */
.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
NVME_QUIRK_IGNORE_DEV_SUBNQN, },
--
2.36.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG SX6000LNP (AKA SPECTRIX S40G)
@ 2022-06-25 12:15 ` Pablo Greco
0 siblings, 0 replies; 5+ messages in thread
From: Pablo Greco @ 2022-06-25 12:15 UTC (permalink / raw)
Cc: Pablo Greco, stable, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, linux-nvme, linux-kernel
ADATA XPG SPECTRIX S40G drives report bogus eui64 values that appear to
be the same across drives in one system. Quirk them out so they are
not marked as "non globally unique" duplicates.
Before:
[ 2.258919] nvme nvme1: pci function 0000:06:00.0
[ 2.264898] nvme nvme2: pci function 0000:05:00.0
[ 2.323235] nvme nvme1: failed to set APST feature (2)
[ 2.326153] nvme nvme2: failed to set APST feature (2)
[ 2.333935] nvme nvme1: allocated 64 MiB host memory buffer.
[ 2.336492] nvme nvme2: allocated 64 MiB host memory buffer.
[ 2.339611] nvme nvme1: 7/0/0 default/read/poll queues
[ 2.341805] nvme nvme2: 7/0/0 default/read/poll queues
[ 2.346114] nvme1n1: p1
[ 2.347197] nvme nvme2: globally duplicate IDs for nsid 1
After:
[ 2.427715] nvme nvme1: pci function 0000:06:00.0
[ 2.427771] nvme nvme2: pci function 0000:05:00.0
[ 2.488154] nvme nvme2: failed to set APST feature (2)
[ 2.489895] nvme nvme1: failed to set APST feature (2)
[ 2.498773] nvme nvme2: allocated 64 MiB host memory buffer.
[ 2.500587] nvme nvme1: allocated 64 MiB host memory buffer.
[ 2.504113] nvme nvme2: 7/0/0 default/read/poll queues
[ 2.507026] nvme nvme1: 7/0/0 default/read/poll queues
[ 2.509467] nvme nvme2: Ignoring bogus Namespace Identifiers
[ 2.512804] nvme nvme1: Ignoring bogus Namespace Identifiers
[ 2.513698] nvme1n1: p1
Signed-off-by: Pablo Greco <pgreco@centosproject.org>
Cc: <stable@vger.kernel.org>
---
drivers/nvme/host/pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index d7b24ee17285..c9ebe6072498 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3470,7 +3470,8 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_NO_NS_DESC_LIST |
NVME_QUIRK_IGNORE_DEV_SUBNQN, },
{ PCI_DEVICE(0x10ec, 0x5762), /* ADATA SX6000LNP */
- .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, },
+ .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
+ NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x1cc1, 0x8201), /* ADATA SX8200PNP 512GB */
.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
NVME_QUIRK_IGNORE_DEV_SUBNQN, },
--
2.36.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG SX6000LNP (AKA SPECTRIX S40G)
2022-06-25 12:15 ` Pablo Greco
(?)
@ 2022-06-27 20:14 ` Keith Busch
-1 siblings, 0 replies; 5+ messages in thread
From: Keith Busch @ 2022-06-27 20:14 UTC (permalink / raw)
To: Pablo Greco
Cc: stable, Jens Axboe, Christoph Hellwig, Sagi Grimberg, linux-nvme,
linux-kernel
On Sat, Jun 25, 2022 at 09:15:02AM -0300, Pablo Greco wrote:
> ADATA XPG SPECTRIX S40G drives report bogus eui64 values that appear to
> be the same across drives in one system. Quirk them out so they are
> not marked as "non globally unique" duplicates.
Looks fine.
Reviewed-by: Keith Busch <kbusch@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG SX6000LNP (AKA SPECTRIX S40G)
2022-06-25 12:15 ` Pablo Greco
(?)
(?)
@ 2022-06-27 20:43 ` Chaitanya Kulkarni
-1 siblings, 0 replies; 5+ messages in thread
From: Chaitanya Kulkarni @ 2022-06-27 20:43 UTC (permalink / raw)
To: Pablo Greco
Cc: stable, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, linux-nvme, linux-kernel
On 6/25/22 05:15, Pablo Greco wrote:
> ADATA XPG SPECTRIX S40G drives report bogus eui64 values that appear to
> be the same across drives in one system. Quirk them out so they are
> not marked as "non globally unique" duplicates.
>
Can be written with moving "not" to the 2nd line, if anyone cares :-
ADATA XPG SPECTRIX S40G drives report bogus eui64 values that appear to
be the same across drives in one system. Quirk them out so they are not
marked as "non globally unique" duplicates.
> Before:
> [ 2.258919] nvme nvme1: pci function 0000:06:00.0
> [ 2.264898] nvme nvme2: pci function 0000:05:00.0
> [ 2.323235] nvme nvme1: failed to set APST feature (2)
> [ 2.326153] nvme nvme2: failed to set APST feature (2)
> [ 2.333935] nvme nvme1: allocated 64 MiB host memory buffer.
> [ 2.336492] nvme nvme2: allocated 64 MiB host memory buffer.
> [ 2.339611] nvme nvme1: 7/0/0 default/read/poll queues
> [ 2.341805] nvme nvme2: 7/0/0 default/read/poll queues
> [ 2.346114] nvme1n1: p1
> [ 2.347197] nvme nvme2: globally duplicate IDs for nsid 1
> After:
> [ 2.427715] nvme nvme1: pci function 0000:06:00.0
> [ 2.427771] nvme nvme2: pci function 0000:05:00.0
> [ 2.488154] nvme nvme2: failed to set APST feature (2)
> [ 2.489895] nvme nvme1: failed to set APST feature (2)
> [ 2.498773] nvme nvme2: allocated 64 MiB host memory buffer.
> [ 2.500587] nvme nvme1: allocated 64 MiB host memory buffer.
> [ 2.504113] nvme nvme2: 7/0/0 default/read/poll queues
> [ 2.507026] nvme nvme1: 7/0/0 default/read/poll queues
> [ 2.509467] nvme nvme2: Ignoring bogus Namespace Identifiers
> [ 2.512804] nvme nvme1: Ignoring bogus Namespace Identifiers
> [ 2.513698] nvme1n1: p1
>
> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
> Cc: <stable@vger.kernel.org>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG SX6000LNP (AKA SPECTRIX S40G)
2022-06-25 12:15 ` Pablo Greco
` (2 preceding siblings ...)
(?)
@ 2022-06-29 14:16 ` Christoph Hellwig
-1 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2022-06-29 14:16 UTC (permalink / raw)
To: Pablo Greco
Cc: stable, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, linux-nvme, linux-kernel
Thanks,
added to nvme-5.19.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-29 14:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-25 12:15 [PATCH v2] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG SX6000LNP (AKA SPECTRIX S40G) Pablo Greco
2022-06-25 12:15 ` Pablo Greco
2022-06-27 20:14 ` Keith Busch
2022-06-27 20:43 ` Chaitanya Kulkarni
2022-06-29 14:16 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.