From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com> To: Allen-KH Cheng <allen-kh.cheng@mediatek.com> Cc: Matthias Brugger <matthias.bgg@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai <wenst@chromium.org> Subject: Re: [PATCH 3/5] arm64: dts: mt8192: Add display nodes Date: Wed, 29 Jun 2022 19:24:29 -0400 [thread overview] Message-ID: <20220629232429.c5oysjgy6gflqhct@notapiano> (raw) In-Reply-To: <20220629121358.19458-4-allen-kh.cheng@mediatek.com> On Wed, Jun 29, 2022 at 08:13:56PM +0800, Allen-KH Cheng wrote: > Add display nodes and gce info for mt8192 SoC. > > GCE (Global Command Engine) properties to the display nodes in order to > enable the usage of the CMDQ (Command Queue), which is required for > operating the display. > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 136 +++++++++++++++++++++++ > 1 file changed, 136 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index a07edc82d403..26d01544b4ea 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi [..] > > + mutex: mutex@14001000 { > + compatible = "mediatek,mt8192-disp-mutex"; > + reg = <0 0x14001000 0 0x1000>; > + interrupts = <GIC_SPI 252 IRQ_TYPE_LEVEL_HIGH 0>; > + clocks = <&mmsys CLK_MM_DISP_MUTEX0>; > + mediatek,gce-events = <CMDQ_EVENT_DISP_STREAM_DONE_ENG_EVENT_0>, > + <CMDQ_EVENT_DISP_STREAM_DONE_ENG_EVENT_1>; This node is missing power-domains. > + }; > + [..] > + rdma0: rdma@14007000 { > + compatible = "mediatek,mt8192-disp-rdma"; dtbs_check is complaining that there isn't a "mediatek,mt8183-disp-rdma" fallback compatible here. But given that the rdma driver matches directly to the mt8192 compatible, I think the node here is fine, and the binding is the one that should be updated. > + reg = <0 0x14007000 0 0x1000>; > + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH 0>; > + clocks = <&mmsys CLK_MM_DISP_RDMA0>; > + iommus = <&iommu0 M4U_PORT_L0_DISP_RDMA0>; > + mediatek,larb = <&larb0>; mediatek,larb is no longer used, so drop it. Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Thanks, Nícolas
WARNING: multiple messages have this Message-ID (diff)
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com> To: Allen-KH Cheng <allen-kh.cheng@mediatek.com> Cc: Matthias Brugger <matthias.bgg@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai <wenst@chromium.org> Subject: Re: [PATCH 3/5] arm64: dts: mt8192: Add display nodes Date: Wed, 29 Jun 2022 19:24:29 -0400 [thread overview] Message-ID: <20220629232429.c5oysjgy6gflqhct@notapiano> (raw) In-Reply-To: <20220629121358.19458-4-allen-kh.cheng@mediatek.com> On Wed, Jun 29, 2022 at 08:13:56PM +0800, Allen-KH Cheng wrote: > Add display nodes and gce info for mt8192 SoC. > > GCE (Global Command Engine) properties to the display nodes in order to > enable the usage of the CMDQ (Command Queue), which is required for > operating the display. > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 136 +++++++++++++++++++++++ > 1 file changed, 136 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index a07edc82d403..26d01544b4ea 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi [..] > > + mutex: mutex@14001000 { > + compatible = "mediatek,mt8192-disp-mutex"; > + reg = <0 0x14001000 0 0x1000>; > + interrupts = <GIC_SPI 252 IRQ_TYPE_LEVEL_HIGH 0>; > + clocks = <&mmsys CLK_MM_DISP_MUTEX0>; > + mediatek,gce-events = <CMDQ_EVENT_DISP_STREAM_DONE_ENG_EVENT_0>, > + <CMDQ_EVENT_DISP_STREAM_DONE_ENG_EVENT_1>; This node is missing power-domains. > + }; > + [..] > + rdma0: rdma@14007000 { > + compatible = "mediatek,mt8192-disp-rdma"; dtbs_check is complaining that there isn't a "mediatek,mt8183-disp-rdma" fallback compatible here. But given that the rdma driver matches directly to the mt8192 compatible, I think the node here is fine, and the binding is the one that should be updated. > + reg = <0 0x14007000 0 0x1000>; > + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH 0>; > + clocks = <&mmsys CLK_MM_DISP_RDMA0>; > + iommus = <&iommu0 M4U_PORT_L0_DISP_RDMA0>; > + mediatek,larb = <&larb0>; mediatek,larb is no longer used, so drop it. Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Thanks, Nícolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-29 23:24 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-29 12:13 [PATCH 0/5] Complete driver nodes for MT8192 SoC Allen-KH Cheng 2022-06-29 12:13 ` Allen-KH Cheng 2022-06-29 12:13 ` [PATCH 1/5] arm64: dts: mt8192: Add pwm node Allen-KH Cheng 2022-06-29 12:13 ` Allen-KH Cheng 2022-06-29 23:12 ` Nícolas F. R. A. Prado 2022-06-29 23:12 ` Nícolas F. R. A. Prado 2022-06-29 12:13 ` [PATCH 2/5] arm64: dts: mt8192: Add mipi_tx node Allen-KH Cheng 2022-06-29 12:13 ` Allen-KH Cheng 2022-06-29 23:14 ` Nícolas F. R. A. Prado 2022-06-29 23:14 ` Nícolas F. R. A. Prado 2022-06-29 12:13 ` [PATCH 3/5] arm64: dts: mt8192: Add display nodes Allen-KH Cheng 2022-06-29 12:13 ` Allen-KH Cheng 2022-06-29 23:24 ` Nícolas F. R. A. Prado [this message] 2022-06-29 23:24 ` Nícolas F. R. A. Prado 2022-06-30 9:41 ` allen-kh.cheng 2022-06-30 9:41 ` allen-kh.cheng 2022-06-30 13:42 ` Nícolas F. R. A. Prado 2022-06-30 13:42 ` Nícolas F. R. A. Prado 2022-07-01 5:25 ` Chen-Yu Tsai 2022-07-01 5:25 ` Chen-Yu Tsai 2022-07-01 5:59 ` allen-kh.cheng 2022-07-01 5:59 ` allen-kh.cheng 2022-06-29 12:13 ` [PATCH 4/5] arm64: dts: mt8192: Add dsi node Allen-KH Cheng 2022-06-29 12:13 ` Allen-KH Cheng 2022-06-29 13:42 ` AngeloGioacchino Del Regno 2022-06-29 13:42 ` AngeloGioacchino Del Regno 2022-06-29 23:31 ` Nícolas F. R. A. Prado 2022-06-29 23:31 ` Nícolas F. R. A. Prado 2022-06-29 12:13 ` [PATCH 5/5] arm64: dts: mt8192: Add vcodec lat and core nodes Allen-KH Cheng 2022-06-29 12:13 ` Allen-KH Cheng 2022-06-29 23:32 ` Nícolas F. R. A. Prado 2022-06-29 23:32 ` Nícolas F. R. A. Prado
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220629232429.c5oysjgy6gflqhct@notapiano \ --to=nfraprado@collabora.com \ --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \ --cc=allen-kh.cheng@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ --cc=wenst@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.